powerpack 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a3a66b83a0099f21936fdf18fdd2465ee803a0b
-  data.tar.gz: 850e52d270c66647b71ff8a98a44bcfca39c9e14
+  metadata.gz: b2e81863714b8ba985b6b8df75e8c80fe0067622
+  data.tar.gz: 8db7578f7f0e9d011bbed495fbd86baec322906e
 SHA512:
-  metadata.gz: 076f54612a3f4c83715654f2c5ecd82792b492b4a52308b52f43f6a4d718334eed4f24f4f578c7ca4f9d04cfa11c1e141075bbafd2fe465b5a63123ae9287dac
-  data.tar.gz: 06746d79155d9a90500fbf93843e2b69aec72aca92b55389267b3f474dcc6127fd659a0bf108d0870d554c824948fb4785fe77f7074ad2a2ee8735d52b7e3606
+  metadata.gz: 0be201c62b1285df95790d9e48f121b6ef78a1cd2f58858b2b12098c03ae8cd8db9bae0ad9cde53a55f5d51c327d5887ca8bd1ec0b66fc7293f9bd16e0e67222
+  data.tar.gz: da8f272a0c79d5d83c04aa87775c4e52f9eea3f235a2074374447b5cab61bfe493aa059ad7427bf78ce7ff8e8809e425ae1776d6636ff34d4b14087712662e74

data/.travis.yml

@@ -1,9 +1,13 @@
+sudo: false
 language: ruby
 rvm:
-  - 1.9.3
-  - 2.0.0
-  - 2.1
-  - 2.2
-  - jruby-19mode
-  - rbx-2
+  - jruby-9.1.13.0
+  - 2.3
+  - 2.4
+  - 2.5
+  - ruby-head
+  - rbx-3
 script: bundle exec rspec
+matrix:
+  allow_failures:
+    - rvm: rbx-3

data/CHANGELOG.md

@@ -2,25 +2,32 @@
 
 ## master (unreleased)
 
-## 0.1.1 (04/05/2015)
+## 0.1.2 (2018-06-10)
+
+* Changed `String#remove_prefix` to return the original string if the parameter is not a prefix.
++* Changed `String#remove_prefix!`to return the original string if the parameter is not a prefix.
++* Changed `String#remove_suffix` to return the original string if the parameter is not a suffix.
++* Changed `String#remove_suffix!` to return the original string if the parameter is not a suffix.
+
+## 0.1.1 (2015-05-04)
 
 No user-visible changes.
 
-## 0.1.0 (25/01/2015)
+## 0.1.0 (2015-01-25)
 
 * Added `String#remove_prefix`
 * Added `String#remove_prefix!`
 * Added `String#remove_suffix`
 * Added `String#remove_suffix!`
 
-## 0.0.9 (22/10/2013)
+## 0.0.9 (2013-10-22)
 
 * Added `String#remove`
 * Added `String#remove!`
 * Added `String#ascii_only`
 * Added `String#ascii_only!`
 
-## 0.0.8 (13/09/2013)
+## 0.0.8 (2013-09-13)
 
 ### New features
 

data/CONTRIBUTING.md

@@ -0,0 +1,62 @@
+# Contributing
+
+If you discover issues, have ideas for improvements or new features,
+please report them to the [issue tracker][1] of the repository or
+submit a pull request. Please, try to follow these guidelines when you
+do so.
+
+## Issue reporting
+
+* Check that the issue has not already been reported.
+* Check that the issue has not already been fixed in the latest code
+  (a.k.a. `master`).
+* Be clear, concise and precise in your description of the problem.
+* Open an issue with a descriptive title and a summary in grammatically correct,
+  complete sentences.
+* Include Powerpack's version number.
+* Include any relevant code to the issue summary.
+
+## Pull requests
+
+* Read [how to properly contribute to open source projects on Github][2].
+* Fork the project.
+* Use a topic/feature branch to easily amend a pull request later, if necessary.
+* Write [good commit messages][3].
+* Use the same coding conventions as the rest of the project.
+* Commit and push until you are happy with your contribution.
+* Make sure to add tests for it. This is important so I don't break it
+  in a future version unintentionally.
+* Add an entry to the [Changelog](CHANGELOG.md) accordingly. See [changelog entry format](#changelog-entry-format).
+* Please try not to mess with the Rakefile, version, or history. If
+  you want to have your own version, or is otherwise necessary, that
+  is fine, but please isolate to its own commit so I can cherry-pick
+  around it.
+* Make sure the test suite is passing ([including rbx and jruby][7]) and the code you wrote doesn't produce
+  RuboCop offenses.
+* [Squash related commits together][5].
+* Open a [pull request][4] that relates to *only* one subject with a clear title
+  and description in grammatically correct, complete sentences.
+
+### Changelog entry format
+
+Here are a few examples:
+
+```
+* [#123](https://github.com/bbatsov/powerpack/issues/123): Fixed a bug in  `Something#something`. ([@bbatsov][])
+* Added new method `Something#something`. ([@bbatsov][])
+```
+
+* Mark it up in [Markdown syntax][6].
+* The entry line should start with `* ` (an asterisk and a space).
+* If the change has a related GitHub issue (e.g. a bug fix for a reported issue), put a link to the issue as `[#123](https://github.com/bbatsov/powerpack/issues/123): `.
+* Describe the brief of the change. The sentence should end with a punctuation.
+* At the end of the entry, add an implicit link to your GitHub user page as `([@username][])`.
+* If this is your first contribution to Powerpack project, add a link definition for the implicit link to the bottom of the changelog as `[@username]: https://github.com/username`.
+
+[1]: https://github.com/bbatsov/powerpack/issues
+[2]: http://gun.io/blog/how-to-github-fork-branch-and-pull-request
+[3]: http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
+[4]: https://help.github.com/articles/using-pull-requests
+[5]: http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html
+[6]: http://daringfireball.net/projects/markdown/syntax
+[7]: http://blog.stwrt.ca/2013/09/06/installing-rubinius-with-rbenv

data/README.md

@@ -1,5 +1,5 @@
-[![Gem Version](https://badge.fury.io/rb/powerpack.png)](http://badge.fury.io/rb/powerpack)
-[![Build Status](https://travis-ci.org/bbatsov/powerpack.png?branch=master)](https://travis-ci.org/bbatsov/powerpack)
+[![Gem Version](https://badge.fury.io/rb/powerpack.svg)](http://badge.fury.io/rb/powerpack)
+[![Build Status](https://travis-ci.org/bbatsov/powerpack.svg?branch=master)](https://travis-ci.org/bbatsov/powerpack)
 
 # Powerpack
 

data/lib/powerpack/enumerable/sum.rb

@@ -3,19 +3,23 @@ unless Enumerable.method_defined? :sum
     # Sums up elements of a collection by invoking their `+` method.
     # Most useful for summing up numbers.
     #
-    # @param default [Object] an optional default return value if there are no elements.
-    #   It's nil by default.
-    # @return The sum of the elements or the default value if there are no
-    #   elements.
+    # @param initial [Object] an optional initial value.
+    #   It defaults to 0 for an empty collection.
+    # @return The sum of the elements, or the initial value if there
+    #   are no elements.
     #
     # @example
     #   [1, 2, 3].sum #=> 6
-    #   ["a", "b", "c"].sum #=> "abc"
     #   [[1], [2], [3]].sum #=> [1, 2, 3]
-    #   [].sum #=> nil
-    #   [].sum(0) #=> 0
-    def sum(default = nil)
-      reduce(&:+) || default
+    #   [].sum #=> 0
+    #   ["a"].sum #=> "a"
+    #   ["b", "c"].sum("a") #=> "abc"
+    def sum(initial = nil)
+      if initial
+        reduce(initial, &:+)
+      else
+        reduce(&:+) || 0
+      end
     end
   end
 end

data/lib/powerpack/string/remove_prefix.rb

@@ -18,6 +18,7 @@ unless String.method_defined? :remove_prefix
     #   'Ladies Night'.remove_prefix!('Ladies ') #=> 'Night'
     def remove_prefix!(pattern)
       gsub!(/\A#{pattern}/, '')
+      self
     end
   end
 end

data/lib/powerpack/string/remove_suffix.rb

@@ -18,6 +18,7 @@ unless String.method_defined? :remove_suffix
     #   'Ladies Night'.remove_suffix!(' Night') #=> 'Ladies'
     def remove_suffix!(pattern)
       gsub!(/#{pattern}\z/, '')
+      self
     end
   end
 end

data/lib/powerpack/version.rb

@@ -1,3 +1,3 @@
 module Powerpack
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/powerpack.gemspec

@@ -20,5 +20,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency('rspec')
-  spec.add_development_dependency('yard', '~> 0.8')
+  spec.add_development_dependency('yard', '~> 0.9')
 end

data/spec/powerpack/enumerable/sum_spec.rb

@@ -1,15 +1,29 @@
 require 'spec_helper'
 
-describe 'Enumerable#sum' do
-  it 'sums up the numbers of an enum' do
-    expect((1..3).sum).to eq(6)
-  end
+unless Enumerable.method_defined? :sum
+  describe 'Enumerable#sum' do
+    it 'sums up the numbers of an enum' do
+      expect((1..3).sum).to eq(6)
+    end
 
-  it 'returns nil when invoked on an empty collection' do
-    expect([].sum).to be_nil
-  end
+    it 'returns zero when invoked on an empty collection' do
+      expect([].sum).to be_zero
+    end
+
+    it 'returns the initial value when invoked on an empty collection' do
+      expect([].sum('')).to be_empty
+    end
+
+    it 'prepends the initial value to the sum' do
+      expect(['b', 'c'].sum('a')).to eq('abc')
+    end
+
+    it 'concatenates strings' do
+      expect(['a', 'b', 'c'].sum).to eq('abc')
+    end
 
-  it 'returns default value when invoked on an empty collection' do
-    expect([].sum(0)).to be_zero
+    it 'concatenates arrays' do
+      expect([[1], [2], [3]].sum).to eq([1, 2, 3])
+    end
   end
 end

data/spec/powerpack/string/remove_prefix_spec.rb

@@ -4,10 +4,18 @@ describe 'String#remove_prefix' do
   it 'removes a prefix in a string' do
     expect('Ladies Night'.remove_prefix('Ladies ')).to eq('Night')
   end
+
+  it 'returns the original string if the parameter is not a prefix' do
+    expect('Ladies Night'.remove_prefix('Night')).to eq('Ladies Night')
+  end
 end
 
 describe 'String#remove_prefix!' do
   it 'removes a prefix in a string' do
     expect('Ladies Night'.remove_prefix!('Ladies ')).to eq('Night')
   end
+
+  it 'returns the original string if the parameter is not a prefix' do
+    expect('Ladies Night'.remove_prefix!('Night')).to eq('Ladies Night')
+  end
 end

data/spec/powerpack/string/remove_suffix_spec.rb

@@ -4,10 +4,18 @@ describe 'String#remove_suffix' do
   it 'removes a suffix in a string' do
     expect('Ladies Night'.remove_suffix(' Night')).to eq('Ladies')
   end
+
+  it 'returns the original string if the parameter is not a suffix' do
+    expect('Ladies Night'.remove_suffix('Ladies')).to eq('Ladies Night')
+  end
 end
 
 describe 'String#remove_suffix!' do
   it 'removes a suffix in a string' do
     expect('Ladies Night'.remove_suffix!(' Night')).to eq('Ladies')
   end
+
+  it 'returns the original string if the parameter is not a suffix' do
+    expect('Ladies Night'.remove_suffix!('Ladies')).to eq('Ladies Night')
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: powerpack
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Bozhidar Batsov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-04 00:00:00.000000000 Z
+date: 2018-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0.9'
 description: A few useful extensions to core Ruby classes.
 email:
 - bozhidar@batsov.com
@@ -77,6 +77,7 @@ files:
 - ".rspec"
 - ".travis.yml"
 - CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: A few useful extensions to core Ruby classes.
@@ -188,4 +189,3 @@ test_files:
 - spec/powerpack/string/strip_indent_spec.rb
 - spec/powerpack/string/strip_margin_spec.rb
 - spec/spec_helper.rb
-has_rdoc: