poundpay 0.2.1 → 0.2.2

data/README.rdoc

@@ -15,6 +15,9 @@ Poundpay is a payments platform for marketplaces
 
 3. Create the file config/poundpay.yml and add your configurations
 
+Note: Make sure your YAML file ends with a blank line; otherwise, Ruby
+will give you a completely unintelligible error message
+
     development:
       developer_sid: DV0383d447360511e0bbac00264a09ff3c
       auth_token: c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a

data/lib/poundpay/elements.rb

@@ -1,3 +1,5 @@
+require 'uri'
+
 require 'poundpay/resource'
 
 class PaymentReleaseException < Exception
@@ -8,6 +10,25 @@ module Poundpay
     def self.me
       find(self.user)
     end
+
+    def save
+      validate_url callback_url
+      super
+    end
+
+    def callback_url=(url)
+      validate_url url
+      attributes['callback_url'] = url
+    end
+
+    protected
+      def validate_url(url)
+        begin
+          URI.parse(url) unless url == nil or url == ''
+        rescue URI::InvalidURIError
+          raise URI::InvalidURIError.new "Invalid URL format: #{url}"
+        end
+      end
   end
 
   class Payment < Resource

data/lib/poundpay/version.rb

@@ -1,3 +1,3 @@
 module Poundpay
-  VERSION = "0.2.1"
-end
+  VERSION = "0.2.2"
+end

data/spec/poundpay/elements_spec.rb

@@ -24,6 +24,33 @@ describe Developer do
       @developer = Developer.me
     end
   end
+
+  describe "#callback_url=" do
+    before (:all) do
+      @developer = Developer.new :callback_url => nil
+    end
+
+    it "should not allow invalid urls to be assigned" do
+      invalid_url = "http://71.212.135.207:3000:payments"  # There's a colon after the port number instead of a backslash
+      expect { @developer.callback_url = invalid_url }.to raise_error(URI::InvalidURIError, /format/)
+    end
+
+    it "should allow a developer to set their url" do
+      valid_url = "http://71.212.135.207:3000/payments"
+      @developer.callback_url = valid_url
+      @developer.callback_url.should == valid_url
+      @developer.callback_url = nil
+      @developer.callback_url.should == nil
+    end
+  end
+
+  describe "#save" do
+    it "should not allow saving with an invalid callback_url" do
+      Developer.should_not_receive(:create)
+      developer = Developer.new :callback_url => 'i am invalid'
+      expect { developer.save }.to raise_error(URI::InvalidURIError)
+    end
+  end
 end
 
 describe Payment do

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 0
   - 2
-  - 1
-  version: 0.2.1
+  - 2
+  version: 0.2.2
 platform: ruby
 authors: 
 - Matin Tamizi
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-02-19 00:00:00 -08:00
+date: 2011-02-20 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency