poundpay 0.0.2 → 0.1.0

data/.autotest

@@ -0,0 +1,2 @@
+require 'autotest/bundler'
+require 'autotest/growl'

data/Rakefile

@@ -1,2 +1,7 @@
 require 'bundler'
-Bundler::GemHelper.install_tasks
+require "rspec"
+require "rspec/core/rake_task"
+
+Bundler::GemHelper.install_tasks
+
+Rspec::Core::RakeTask.new(:spec)

data/lib/poundpay/elements.rb

@@ -0,0 +1,22 @@
+require 'poundpay/resource'
+
+class PaymentReleaseException < Exception
+end
+
+module Poundpay
+  class Developer < Resource
+    def self.me
+      find(self.user)
+    end
+  end
+
+  class Payment < Resource
+    def release
+      unless status == 'ESCROWED'
+        raise PaymentReleaseException.new "Payment status is #{status}.  Only ESCROWED payments may be released"
+      end
+      status = 'RELEASED'
+      save
+    end
+  end
+end

data/lib/poundpay/resource.rb

@@ -11,19 +11,20 @@ module Poundpay
 
       # Modified default to not use an extension
       def element_path(id, prefix_options = {}, query_options = nil)
-        prefix_options, query_options = split_options(prefix_options) if query_options.nil?
-        "#{prefix(prefix_options)}#{collection_name}/#{URI.escape id.to_s}#{query_string(query_options)}"
+        path = super(id, prefix_options, query_options)
+        remove_extension(path)
       end
 
       # Modified default to not use an extension
       def new_element_path(prefix_options = {})
-        "#{prefix(prefix_options)}#{collection_name}/new"
+        path = super(prefix_options)
+        remove_extension(path)
       end
 
       # Modified default to not use an extension
       def collection_path(prefix_options = {}, query_options = nil)
-        prefix_options, query_options = split_options(prefix_options) if query_options.nil?
-        "#{prefix(prefix_options)}#{collection_name}#{query_string(query_options)}"
+        path = super(prefix_options, query_options)
+        remove_extension(path)
       end
 
       # Handle paginated collections
@@ -32,6 +33,11 @@ module Poundpay
         collection = collection[collection_name]
         super(collection, prefix_options)
       end
+
+      protected
+        def remove_extension(path)
+          path.sub /(\.#{format.extension})$/, ""
+        end
     end
 
     # Poundpay accepts urlencoded form parameters

data/lib/poundpay/version.rb

@@ -1,3 +1,3 @@
 module Poundpay
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/lib/poundpay.rb

@@ -1,33 +1,20 @@
 require 'poundpay/resource'
+require 'poundpay/elements'
 
 module Poundpay
   API_URL = "https://api.poundpay.com"
-  VERSION = "silver"
+  API_VERSION = "silver"
 
   class << self
-    def configure(developer_sid, auth_token, api_url=API_URL, version=VERSION)
+    def configure(developer_sid, auth_token, api_url=API_URL, version=API_VERSION)
       unless developer_sid.start_with? "DV"
-        raise ArgumentError.new "developer_sid should start with DV.  Make sure " \
+        raise ArgumentError.new "developer_sid should start with 'DV'.  Make sure " \
           "you're using the right developer_sid"
       end
+      api_url.sub! /(\/)$/, ""  # Remove trailing backslash
       Resource.site = "#{api_url}/#{version}/"
       Resource.user = developer_sid
       Resource.password = auth_token
     end
   end
-
-  class Developer < Resource
-    class << self
-      def me
-        find(self.user)
-      end
-    end
-  end
-
-  class Payment < Resource
-    def release
-      self.status = 'RELEASED'
-      self.save
-    end
-  end
 end

data/poundpay.gemspec

@@ -16,6 +16,8 @@ Gem::Specification.new do |s|
 
   s.add_dependency("activeresource", ">= 3.0")
 
+  s.add_development_dependency("rspec", ">= 2.0")
+
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }

data/spec/fixtures/developers.rb

@@ -0,0 +1,13 @@
+module Poundpay
+  module DeveloperFixture
+    def developer_attributes
+      {
+        "sid"          => "DV0383d447360511e0bbac00264a09ff3c",
+        "created_at"   => "2011-01-21T01:48:18.649355Z",
+        "balance"      => 500000,
+        "name"         => "Awesome Marketplace",
+        "callback_url" => "http://awesomemarketplace.com/poundpay_callback",
+      }
+    end
+  end
+end

data/spec/fixtures/payments.rb

@@ -0,0 +1,69 @@
+module Poundpay
+  module PaymentFixture
+    def created_payment_attributes
+      {
+        "amount"                     => 20000,
+        "payer_fee_amount"           => 0,
+        "payer_email_address"        => "goliath@example.com",
+        "recipient_fee_amount"       => 500,
+        "recipient_email_address"    => "david@example.com",
+        "description"                => "Beats by Dr. Dre",
+        "sid"                        => "PY1d82752a361211e0bce31231400042c7",
+        "status"                     => "STAGED",
+        "amount_to_credit_developer" => 550,
+        "updated_at"                 => "2011-02-11T19:07:05.332356Z",
+        "recipient_sid"              => nil,
+        "payer_sid"                  => nil,
+        "developer_sid"              => "DV8539761e250011e0a81d1231400042c7",
+        "poundpay_fee_amount"        => 450,
+        "created_at"                 => "2011-02-11T19:07:05.332356Z",
+        "amount_to_credit_recipient" => 19500,
+        "amount_to_charge_payer"     => 20000,
+      }
+    end
+
+    def escrowed_payment_attributes
+      {
+        "amount"                     => 20000,
+        "payer_fee_amount"           => 0,
+        "payer_email_address"        => "goliath@example.com",
+        "recipient_fee_amount"       => 500,
+        "recipient_email_address"    => "david@example.com",
+        "description"                => "Beats by Dr. Dre",
+        "sid"                        => "PY1d82752a361211e0bce31231400042c7",
+        "status"                     => "ESCROWED",
+        "amount_to_credit_developer" => 550,
+        "updated_at"                 => "2011-02-11T19:07:05.332356Z",
+        "recipient_sid"              => nil,
+        "payer_sid"                  => "US552595ee364111e0b18800264a09ff3c",
+        "developer_sid"              => "DV8539761e250011e0a81d1231400042c7",
+        "poundpay_fee_amount"        => 450,
+        "created_at"                 => "2011-02-11T19:07:05.332356Z",
+        "amount_to_credit_recipient" => 19500,
+        "amount_to_charge_payer"     => 20000,
+      }
+    end
+
+    def released_payment_attributes
+      {
+        "amount"                     => 20000,
+        "payer_fee_amount"           => 0,
+        "payer_email_address"        => "goliath@example.com",
+        "recipient_fee_amount"       => 500,
+        "recipient_email_address"    => "david@example.com",
+        "description"                => "Beats by Dr. Dre",
+        "sid"                        => "PY1d82752a361211e0bce31231400042c7",
+        "status"                     => "RELEASED",
+        "amount_to_credit_developer" => 550,
+        "updated_at"                 => "2011-02-11T19:07:05.332356Z",
+        "recipient_sid"              => nil,
+        "payer_sid"                  => "US552595ee364111e0b18800264a09ff3c",
+        "developer_sid"              => "DV8539761e250011e0a81d1231400042c7",
+        "poundpay_fee_amount"        => 450,
+        "created_at"                 => "2011-02-11T19:07:05.332356Z",
+        "amount_to_credit_recipient" => 19500,
+        "amount_to_charge_payer"     => 20000,
+      }
+    end
+  end
+end

data/spec/poundpay/elements_spec.rb

@@ -0,0 +1,50 @@
+require 'poundpay'
+require 'poundpay/elements'
+require 'fixtures/payments'
+require 'fixtures/developers'
+
+include Poundpay
+
+describe Developer do
+  include DeveloperFixture
+
+  before (:all) do
+    Poundpay.configure(
+      "DV0383d447360511e0bbac00264a09ff3c",
+      "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
+    )
+  end
+
+  describe "#me" do
+    it "should return the developer's information" do
+      Developer.should_receive(:find).with(Developer.user).and_return(Developer.new developer_attributes)
+      @developer = Developer.me
+    end
+  end
+end
+
+describe Payment do
+  include PaymentFixture
+
+  before (:all) do
+    Poundpay.configure(
+      "DV0383d447360511e0bbac00264a09ff3c",
+      "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
+    )
+  end
+
+  describe "#release" do
+    it "should not be able to release a STAGED payment" do
+      @created_payment = Payment.new created_payment_attributes
+      expect {@created_payment.release}.to raise_error(PaymentReleaseException)
+    end
+
+    it "should release a ESCROWED payment" do
+      @escrowed_payment = Payment.new escrowed_payment_attributes
+      @escrowed_payment.should_receive(:save).and_return(Payment.new released_payment_attributes)
+
+      @escrowed_payment.release
+      @escrowed_payment.status.should == 'ESCROWED'
+    end
+  end
+end

data/spec/poundpay/formats_spec.rb

@@ -0,0 +1,15 @@
+require 'active_resource/formats'
+require 'poundpay/formats'
+include Poundpay
+
+describe Formats::UrlencodedJsonFormat do
+  describe "#mime_type" do
+    it "should have a content type for a urlencoded form" do
+      Formats::UrlencodedJsonFormat.mime_type.should == "application/x-www-form-urlencoded"
+    end
+
+    it "should extend from active_resource JsonFormat" do
+      Formats::UrlencodedJsonFormat.should be_a ActiveResource::Formats::JsonFormat
+    end
+  end
+end

data/spec/poundpay/resource_spec.rb

@@ -0,0 +1,53 @@
+require 'poundpay/resource'
+include Poundpay
+
+class FakeElement < Resource
+  self.site = "http://api.example.com/version/"
+end
+
+describe Resource do
+  describe "#self.primary_key" do
+    it "should default to 'sid'" do
+      Resource.primary_key.should == "sid"
+    end
+  end
+
+  describe "#self.element_path" do
+    it "should not add a extension to the element_path" do
+      FakeElement.element_path(1).should == "/version/fake_elements/1"
+    end
+  end
+
+  describe "#self.new_element_path" do
+    it "should not add a extension to the new_element_path" do
+      FakeElement.new_element_path.should == "/version/fake_elements/new"
+    end
+  end
+
+  describe "#self.collection_path" do
+    it "should not add a extension to the collection_path" do
+      FakeElement.collection_path.should == "/version/fake_elements"
+    end
+  end
+
+  describe "#self.instantiate_collection" do
+    it "should handle paginated responses" do
+      collection = {"fake_elements" => [{"sid" => 1}, {"sid" => 2}]}
+      fake_elements = FakeElement.instantiate_collection(collection)
+      fake_elements.should == [FakeElement.new(:sid => 1), FakeElement.new(:sid => 2)]
+    end
+  end
+
+  describe "#encode" do
+    it "should urlencode the attributes" do
+      fake_element = FakeElement.new(:foo => "bar baz")
+      fake_element.encode.should == "foo=bar+baz"
+    end
+  end
+
+  describe "#collection_name" do
+    it "should get the collection_name" do
+      FakeElement.new.collection_name.should == "fake_elements"
+    end
+  end
+end

data/spec/poundpay_spec.rb

@@ -1,34 +1,42 @@
 require 'poundpay'
 
-describe Poundpay do
-  describe "#configure" do
-    it "should require developer_sid to start with DV" do
-      expect {
-        # Pass developer_sid and auth_token in wrong order
-        Poundpay.configure(
-          "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
-          "DV0383d447360511e0bbac00264a09ff3c",
-        )
-      }.to raise_error(ArgumentError, /DV/)
-    end
-
-    it "should be configured with default api_url and version" do
-      developer_sid = "DV0383d447360511e0bbac00264a09ff3c"
-      auth_token = "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a"
-      Poundpay.configure(developer_sid, auth_token)
-      Poundpay::Resource.user.should == developer_sid
-      Poundpay::Resource.password.should == auth_token
-      Poundpay::Resource.site.to_s.should == "https://api.poundpay.com/silver/"
-    end
-
-    it "should accept optional api_url and version" do
+describe Poundpay, ".configure" do
+  it "should require developer_sid to start with 'DV'" do
+    expect {
+      # Pass developer_sid and auth_token in wrong order
       Poundpay.configure(
-        "DV0383d447360511e0bbac00264a09ff3c",
         "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
-        api_url="https://api-sandbox.poundpay.com",
-        version="gold",
+        "DV0383d447360511e0bbac00264a09ff3c",
       )
-      Poundpay::Resource.site.to_s.should == "https://api-sandbox.poundpay.com/gold/"
-    end
+    }.to raise_error(ArgumentError, /DV/)
+  end
+
+  it "should be configured with default api_url and version" do
+    developer_sid = "DV0383d447360511e0bbac00264a09ff3c"
+    auth_token = "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a"
+    Poundpay.configure(developer_sid, auth_token)
+    Poundpay::Resource.user.should == developer_sid
+    Poundpay::Resource.password.should == auth_token
+    Poundpay::Resource.site.to_s.should == "https://api.poundpay.com/silver/"
+  end
+
+  it "should accept optional api_url and version" do
+    Poundpay.configure(
+      "DV0383d447360511e0bbac00264a09ff3c",
+      "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
+      api_url="https://api-sandbox.poundpay.com",
+      version="gold",
+    )
+    Poundpay::Resource.site.to_s.should == "https://api-sandbox.poundpay.com/gold/"
+  end
+
+  it "should allow api_url to have a trailing backslash" do
+    Poundpay.configure(
+      "DV0383d447360511e0bbac00264a09ff3c",
+      "c31155b9f944d7aed204bdb2a253fef13b4fdcc6ae1540200449cc4526b2381a",
+      api_url="https://api-sandbox.poundpay.com/",
+      version="gold",
+    )
+    Poundpay::Resource.site.to_s.should == "https://api-sandbox.poundpay.com/gold/"
   end
 end

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 0
+  - 1
   - 0
-  - 2
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors: 
 - Matin Tamizi
@@ -31,6 +31,20 @@ dependencies:
         version: "3.0"
   type: :runtime
   version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: rspec
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 2
+        - 0
+        version: "2.0"
+  type: :development
+  version_requirements: *id002
 description: Payments platform for marketplaces
 email: devsupport@poundpay.com
 executables: []
@@ -40,7 +54,9 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
+- .autotest
 - .gitignore
+- .rspec
 - .rvmrc
 - Gemfile
 - README
@@ -53,10 +69,16 @@ files:
 - examples/simple_application/config.ru
 - examples/simple_application/index.html.erb
 - lib/poundpay.rb
+- lib/poundpay/elements.rb
 - lib/poundpay/formats.rb
 - lib/poundpay/resource.rb
 - lib/poundpay/version.rb
 - poundpay.gemspec
+- spec/fixtures/developers.rb
+- spec/fixtures/payments.rb
+- spec/poundpay/elements_spec.rb
+- spec/poundpay/formats_spec.rb
+- spec/poundpay/resource_spec.rb
 - spec/poundpay_spec.rb
 has_rdoc: true
 homepage: http://github.com/poundpay/poundpay-ruby
@@ -91,4 +113,9 @@ signing_key:
 specification_version: 3
 summary: Poundpay Ruby library
 test_files: 
+- spec/fixtures/developers.rb
+- spec/fixtures/payments.rb
+- spec/poundpay/elements_spec.rb
+- spec/poundpay/formats_spec.rb
+- spec/poundpay/resource_spec.rb
 - spec/poundpay_spec.rb