postshift 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d56e8e34b5465bcc83091a128c2357491865e88
-  data.tar.gz: 94549f9d870f3413c55f1e81ed37f2645b18bad5
+  metadata.gz: 89767224483b00b48a2bec2b34b1987cbfbcc2b0
+  data.tar.gz: e2dda97f1a6273344b5086b44a005a104321ca36
 SHA512:
-  metadata.gz: 9b8cc4652f550d94ea5036a311f864f49e8188fa93070e9be5dcc416b4c5566984070d1d4cc5340413d17c728681ef383621981c54d3c0344c380ee127c1ab6b
-  data.tar.gz: ba0f86afb60821ac0dfc69f58752ed13549b75747c23e0e44fe3e26a14a8df482ecd881ff613ae78f915237726e7b05a0f6a78bfa0a97540187e1eaa4caf8695
+  metadata.gz: fb536aa4a2d974f8b01abeec69525eef326c5ad44bb8f587fa13b2acbcac70431f86724f6f6f1d2c1343e75fa845b4489181e080e7127999b7bbc13cdaed3632
+  data.tar.gz: 11a3d8c4e862a41493448cb99596c1e9fd388694962d03b4a31d969a24fb4754815174c31047c14938c69ff27523e05dc8ecda6efbed34c5a7adee1e91ab3734

data/Appraisals

@@ -1,9 +1,17 @@
 appraise 'ar-5.0' do
+  gem 'pg', '~> 0.20.0'
   gem 'activerecord', '5.0.2'
   gem 'activesupport', '5.0.2'
 end
 
 appraise 'ar-5.1' do
+  gem 'pg', '~> 0.20.0'
   gem 'activerecord', '5.1.0'
   gem 'activesupport', '5.1.0'
 end
+
+appraise 'ar-5.2' do
+  gem 'pg', '~> 1.0.0'
+  gem 'activerecord', '5.2.0'
+  gem 'activesupport', '5.2.0'
+end

data/README.md

@@ -4,7 +4,10 @@ Amazon Redshift extension for ActiveRecord 5 (Rails 5) PostgreSQL adapter based
 
 1. Function as an extension of the PostgreSQL ActiveRecord adapter.  Overriding or extending as needed to properly account for the differences between PostgreSQL and Redshift.
 2. Create a functioning test suite.
-3. Operate within both ActiveRecord 5 and 5.1.
+3. Support the following versions of ActiveRecord:
+	* 5.0
+	* 5.1
+	* 5.2
 
 <https://github.com/ConsultingMD/activerecord5-redshift-adapter>
 
@@ -117,6 +120,7 @@ Additionally, there is multi-version test support through [Appraisal](https://gi
 appraisal install
 appraisal ar-5.0 rake spec
 appraisal ar-5.1 rake spec
+appraisal ar-5.2 rake spec
 ```
 
 ## Contributing

data/gemfiles/ar_5.0.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "pg", "~> 0.20.0"
 gem "activerecord", "5.0.2"
 gem "activesupport", "5.0.2"
 

data/gemfiles/ar_5.0.gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: ..
   specs:
-    postshift (0.1.0)
-      activerecord (>= 5.0)
-      activesupport (>= 5.0)
-      pg (~> 0.20.0)
+    postshift (0.2.1)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      pg (>= 0.20.0)
 
 GEM
   remote: https://rubygems.org/
@@ -26,30 +26,31 @@ GEM
       thor (>= 0.14.0)
     arel (7.1.4)
     concurrent-ruby (1.0.5)
-    database_cleaner (1.6.1)
+    database_cleaner (1.7.0)
     diff-lcs (1.3)
-    factory_girl (4.8.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    i18n (0.8.1)
-    minitest (5.10.2)
+    i18n (0.9.1)
+      concurrent-ruby (~> 1.0)
+    minitest (5.11.1)
     pg (0.20.0)
     rake (10.5.0)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-    thor (0.19.4)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    thor (0.20.0)
     thread_safe (0.3.6)
-    tzinfo (1.2.3)
+    tzinfo (1.2.4)
       thread_safe (~> 0.1)
 
 PLATFORMS
@@ -58,13 +59,14 @@ PLATFORMS
 DEPENDENCIES
   activerecord (= 5.0.2)
   activesupport (= 5.0.2)
-  appraisal (~> 2.2.0)
+  appraisal (~> 2.2)
   bundler (~> 1.14)
-  database_cleaner (~> 1.6.0)
-  factory_girl (~> 4.8.0)
+  database_cleaner (~> 1.7)
+  factory_bot (~> 4.8)
+  pg (~> 0.20.0)
   postshift!
   rake (~> 10.0)
   rspec (~> 3.0)
 
 BUNDLED WITH
-   1.14.6
+   1.16.1

data/gemfiles/ar_5.1.gemfile

@@ -2,6 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "pg", "~> 0.20.0"
 gem "activerecord", "5.1.0"
 gem "activesupport", "5.1.0"
 

data/gemfiles/ar_5.1.gemfile.lock

@@ -1,10 +1,10 @@
 PATH
   remote: ..
   specs:
-    postshift (0.1.0)
-      activerecord (>= 5.0)
-      activesupport (>= 5.0)
-      pg (~> 0.20.0)
+    postshift (0.2.1)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      pg (>= 0.20.0)
 
 GEM
   remote: https://rubygems.org/
@@ -26,30 +26,31 @@ GEM
       thor (>= 0.14.0)
     arel (8.0.0)
     concurrent-ruby (1.0.5)
-    database_cleaner (1.6.1)
+    database_cleaner (1.7.0)
     diff-lcs (1.3)
-    factory_girl (4.8.0)
+    factory_bot (4.8.2)
       activesupport (>= 3.0.0)
-    i18n (0.8.1)
-    minitest (5.10.2)
+    i18n (0.9.1)
+      concurrent-ruby (~> 1.0)
+    minitest (5.11.1)
     pg (0.20.0)
     rake (10.5.0)
-    rspec (3.6.0)
-      rspec-core (~> 3.6.0)
-      rspec-expectations (~> 3.6.0)
-      rspec-mocks (~> 3.6.0)
-    rspec-core (3.6.0)
-      rspec-support (~> 3.6.0)
-    rspec-expectations (3.6.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-mocks (3.6.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.6.0)
-    rspec-support (3.6.0)
-    thor (0.19.4)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    thor (0.20.0)
     thread_safe (0.3.6)
-    tzinfo (1.2.3)
+    tzinfo (1.2.4)
       thread_safe (~> 0.1)
 
 PLATFORMS
@@ -58,13 +59,14 @@ PLATFORMS
 DEPENDENCIES
   activerecord (= 5.1.0)
   activesupport (= 5.1.0)
-  appraisal (~> 2.2.0)
+  appraisal (~> 2.2)
   bundler (~> 1.14)
-  database_cleaner (~> 1.6.0)
-  factory_girl (~> 4.8.0)
+  database_cleaner (~> 1.7)
+  factory_bot (~> 4.8)
+  pg (~> 0.20.0)
   postshift!
   rake (~> 10.0)
   rspec (~> 3.0)
 
 BUNDLED WITH
-   1.14.6
+   1.16.1

data/gemfiles/ar_5.2.beta.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pg", "~> 1.0.0"
+gem "activerecord", "5.2.0.beta2"
+gem "activesupport", "5.2.0.beta2"
+
+gemspec path: "../"

data/gemfiles/ar_5.2.beta.gemfile.lock

@@ -0,0 +1,72 @@
+PATH
+  remote: ..
+  specs:
+    postshift (0.2.0)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      pg (>= 0.20.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+    activerecord (5.2.0.beta2)
+      activemodel (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      arel (>= 9.0)
+    activesupport (5.2.0.beta2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    concurrent-ruby (1.0.5)
+    database_cleaner (1.6.2)
+    diff-lcs (1.3)
+    factory_girl (4.9.0)
+      activesupport (>= 3.0.0)
+    i18n (0.9.1)
+      concurrent-ruby (~> 1.0)
+    minitest (5.11.1)
+    pg (1.0.0)
+    rake (10.5.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (= 5.2.0.beta2)
+  activesupport (= 5.2.0.beta2)
+  appraisal (~> 2.2)
+  bundler (~> 1.14)
+  database_cleaner (~> 1.6)
+  factory_girl (~> 4.8)
+  pg (~> 1.0.0)
+  postshift!
+  rake (~> 10.0)
+  rspec (~> 3.0)
+
+BUNDLED WITH
+   1.16.1

data/gemfiles/ar_5.2.gemfile

@@ -0,0 +1,10 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pg", "~> 1.0.0"
+gem "rails", git: "https://github.com/rails/rails", require: false
+gem "activerecord"
+gem "activesupport"
+
+gemspec path: "../"

data/gemfiles/ar_5.2.gemfile.lock

@@ -0,0 +1,164 @@
+GIT
+  remote: https://github.com/rails/rails
+  revision: 4c0cb1c2c9269c74588da9f114f52ea3707ae8fb
+  specs:
+    actioncable (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      nio4r (~> 2.0)
+      websocket-driver (~> 0.6.1)
+    actionmailer (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      actionview (= 5.2.0.beta2)
+      activejob (= 5.2.0.beta2)
+      mail (~> 2.5, >= 2.5.4)
+      rails-dom-testing (~> 2.0)
+    actionpack (5.2.0.beta2)
+      actionview (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      rack (~> 2.0)
+      rack-test (>= 0.6.3)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.2)
+    actionview (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.0, >= 1.0.3)
+    activejob (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      globalid (>= 0.3.6)
+    activemodel (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+    activerecord (5.2.0.beta2)
+      activemodel (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      arel (>= 9.0)
+    activestorage (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      activerecord (= 5.2.0.beta2)
+      marcel (~> 0.3.1)
+    activesupport (5.2.0.beta2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    rails (5.2.0.beta2)
+      actioncable (= 5.2.0.beta2)
+      actionmailer (= 5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      actionview (= 5.2.0.beta2)
+      activejob (= 5.2.0.beta2)
+      activemodel (= 5.2.0.beta2)
+      activerecord (= 5.2.0.beta2)
+      activestorage (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      bundler (>= 1.3.0)
+      railties (= 5.2.0.beta2)
+      sprockets-rails (>= 2.0.0)
+    railties (5.2.0.beta2)
+      actionpack (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      method_source
+      rake (>= 0.8.7)
+      thor (>= 0.18.1, < 2.0)
+
+PATH
+  remote: ..
+  specs:
+    postshift (0.2.1)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      pg (>= 0.20.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    builder (3.2.3)
+    concurrent-ruby (1.0.5)
+    crass (1.0.3)
+    database_cleaner (1.7.0)
+    diff-lcs (1.3)
+    erubi (1.7.0)
+    factory_bot (4.8.2)
+      activesupport (>= 3.0.0)
+    globalid (0.4.1)
+      activesupport (>= 4.2.0)
+    i18n (0.9.1)
+      concurrent-ruby (~> 1.0)
+    loofah (2.1.1)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
+    mail (2.7.0)
+      mini_mime (>= 0.1.1)
+    marcel (0.3.1)
+      mimemagic (~> 0.3.2)
+    method_source (0.9.0)
+    mimemagic (0.3.2)
+    mini_mime (1.0.0)
+    mini_portile2 (2.3.0)
+    minitest (5.11.1)
+    nio4r (2.2.0)
+    nokogiri (1.8.1)
+      mini_portile2 (~> 2.3.0)
+    pg (1.0.0)
+    rack (2.0.3)
+    rack-test (0.8.2)
+      rack (>= 1.0, < 3)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.0.3)
+      loofah (~> 2.0)
+    rake (10.5.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    sprockets (3.7.1)
+      concurrent-ruby (~> 1.0)
+      rack (> 1, < 3)
+    sprockets-rails (3.2.1)
+      actionpack (>= 4.0)
+      activesupport (>= 4.0)
+      sprockets (>= 3.0.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+    websocket-driver (0.6.5)
+      websocket-extensions (>= 0.1.0)
+    websocket-extensions (0.1.3)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord
+  activesupport
+  appraisal (~> 2.2)
+  bundler (~> 1.14)
+  database_cleaner (~> 1.7)
+  factory_bot (~> 4.8)
+  pg (~> 1.0.0)
+  postshift!
+  rails!
+  rake (~> 10.0)
+  rspec (~> 3.0)
+
+BUNDLED WITH
+   1.16.1

data/gemfiles/ar_5.2_beta.gemfile

@@ -0,0 +1,9 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "pg", "~> 1.0.0"
+gem "activerecord", "5.2.0.beta2"
+gem "activesupport", "5.2.0.beta2"
+
+gemspec path: "../"

data/gemfiles/ar_5.2_beta.gemfile.lock

@@ -0,0 +1,72 @@
+PATH
+  remote: ..
+  specs:
+    postshift (0.2.0)
+      activerecord (~> 5.0)
+      activesupport (~> 5.0)
+      pg (>= 0.20.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+    activerecord (5.2.0.beta2)
+      activemodel (= 5.2.0.beta2)
+      activesupport (= 5.2.0.beta2)
+      arel (>= 9.0)
+    activesupport (5.2.0.beta2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    appraisal (2.2.0)
+      bundler
+      rake
+      thor (>= 0.14.0)
+    arel (9.0.0)
+    concurrent-ruby (1.0.5)
+    database_cleaner (1.6.2)
+    diff-lcs (1.3)
+    factory_girl (4.9.0)
+      activesupport (>= 3.0.0)
+    i18n (0.9.1)
+      concurrent-ruby (~> 1.0)
+    minitest (5.11.1)
+    pg (1.0.0)
+    rake (10.5.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.0)
+    thor (0.20.0)
+    thread_safe (0.3.6)
+    tzinfo (1.2.4)
+      thread_safe (~> 0.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  activerecord (= 5.2.0.beta2)
+  activesupport (= 5.2.0.beta2)
+  appraisal (~> 2.2)
+  bundler (~> 1.14)
+  database_cleaner (~> 1.6)
+  factory_girl (~> 4.8)
+  pg (~> 1.0.0)
+  postshift!
+  rake (~> 10.0)
+  rspec (~> 3.0)
+
+BUNDLED WITH
+   1.16.1

data/lib/active_record/connection_adapters/redshift_adapter.rb

@@ -131,7 +131,7 @@ module ActiveRecord
     private
 
       # Copied from PostgreSQL with minor registration changes.  If broken out, could override segments, etc
-      def initialize_type_map(m) # :nodoc:
+      def initialize_type_map(m = type_map) # :nodoc:
         register_class_with_limit m, 'int2', Type::Integer
         register_class_with_limit m, 'int4', Type::Integer
         register_class_with_limit m, 'int8', Type::Integer

data/lib/postshift/version.rb

@@ -1,3 +1,3 @@
 module Postshift
-  VERSION = '0.2.1'
+  VERSION = '0.3.0'
 end

data/lib/tasks/v_generate_tbl_ddl.sql

@@ -41,6 +41,7 @@ History:
 2015-10-31 ericfe Added cast tp increase size of returning constraint name
 2016-05-24 chriz-bigdata Added support for BACKUP NO tables
 2017-05-03 pvbouwel Change table & schemaname of Foreign key constraints to allow for filters
+2018-01-15 pvbouwel Add QUOTE_IDENT for identifiers (schema,table and column names)
 **********************************************************************************************/
 CREATE OR REPLACE VIEW admin.v_generate_tbl_ddl
 AS
@@ -63,7 +64,7 @@ FROM
    n.nspname AS schemaname
    ,c.relname AS tablename
    ,0 AS seq
-   ,'--DROP TABLE "' + n.nspname + '"."' + c.relname + '";' AS ddl
+   ,'--DROP TABLE ' + QUOTE_IDENT(n.nspname) + '.' + QUOTE_IDENT(c.relname) + ';' AS ddl
   FROM pg_namespace AS n
   INNER JOIN pg_class AS c ON n.oid = c.relnamespace
   WHERE c.relkind = 'r'
@@ -72,7 +73,7 @@ FROM
    n.nspname AS schemaname
    ,c.relname AS tablename
    ,2 AS seq
-   ,'CREATE TABLE IF NOT EXISTS "' + n.nspname + '"."' + c.relname + '"' AS ddl
+   ,'CREATE TABLE IF NOT EXISTS ' + QUOTE_IDENT(n.nspname) + '.' + QUOTE_IDENT(c.relname) + '' AS ddl
   FROM pg_namespace AS n
   INNER JOIN pg_class AS c ON n.oid = c.relnamespace
   WHERE c.relkind = 'r'
@@ -94,7 +95,7 @@ FROM
     ,c.relname AS tablename
     ,100000000 + a.attnum AS seq
     ,CASE WHEN a.attnum > 1 THEN ',' ELSE '' END AS col_delim
-    ,'"' + a.attname + '"' AS col_name
+    ,QUOTE_IDENT(a.attname) AS col_name
     ,CASE WHEN STRPOS(UPPER(format_type(a.atttypid, a.atttypmod)), 'CHARACTER VARYING') > 0
       THEN REPLACE(UPPER(format_type(a.atttypid, a.atttypmod)), 'CHARACTER VARYING', 'VARCHAR')
      WHEN STRPOS(UPPER(format_type(a.atttypid, a.atttypmod)), 'CHARACTER') > 0
@@ -183,7 +184,7 @@ FROM pg_namespace AS n
    n.nspname AS schemaname
    ,c.relname AS tablename
    ,400000000 + a.attnum AS seq
-   ,'DISTKEY ("' + a.attname + '")' AS ddl
+   ,'DISTKEY (' + QUOTE_IDENT(a.attname) + ')' AS ddl
   FROM pg_namespace AS n
   INNER JOIN pg_class AS c ON n.oid = c.relnamespace
   INNER JOIN pg_attribute AS a ON c.oid = a.attrelid
@@ -209,8 +210,8 @@ from (SELECT
    ,c.relname AS tablename
    ,500000000 + abs(a.attsortkeyord) AS seq
    ,CASE WHEN abs(a.attsortkeyord) = 1
-    THEN '\t"' + a.attname + '"'
-    ELSE '\t, "' + a.attname + '"'
+    THEN '\t' + QUOTE_IDENT(a.attname)
+    ELSE '\t, ' + QUOTE_IDENT(a.attname)
     END AS ddl
   FROM  pg_namespace AS n
   INNER JOIN pg_class AS c ON n.oid = c.relnamespace
@@ -239,7 +240,7 @@ from (SELECT
     SELECT 'zzzzzzzz' || n.nspname AS schemaname,
        'zzzzzzzz' || c.relname AS tablename,
        700000000 + CAST(con.oid AS INT) AS seq,
-       'ALTER TABLE ' + n.nspname + '.' + c.relname + ' ADD ' + pg_get_constraintdef(con.oid)::VARCHAR(1024) + ';' AS ddl
+       'ALTER TABLE ' + QUOTE_IDENT(n.nspname) + '.' + QUOTE_IDENT(c.relname) + ' ADD ' + pg_get_constraintdef(con.oid)::VARCHAR(1024) + ';' AS ddl
     FROM pg_constraint AS con
       INNER JOIN pg_class AS c
              ON c.relnamespace = con.connamespace

data/lib/tasks/v_generate_view_ddl.sql

@@ -3,17 +3,19 @@
 Purpose: View to get the DDL for a view.  
 History:
 2014-02-10 jjschmit Created
+2018-01-15 pvbouwel Replace tabs and add QUOTE_IDENT for identifiers (schema and view names)
 **********************************************************************************************/
 CREATE OR REPLACE VIEW admin.v_generate_view_ddl
 AS
 SELECT 
-	n.nspname AS schemaname
-	,c.relname AS viewname
-	,'--DROP VIEW ' + n.nspname + '.' + c.relname + ';\nCREATE OR REPLACE VIEW ' + n.nspname + '.' + c.relname + ' AS\n' + COALESCE(pg_get_viewdef(c.oid, TRUE), '') AS ddl
+    n.nspname AS schemaname
+    ,c.relname AS viewname
+    ,'--DROP VIEW ' + QUOTE_IDENT(n.nspname) + '.' + QUOTE_IDENT(c.relname) + ';\n'
+    + 'CREATE OR REPLACE VIEW ' + QUOTE_IDENT(n.nspname) + '.' + QUOTE_IDENT(c.relname) + ' AS\n' + COALESCE(pg_get_viewdef(c.oid, TRUE), '') AS ddl
 FROM 
-	pg_catalog.pg_class AS c
+    pg_catalog.pg_class AS c
 INNER JOIN
-	pg_catalog.pg_namespace AS n
-		ON c.relnamespace = n.oid
+    pg_catalog.pg_namespace AS n
+    ON c.relnamespace = n.oid
 WHERE relkind = 'v'
 ;

data/postshift.gemspec

@@ -24,14 +24,14 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.2.2'
 
-  spec.add_dependency 'pg', '~> 0.20', '>= 0.20.0'
+  spec.add_dependency 'pg', '>= 0.20.0'
   spec.add_dependency 'activerecord', '~> 5.0'
   spec.add_dependency 'activesupport', '~> 5.0'
 
   spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'factory_girl', '~> 4.8'
-  spec.add_development_dependency 'database_cleaner', '~> 1.6'
+  spec.add_development_dependency 'factory_bot', '~> 4.8'
+  spec.add_development_dependency 'database_cleaner', '~> 1.7'
   spec.add_development_dependency 'appraisal', '~> 2.2'
 end

metadata

@@ -1,22 +1,19 @@
 --- !ruby/object:Gem::Specification
 name: postshift
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Dave Krupinski
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-24 00:00:00.000000000 Z
+date: 2018-05-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.20'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.20.0
@@ -24,9 +21,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.20'
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.20.0
@@ -101,7 +95,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: factory_girl
+  name: factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
@@ -120,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '1.7'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -150,6 +144,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
@@ -162,12 +157,17 @@ files:
 - Rakefile
 - bin/console
 - bin/setup
-- circle.yml
 - gemfiles/.bundle/config
 - gemfiles/ar_5.0.gemfile
 - gemfiles/ar_5.0.gemfile.lock
 - gemfiles/ar_5.1.gemfile
 - gemfiles/ar_5.1.gemfile.lock
+- gemfiles/ar_5.2.beta.gemfile
+- gemfiles/ar_5.2.beta.gemfile.lock
+- gemfiles/ar_5.2.gemfile
+- gemfiles/ar_5.2.gemfile.lock
+- gemfiles/ar_5.2_beta.gemfile
+- gemfiles/ar_5.2_beta.gemfile.lock
 - lib/active_record/connection_adapters/redshift/column.rb
 - lib/active_record/connection_adapters/redshift/referential_integrity.rb
 - lib/active_record/connection_adapters/redshift/schema_definitions.rb

data/circle.yml

@@ -1,9 +0,0 @@
-machine:
-  ruby:
-    version: 2.4.0
-database:
-  override:
-    - echo 'Skipping DB section.'
-test:
-  override:
-    - bundle exec rake spec:isolated