postmodern 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 65c24efcd6053881f84ed0084efe2442c0a78d82
-  data.tar.gz: ec44170dedc5a7c2f59f34f91cfb16896bb4d830
+  metadata.gz: 0fc59b87120d01d64d1be1ed192f69d0625bffd2
+  data.tar.gz: 0f7525513257d166ef098b5c111f943b99a5f6a5
 SHA512:
-  metadata.gz: 89e96ef4176c6e887e9ff106033e63d78a0287cae0b0c7908767651de6c19a863eabadf65da699bb2f483be3906696f96662638d668670e4f676a27abeb73119
-  data.tar.gz: ccd1a255715acd723db55c0619fc49574565a9d8efe2814ca97b9cb82fb75d87197875b14223150d4982c9abdc5fdcef87d516ba726d20eeb861fcb4b2b292f5
+  metadata.gz: 91e8a3dcc83684764b9a84f9fd83a27271f0cb89708058a4a86bf68dc7fb5685752d8ed4bcbde7dfd6bd496e5dffb9b72d0601b1518af5d956047226c41707a5
+  data.tar.gz: fd1996258734c3e8f70860887e71a8a3231fc40495b215ea2bcbbbc1e94763b78a42af548f83df0d1d564345385963d92c4c88a2bddb507c090ebe801835869b

data/Gemfile

@@ -5,6 +5,7 @@ gemspec
 
 group :development do
   gem 'rubocop'
+  gem 'pry-nav'
 end
 
 group :test do

data/README.md

@@ -5,6 +5,8 @@ Postmodern
 
 Tools for managing PostgreSQL databases.
 
+* WAL archiving and restoration
+
 ## Installation
 
 ```bash

data/lib/postmodern/version.rb

@@ -1,3 +1,3 @@
 module Postmodern
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/lib/postmodern/wal/base.rb

@@ -6,15 +6,16 @@ module Postmodern
       def initialize(filename, path)
         @filename = filename
         @path = path
-
-        ENV['WAL_ARCHIVE_PATH'] = path
-        ENV['WAL_ARCHIVE_FILE'] = filename
       end
 
       def run
         if local_script_exists?
-          log
-          `#{local_script} #{path} #{filename}`
+          IO.popen("#{local_script} #{path} #{filename}",
+            env: {
+              'WAL_ARCHIVE_PATH' => path,
+              'WAL_ARCHIVE_FILE' => filename,
+              'PATH' => ENV['PATH']
+            })
         end
       end
 
@@ -28,11 +29,6 @@ module Postmodern
       def local_script
         'postmodern_archive.local'
       end
-
-      def log
-        puts "Archiving file: #{filename}, path: #{path}"
-      end
     end
   end
 end
-

data/spec/bin/postmodern_spec.rb

@@ -6,19 +6,10 @@ describe 'postmodern' do
 
     before do
       double_cmd('postmodern_archive.local')
-      double_cmd('which', exit: 0)
-    end
-
-    it 'exports second argument as WAL_ARCHIVE_FILE' do
-      expect(command).to include('Archiving file: filename')
-    end
-
-    it 'exports first argument WAL_ARCHIVE_PATH' do
-      expect(command).to include('path: filepath')
     end
 
     context 'when local script is present' do
-      before { double_cmd('which postmodern_archive.local', exit: 0) }
+      before { double_cmd('which', exit: 0) }
 
       it 'succeeds' do
         expect { command }.to have_exit_status(0)
@@ -30,7 +21,7 @@ describe 'postmodern' do
     end
 
     context 'when local script is not present' do
-      before { double_cmd('which postmodern_archive.local', exit: 1) }
+      before { double_cmd('which', exit: 1) }
 
       it 'succeeds' do
         expect { command }.to have_exit_status(0)
@@ -47,19 +38,10 @@ describe 'postmodern' do
 
     before do
       double_cmd('postmodern_restore.local')
-      double_cmd('which', exit: 0)
-    end
-
-    it 'exports second argument as WAL_restore_FILE' do
-      expect(command).to include('Restoring file: filename')
-    end
-
-    it 'exports first argument WAL_restore_PATH' do
-      expect(command).to include('path: filepath')
     end
 
     context 'when local script is present' do
-      before { double_cmd('which postmodern_restore.local', exit: 0) }
+      before { double_cmd('which', exit: 0) }
 
       it 'succeeds' do
         expect { command }.to have_exit_status(0)
@@ -71,7 +53,7 @@ describe 'postmodern' do
     end
 
     context 'when local script is not present' do
-      before { double_cmd('which postmodern_restore.local', exit: 1) }
+      before { double_cmd('which', exit: 1) }
 
       it 'succeeds' do
         expect { command }.to have_exit_status(0)

data/spec/postmodern/wal/archive_spec.rb

@@ -0,0 +1,39 @@
+require 'spec_helper'
+require 'postmodern/wal/archive'
+
+describe Postmodern::WAL::Archive do
+  before { allow(IO).to receive(:popen) }
+
+  let(:filename) { "some_file" }
+  let(:path) { "/path/to/file" }
+
+  subject(:archiver) { Postmodern::WAL::Archive.new(filename, path) }
+
+  describe '#run' do
+    let(:expected_command) { "postmodern_archive.local #{path} #{filename}" }
+
+    context 'when local script exists' do
+      before { double_cmd('which postmodern_archive.local', exit: 0) }
+
+      it 'executes postmodern_archive.local with filename and path' do
+        archiver.run
+        expect(IO).to have_received(:popen).with(expected_command, env:
+          {
+            'WAL_ARCHIVE_PATH' => path,
+            'WAL_ARCHIVE_FILE' => filename,
+            'PATH' => anything
+          }
+        )
+      end
+    end
+
+    context 'when local script does not exist' do
+      before { double_cmd('which postmodern_archive.local', exit: 1) }
+
+      it 'executes postmodern_archive.local with filename and path' do
+        archiver.run
+        expect(IO).not_to have_received(:popen)
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'aruba/rspec'
+require 'pry'
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postmodern
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Eric Saxby
@@ -64,6 +64,7 @@ files:
 - lib/postmodern/wal/restore.rb
 - postmodern.gemspec
 - spec/bin/postmodern_spec.rb
+- spec/postmodern/wal/archive_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/wanelo/postmodern
 licenses:
@@ -91,5 +92,6 @@ specification_version: 4
 summary: Tools for managing PostgreSQL
 test_files:
 - spec/bin/postmodern_spec.rb
+- spec/postmodern/wal/archive_spec.rb
 - spec/spec_helper.rb
 has_rdoc: