postmark 1.25.0 → 1.25.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b36e7eff4dabb977637da4527446a61f1f5b1907b0d327fefee9b9068f9ee874
-  data.tar.gz: c65b4c7bb6b1e7529f3b202d93e0898fdb51a067ae8496a8c8ae04b0eca9eb48
+  metadata.gz: 90fcc71a7a7018bbcd3e4784d0276291a511ada74d290f284ca88d0909aea119
+  data.tar.gz: 8f7474cc7af5f878fd3ffee1f98e8eeab4361e48981359794f0426411c7659ee
 SHA512:
-  metadata.gz: 122e2d925a0dcff98d93fbd60d11db94c5e8f443b73cf67a20eea839a07fd4955fcf0e782a1e49bc3ee9abf0593f8d513a957e6541bc6774ecfb1b1268d152d9
-  data.tar.gz: 7db9801b4d8cbdb47c6d8b277d03871ea40ccacb62df06e10169f61cf3368c416e41699a65cfd0f667e0889df7c88e796b0ae4fbac30832a84644644ff63bfdf
+  metadata.gz: c90ab55895ab6b55b399e137e5193cc4465d081d554611df9e60751b0167102ffe598594d83c9ff2f94aac0a5ec165ed17cc94386807c9958ec10889972d6d9a
+  data.tar.gz: 9857b3188c3dec4daeaa1217cf0c6e8ce1142a7f057556b931e19ca8c981ed8812d2443a26757f1b7474080d2f406c22404c6b9e4f3021c7ca9326bc10c17428

data/CHANGELOG.rdoc

@@ -1,5 +1,8 @@
 = Changelog
 
+== 1.25.1
+* Fix: Postmark::AccountApiClient would mutate "options" argument 
+
 == 1.25.0
 * Add support for https://postmarkapp.com/developer/api/data-removals-api
 

data/README.md

@@ -23,8 +23,8 @@ For details about Postmark API in general, please check out [Postmark developer
 You will need a Postmark account, server and sender signature (or verified domain) set up to use it. For details about setup, check out [wiki pages](https://github.com/ActiveCampaign/postmark-gem/wiki/Getting-Started).
 
 If you plan using the library in a Rails project, check out the [postmark-rails](https://github.com/ActiveCampaign/postmark-rails/) gem, which
-is meant to integrate with ActionMailer. The plugin will try to use ActiveSupport JSon if it is already included. If not,
-it will attempt to use the built-in Ruby JSon library.
+is meant to integrate with ActionMailer. The plugin will try to use ActiveSupport JSON if it is already included. If not,
+it will attempt to use the built-in Ruby JSON library.
 
 You can also explicitly specify which one to be used, using following code:
 

data/VERSION

@@ -1 +1 @@
-1.25.0
+1.25.1

data/lib/postmark/account_api_client.rb

@@ -3,6 +3,7 @@ module Postmark
   class AccountApiClient < Client
 
     def initialize(api_token, options = {})
+      options = options.dup
       options[:auth_header_name] = 'X-Postmark-Account-Token'
       super
     end

data/lib/postmark/version.rb

@@ -1,3 +1,3 @@
 module Postmark
-  VERSION = '1.25.0'
+  VERSION = '1.25.1'
 end

data/postmark.gemspec

@@ -21,6 +21,10 @@ Gem::Specification.new do |s|
   s.executables      = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths    = ["lib"]
 
+  if s.respond_to?(:metadata) # not supported in Bundler/Ruby 1.x
+    s.metadata["changelog_uri"] = "https://github.com/ActiveCampaign/postmark-gem/blob/main/CHANGELOG.rdoc"
+  end
+
   s.post_install_message = %q{
     ==================
     Thanks for installing the postmark gem. If you don't have an account, please

data/spec/unit/postmark/account_api_client_spec.rb

@@ -12,6 +12,13 @@ describe Postmark::AccountApiClient do
     expect { subject.new(api_token, :http_read_timeout => 5) }.not_to raise_error
   end
 
+  it "doesn't mutate options hash" do
+    options = { "my_option" => true }
+    subject.new(api_token, options)
+
+    expect(options).to eq({ "my_option" => true })
+  end
+
   context 'instance' do
     subject { Postmark::AccountApiClient.new(api_token) }
 
@@ -37,7 +44,8 @@ describe Postmark::AccountApiClient do
       end
 
       it 'lazily loads senders' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
+            exactly(5).times.
             with('senders', an_instance_of(Hash)).and_return(response)
         subject.senders.take(1000)
       end
@@ -63,20 +71,20 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a GET request to /senders endpoint' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('senders', :offset => 0, :count => 30).
             and_return(response)
         subject.get_senders
       end
 
       it 'formats the keys of returned list of senders' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_senders.map { |s| s.keys }.flatten
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
 
       it 'accepts offset and count options' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('senders', :offset => 10, :count => 42).
             and_return(response)
         subject.get_senders(:offset => 10, :count => 42)
@@ -92,7 +100,7 @@ describe Postmark::AccountApiClient do
       end
 
       it 'returns a total number of senders' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('senders', an_instance_of(Hash)).and_return(response)
         expect(subject.get_senders_count).to eq(42)
       end
@@ -115,13 +123,13 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a GET request to /senders/:id endpoint' do
-        allow(subject.http_client).to receive(:get).with("senders/42").
+        expect(subject.http_client).to receive(:get).with("senders/42").
                                                     and_return(response)
         subject.get_sender(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_sender(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -144,19 +152,19 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a POST request to /senders endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with("senders", an_instance_of(String)).and_return(response)
         subject.create_sender(:name => 'Chris Nagele')
       end
 
       it 'converts the sender attributes names to camel case' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with("senders", {'FooBar' => 'bar'}.to_json).and_return(response)
         subject.create_sender(:foo_bar => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.create_sender(:foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -180,19 +188,19 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a PUT request to /senders/:id endpoint' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with('senders/42', an_instance_of(String)).and_return(response)
         subject.update_sender(42, :name => 'Chris Nagele')
       end
 
       it 'converts the sender attributes names to camel case' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with('senders/42', {'FooBar' => 'bar'}.to_json).and_return(response)
         subject.update_sender(42, :foo_bar => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:put).and_return(response)
+        expect(subject.http_client).to receive(:put).and_return(response)
         keys = subject.update_sender(42, :foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -212,13 +220,13 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a POST request to /senders/:id/resend endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('senders/42/resend').and_return(response)
         subject.resend_sender_confirmation(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.resend_sender_confirmation(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -233,18 +241,18 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a POST request to /senders/:id/verifyspf endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('senders/42/verifyspf').and_return(response)
         subject.verified_sender_spf?(42)
       end
 
       it 'returns false when SPFVerified field of the response is false' do
-        allow(subject.http_client).to receive(:post).and_return(false_response)
+        expect(subject.http_client).to receive(:post).and_return(false_response)
         expect(subject.verified_sender_spf?(42)).to be false
       end
 
       it 'returns true when SPFVerified field of the response is true' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         expect(subject.verified_sender_spf?(42)).to be true
       end
     end
@@ -267,13 +275,13 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a POST request to /senders/:id/requestnewdkim endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('senders/42/requestnewdkim').and_return(response)
         subject.request_new_sender_dkim(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.request_new_sender_dkim(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -292,13 +300,13 @@ describe Postmark::AccountApiClient do
       end
 
       it 'performs a DELETE request to /senders/:id endpoint' do
-        allow(subject.http_client).to receive(:delete).
+        expect(subject.http_client).to receive(:delete).
             with('senders/42').and_return(response)
         subject.delete_sender(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:delete).and_return(response)
+        expect(subject.http_client).to receive(:delete).and_return(response)
         keys = subject.delete_sender(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -312,7 +320,8 @@ describe Postmark::AccountApiClient do
       end
 
       it 'lazily loads domains' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
+            exactly(5).times.
             with('domains', an_instance_of(Hash)).and_return(response)
         subject.domains.take(1000)
       end
@@ -332,20 +341,20 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a GET request to /domains endpoint' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('domains', :offset => 0, :count => 30).
             and_return(response)
         subject.get_domains
       end
 
       it 'formats the keys of returned list of domains' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_domains.map { |s| s.keys }.flatten
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
 
       it 'accepts offset and count options' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('domains', :offset => 10, :count => 42).
             and_return(response)
         subject.get_domains(:offset => 10, :count => 42)
@@ -357,7 +366,7 @@ describe Postmark::AccountApiClient do
       let(:response) { {'TotalCount' => 42} }
 
       it 'returns a total number of domains' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('domains', an_instance_of(Hash)).and_return(response)
         expect(subject.get_domains_count).to eq(42)
       end
@@ -372,13 +381,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a GET request to /domains/:id endpoint' do
-        allow(subject.http_client).to receive(:get).with("domains/42").
+        expect(subject.http_client).to receive(:get).with("domains/42").
                                                     and_return(response)
         subject.get_domain(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_domain(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -393,19 +402,19 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a POST request to /domains endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with("domains", an_instance_of(String)).and_return(response)
         subject.create_domain(:name => 'example.com')
       end
 
       it 'converts the domain attributes names to camel case' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with("domains", {'FooBar' => 'bar'}.to_json).and_return(response)
         subject.create_domain(:foo_bar => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.create_domain(:foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -421,19 +430,19 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a PUT request to /domains/:id endpoint' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with('domains/42', an_instance_of(String)).and_return(response)
         subject.update_domain(42, :return_path_domain => 'updated-return.example.com')
       end
 
       it 'converts the domain attributes names to camel case' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with('domains/42', {'FooBar' => 'bar'}.to_json).and_return(response)
         subject.update_domain(42, :foo_bar => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:put).and_return(response)
+        expect(subject.http_client).to receive(:put).and_return(response)
         keys = subject.update_domain(42, :foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -444,18 +453,18 @@ describe Postmark::AccountApiClient do
       let(:false_response) { {"SPFVerified" => false} }
 
       it 'performs a POST request to /domains/:id/verifyspf endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('domains/42/verifyspf').and_return(response)
         subject.verified_domain_spf?(42)
       end
 
       it 'returns false when SPFVerified field of the response is false' do
-        allow(subject.http_client).to receive(:post).and_return(false_response)
+        expect(subject.http_client).to receive(:post).and_return(false_response)
         expect(subject.verified_domain_spf?(42)).to be false
       end
 
       it 'returns true when SPFVerified field of the response is true' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         expect(subject.verified_domain_spf?(42)).to be true
       end
     end
@@ -469,13 +478,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a POST request to /domains/:id/rotatedkim endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('domains/42/rotatedkim').and_return(response)
         subject.rotate_domain_dkim(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.rotate_domain_dkim(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -490,13 +499,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a DELETE request to /domains/:id endpoint' do
-        allow(subject.http_client).to receive(:delete).
+        expect(subject.http_client).to receive(:delete).
             with('domains/42').and_return(response)
         subject.delete_domain(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:delete).and_return(response)
+        expect(subject.http_client).to receive(:delete).and_return(response)
         keys = subject.delete_sender(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -510,7 +519,8 @@ describe Postmark::AccountApiClient do
       end
 
       it 'lazily loads servers' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
+            exactly(5).times.
             with('servers', an_instance_of(Hash)).and_return(response)
         subject.servers.take(100)
       end
@@ -542,19 +552,19 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a GET request to /servers endpoint' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('servers', an_instance_of(Hash)).and_return(response)
         subject.get_servers
       end
 
       it 'formats the keys of returned list of servers' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_servers.map { |s| s.keys }.flatten
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
 
       it 'accepts offset and count options' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('servers', :offset => 30, :count => 50).
             and_return(response)
         subject.get_servers(:offset => 30, :count => 50)
@@ -582,13 +592,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a GET request to /servers/:id endpoint' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('servers/42').and_return(response)
         subject.get_server(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_server(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -598,7 +608,7 @@ describe Postmark::AccountApiClient do
       let(:response) { {'TotalCount' => 42} }
 
       it 'returns a total number of servers' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
             with('servers', an_instance_of(Hash)).and_return(response)
         expect(subject.get_servers_count).to eq(42)
       end
@@ -619,20 +629,20 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a POST request to /servers endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('servers', an_instance_of(String)).and_return(response)
         subject.create_server(:foo => 'bar')
       end
 
       it 'converts the server attribute names to camel case' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
             with('servers', {'FooBar' => 'foo_bar'}.to_json).
             and_return(response)
         subject.create_server(:foo_bar => 'foo_bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.create_server(:foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -659,21 +669,21 @@ describe Postmark::AccountApiClient do
       }
 
       it 'converts the server attribute names to camel case' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with(an_instance_of(String), {'FooBar' => 'foo_bar'}.to_json).
             and_return(response)
         subject.update_server(42, :foo_bar => 'foo_bar')
       end
 
       it 'performs a PUT request to /servers/:id endpoint' do
-        allow(subject.http_client).to receive(:put).
+        expect(subject.http_client).to receive(:put).
             with('servers/42', an_instance_of(String)).
             and_return(response)
         subject.update_server(42, :foo => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:put).and_return(response)
+        expect(subject.http_client).to receive(:put).and_return(response)
         keys = subject.update_server(42, :foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -688,13 +698,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a DELETE request to /servers/:id endpoint' do
-        allow(subject.http_client).to receive(:delete).
+        expect(subject.http_client).to receive(:delete).
             with('servers/42').and_return(response)
         subject.delete_server(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:delete).and_return(response)
+        expect(subject.http_client).to receive(:delete).and_return(response)
         keys = subject.delete_server(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -711,7 +721,7 @@ describe Postmark::AccountApiClient do
       let(:request_data) {{:source_server_id => 1, :destination_server_id => 2, :perform_changes => false}}
 
       it 'gets templates info and converts it to ruby format' do
-        allow(subject.http_client).to receive(:put).and_return(response)
+        expect(subject.http_client).to receive(:put).and_return(response)
         templates = subject.push_templates({:source_server_id => 1, :destination_server_id => 2, :perform_changes => false} )
 
         expect(templates.size).to eq(2)
@@ -720,7 +730,7 @@ describe Postmark::AccountApiClient do
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:put).and_return(response)
+        expect(subject.http_client).to receive(:put).and_return(response)
         templates = subject.push_templates({:source_server_id => 1, :destination_server_id => 2, :perform_changes => false} )
 
         keys = templates.map { |template| template.keys }.flatten
@@ -737,13 +747,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a GET request to /data-removals/:id endpoint' do
-        allow(subject.http_client).to receive(:get).
+        expect(subject.http_client).to receive(:get).
           with('data-removals/42').and_return(response)
         subject.get_data_removal_status(42)
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:get).and_return(response)
+        expect(subject.http_client).to receive(:get).and_return(response)
         keys = subject.get_data_removal_status(42).keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end
@@ -758,13 +768,13 @@ describe Postmark::AccountApiClient do
       }
 
       it 'performs a POST request to /data-removals endpoint' do
-        allow(subject.http_client).to receive(:post).
+        expect(subject.http_client).to receive(:post).
           with('data-removals', an_instance_of(String)).and_return(response)
         subject.request_data_removal(:foo => 'bar')
       end
 
       it 'formats the keys of returned response' do
-        allow(subject.http_client).to receive(:post).and_return(response)
+        expect(subject.http_client).to receive(:post).and_return(response)
         keys = subject.request_data_removal(:foo => 'bar').keys
         expect(keys.all? { |k| k.is_a?(Symbol) }).to be true
       end

data/spec/unit/postmark/api_client_spec.rb

@@ -161,7 +161,7 @@ describe Postmark::ApiClient do
     end
 
     it "proxies errors" do
-      allow(http_client).to receive(:post).and_raise(Postmark::TimeoutError)
+      expect(http_client).to receive(:post).and_raise(Postmark::TimeoutError)
       expect {subject}.to raise_error(Postmark::TimeoutError)
     end
 
@@ -188,7 +188,7 @@ describe Postmark::ApiClient do
     end
 
     it "proxies errors" do
-      allow(http_client).to receive(:post).and_raise(Postmark::TimeoutError)
+      expect(http_client).to receive(:post).and_raise(Postmark::TimeoutError)
       expect {subject}.to raise_error(Postmark::TimeoutError)
     end
 
@@ -262,7 +262,7 @@ describe Postmark::ApiClient do
       end
 
       it 'loads outbound messages' do
-        allow(api_client.http_client).to receive(:get).
+        expect(api_client.http_client).to receive(:get).
             with('messages/outbound', an_instance_of(Hash)).and_return(response)
         expect(api_client.messages.count).to eq(5)
       end
@@ -276,7 +276,7 @@ describe Postmark::ApiClient do
       end
 
       it 'loads inbound messages' do
-        allow(api_client.http_client).to receive(:get).with('messages/inbound', an_instance_of(Hash)).and_return(response)
+        expect(api_client.http_client).to receive(:get).with('messages/inbound', an_instance_of(Hash)).and_return(response)
         expect(api_client.messages(:inbound => true).count).to eq(5)
       end
     end
@@ -308,19 +308,22 @@ describe Postmark::ApiClient do
     let(:response) {{'TotalCount' => 42}}
 
     context 'given outbound' do
-
-      it 'requests and returns outbound messages count' do
-        allow(api_client.http_client).to receive(:get).
+      it 'requests and returns outbound messages count by default' do
+        expect(api_client.http_client).to receive(:get).
             with('messages/outbound', an_instance_of(Hash)).and_return(response)
         expect(api_client.get_messages_count).to eq(42)
-        expect(api_client.get_messages_count(:inbound => false)).to eq(42)
       end
 
+      it 'requests and returns outbound messages count when inbound => false' do
+        expect(api_client.http_client).to receive(:get).
+          with('messages/outbound', an_instance_of(Hash)).and_return(response)
+        expect(api_client.get_messages_count(:inbound => false)).to eq(42)
+      end
     end
 
     context 'given inbound' do
       it 'requests and returns inbound messages count' do
-        allow(api_client.http_client).to receive(:get).
+        expect(api_client.http_client).to receive(:get).
             with('messages/inbound', an_instance_of(Hash)).and_return(response)
         expect(api_client.get_messages_count(:inbound => true)).to eq(42)
       end
@@ -382,7 +385,7 @@ describe Postmark::ApiClient do
     end
 
     it 'requests data at /bounces' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with('bounces', an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Bounces' => [{}])
       expect(api_client.bounces.first(5).count).to eq(1)
@@ -394,9 +397,10 @@ describe Postmark::ApiClient do
     let(:response) {{"Bounces" => []}}
 
     it 'requests data at /bounces' do
-      allow(http_client).to receive(:get).with("bounces", options) {response}
-      expect(api_client.get_bounces(options)).to be_an(Array)
-      expect(api_client.get_bounces(options).count).to be_zero
+      expect(http_client).to receive(:get).with("bounces", options) {response}
+      result = api_client.get_bounces(options)
+      expect(result).to be_an(Array)
+      expect(result.count).to be_zero
     end
   end
 
@@ -434,7 +438,7 @@ describe Postmark::ApiClient do
     end
 
     it 'performs a GET request to /opens/tags' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with('messages/outbound/opens', an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Opens' => [{}])
       expect(api_client.opens.first(5).count).to eq(1)
@@ -447,7 +451,7 @@ describe Postmark::ApiClient do
     end
 
     it 'performs a GET request to /clicks/tags' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with('messages/outbound/clicks', an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Clicks' => [{}])
       expect(api_client.clicks.first(5).count).to eq(1)
@@ -459,9 +463,10 @@ describe Postmark::ApiClient do
     let(:response) {{'Opens' => [], 'TotalCount' => 0}}
 
     it 'performs a GET request to /messages/outbound/opens' do
-      allow(http_client).to receive(:get).with('messages/outbound/opens', options) {response}
-      expect(api_client.get_opens(options)).to be_an(Array)
-      expect(api_client.get_opens(options).count).to be_zero
+      expect(http_client).to receive(:get).with('messages/outbound/opens', options) {response}
+      result = api_client.get_opens(options)
+      expect(result).to be_an(Array)
+      expect(result.count).to be_zero
     end
   end
 
@@ -470,9 +475,10 @@ describe Postmark::ApiClient do
     let(:response) {{'Clicks' => [], 'TotalCount' => 0}}
 
     it 'performs a GET request to /messages/outbound/clicks' do
-      allow(http_client).to receive(:get).with('messages/outbound/clicks', options) {response}
-      expect(api_client.get_clicks(options)).to be_an(Array)
-      expect(api_client.get_clicks(options).count).to be_zero
+      expect(http_client).to receive(:get).with('messages/outbound/clicks', options) {response}
+      result = api_client.get_clicks(options)
+      expect(result).to be_an(Array)
+      expect(result.count).to be_zero
     end
   end
 
@@ -482,9 +488,10 @@ describe Postmark::ApiClient do
     let(:response) {{'Opens' => [], 'TotalCount' => 0}}
 
     it 'performs a GET request to /messages/outbound/opens' do
-      allow(http_client).to receive(:get).with("messages/outbound/opens/#{message_id}", options).and_return(response)
-      expect(api_client.get_opens_by_message_id(message_id, options)).to be_an(Array)
-      expect(api_client.get_opens_by_message_id(message_id, options).count).to be_zero
+      expect(http_client).to receive(:get).with("messages/outbound/opens/#{message_id}", options).and_return(response)
+      result = api_client.get_opens_by_message_id(message_id, options)
+      expect(result).to be_an(Array)
+      expect(result.count).to be_zero
     end
   end
 
@@ -494,9 +501,10 @@ describe Postmark::ApiClient do
     let(:response) {{'Clicks' => [], 'TotalCount' => 0}}
 
     it 'performs a GET request to /messages/outbound/clicks' do
-      allow(http_client).to receive(:get).with("messages/outbound/clicks/#{message_id}", options).and_return(response)
-      expect(api_client.get_clicks_by_message_id(message_id, options)).to be_an(Array)
-      expect(api_client.get_clicks_by_message_id(message_id, options).count).to be_zero
+      expect(http_client).to receive(:get).with("messages/outbound/clicks/#{message_id}", options).and_return(response)
+      result = api_client.get_clicks_by_message_id(message_id, options)
+      expect(result).to be_an(Array)
+      expect(result.count).to be_zero
     end
   end
 
@@ -508,7 +516,7 @@ describe Postmark::ApiClient do
     end
 
     it 'performs a GET request to /opens/tags' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with("messages/outbound/opens/#{message_id}", an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Opens' => [{}])
       expect(api_client.opens_by_message_id(message_id).first(5).count).to eq(1)
@@ -523,7 +531,7 @@ describe Postmark::ApiClient do
     end
 
     it 'performs a GET request to /clicks/tags' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with("messages/outbound/clicks/#{message_id}", an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Clicks' => [{}])
       expect(api_client.clicks_by_message_id(message_id).first(5).count).to eq(1)
@@ -536,13 +544,13 @@ describe Postmark::ApiClient do
       let(:response) {{'Rule' => 'example.com'}}
 
       it 'performs a POST request to /triggers/inboundrules with given options' do
-        allow(http_client).to receive(:post).with('triggers/inboundrules',
+        expect(http_client).to receive(:post).with('triggers/inboundrules',
                                                   {'Rule' => 'example.com'}.to_json)
         api_client.create_trigger(:inbound_rules, options)
       end
 
       it 'symbolizes response keys' do
-        allow(http_client).to receive(:post).and_return(response)
+        expect(http_client).to receive(:post).and_return(response)
         expect(api_client.create_trigger(:inbound_rules, options)).to eq(:rule => 'example.com')
       end
     end
@@ -552,12 +560,12 @@ describe Postmark::ApiClient do
     let(:id) {42}
 
     it 'performs a GET request to /triggers/tags/:id' do
-      allow(http_client).to receive(:get).with("triggers/tags/#{id}")
+      expect(http_client).to receive(:get).with("triggers/tags/#{id}")
       api_client.get_trigger(:tags, id)
     end
 
     it 'symbolizes response keys' do
-      allow(http_client).to receive(:get).and_return('Foo' => 'Bar')
+      expect(http_client).to receive(:get).and_return('Foo' => 'Bar')
       expect(api_client.get_trigger(:tags, id)).to eq(:foo => 'Bar')
     end
   end
@@ -567,12 +575,12 @@ describe Postmark::ApiClient do
       let(:id) {42}
 
       it 'performs a DELETE request to /triggers/tags/:id' do
-        allow(http_client).to receive(:delete).with("triggers/tags/#{id}")
+        expect(http_client).to receive(:delete).with("triggers/tags/#{id}")
         api_client.delete_trigger(:tags, id)
       end
 
       it 'symbolizes response keys' do
-        allow(http_client).to receive(:delete).and_return('Foo' => 'Bar')
+        expect(http_client).to receive(:delete).and_return('Foo' => 'Bar')
         expect(api_client.delete_trigger(:tags, id)).to eq(:foo => 'Bar')
       end
     end
@@ -581,12 +589,12 @@ describe Postmark::ApiClient do
       let(:id) {42}
 
       it 'performs a DELETE request to /triggers/inboundrules/:id' do
-        allow(http_client).to receive(:delete).with("triggers/inboundrules/#{id}")
+        expect(http_client).to receive(:delete).with("triggers/inboundrules/#{id}")
         api_client.delete_trigger(:inbound_rules, id)
       end
 
       it 'symbolizes response keys' do
-        allow(http_client).to receive(:delete).and_return('Rule' => 'example.com')
+        expect(http_client).to receive(:delete).and_return('Rule' => 'example.com')
         expect(api_client.delete_trigger(:tags, id)).to eq(:rule => 'example.com')
       end
     end
@@ -599,9 +607,10 @@ describe Postmark::ApiClient do
       let(:response) {{'InboundRules' => [], 'TotalCount' => 0}}
 
       it 'performs a GET request to /triggers/inboundrules' do
-        allow(http_client).to receive(:get).with('triggers/inboundrules', options) {response}
-        expect(api_client.get_triggers(:inbound_rules, options)).to be_an(Array)
-        expect(api_client.get_triggers(:inbound_rules, options).count).to be_zero
+        expect(http_client).to receive(:get).with('triggers/inboundrules', options) {response}
+        result = api_client.get_triggers(:inbound_rules, options)
+        expect(result).to be_an(Array)
+        expect(result.count).to be_zero
       end
     end
   end
@@ -612,7 +621,7 @@ describe Postmark::ApiClient do
     end
 
     it 'performs a GET request to /triggers/tags' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with('triggers/tags', an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Tags' => [{}])
       expect(api_client.triggers(:tags).first(5).count).to eq(1)
@@ -688,7 +697,7 @@ describe Postmark::ApiClient do
     end
 
     it 'requests data at /templates' do
-      allow(api_client.http_client).to receive(:get).
+      expect(api_client.http_client).to receive(:get).
           with('templates', an_instance_of(Hash)).
           and_return('TotalCount' => 1, 'Templates' => [{}])
       expect(api_client.templates.first(5).count).to eq(1)
@@ -1025,7 +1034,7 @@ describe Postmark::ApiClient do
     subject(:result) { api_client.get_message_streams(:offset => 22, :count => 33) }
 
     before do
-      allow(http_client).to receive(:get).
+      expect(http_client).to receive(:get).
         with('message-streams', :offset => 22, :count => 33).
         and_return({ 'TotalCount' => 1, 'MessageStreams' => [{'Name' => 'abc'}]})
     end
@@ -1045,7 +1054,7 @@ describe Postmark::ApiClient do
     it { is_expected.to be_kind_of(Enumerable) }
 
     it 'requests data at /message-streams' do
-      allow(http_client).to receive(:get).
+      expect(http_client).to receive(:get).
         with('message-streams', anything).
         and_return('TotalCount' => 1, 'MessageStreams' => [{}])
       expect(subject.first(5).count).to eq(1)
@@ -1056,7 +1065,7 @@ describe Postmark::ApiClient do
     subject(:result) { api_client.get_message_stream(123) }
 
     before do
-      allow(http_client).to receive(:get).
+      expect(http_client).to receive(:get).
         with('message-streams/123').
         and_return({
           'Id' => 'xxx',

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postmark
 version: !ruby/object:Gem::Version
-  version: 1.25.0
+  version: 1.25.1
 platform: ruby
 authors:
 - Tomek Maszkowski
@@ -13,7 +13,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-10-11 00:00:00.000000000 Z
+date: 2024-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -133,7 +133,8 @@ files:
 homepage: https://postmarkapp.com
 licenses:
 - MIT
-metadata: {}
+metadata:
+  changelog_uri: https://github.com/ActiveCampaign/postmark-gem/blob/main/CHANGELOG.rdoc
 post_install_message: "\n    ==================\n    Thanks for installing the postmark
   gem. If you don't have an account, please\n    sign up at https://postmarkapp.com/.\n\n
   \   Review the README.md for implementation details and examples.\n    ==================\n