postmark 1.12.0 → 1.13.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7d65fe77b30becc8c00a0e19a057d885176f20dd
-  data.tar.gz: df33b575861a790eaea91e65ff7d937fd7c0be03
+  metadata.gz: b3eb03641468ddcbee6aab9cdc449257f5bb309c
+  data.tar.gz: 19f4463b421ead1daae9e1121a1a24e5a4485c98
 SHA512:
-  metadata.gz: 001d1b715e69f99ee6eb3a7f1dc63f282f51ef1b8dbe3acf42344e4c421cbc8d5cd23f269c2525460499d4d8ece1f7060355e747bb758024f0ffbcfe9aa5bf5e
-  data.tar.gz: 83ad3ace1faa7086fd327afdd2676737aeae6130fe4f9013e79e291984e0a8bab0f47e44247aa518f41d49fca04aed686e5afa9ced07ba4821621debc1131569
+  metadata.gz: ad68cc4ef04239f9a222d0a9426e9d0c8b8bdd696741990ff06076e34c8d4e1a9ff1ebaec7f0f2539ddd3b8147fba3c311286988f519b8121aa5ea71e9687a42
+  data.tar.gz: 356a337ee74c68a196f11110537a2ab525ec4d446e597c32c8df0fb69166e03ef67aa0d317a3904cfe5c00cec39729c78be5c21c654919efa40ef972b395c8ea

data/CHANGELOG.rdoc

@@ -1,5 +1,10 @@
 = Changelog
 
+== 1.13.0
+
+* Changed default value returned by Mail::Message#metadata to a mutable hash (makes things easier for postmark-rails).
+* All message JSON payloads now include an empty metadata object even if metadata is unset.
+
 == 1.12.0
 
 * Added support for attaching metadata to messages.

data/VERSION

@@ -1 +1 @@
-1.12.0
+1.13.0

data/lib/postmark/mail_message_converter.rb

@@ -32,7 +32,7 @@ module Postmark
         'Tag' => @message.tag.to_s,
         'TrackOpens' => (cast_to_bool(@message.track_opens) unless @message.track_opens.empty?),
         'TrackLinks' => (::Postmark::Inflector.to_postmark(@message.track_links) unless @message.track_links.empty?),
-        'Metadata' => (@message.metadata unless @message.metadata.nil?)
+        'Metadata' => @message.metadata
       }
     end
 

data/lib/postmark/message_extensions/mail.rb

@@ -34,8 +34,11 @@ module Mail
     end
 
     def metadata(val = nil)
-      @metadata=val unless val.nil?
-      @metadata
+      if val
+        @metadata = val
+      else
+        @metadata ||= {}
+      end
     end
 
     def metadata=(val)

data/lib/postmark/version.rb

@@ -1,3 +1,3 @@
 module Postmark
-  VERSION = '1.12.0'
+  VERSION = '1.13.0'
 end

data/spec/unit/postmark/mail_message_converter_spec.rb

@@ -328,7 +328,7 @@ describe Postmark::MailMessageConverter do
 
     it 'converts multiple metadata fields' do
       metadata = {}
-      metadata = 10.times { |i| metadata["test#{i+1}"] = "t"*80 }
+      10.times { |i| metadata["test#{i+1}"] = "t"*80 }
       msg = mail_html_message
       msg.metadata = metadata
       expect(subject.new(msg).run).to include('Metadata' => metadata)

data/spec/unit/postmark/message_extensions/mail_spec.rb

@@ -88,24 +88,20 @@ describe Mail::Message do
   end
 
   describe '#metadata' do
-    let(:metadata) {{:test => "test"}}
+    let(:metadata) { { :test => 'test' } }
 
-    it 'returns nil if unset' do
-      expect(mail_message.metadata).to eq nil
+    it 'returns a mutable empty hash if unset' do
+      expect(mail_message.metadata).to eq({})
+      expect(mail_message.metadata.equal?(mail_message.metadata)).to be true
     end
 
-    context 'when assigned via #metadata=' do
-      it 'returns assigned value' do
-        mail_message.metadata=metadata
-        expect(mail_message.metadata).to eq metadata
-      end
+    it 'supports assigning non-null values (for the builder DSL)' do
+      expect { mail_message.metadata(metadata) }.to change { mail_message.metadata }.to(metadata)
+      expect { mail_message.metadata(nil) }.to_not change { mail_message.metadata }
     end
 
-    context 'when assigned via metadata()' do
-      it 'returns assigned value' do
-        mail_message.metadata(metadata)
-        expect(mail_message.metadata).to eq metadata
-      end
+    it 'returns value assigned via metadata=' do
+      expect { mail_message.metadata = metadata }.to change { mail_message.metadata }.to(metadata)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postmark
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.13.0
 platform: ruby
 authors:
 - Petyo Ivanov
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-07-02 00:00:00.000000000 Z
+date: 2018-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake