posthog-rails 3.18.0 → 3.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 39083887214818f6cd6251a610b87166f0e5c1496a5bae1fbc724c311c964dd3
-  data.tar.gz: 207e9ab104f2b4f0c075e847208624fb34270a6b3616c5cf5c7e7ece79300af5
+  metadata.gz: 0a7b0ad61d233027e7990c402f2ca9f851f35122859cdeb18ec7887144484e34
+  data.tar.gz: e42012a9157687d9f63928c3bf1d7b7155141bec78322d1aa6f5195471f2107a
 SHA512:
-  metadata.gz: 41b32a4fd7c50c1ab08b233a909ab6fb518253c45ee0eae9054711686c03420defd92ec91d6bf679acfcfbdc6adeccc1d265fb036ebcdd69505bc67f6802c11f
-  data.tar.gz: 6488c4f6c22abe845c64e6feb35474696cddc35824e488ef1261b80395f781b9621fd03714d1208967f9426a96afa376c5ad603ab3e2cbf2c477391e2dc27486
+  metadata.gz: 3ec025711df0d6c208d771d49ab18dfc8771c5de9ec73f6a0d3bded20e3dbe3ac3e43c2241563391f596200c57baec4d59f9174d18bae6f46d7f213e75b8680f
+  data.tar.gz: b54c95eea70699a408d3209cda57f1ab641c881998ce0d1c7bde9d16eb94a0dec351b1c530202a790e78a9be22e29da4a9a663e8396f59dd7f6da137f7784455

data/lib/posthog/rails/capture_exceptions.rb

@@ -60,12 +60,13 @@ module PostHog
         distinct_id = extract_distinct_id(env)
         additional_properties = build_properties(request, env)
 
-        PostHog.capture_exception(
+        captured = PostHog.capture_exception(
           exception,
           distinct_id,
           additional_properties,
           mechanism: { 'type' => 'rails', 'handled' => false }
         )
+        PostHog::Rails.mark_web_exception_captured(exception) if captured
       rescue StandardError => e
         PostHog::Logging.logger.error("Failed to capture exception: #{e.message}")
         PostHog::Logging.logger.error("Backtrace: #{e.backtrace&.first(5)&.join("\n")}")

data/lib/posthog/rails/error_subscriber.rb

@@ -23,6 +23,10 @@ module PostHog
         # Skip if in a web request - CaptureExceptions middleware will handle it
         # with richer context (URL, params, controller, etc.)
         return if PostHog::Rails.in_web_request?
+        # ActionDispatch::Executor reports the exception once the response has
+        # unwound past our middleware, so the flag above is already cleared.
+        # CaptureExceptions marks what it captured to catch that late report.
+        return if PostHog::Rails.web_exception_captured?(error)
         return if PostHog::Rails.config&.auto_instrument_active_job &&
                   PostHog::Rails.active_job_exception_captured?(error)
 

data/lib/posthog/rails/version.rb

@@ -2,6 +2,6 @@
 
 module PostHog
   module Rails
-    VERSION = '3.18.0'
+    VERSION = '3.18.1'
   end
 end

data/lib/posthog/rails.rb

@@ -21,8 +21,10 @@ module PostHog
     # Thread-local key for tracking web request context
     IN_WEB_REQUEST_KEY = :posthog_in_web_request
     ACTIVE_JOB_CAPTURED_EXCEPTION_IVAR = :@posthog_active_job_exception_captured
+    WEB_CAPTURED_EXCEPTION_IVAR = :@posthog_web_exception_captured
 
     private_constant :ACTIVE_JOB_CAPTURED_EXCEPTION_IVAR
+    private_constant :WEB_CAPTURED_EXCEPTION_IVAR
 
     class << self
       # @return [PostHog::Rails::Configuration] Rails integration configuration.
@@ -85,6 +87,42 @@ module PostHog
       rescue StandardError
         false
       end
+
+      # Mark an exception as already captured by the CaptureExceptions middleware.
+      #
+      # ActionDispatch::Executor sits above our middleware and reports unhandled
+      # exceptions to Rails.error *after* the response has unwound back through
+      # CaptureExceptions, so `in_web_request?` is already false by then. The mark
+      # lets ErrorSubscriber recognize the report as a duplicate.
+      #
+      # The whole cause chain is marked because ActionDispatch::ExceptionWrapper
+      # unwraps ActionView::Template::Error to its cause, meaning Rails can report
+      # a different object than the one the middleware captured.
+      # @api private
+      # @param exception [Exception]
+      # @return [void]
+      def mark_web_exception_captured(exception)
+        current = exception
+        seen = {}.compare_by_identity
+
+        while current.is_a?(Exception) && !seen[current]
+          seen[current] = true
+          current.instance_variable_set(WEB_CAPTURED_EXCEPTION_IVAR, true)
+          current = current.cause
+        end
+      rescue StandardError
+        nil
+      end
+
+      # Check whether an exception was already captured by CaptureExceptions.
+      # @api private
+      # @param exception [Exception]
+      # @return [Boolean]
+      def web_exception_captured?(exception)
+        exception.instance_variable_get(WEB_CAPTURED_EXCEPTION_IVAR) == true
+      rescue StandardError
+        false
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: posthog-rails
 version: !ruby/object:Gem::Version
-  version: 3.18.0
+  version: 3.18.1
 platform: ruby
 authors:
 - PostHog