postcode_anywhere-email_validation 0.0.2 → 0.0.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YzQzODgyZDZhM2Y1ZDkwZmVmMjMxZDBiMzM3ZjEyMDY3MzNmMjUwMQ==
-  data.tar.gz: !binary |-
-    YWE0MGMxMjliOWQzMTg4OTU1Mzc2MWRkYjc2NTc1ZTYzYmQ3YTExYg==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    ZWIxZGZmY2M0ZTlhMDYwNWNlZjc0MzBmMDg2ZjMxYjgyMTc0ZGJkNWFkMzlj
-    ZjI5OWRiZDMyYTkxNjRiNTQ1ZmFmOTAyMjJhMjgyMGM2NmFmYzllOWUyYjcw
-    ZjdmNWIxMDJjYThlOWNjMTA3YWNiYTdhNzk1ZjJiMTc2NTUwMDk=
-  data.tar.gz: !binary |-
-    MjFiM2JjN2UxZDAwMzIwODI4NmFhMzM5ZTkxMDcyZjYzMGM1MWI4ODg2YzYz
-    MjI0YzNjM2VlMjUyYzIwMWM5ZTNlZmMzZDFkNGI1MzU2M2FiOWU3Y2VlNmRk
-    ZDU3M2FkZTMwNGM0ZGNiZWQyNzZlYmNiZTU5MzI0YjQ3NzM0MmY=
+SHA1:
+  metadata.gz: 6d4d019cee86c4a0ba5c2f2b6e39453d46fb36cb
+  data.tar.gz: cc4e8be9c412e37083a14c1d1642258eb241ce94
+SHA512:
+  metadata.gz: c9e3151a9655e9b02cf90929ba60395b2dd8a02b26e0a2db66451222d7f8e95009d947187b6ae9ba09a4f0e39a946e6c8cf2bca4132f648395950a1580cc3e0f
+  data.tar.gz: b8877f6ee3dad316078da55c08f36aa4ce72d9f77a5af2fcaae3a8b5fe90b05db36c5ab2dd8dead3538bae0cb27703ea068615ebc381c55cd3eadf39e332f371

data/.gitignore

@@ -5,3 +5,4 @@ Gemfile.lock
 pkg
 .idea
 .DS_Store
+coverage

data/.travis.yml

@@ -0,0 +1,8 @@
+language: ruby
+rvm:
+  - 2.0.0
+  - 1.9.3
+  - jruby-19mode
+  - rbx-19mode
+  - ruby-head
+  - jruby-head

data/README.md

@@ -1,5 +1,9 @@
 # PostcodeAnywhere::EmailValidation
 
+[![Build Status][build-status-badge]] [build-status]
+[![Code Climate][code-climate-badge]] [code-climate-feed]
+[![Coverage Status][coverage-status-badge]] [coverage-status]
+
 Verifies the existence of an email address using the
 [Email Validation web services] [email-validation]
 from [PostcodeAnywhere].
@@ -31,6 +35,32 @@ PostcodeAnywhere::EmailValidation.key = 'AA11-AA11-AA11-AA11'
 PostcodeAnywhere::EmailValidation.valid?('info@google.com') #=> true
 ```
 
+Or use the provided ActiveModel validator:
+
+```ruby
+class ValidatedClass
+  include ActiveModel::Validations
+
+  attr_accessor :email
+
+  validates_with PostcodeAnywhere::EmailValidation::Validator, attributes: %w{ email }
+end
+```
+
+## Usage with RSpec
+
+With default attribute: :email
+
+```ruby
+  it { should validate_email_with_postcode_anywhere }
+```
+
+With custom attribute.
+
+```ruby
+  it { should validate_email_with_postcode_anywhere.on_attribute(:email) }
+```
+
 ## Contributing
 
 1. Fork it
@@ -44,3 +74,21 @@ PostcodeAnywhere::EmailValidation.valid?('info@google.com') #=> true
 
 [email-validation]: http://www.postcodeanywhere.co.uk/email-validation/
   "PostcodeAnywhere's Email Validation web services"
+
+[build-status]: https://travis-ci.org/moneyadviceservice/postcode_anywhere-email_validation
+  "Build Status"
+
+[build-status-badge]: https://travis-ci.org/moneyadviceservice/postcode_anywhere-email_validation.png
+  "Build Status"
+
+[code-climate-feed]: https://codeclimate.com/github/moneyadviceservice/postcode_anywhere-email_validation
+  "Code Climate"
+
+[code-climate-badge]: https://codeclimate.com/github/moneyadviceservice/postcode_anywhere-email_validation.png
+  "Code Climate"
+
+[coverage-status]: https://coveralls.io/r/moneyadviceservice/postcode_anywhere-email_validation
+  "Coverage Status"
+
+[coverage-status-badge]: https://coveralls.io/repos/moneyadviceservice/postcode_anywhere-email_validation/badge.png
+  "Coverage Status"

data/lib/postcode_anywhere/email_validation.rb

@@ -2,6 +2,7 @@ require 'postcode_anywhere/email_validation/response'
 require 'postcode_anywhere/email_validation/validation_error'
 require 'postcode_anywhere/email_validation/validator'
 require 'postcode_anywhere/email_validation/version'
+require 'postcode_anywhere/matchers/email_validator' if defined?(RSpec)
 
 require 'rest_client'
 

data/lib/postcode_anywhere/email_validation/validator.rb

@@ -4,7 +4,9 @@ module PostcodeAnywhere
   module EmailValidation
     class Validator < ActiveModel::EachValidator
       def validate_each(record, attribute, value)
-        unless PostcodeAnywhere::EmailValidation.valid?(value)
+        if value.blank?
+          record.errors.add(attribute, :blank, value: value)
+        elsif !PostcodeAnywhere::EmailValidation.valid?(value)
           record.errors.add(attribute, :invalid, value: value)
         end
       end

data/lib/postcode_anywhere/email_validation/version.rb

@@ -1,5 +1,5 @@
 module PostcodeAnywhere
   module EmailValidation
-    VERSION = '0.0.2'
+    VERSION = '0.0.4'
   end
 end

data/lib/postcode_anywhere/matchers/email_validator.rb

@@ -0,0 +1,30 @@
+module PostcodeAnywhere
+  module Matchers
+    RSpec::Matchers.define :validate_email_with_postcode_anywhere do
+      chain :on_attribute do |attribute|
+        @attribute = attribute
+      end
+
+      match do |model|
+        model_validators = model.class.validators_on(attribute)
+        model_validators.any? { |validator| validator.instance_of?(PostcodeAnywhere::EmailValidation::Validator) }
+      end
+
+      def attribute
+        @attribute || :email
+      end
+
+      failure_message_for_should do |model|
+        failure_message(model, 'should')
+      end
+
+      failure_message_for_should_not do |model|
+        failure_message(model, 'snould not')
+      end
+
+      def failure_message(model, should_or_should_not)
+        "#{model.class} #{should_or_should_not} have 'PostcodeAnywhere::EmailValidation::Validator' on attribute #{attribute}"
+      end
+    end
+  end
+end

data/postcodeanywhere-emailvalidation.gemspec

@@ -11,18 +11,19 @@ Gem::Specification.new do |spec|
   spec.description           = %q{Verify the existence of an email address.}
   spec.summary               = %q{Verifies the existence of an email address using the Email Validation web services from PostcodeAnywhere.}
   spec.homepage              = 'https://github.com/moneyadviceservice/postcode_anywhere-email_validation'
-  spec.date                  = "2013-06-04"
+  spec.date                  = '2013-06-04'
   spec.files                 = `git ls-files`.split($/)
   spec.executables           = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files            = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths         = ['lib']
-  spec.required_ruby_version = '>= 1.9.2'
+  spec.required_ruby_version = '>= 1.9.3'
 
   spec.add_dependency 'rest-client', '~> 1.6'
   spec.add_dependency 'activemodel', '~> 3.2'
 
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler', '~> 1.2'
   spec.add_development_dependency 'capybara', '~> 2.1'
+  spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 2.0'
   spec.add_development_dependency 'vcr', '~> 2.4'

data/spec/lib/postcode_anywhere/email_validation/validator_spec.rb

@@ -7,6 +7,13 @@ module PostcodeAnywhere
 
       subject { ::ValidatedClass.new }
 
+      context 'blank email' do
+        it 'is not valid' do
+          PostcodeAnywhere::EmailValidation.should_not_receive(:valid?)
+          expect(subject).to_not be_valid
+        end
+      end
+
       context 'Using Postcode Anywhere' do
         before { subject.email = 'an_email' }
 
@@ -21,6 +28,14 @@ module PostcodeAnywhere
         end
       end
 
+      describe 'RSpec Matcher' do
+        context 'with default attribute' do
+          it { should validate_email_with_postcode_anywhere }
+        end
+        context 'with custom attribute' do
+          it { should validate_email_with_postcode_anywhere.on_attribute(:email) }
+        end
+      end
     end
   end
 end

data/spec/lib/postcode_anywhere/matchers/email_validator_spec.rb

@@ -0,0 +1,24 @@
+require 'spec_helper'
+
+module PostcodeAnywhere::EmailValidation
+
+  describe 'Validator Matcher' do
+
+    context 'when Validator is defined' do
+      subject { ::ValidatedClass.new }
+
+      it { should validate_email_with_postcode_anywhere }
+
+      it { should validate_email_with_postcode_anywhere.on_attribute(:email) }
+
+      it { should_not validate_email_with_postcode_anywhere.on_attribute(:email_address) }
+    end
+
+    context 'when Validator is not defined' do
+      subject { ::NotValidatedClass.new }
+
+      it { should_not validate_email_with_postcode_anywhere }
+    end
+
+  end
+end

data/spec/spec_helper.rb

@@ -3,12 +3,12 @@ ENV['POSTCODE_ANYWHERE_KEY'] ||= 'AA11-AA11-AA11-AA11'
 require 'postcode_anywhere/email_validation'
 
 require 'capybara/rspec'
+require 'coveralls'
 require 'vcr'
 require 'pry'
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].each { |f| require f }
 
-
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
 
@@ -30,3 +30,5 @@ VCR.configure do |config|
   config.hook_into :webmock
   config.filter_sensitive_data('{{Key}}') { ENV['POSTCODE_ANYWHERE_KEY'] }
 end
+
+Coveralls.wear!

data/spec/support/not_validated_class.rb

@@ -0,0 +1,4 @@
+class NotValidatedClass
+  include ActiveModel::Validations
+end
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: postcode_anywhere-email_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Andrew Garner
@@ -45,14 +45,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '1.2'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
@@ -67,18 +67,32 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.1'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -133,6 +147,7 @@ extra_rdoc_files: []
 files:
 - .gitignore
 - .rspec
+- .travis.yml
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -142,6 +157,7 @@ files:
 - lib/postcode_anywhere/email_validation/validation_error.rb
 - lib/postcode_anywhere/email_validation/validator.rb
 - lib/postcode_anywhere/email_validation/version.rb
+- lib/postcode_anywhere/matchers/email_validator.rb
 - postcodeanywhere-emailvalidation.gemspec
 - spec/features/email_validation_spec.rb
 - spec/features/email_validator_spec.rb
@@ -149,6 +165,7 @@ files:
 - spec/lib/postcode_anywhere/email_validation/validation_error_spec.rb
 - spec/lib/postcode_anywhere/email_validation/validator_spec.rb
 - spec/lib/postcode_anywhere/email_validation_spec.rb
+- spec/lib/postcode_anywhere/matchers/email_validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixtures/vcr_cassettes/activemodel_validator_with_invalid_values_is_not_valid_on_value_example_com_.yml
 - spec/support/fixtures/vcr_cassettes/activemodel_validator_with_invalid_values_is_not_valid_on_value_john_doe_.yml
@@ -158,6 +175,7 @@ files:
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_with_invalid_format.yml
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_with_valid_format_and_valid_dns_record.yml
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_without_api_key.yml
+- spec/support/not_validated_class.rb
 - spec/support/validated_class.rb
 homepage: https://github.com/moneyadviceservice/postcode_anywhere-email_validation
 licenses: []
@@ -168,12 +186,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
-      version: 1.9.2
+      version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -190,6 +208,7 @@ test_files:
 - spec/lib/postcode_anywhere/email_validation/validation_error_spec.rb
 - spec/lib/postcode_anywhere/email_validation/validator_spec.rb
 - spec/lib/postcode_anywhere/email_validation_spec.rb
+- spec/lib/postcode_anywhere/matchers/email_validator_spec.rb
 - spec/spec_helper.rb
 - spec/support/fixtures/vcr_cassettes/activemodel_validator_with_invalid_values_is_not_valid_on_value_example_com_.yml
 - spec/support/fixtures/vcr_cassettes/activemodel_validator_with_invalid_values_is_not_valid_on_value_john_doe_.yml
@@ -199,4 +218,5 @@ test_files:
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_with_invalid_format.yml
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_with_valid_format_and_valid_dns_record.yml
 - spec/support/fixtures/vcr_cassettes/validating_an_email_address_without_api_key.yml
+- spec/support/not_validated_class.rb
 - spec/support/validated_class.rb