postburner 0.3.2 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ba4b7b0b6ccdc3f0ce25453614c73e683dcac10fde47c6382337e9d0a8eecc42
-  data.tar.gz: 20899869073130b8fb856009c1a69dfa5b0bc4594c79477ff7593d17775cf35f
+  metadata.gz: 4b21ae5985bd9458b91095fe9a40370c6efe0a2d1903be46b47a0785dc6e0f73
+  data.tar.gz: e7e3989d2805bc64815f6b586ba8e594b11963a7330e0d012a7671928b55576d
 SHA512:
-  metadata.gz: 32d316908465caab8c6276ba6db4be43bfdcab5185146cbff59a708057ef331dac90374b817f65a25c623530cfbcb8bfbded3d152aaabd7607fd8df4e7288a1a
-  data.tar.gz: b7ba8bce12c6ddd9e2e353b8dd11fb6e87cd7e7ecbde3a410bc73e8c06464cfb6142172200528e66a2cdd3e02f903366f27ebd7d63e0b2ca14fb6a83335269bd
+  metadata.gz: af927556728f74e306075633a45851a51c4f26faa44f1c54901aa2c7a6f176e494b2c220d2040239e49c458a5cdc6c2e4ae19fd9d35548de1a2028f2a24c074a
+  data.tar.gz: 22d1b312e5b44a21b9035ecaf6a732aa6bac2100244144ed1084bf1f1d83f170df1f378f262fabdc1c8ec2edf26c2c97d4cfd94b006c27992a5871261f09bb4d

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## v0.3.3 - 2021-06-15
+
+### Fixed
+- re-raise exception after logging during perform.
+- log but swallow post perform data update exceptions.
+- only allow remove! if job still present.
+
+### Added
+- Job#log! and Job#log_exception! that save the data immediately.
+
 ## v0.3.2 - 2021-05-07
 
 ### Fixed

data/app/models/postburner/job.rb

@@ -56,22 +56,19 @@ module Postburner
 
       begin
         if self.processed_at.present?
-          self.log "Already Processed", level: :error
-          update_column :logs, self.logs
+          self.log! "Already Processed", level: :error
           self.delete!
           return
         end
 
         if self.removed_at.present?
-          self.log "Removed", level: :error
-          update_column :logs, self.logs
+          self.log! "Removed", level: :error
           return
         end
 
         if self.run_at && self.run_at > Time.zone.now
           response = self.insert! delay: self.run_at - Time.zone.now
-          self.log "PREMATURE; RE-INSERTED: #{response}"
-          update_column :logs, self.logs
+          self.log! "PREMATURE; RE-INSERTED: #{response}"
           return
         end
 
@@ -81,26 +78,29 @@ module Postburner
 
         self.log('DONE')
 
-      rescue Exception => e
-        self.log_exception(e)
-      end
+        begin
+          now = Time.zone.now
+          _duration =  (now - self.processing_at) * 1000 rescue nil
+          self.update_columns(
+            processed_at: now,
+            duration:     _duration,
+            errata:       self.errata,
+            error_count:  self.errata.length,
+            logs:         self.logs,
+            log_count:    self.logs.length,
+          )
+        rescue Exception => e
+          self.log_exception!(e)
+          self.log! '[Postburner] Could not set data after processing.'
+          # TODO README doesn't retry if Postburner is to blame
+        end
 
-      begin
-        now = Time.zone.now
-        _duration =  (now - self.processing_at) * 1000 rescue nil
-        self.update_columns(
-          processed_at: now,
-          duration:     _duration,
-          errata:       self.errata,
-          error_count:  self.errata.length,
-          logs:         self.logs,
-          log_count:    self.logs.length,
-        )
-      rescue Exception => e
-        raise e if Rails.env.development? || Rails.env.production?
-        self.log_exception(e)
-        update_column :errata, self.errata
+      rescue Exception => exception
+        self.log_exception!(exception)
+        self.log! '[Postburner] Exception raised during perform prevented completion.'
+        raise exception
       end
+
     end
 
     def delete!
@@ -122,9 +122,12 @@ module Postburner
     end
 
     def remove!
-      return false if self.attempts.any?
-      self.delete!
-      self.update_column(removed_at: Time.zone.now)
+      if self.beanstalk_job
+        self.delete!
+        self.update_column(:removed_at, Time.zone.now)
+      else
+        false
+      end
     end
 
     def beanstalk_job
@@ -152,6 +155,11 @@ module Postburner
       ]
     end
 
+    def log_exception!(exception)
+      self.log_exception(exception)
+      self.update_column :errata, self.errata
+    end
+
     def log(message, options={})
       options[:level] ||= :info
       options[:level] = :error unless LOG_LEVELS.member?(options[:level])
@@ -163,6 +171,11 @@ module Postburner
       ]
     end
 
+    def log!(message, options={})
+      self.log(message, options)
+      self.update_column :logs, self.logs
+    end
+
     private
 
     def insert!(options={})

data/lib/postburner/version.rb

@@ -1,3 +1,3 @@
 module Postburner
-  VERSION = '0.3.2'
+  VERSION = '0.3.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: postburner
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.3
 platform: ruby
 authors:
 - Matt Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-07 00:00:00.000000000 Z
+date: 2021-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails