porras-imdb 0.0.5 → 0.0.6

data/README

@@ -5,6 +5,7 @@ ImdbMovie Indiana Jones and the Last Crusade
 - should query IMDB url
 - should get director
 - should get the poster
+- should get the rating
 - should get cast members
 - should get the writers
 - should get the release date
@@ -64,6 +65,6 @@ String unescape_html
 String strip_tags
 - should strip HTML tags
 
-Finished in 2.848225 seconds
+Finished in 3.044303 seconds
 
-41 examples, 0 failures
+42 examples, 0 failures

data/lib/imdb/imdb_movie.rb

@@ -13,7 +13,11 @@ class ImdbMovie
   end
   
   def poster
-    document.at("a[@name='poster'] img")['src'] rescue nil
+    document.at("a[@name='poster'] img")['src'][/http:.+@@/] + '.jpg' rescue nil
+  end
+  
+  def rating
+    document.at(".general.rating b").innerHTML.strip.unescape_html.split('/').first.to_f rescue nil
   end
   
   def cast_members

data/spec/imdb_movie_spec.rb

@@ -0,0 +1,186 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe ImdbMovie do
+  
+  describe 'Indiana Jones and the Last Crusade' do
+
+    before(:each) do
+      @imdb_movie = ImdbMovie.new('0097576', 'Indiana Jones and the Last Crusade')
+      @imdb_movie.stub!(:open).and_return(open("#{$samples_dir}/sample_movie.html"))
+    end
+  
+    it "should query IMDB url" do
+      @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0097576/").and_return(open("#{$samples_dir}/sample_movie.html"))
+      @imdb_movie.send(:document)
+    end
+  
+    it "should get director" do
+      @imdb_movie.director.should == 'Steven Spielberg'
+    end
+  
+    it "should get the poster" do
+      @imdb_movie.poster.should == 'http://ia.media-imdb.com/images/M/MV5BMTkzODA5ODYwOV5BMl5BanBnXkFtZTcwMjAyNDYyMQ@@.jpg'
+    end
+    
+    it "should get the rating" do
+      @imdb_movie.rating.should == 8.3
+    end
+  
+    it "should get cast members" do
+      @imdb_movie.cast_members.should include('Harrison Ford')
+      @imdb_movie.cast_members.should include('Sean Connery')
+      @imdb_movie.cast_members.should include('Denholm Elliott')
+      @imdb_movie.cast_members.should include('Alison Doody')
+      @imdb_movie.cast_members.should include('John Rhys-Davies')
+      @imdb_movie.cast_members.should_not include('more')
+    end
+  
+    it "should get the writers" do
+      @imdb_movie.writers.should include('George Lucas')
+      @imdb_movie.writers.should include('Philip Kaufman')
+      @imdb_movie.writers.should_not include('more')
+    end
+  
+    it "should get the release date" do
+      @imdb_movie.release_date.should be_an_instance_of(Date)
+      @imdb_movie.release_date.should == Date.new(1989, 9, 1)
+    end
+  
+    it "should get the genres" do
+      @imdb_movie.genres.should have(2).strings
+      @imdb_movie.genres.should include('Action')
+      @imdb_movie.genres.should include('Adventure')
+    end
+  
+    it "should get the plot" do
+      @imdb_movie.plot.should == "When Dr. Henry Jones Sr. suddenly goes missing while pursuing the Holy Grail, eminent archaeologist Indiana Jones must follow in his father's footsteps and stop the Nazis."
+    end
+  
+    it "should get the length" do
+      @imdb_movie.length.should == '127 min'
+    end
+  
+    it "should get the countries" do
+      @imdb_movie.countries.should have(1).string
+      @imdb_movie.countries.should include('USA')
+    end
+  
+    it "should get the languages" do
+      @imdb_movie.languages.should have(3).strings
+      @imdb_movie.languages.should include('English')
+      @imdb_movie.languages.should include('German')
+      @imdb_movie.languages.should include('Greek')
+    end
+  
+    it "should get the color" do
+      @imdb_movie.color.should == 'Color'
+    end
+  
+    it "should get the company" do
+      @imdb_movie.company.should == 'Lucasfilm'
+    end
+  
+    it "should get some photos" do
+      @imdb_movie.photos.should have(10).strings
+      @imdb_movie.photos.should include('http://ia.media-imdb.com/images/M/MV5BMTY4MzY3OTY0MF5BMl5BanBnXkFtZTYwODM0OTE3._V1._CR82,0,320,320_SS90_.jpg')
+      @imdb_movie.photos.should include('http://ia.media-imdb.com/images/M/MV5BMjAwNTM4ODc3Nl5BMl5BanBnXkFtZTYwNzU0OTE3._V1._CR82,0,320,320_SS90_.jpg') 
+    end
+    
+    it "should get the tagline" do
+      @imdb_movie.tagline.should == "He's back in an all new adventure. Memorial Day 1989."
+    end
+    
+    it "should get the aspect ratio" do
+      @imdb_movie.aspect_ratio.should == "2.20 : 1"
+    end
+    
+    describe "title pre-caching & get_data" do
+      
+      it "should have the original title before querying anything" do
+        @imdb_movie.should_not_receive(:open)
+        @imdb_movie.title.should == 'Indiana Jones and the Last Crusade'
+      end
+      
+      it "should have the updated title after calling get_data" do
+        @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0097576/").and_return(open("#{$samples_dir}/sample_movie.html"))
+        @imdb_movie.get_data
+        @imdb_movie.title.should == 'Indiana Jones and the Last Crusade'
+      end
+      
+    end
+    
+  end
+
+
+  describe 'Han robado una estrella' do
+
+    before(:each) do
+      @imdb_movie = ImdbMovie.new('0054961', 'Han robado una estrella')
+      @imdb_movie.stub!(:open).and_return(open("#{$samples_dir}/sample_incomplete_movie.html"))
+    end
+  
+    it "should query IMDB url" do
+      @imdb_movie.should_receive(:open).with("http://www.imdb.com/title/tt0054961/").and_return(open("#{$samples_dir}/sample_incomplete_movie.html"))
+      @imdb_movie.send(:document)
+    end
+  
+    it "should get director" do
+      @imdb_movie.director.should == 'Javier Setó'
+    end
+  
+    it "should not get the poster" do
+      @imdb_movie.poster.should be_nil
+    end
+  
+    it "should get cast members" do
+      @imdb_movie.cast_members.should include('Rafaela Aparicio')
+      @imdb_movie.cast_members.should include('Marujita Díaz')
+      @imdb_movie.cast_members.should include('Espartaco Santoni')
+      @imdb_movie.cast_members.should_not include('more')
+    end
+  
+    it "should get the writers" do
+      @imdb_movie.writers.should have(1).string
+      @imdb_movie.writers.should include('Paulino Rodrigo')
+    end
+  
+    it "should get the release date" do
+      @imdb_movie.release_date.should be_an_instance_of(Date)
+      @imdb_movie.release_date.should == Date.new(1963, 9, 9)
+    end
+  
+    it "should get the genres" do
+      @imdb_movie.genres.should == ['Comedy', 'Musical']
+    end
+  
+    it "should not get the plot" do
+      @imdb_movie.plot.should be_nil
+    end
+  
+    it "should get the length" do
+      @imdb_movie.length.should == '93 min'
+    end
+  
+    it "should get the countries" do
+      @imdb_movie.countries.should == ['Spain']
+    end
+  
+    it "should get the languages" do
+      @imdb_movie.languages.should == ['Spanish']
+    end
+  
+    it "should not get the color" do
+      @imdb_movie.color.should be_nil
+    end
+  
+    it "should get the company" do
+      @imdb_movie.company.should == 'Brepi Films'
+    end
+  
+    it "should not get any photos" do
+      @imdb_movie.photos.should be_empty
+    end
+    
+  end
+
+end

data/spec/imdb_search_spec.rb

@@ -0,0 +1,64 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe ImdbSearch do
+
+  describe 'Indiana Jones' do
+
+    before(:each) do
+      @imdb_search = ImdbSearch.new('indiana jones')
+      @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_search.html"))
+    end
+
+    it "should query IMDB url" do
+      @imdb_search.should_receive(:open).with("http://www.imdb.com/find?q=indiana+jones;s=tt").and_return(open("#{$samples_dir}/sample_search.html"))
+      @imdb_search.send(:document)
+    end
+
+    describe "movies" do
+
+      it "should be a collection of ImdbMovie instances" do
+        @imdb_search.movies.should be_an_instance_of(Array)
+        @imdb_search.movies.should_not be_empty
+        @imdb_search.movies.each do |movie|
+          movie.should be_an_instance_of(ImdbMovie)
+        end
+      end
+
+      it "should include 'Indiana Jones and the Last Crusade'" do
+        @imdb_search.movies.map { |m| m.title }.should include('Indiana Jones and the Last Crusade')
+      end
+
+      it "should have titles" do
+        @imdb_search.movies.each do |movie|
+          movie.title.should_not be_empty
+        end
+      end
+
+      it "should not have titles with HTML tags" do
+        @imdb_search.movies.each do |movie|
+          movie.title.should_not match(/<.+>/)
+        end
+      end
+
+    end
+
+  end
+  
+  describe 'searches with potential encoding issues' do
+
+    before(:each) do
+      @imdb_search = ImdbSearch.new('torrente')
+      @imdb_search.stub!(:open).and_return(open("#{$samples_dir}/sample_spanish_search.html"))
+    end
+
+    describe "movies" do
+
+      it "should include 'Misión en Marbella'" do
+        @imdb_search.movies.map { |m| m.title }.should include('Misión en Marbella')
+      end
+      
+    end
+  
+  end
+
+end

data/spec/spec_helper.rb

@@ -0,0 +1,3 @@
+require File.dirname(__FILE__) + '/../lib/imdb'
+
+$samples_dir = File.dirname(__FILE__) + '/samples'

data/spec/string_extensions_spec.rb

@@ -0,0 +1,25 @@
+require File.dirname(__FILE__) + '/spec_helper'
+
+describe String do
+  
+  describe "unescape_html" do
+    
+    it "should convert & to &" do
+      "M&M".unescape_html.should == 'M&M'
+    end
+    
+    it "should convert ó to ó" do
+      "ósmosis".unescape_html.should == 'ósmosis'
+    end
+    
+  end
+  
+  describe "strip_tags" do
+    
+    it "should strip HTML tags" do
+      "<em>Hola</em> hola".strip_tags.should == 'Hola hola'
+    end
+    
+  end
+  
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: porras-imdb
 version: !ruby/object:Gem::Version 
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors: 
 - Sergio Gil
@@ -9,11 +9,12 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-08-13 00:00:00 -07:00
+date: 2009-05-30 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: hpricot
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -23,6 +24,7 @@ dependencies:
     version: 
 - !ruby/object:Gem::Dependency 
   name: chronic
+  type: :runtime
   version_requirement: 
   version_requirements: !ruby/object:Gem::Requirement 
     requirements: 
@@ -36,19 +38,19 @@ executables: []
 
 extensions: []
 
-extra_rdoc_files: []
-
+extra_rdoc_files: 
+- README
 files: 
+- README
+- lib/imdb.rb
 - lib/imdb/imdb_movie.rb
 - lib/imdb/imdb_search.rb
-- lib/imdb.rb
 - lib/string_extensions.rb
-- README
-has_rdoc: false
+has_rdoc: true
 homepage: 
 post_install_message: 
-rdoc_options: []
-
+rdoc_options: 
+- --charset=UTF-8
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
@@ -68,7 +70,10 @@ requirements: []
 rubyforge_project: 
 rubygems_version: 1.2.0
 signing_key: 
-specification_version: 2
+specification_version: 3
 summary: Internet Movie DataBase
-test_files: []
-
+test_files: 
+- spec/imdb_movie_spec.rb
+- spec/imdb_search_spec.rb
+- spec/spec_helper.rb
+- spec/string_extensions_spec.rb