popcircle 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 649a45aebd28ba28334d070736fb03f2af7db3df
-  data.tar.gz: 2d05345c7c542fc745a962427a2bb609de5650ad
+  metadata.gz: eaafd3ee80684a0e50c1b6760b82b4885e9b25db
+  data.tar.gz: 5959d18b703561a3d7349f4340bd2b05425c43c4
 SHA512:
-  metadata.gz: ffa464ef6d94af46886f63ab339f64cc2241d5b03bfe3a2ef1663e21391978e9d81918d527942cda48803de145a83501af7ca903795c01b9d68ce099b7fa6a3f
-  data.tar.gz: a98c3894e761a6c2f908dd32d9a9e7fc6485f37dcb5f9b8d88788dbbad827235473ea7ec53c6556170a30dfecb813af6147073c504ebb3424a935d1a64bb6fbd
+  metadata.gz: d317e03ac59ec2ef1c754dced24f57f0ccd8cc25d75755f6fa07c36a5e464dc15309f48935b070f5251c169a3cc9b4c52ac8e0c457b1f640806d0a359388d922
+  data.tar.gz: 4462057a7952ed4aff147d9142301bea32645a57a29b96141f4dfbf41b33d79b5800af64bb900c5e21525bb66aedb77bf03c7f57185a3bf3a3a081f8ed102aaa

data/README.md

@@ -1,5 +1,7 @@
 # Popcircle
 
+![](https://img.shields.io/gem/dt/popcircle.svg)
+
 ![Alt text](/popcircle.gif)
 
 This gem adds `jquery.easing` and `jquery.popcircle` to your application and provides a view helper to add a radial menu with images or icons as the links surrounding the main trigger.
@@ -9,7 +11,7 @@ This gem adds `jquery.easing` and `jquery.popcircle` to your application and pro
 Add this line to your application's Gemfile:
 
 ```ruby
-    gem 'popcircle', github: 'jakehockey10/popcircle'
+gem 'popcircle'
 ```
 
 And then execute:
@@ -25,34 +27,38 @@ Or install it yourself as:
 First, make sure your `application.js` file includes the following:
 
 ```javascript
-    //= require popcircle/popcircle
+//= require popcircle/popcircle
 ```
 
 Second, you can include something like this in your `HTML`
 
 ```HTML
-    <%= popcircle(images: %w(one.png two.png three.png four.png five.png)) %>
+<%= popcircle(images: %w(one.png two.png three.png four.png five.png)) %>
 ```
 
 ## TODO
 
-- More than one popcircle makes the click handler not work.
 - Get helper tests back to running
 - improve helper method
 - allow trigger background image to be configurable
 - allow size to be configurable
-- make icons line up
 
 ## Contributing
 
 I could use some help!
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/popcircle. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome on GitHub at https://github.com/jakehockey10/popcircle. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
 ## Development
 
 After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
+#### Note
+
+I have begun the development of this app with integration tests in a dummy rails app inside the test folder of the gem's project.  The integration tests in this rails app should be run from the root of the project.
+
+#### Installing
+
 To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## License

data/Rakefile

@@ -1,9 +1,9 @@
-require "bundler/gem_tasks"
-require "rake/testtask"
+require 'bundler/gem_tasks'
+require 'rake/testtask'
 
 Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
+  t.libs << 'test'
+  t.libs << 'lib'
   t.test_files = FileList['test/**/*_test.rb']
 end
 

data/app/assets/javascripts/popcircle/popcircle.js.erb

@@ -1,19 +1,28 @@
-// app/assets/javascripts/popcircle.js
-//
 // jQuery Popcircle setup for popcircle helpers
 //
 //= require jquery.easing
 //= require jquery.popcircle
 
 $(document).on('turbolinks:load', function () {
-  $('.popcircle-trigger').click(function (e) {
-    e.preventDefault();
-    $.popcircle('#pops', {
-      spacing: '10px',
-      type: 'full', // full, half, quad
-      offset: 1.95, // 0, 1, 2, 3, 4, 5, 6, 7, or 5.1
-      ease: 'easeOutElastic',
-      time: 'slow' // slow, fast, 1000
+  $.each($('.popcircle-list'), function (index, value) {
+    $(this).closest('.popcircle-box').find('.popcircle-trigger').on('click', function (e) {
+      e.preventDefault();
+      var newClass = 'popcircle-' + index;
+      $(value).removeClass('popcircle-list').addClass(newClass);
+      $.popcircle('.' + newClass, {
+        spacing: '10px',
+        type: 'full', // full, half, quad
+        offset: 1.95, // 0, 1, 2, 3, 4, 5, 6, 7, or 5.1
+        ease: 'easeOutElastic',
+        time: 'slow' // slow, fast, 1000
+      });
     });
+//    $.popcircle('.popcircle-list', {
+//      spacing: '10px',
+//      type: 'full', // full, half, quad
+//      offset: 1.95, // 0, 1, 2, 3, 4, 5, 6, 7, or 5.1
+//      ease: 'easeOutElastic',
+//      time: 'slow' // slow, fast, 1000
+//    });
   });
-});
+});

data/app/assets/stylesheets/popcircle/popcircle.scss.erb

@@ -40,4 +40,15 @@
   height: 100px;
   width: 100px;
   position: absolute;
+}
+
+.popcircle > ul > li > a {
+  display: table;
+  height: 100%;
+  text-decoration: none;
+  margin: auto;
+  i {
+    display: table-cell;
+    vertical-align: middle;
+  }
 }

data/app/helpers/popcircle/rails/popcircle_helper.rb

@@ -5,7 +5,6 @@ module Popcircle
       include FontAwesome::Rails::IconHelper
 
       def popcircle(circles, options = {})
-        # options        = circles.length > 1 ? circles.extract_options! : {}
         raise Exception.new('Argument `circles` not a Hash...') unless circles.is_a? Hash
 
         if circles[:icons]
@@ -13,7 +12,7 @@ module Popcircle
         elsif circles[:images]
           circles = circles[:images].map { |circle| { image: circle } }
         end
-        options[:list] ||= 'pops'
+        options[:list] ||= 'popcircle-list'
         content_tag :div, class: 'popcircle-box' do
           trigger + list(circles, options)
         end if circles
@@ -27,7 +26,7 @@ module Popcircle
 
       def list(circles, options)
         content_tag :div, class: 'popcircle' do
-          content_tag :ul, id: options[:list] do
+          content_tag :ul, class: options[:list] do
             circles.each do |circle|
               concat list_item(circle)
             end

data/lib/popcircle/version.rb

@@ -2,6 +2,6 @@ module Popcircle
   module Rails
     EASING_VERSION = '1.4.0'
     POPCIRCLE_VERSION = '1.0'
-    VERSION = '0.1.0'
+    VERSION = '0.2.0'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: popcircle
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Jake Smith
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-24 00:00:00.000000000 Z
+date: 2016-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails