pompompom 1.0.0 → 1.0.1

data/README.mdown

@@ -22,7 +22,7 @@ There is a command line tool that can be used to install artifacts:
 
     pompompom com.rabbitmq:amqp-client:1.8.0 com.google.inject:guice:2.0
     
-It will create a directory called `lib` and download JARs into it. In the future things may be configurable, and POMs will be cached to make things quicker.
+It will create a directory called `lib` and download JARs into it. By default it will look in the main Maven repository, but you can add more repositories by editing ~/.pompompomrc (which is created automatically on the first run). Downloaded artifacts and POMs are cached in ~/.pompompom.
 
 ## Why another dependency management tool, why not use Maven, Buildr, sbt or Ivy?
 

data/lib/pompompom/cli.rb

@@ -1,14 +1,17 @@
+require 'yaml'
+
+
 module PomPomPom
   class Cli
-    STANDARD_REPOSITORIES = [
-      'http://repo1.maven.org/maven2/'
-    ]
-    
+    STANDARD_REPOSITORIES = %w(http://repo1.maven.org/maven2)
     DEFAULT_DESTINATION_DIR = 'lib'
+    CACHE_DIR = File.expand_path('~/.pompompom')
+    CONFIG_FILE = File.expand_path('~/.pompompomrc')
     
     def initialize(stdin, stdout, stderr)
       @stdin, @stdout, @stderr = stdin, stdout, stderr
       @status_logger = EchoLogger.new(@stderr)
+      @downloader = CachingDownloader.new(CACHE_DIR, Downloader.new)
     end
     
     def run!(*args)
@@ -16,23 +19,24 @@ module PomPomPom
         print_usage
         return 1
       end
-
+      
       resolver = create_resolver
     
+      create_config_file!
       create_lib_directory!
     
       @status_logger.info("Determining transitive dependencies...")
     
       dependencies = parse_dependencies(args)
       dependencies = resolver.find_transitive_dependencies(*dependencies)
-      dependencies = dependencies.reject { |d| File.exists?(File.join(DEFAULT_DESTINATION_DIR, d.jar_file_name)) }
+      dependencies = dependencies.reject { |d| File.exists?(File.join(destination_dir_path, d.jar_file_name)) }
     
       if dependencies.empty?
         @status_logger.info('All dependencies are met')
       else
         dependencies.each do |dependency|
           @status_logger.info(%(Downloading "#{dependency.to_dependency.to_s}"))
-          resolver.download!(DEFAULT_DESTINATION_DIR, false, dependency)
+          resolver.download!(destination_dir_path, false, dependency)
         end
       end
       
@@ -44,14 +48,42 @@ module PomPomPom
     
   private
   
+    def create_config_file!
+      return if File.exists?(config_file_path)
+      File.open(config_file_path, 'w') { |f| f.write(YAML.dump('repositories' => STANDARD_REPOSITORIES))}
+    end
+  
     def create_lib_directory!
-      return if File.directory?(DEFAULT_DESTINATION_DIR)
-      raise %(Cannot create destination, "#{DEFAULT_DESTINATION_DIR}" is a file!) if File.exists?(DEFAULT_DESTINATION_DIR)
-      Dir.mkdir(DEFAULT_DESTINATION_DIR)
+      return if File.directory?(destination_dir_path)
+      raise %(Cannot create destination, "#{destination_dir_path}" is a file!) if File.exists?(destination_dir_path)
+      Dir.mkdir(destination_dir_path)
     end
   
     def create_resolver
-      Resolver.new(STANDARD_REPOSITORIES, :logger => @status_logger)
+      Resolver.new(
+        config[:repositories], 
+        :logger => @status_logger, 
+        :downloader => @downloader
+      )
+    end
+    
+    def config
+      @config ||= symbolize_keys(YAML.load(File.read(config_file_path)))
+    end
+    
+    def symbolize_keys(h)
+      h.keys.inject({}) do |acc, k|
+        acc[k.to_sym] = if Hash === h[k] then symbolize_keys(h[k]) else h[k] end
+        acc
+      end
+    end
+    
+    def config_file_path
+      CONFIG_FILE
+    end
+    
+    def destination_dir_path
+      DEFAULT_DESTINATION_DIR
     end
   
     def parse_dependencies(args)

data/lib/pompompom/downloader.rb

@@ -1,4 +1,7 @@
 require 'open-uri'
+require 'fileutils'
+require 'uri'
+
 
 module PomPomPom
   class Downloader
@@ -9,7 +12,35 @@ module PomPomPom
   
   class FilesystemDownloader
     def get(path)
-      File.read(path) if File.exists?(path)
+      raise %(Cannot read "#{path}": No such file) unless File.exists?(path)
+      File.read(path)
+    end
+  end
+  
+  class CachingDownloader
+    def initialize(cache_dir, downloader=Downloader.new)
+      @cache_dir, @downloader = cache_dir, downloader
+    end
+    
+    def get(url)
+      cached = cache_path(url)
+      if File.exists?(cached)
+        File.read(cached)
+      else
+        data = @downloader.get(url)
+        FileUtils.mkdir_p(File.dirname(cached))
+        File.open(cached, 'w') { |f| f.write(data) }
+        data
+      end
+    end
+    
+  private
+  
+    def cache_path(url)
+      uri = URI.parse(url)
+      path_components = uri.path.sub(%r{^/}, '').split('/')
+      path = File.join(@cache_dir, uri.host, *path_components)
+      path
     end
   end
 end

data/lib/pompompom.rb

@@ -6,5 +6,5 @@ require 'pompompom/downloader'
 require 'pompompom/resolver'
 
 module PomPomPom
-  VERSION = '1.0.0'
+  VERSION = '1.0.1'
 end

data/pompompom.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = %q{pompompom}
-  s.version = "1.0.0"
+  s.version = "1.0.1"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Theo Hultberg"]
@@ -38,6 +38,7 @@ Gem::Specification.new do |s|
      "pompompom.gemspec",
      "spec/pompompom/cli_spec.rb",
      "spec/pompompom/dependency_spec.rb",
+     "spec/pompompom/downloader_spec.rb",
      "spec/pompompom/metadata_spec.rb",
      "spec/pompompom/pom_spec.rb",
      "spec/pompompom/resolver_spec.rb",
@@ -96,6 +97,7 @@ Gem::Specification.new do |s|
   s.test_files = [
     "spec/pompompom/cli_spec.rb",
      "spec/pompompom/dependency_spec.rb",
+     "spec/pompompom/downloader_spec.rb",
      "spec/pompompom/metadata_spec.rb",
      "spec/pompompom/pom_spec.rb",
      "spec/pompompom/resolver_spec.rb",

data/spec/pompompom/cli_spec.rb

@@ -1,6 +1,7 @@
 require File.expand_path('../../spec_helper', __FILE__)
 require 'tmpdir'
 require 'fileutils'
+require 'yaml'
 
 
 module PomPomPom
@@ -13,12 +14,14 @@ module PomPomPom
       @downloader = FilesystemDownloader.new
       @resolver = Resolver.new([@repository_path])
       @cli = Cli.new(@stdin, @stdout, @stderr)
-      @cli.stub!(:create_resolver).and_return(@resolver)
-      @cli.stub!(:create_lib_directory!)
       @tmp_dir = File.join(Dir.tmpdir, 'pompompom')
       FileUtils.rm_rf(@tmp_dir)
       Dir.mkdir(@tmp_dir)
       Dir.chdir(@tmp_dir)
+      @config_file_path = File.join(@tmp_dir, '.pompompomrc')
+      @cli.stub!(:create_resolver).and_return(@resolver)
+      @cli.stub!(:create_lib_directory!)
+      @cli.stub!(:config_file_path).and_return(@config_file_path)
     end
     
     after do
@@ -89,5 +92,35 @@ module PomPomPom
         @cli.run!('com.example:test:9.9').should == 1
       end
     end
+
+    context 'config file' do
+      it 'creates the config file if it doesn\'t exist' do
+        @cli.run!('net.iconara:pompompom:1.0', 'com.example:test:9.9')
+        File.exists?(@config_file_path).should be_true
+      end
+      
+      it 'adds the standard repositories to the config file, if it doesn\'t exist' do
+        @cli.run!('net.iconara:pompompom:1.0', 'com.example:test:9.9')
+        @config = YAML.load(File.read(@config_file_path))
+        @config['repositories'].should == Cli::STANDARD_REPOSITORIES
+      end
+      
+      it 'doesn\'t clobber an existing config file' do
+        @config = {'repositories' => %w(http://example.com/repo1 http://example.com/repo2)}
+        File.open(@config_file_path, 'w') { |f| f.write(YAML::dump(@config)) }
+        @cli.run!('net.iconara:pompompom:1.0', 'com.example:test:9.9')
+        @config = YAML.load(File.read(@config_file_path))
+        @config['repositories'].should == %w(http://example.com/repo1 http://example.com/repo2)
+      end
+      
+      it 'reads the config file' do
+        @config = {'repositories' => %w(http://example.com/repo1 http://example.com/repo2)}
+        File.open(@config_file_path, 'w') { |f| f.write(YAML::dump(@config)) }
+        Resolver.should_receive(:new).with(%w(http://example.com/repo1 http://example.com/repo2), an_instance_of(Hash))
+        @cli = Cli.new(@stdin, @stdout, @stderr)
+        @cli.stub!(:config_file_path).and_return(@config_file_path)
+        @cli.run!('net.iconara:pompompom:1.0', 'com.example:test:9.9')
+      end
+    end
   end
 end

data/spec/pompompom/downloader_spec.rb

@@ -0,0 +1,63 @@
+require File.expand_path('../../spec_helper', __FILE__)
+require 'tmpdir'
+require 'fileutils'
+
+
+module PomPomPom
+  describe Downloader do
+    it 'downloads the given URL' do
+      Downloader.new.get('http://iconara.net/').should_not be_nil
+    end
+    
+    it 'raises an error if the URL cannot be found' do
+      expect { Downloader.new.get('http://example.com/test') }.to raise_error
+    end
+  end
+  
+  describe FilesystemDownloader do
+    it 'reads a file' do
+      FilesystemDownloader.new.get('/etc/hosts').should_not be_nil
+    end
+    
+    it 'raises an error if the file cannot be found' do
+      expect { FilesystemDownloader.new.get('/plink') }.to raise_error
+    end
+  end
+  
+  describe CachingDownloader do
+    before do
+      @tmp_dir = File.join(Dir.tmpdir, 'pompompom_cache')
+      FileUtils.rm_rf(@tmp_dir)
+    end
+    
+    after do
+      FileUtils.rm_rf(@tmp_dir)
+    end
+    
+    it 'creates the directory if it does not exist' do
+      CachingDownloader.new(@tmp_dir, stub(:get => 'DATA!')).get('http://example.com/')
+      File.directory?(@tmp_dir).should be_true
+    end
+    
+    it 'delegates downloading to another downloader' do
+      @wrapped_downloader = stub()
+      @wrapped_downloader.should_receive(:get).with('http://example.com/')
+      CachingDownloader.new(@tmp_dir, @wrapped_downloader).get('http://example.com/')
+    end
+    
+    it 'only downloads a URL once (same instance)' do
+      @wrapped_downloader = stub()
+      @wrapped_downloader.stub(:get).with('http://example.com/some/path/to/a/file.json').once.and_return('DATA!')
+      @downloader = CachingDownloader.new(@tmp_dir, @wrapped_downloader)
+      @downloader.get('http://example.com/some/path/to/a/file.json').should == 'DATA!'
+      @downloader.get('http://example.com/some/path/to/a/file.json').should == 'DATA!'
+    end
+    
+    it 'only downloads a URL once (different instances)' do
+      @wrapped_downloader = stub()
+      @wrapped_downloader.stub(:get).with('http://example.com/some/path/to/a/file.json').once.and_return('DATA!')
+      CachingDownloader.new(@tmp_dir, @wrapped_downloader).get('http://example.com/some/path/to/a/file.json').should == 'DATA!'
+      CachingDownloader.new(@tmp_dir, @wrapped_downloader).get('http://example.com/some/path/to/a/file.json').should == 'DATA!'
+    end
+  end
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: pompompom
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 1
   - 0
-  - 0
-  version: 1.0.0
+  - 1
+  version: 1.0.1
 platform: ruby
 authors: 
 - Theo Hultberg
@@ -48,6 +48,7 @@ files:
 - pompompom.gemspec
 - spec/pompompom/cli_spec.rb
 - spec/pompompom/dependency_spec.rb
+- spec/pompompom/downloader_spec.rb
 - spec/pompompom/metadata_spec.rb
 - spec/pompompom/pom_spec.rb
 - spec/pompompom/resolver_spec.rb
@@ -135,6 +136,7 @@ summary: Ruby dependency manager for Maven repository artifacts
 test_files: 
 - spec/pompompom/cli_spec.rb
 - spec/pompompom/dependency_spec.rb
+- spec/pompompom/downloader_spec.rb
 - spec/pompompom/metadata_spec.rb
 - spec/pompompom/pom_spec.rb
 - spec/pompompom/resolver_spec.rb