polyphony 0.30 → 0.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf1cef97b80aa22506d7b5d1547062cfb62909ef12411fe0877ff3972f00198f
-  data.tar.gz: 5418b1912ea214600fbbc435e91f56e6db325dd21710530932fef944b27fc7ab
+  metadata.gz: 24126ff67fd9fd240299e1af8567da58f072c6c60df3f77b40f87ac108010f80
+  data.tar.gz: 95bcac53f361d65718aea1b55b557a7f68624d9815c38ee7c0cb79e11cb7bc96
 SHA512:
-  metadata.gz: f878c45416276bb13e40c8641ab614d75c47f82b82859ab21fa37ae7012e487d040919b50a8f588d097fa2ab95295f20b79a91ab5ae4ec8177f0846c6cbd3892
-  data.tar.gz: 9d97c148ea0f54e15d1c55209a53131d09278fa7c8dd426c1f3d945ba26f86c0ffebb056dde9f4e324719a3dc424afcde2bbf99cddbadfe781bc9e1fab965ef9
+  metadata.gz: 8849c26d4c2eccba56e786ac7ad76c2e2129244b619b988d649dca636491dd6158c0bed8feac191df9a7958f946592a8987a1e6709f27ef1383403b279f5595d
+  data.tar.gz: e8797e0b6e3852a208488213634b1360fc297e3ee9efa5c5e05d538a2684a02dfdf5efb00aca82b72064fc996a50c91de5c477a55ef5fd9dbf85275fd10e1f42

data/CHANGELOG.md

@@ -1,9 +1,16 @@
-0.30 2020-14-02
----------------
+* Fix adapter requires (redis and postgres).
+
+## 0.31 2020-02-20
+
+* Fix signal handling race condition (#13)
+* Move adapter code into polyphony/adapters
+* Fix spin_loop caller, add tag parameter
+
+## 0.30 2020-02-04
 
 * Add support for awaiting a fiber from multiple monitor fibers at once
 * Implemented child fibers
-* Fix TERM and INT signal handling (close #11)
+* Fix TERM and INT signal handling (#11)
 * Fix compiling on Linux
 * Do not reset runnable value in Gyro_suspend (prevents interrupting timers)
 * Don't snooze when stopping a fiber
@@ -12,8 +19,7 @@
 * Prevent signalling of inactive async watcher
 * Better fiber messaging
 
-0.29 2020-02-02
----------------
+## 0.29 2020-02-02
 
 * Pass SignalException to main fiber
 * Add (restore) default thread pool
@@ -24,8 +30,7 @@
 * Improve tracing
 * Fix IRB adapter
 
-0.28 2020-01-27
----------------
+## 0.28 2020-01-27
 
 * Accept block in Supervisor#initialize
 * Refactor `ThreadPool`
@@ -37,37 +42,32 @@
 * Use `:waiting`, `:runnable`, `:running`, `:dead` for fiber states
 * Move docs to https://digital-fabric.github.io/polyphony/
 
-0.27 2020-01-19
----------------
+## 0.27 2020-01-19
 
 * Reimplement `Throttler` using recurring timer
 * Add `Gyro::Selector` for wrapping libev
 * Add `Gyro::Queue`, a fiber-aware thread-safe queue
 * Implement multithreaded fiber scheduling
 
-0.26 2020-01-12
----------------
+## 0.26 2020-01-12
 
 * Optimize `IO#read_watcher`, `IO#write_watcher`
 * Implement `Fiber#raise`
 * Fix `Kernel#gets` with `ARGV`
 * Return `[pid, exit_status]` from `Gyro::Child#await`
 
-0.25 2020-01-10
----------------
+## 0.25 2020-01-10
 
 * Fold `Coprocess` functionality into `Fiber`
 * Add support for indefinite `#sleep`
 
-0.24 2020-01-08
----------------
+## 0.24 2020-01-08
 
 * Extract HTTP code into separate polyphony-http gem
 * Cull core, io examples
 * Remove `SIGINT` handler
 
-0.23 2020-01-07
----------------
+## 0.23 2020-01-07
 
 * Remove `API#pulse`
 * Better repeat timer, reimplement `API#every`
@@ -91,8 +91,7 @@
 * Add Gyro.run
 * Move away from callback-based API for `Gyro::Timer`, `Gyro::Signal`
 
-0.22 2020-01-02
----------------
+## 0.22 2020-01-02
 
 * Redesign Gyro scheduling subsystem, go scheduler-less
 * More docs
@@ -102,8 +101,7 @@
 * Fix socket extensions
 * Fix ALPN setup in Net.secure_socket
 
-0.21 2019-12-12
----------------
+## 0.21 2019-12-12
 
 * Add Coprocess.await (for waiting for multiple coprocesses)
 * Add Coprocess#caller, Coprocess#location methods
@@ -112,8 +110,7 @@
 * Improve error handling in HTTP/2 adapter
 * More documentation
 
-0.20 2019-11-27
----------------
+## 0.20 2019-11-27
 
 * Refactor and improve CancelScope, ResourcePool
 * Reimplement cancel_after, move_on_after using plain timers
@@ -147,8 +144,7 @@
 * Fix HTTP1 adapter
 * Better support for debugging with ruby-debug-ide (WIP)
 
-0.19 2019-06-12
----------------
+## 0.19 2019-06-12
 
 * Rewrite HTTP server for better concurrency, sequential API
 * Support 204 no-content response in HTTP 1
@@ -156,14 +152,12 @@
 * Implement Fiber#safe_transfer in C
 * Optimize Kernel#next_tick implementation using ev_idle instead of ev_timer
 
-0.18 2019-06-08
----------------
+## 0.18 2019-06-08
 
 * Rename Kernel#coproc to Kernel#spin
 * Rewrite Supervisor#spin
 
-0.17 2019-05-24
----------------
+## 0.17 2019-05-24
 
 * Implement IO#read_watcher, IO#write_watcher in C for better performance
 * Implement nonblocking (yielding) versions of Kernel#system, IO.popen,
@@ -173,14 +167,12 @@
 * Fix encoding of strings read with IO#read, IO#readpartial
 * Fix non-blocking behaviour of IO#read, IO#readpartial, IO#write
 
-0.16 2019-05-22
----------------
+## 0.16 2019-05-22
 
 * Reorganize and refactor code
 * Allow opening secure socket without OpenSSL context
 
-0.15 2019-05-20
----------------
+## 0.15 2019-05-20
 
 * Optimize `#next_tick` callback (about 6% faster than before)
 * Fix IO#<< to return self
@@ -188,8 +180,7 @@
 * Fix race condition in `Supervisor#stop!`
 * Add `Kernel#snooze` method (`EV.snooze` will be deprecated eventually)
 
-0.14 2019-05-17
----------------
+## 0.14 2019-05-17
 
 * Use chunked encoding in HTTP 1 response
 * Rewrite `IO#read`, `#readpartial`, `#write` in C (about 30% performance improvement)
@@ -199,13 +190,11 @@
 * Preliminary support for websocket (see `examples/io/http_ws_server.rb`)
 * Rename `Coroutine` to `Coprocess`
 
-0.13 2019-01-05
----------------
+## 0.13 2019-01-05
 
 * Rename Rubato to Polyphony (I know, this is getting silly...)
 
-0.12 2019-01-01
----------------
+## 0.12 2019-01-01
 
 * Add Coroutine#resume
 * Improve startup time
@@ -214,8 +203,7 @@
 * Improve handling of uncaught raised errors
 * Implement HTTP 1.1/2 client agent with connection management
 
-0.11 2018-12-27
----------------
+## 0.11 2018-12-27
 
 * Move reactor loop to secondary fiber, allow blocking operations on main
   fiber.
@@ -225,8 +213,7 @@
   for message passing
 * Add Coroutine.current for getting current coroutine
 
-0.10 2018-11-20
----------------
+## 0.10 2018-11-20
 
 * Rewrite Rubato core for simpler code and better performance
 * Implement EV.snooze (sleep until next tick)
@@ -236,20 +223,17 @@
 * Rate throttling
 * Implement async SSL server
 
-0.9 2018-11-14
---------------
+## 0.9 2018-11-14
 
 * Rename Nuclear to Rubato
 
-0.8 2018-10-04
---------------
+## 0.8 2018-10-04
 
 * Replace nio4r with in-house extension based on libev, with better API,
   better performance, support for IO, timer, signal and async watchers
 * Fix mem leak coming from nio4r (probably related to code in Selector#select)
 
-0.7 2018-09-13
---------------
+## 0.7 2018-09-13
 
 * Implement resource pool
 * transaction method for pg cient
@@ -258,22 +242,19 @@
 * Improve HTTP server performance
 * Proper promise chaining
 
-0.6 2018-09-11
---------------
+## 0.6 2018-09-11
 
 * Add http, redis, pg dependencies
 * Move ALPN code inside net module
 
-0.4 2018-09-10
---------------
+## 0.4 2018-09-10
 
 * Code refactored and reogranized
 * Fix recursion in next_tick
 * HTTP 2 server with support for ALPN protocol negotiation and HTTP upgrade
 * OpenSSL server
 
-0.3 2018-09-06
---------------
+## 0.3 2018-09-06
 
 * Event reactor
 * Timers

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    polyphony (0.30)
+    polyphony (0.31)
       modulation (~> 1.0)
 
 GEM
@@ -90,12 +90,14 @@ GEM
     rb-inotify (0.10.1)
       ffi (~> 1.0)
     redis (4.1.0)
+    rexml (3.2.4)
     rouge (3.15.0)
-    rubocop (0.79.0)
+    rubocop (0.80.0)
       jaro_winkler (~> 1.5.1)
       parallel (~> 1.10)
       parser (>= 2.7.0.1)
       rainbow (>= 2.2.2, < 4.0)
+      rexml
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 1.7)
     ruby-progressbar (1.10.1)
@@ -131,7 +133,7 @@ DEPENDENCIES
   polyphony!
   rake-compiler (= 1.0.5)
   redis (= 4.1.0)
-  rubocop (= 0.79.0)
+  rubocop (= 0.80.0)
   simplecov (= 0.17.1)
 
 BUNDLED WITH

data/Rakefile

@@ -3,8 +3,6 @@
 require "bundler/gem_tasks"
 require "rake/clean"
 
-# frozen_string_literal: true
-
 require "rake/extensiontask"
 Rake::ExtensionTask.new("gyro_ext") do |ext|
   ext.ext_dir = "ext/gyro"
@@ -21,6 +19,4 @@ task :docs do
   exec 'RUBYOPT=-W0 jekyll serve -s docs'
 end
 
-task default: %w[compile]
-
 CLEAN.include "**/*.o", "**/*.so", "**/*.bundle", "**/*.jar", "pkg", "tmp"

data/TODO.md

@@ -1,4 +1,47 @@
-## 0.31 Working Sinatra application
+## 0.32 Working Sinatra application
+
+  - Introduce mailbox limiting:
+    - add API for limiting mailbox size:
+
+      ```ruby
+      Fiber.current.mailbox_limit = 1000
+      ```
+
+    - Add the limit for `Gyro::Queue`
+
+      ```ruby
+      Gyro::Queue.new(1000)
+      ```
+
+    - Pushing to a limited queue will block if limit is reached
+
+  - Introduce selective receive:
+
+    ```ruby
+    # returns (or waits for) the first message for which the block returns true
+    (_, item) = receive { |msg| msg.first == ref }
+    ```
+
+    Possible implementation:
+
+    ```ruby
+    def receive
+      return @mailbox.shift unless block_given?
+      
+      loop
+        msg = @mailbox.shift
+        return msg if yield(msg)
+
+        # message didn't match condition, put it back in queue
+        @mailbox.push msg
+      end
+    end
+    ```
+
+- Test hypothetical situation 1:
+  - fiber A sends a request to fiber B
+  - fiber B terminates on a raised exception
+  - What happens to fiber A? (it should get the exception)
 
 - Accept rate/interval in `spin_loop` and `spin_worker_loop`:
 
@@ -8,13 +51,22 @@
   spin_loop(interval: 10) { ... } # once every ten seconds
   ```
 
-- Docs: explain difference between `sleep` and `suspend`
+- Docs
+  - landing page:
+    - links to the interesting stuff
+      - concurrency overview
+      - faq
+      - benchmarks
+  - explain difference between `sleep` and `suspend`
+  - concurrency overview: add explanation about async vs sync
+
+- move all adapters into polyphony/adapters
+
 - Check why first call to `#sleep` returns too early in tests. Check the
   sleep behaviour in a spawned thread.
-- app with database access (postgresql)
-- benchmarks!
+- sintra app with database access (postgresql)
 
-## 0.32 Sidekick
+## 0.33 Sidekick
 
 Plan of action:
 
@@ -22,13 +74,13 @@ Plan of action:
 - test performance
 - proceed from there
 
-## 0.33 Testing && Docs
+## 0.34 Testing && Docs
 
 - Pull out redis/postgres code, put into new `polyphony-xxx` gems
 
-## 0.34 Integration
+## 0.35 Integration
 
-## 0.35 Real IO#gets and IO#read
+## 0.36 Real IO#gets and IO#read
 
 - More tests
 - Implement some basic stuff missing:
@@ -38,7 +90,7 @@ Plan of action:
   - `IO.foreach`
   - `Process.waitpid`
 
-## 0.36 Rails
+## 0.37 Rails
 
 - Rails?
 

data/examples/{interfaces → adapters}/pg_client.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony/postgres'
+require 'polyphony/adapters/postgres'
 
 def get_records
   $db.query('select 1 as test')

data/examples/{interfaces → adapters}/pg_notify.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony/postgres'
+require 'polyphony/adapters/postgres'
 
 opts = {
   host:     '/tmp',

data/examples/{interfaces → adapters}/pg_pool.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony/postgres'
+require 'polyphony/adapters/postgres'
 
 PGOPTS = {
   host:     '/tmp',

data/examples/{interfaces → adapters}/pg_transaction.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony/postgres'
+require 'polyphony/adapters/postgres'
 
 DB = PG.connect(
   host:     '/tmp',

data/examples/{interfaces → adapters}/redis_channels.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony'
-require 'polyphony/redis'
+require 'polyphony/adapters/redis'
 
 class RedisChannel < Polyphony::Channel
   def self.publish_connection

data/examples/{interfaces → adapters}/redis_client.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony/redis'
+require 'polyphony/adapters/redis'
 
 redis = Redis.new
 

data/examples/{interfaces → adapters}/redis_pubsub.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony'
-require 'polyphony/redis'
+require 'polyphony/adapters/redis'
 
 spin do
   redis = Redis.new

data/examples/{interfaces → adapters}/redis_pubsub_perf.rb

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
 require 'bundler/setup'
-require 'polyphony'
-require 'polyphony/redis'
+require 'polyphony/adapters/redis'
 require 'json'
 
 X_SESSIONS = 1000

data/ext/gyro/thread.c

@@ -129,6 +129,39 @@ VALUE Thread_schedule_fiber(VALUE self, VALUE fiber, VALUE value) {
   return self;
 }
 
+VALUE Thread_schedule_fiber_with_priority(VALUE self, VALUE fiber, VALUE value) {
+  if (rb_fiber_alive_p(fiber) != Qtrue) {
+    return self;
+  }
+  FIBER_TRACE(3, SYM_fiber_schedule, fiber, value);
+  rb_ivar_set(fiber, ID_runnable_value, value);
+
+  VALUE queue = rb_ivar_get(self, ID_run_queue);
+
+  // if fiber is already scheduled, remove it from the run queue
+  if (rb_ivar_get(fiber, ID_runnable) != Qnil) {
+    rb_ary_delete(queue, fiber);
+  } else {
+    rb_ivar_set(fiber, ID_runnable, Qtrue);
+  }
+
+  // the fiber is given priority by putting it at the front of the run queue
+  rb_ary_unshift(queue, fiber);
+
+  if (rb_thread_current() != self) {
+    // if the fiber scheduling is done across threads, we need to make sure the
+    // target thread is woken up in case it is in the middle of running its
+    // event selector. Otherwise it's gonna be stuck waiting for an event to
+    // happen, not knowing that it there's already a fiber ready to run in its
+    // run queue.
+    VALUE selector = rb_ivar_get(self, ID_ivar_event_selector);
+    if (selector != Qnil) {
+      Gyro_Selector_break_out_of_ev_loop(selector);
+    }
+  }
+  return self;
+}
+
 VALUE Thread_switch_fiber(VALUE self) {
   VALUE current_fiber = rb_fiber_current();
   if (__tracing_enabled__) {
@@ -202,7 +235,7 @@ VALUE Thread_current_event_selector() {
 
 VALUE Thread_fiber_break_out_of_ev_loop(VALUE self, VALUE resume_obj) {
   VALUE selector = rb_ivar_get(self, ID_ivar_event_selector);
-  Thread_schedule_fiber(self, rb_fiber_current(), resume_obj);
+  Thread_schedule_fiber_with_priority(self, rb_fiber_current(), resume_obj);
 
   if (Gyro_Selector_break_out_of_ev_loop(selector) == Qnil) {
     // we're not inside the ev_loop, so we just do a switchpoint
@@ -243,6 +276,8 @@ void Init_Thread() {
   rb_define_method(rb_cThread, "break_out_of_ev_loop", Thread_fiber_break_out_of_ev_loop, 1);
 
   rb_define_method(rb_cThread, "schedule_fiber", Thread_schedule_fiber, 2);
+  rb_define_method(rb_cThread, "schedule_fiber_with_priority",
+    Thread_schedule_fiber_with_priority, 2);
   rb_define_method(rb_cThread, "switch_fiber", Thread_switch_fiber, 0);
 
   rb_define_method(rb_cThread, "join_perform", Thread_join_perform, 0);

data/ext/gyro/timer.c

@@ -131,11 +131,12 @@ VALUE Gyro_Timer_await(VALUE self) {
     ev_timer_stop(timer->ev_loop, &timer->ev_timer);
     timer->ev_loop = 0;
   }
-  RB_GC_GUARD(self);
 
   // fiber is resumed, check if resumed value is an exception
   timer->fiber = Qnil;
   timer->selector = Qnil;
+
+  RB_GC_GUARD(self);
   if (RTEST(rb_obj_is_kind_of(ret, rb_eException))) {
     return rb_funcall(rb_mKernel, ID_raise, 1, ret);
   }

data/lib/polyphony.rb

@@ -30,12 +30,12 @@ module Polyphony
   auto_import(
     CancelScope:  './polyphony/core/cancel_scope',
     Channel:      './polyphony/core/channel',
-    FS:           './polyphony/fs',
+    FS:           './polyphony/adapters/fs',
     ResourcePool: './polyphony/core/resource_pool',
     Sync:         './polyphony/core/sync',
     ThreadPool:   './polyphony/core/thread_pool',
     Throttler:    './polyphony/core/throttler',
-    Trace:        './polyphony/trace',
+    Trace:        './polyphony/adapters/trace',
     Websocket:    './polyphony/websocket'
   )
 

data/lib/polyphony/adapters/irb.rb

@@ -0,0 +1,51 @@
+# frozen_string_literal: true
+
+require 'polyphony'
+
+if Object.constants.include?(:Reline)
+  class Reline::ANSI
+    def self.select(read_ios = [], write_ios = [], error_ios = [], timeout = nil)
+      p [:select, read_ios]
+      raise if read_ios.size > 1
+      raise if write_ios.size > 0
+      raise if error_ios.size > 0
+      
+      fiber = Fiber.current
+      timer = spin do
+        sleep timeout
+        fiber.cancel!
+      end
+      read_ios.each do |io|
+        io.read_watcher.await
+        return [io]
+      end
+    rescue Polyphony::Cancel
+      return nil
+    ensure
+      timer.stop
+    end
+  end
+else
+  # readline blocks the current thread, so we offload it to the blocking-ops
+  # thread pool. That way, the reactor loop can keep running while waiting for
+  # readline to return
+  module ::Readline
+    alias_method :orig_readline, :readline
+
+    Workers = Polyphony::ThreadPool.new
+
+    def readline(*args)
+      p :readline
+      # caller.each do |l|
+      #   STDOUT.orig_puts l
+      # end
+      Workers.process { orig_readline(*args) }
+    end
+  end
+
+  class ::RubyLex
+    class TerminateLineInput2 < RuntimeError
+    end
+    const_set(:TerminateLineInput, TerminateLineInput2)
+  end
+end

data/lib/polyphony/{postgres.rb → adapters/postgres.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../polyphony'
+require_relative '../../polyphony'
 require 'pg'
 
 # PG overrides

data/lib/polyphony/{redis.rb → adapters/redis.rb}

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../polyphony'
+require_relative '../../polyphony'
 
 require 'redis'
 require 'hiredis/reader'

data/lib/polyphony/core/global_api.rb

@@ -32,8 +32,8 @@ module API
     Fiber.current.spin(tag, caller, &block)
   end
 
-  def spin_loop(&block)
-    spin { loop(&block) }
+  def spin_loop(tag = nil, &block)
+    Fiber.current.spin(tag, caller) { loop(&block) }
   end
 
   def every(interval)

data/lib/polyphony/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Polyphony
-  VERSION = '0.30'
+  VERSION = '0.31'
 end

data/polyphony.gemspec

@@ -28,7 +28,7 @@ Gem::Specification.new do |s|
   s.add_development_dependency  'minitest',             '5.13.0'
   s.add_development_dependency  'minitest-reporters',   '1.4.2'
   s.add_development_dependency  'simplecov',            '0.17.1'
-  s.add_development_dependency  'rubocop',              '0.79.0'
+  s.add_development_dependency  'rubocop',              '0.80.0'
   s.add_development_dependency  'pg',                   '1.1.3'
   s.add_development_dependency  'rake-compiler',        '1.0.5'
   s.add_development_dependency  'redis',                '4.1.0'

data/test/test_fiber.rb

@@ -608,7 +608,7 @@ class FiberTest < MiniTest::Test
     Process.kill('INT', pid)
     f.await
     klass = i.read
-    o.close
+    i.close
     assert_equal 'Interrupt', klass
   end
 

data/test/test_global_api.rb

@@ -230,6 +230,19 @@ class MoveOnAfterTest < MiniTest::Test
     assert_equal [1, 2, 3], buffer
   end
 
+  def test_spin_loop_location
+    location = /^#{__FILE__}:#{__LINE__ + 1}/
+    f = spin_loop {}
+    
+    assert_match location, f.location
+  end
+
+  def test_spin_loop_tag
+    f = spin_loop(:my_loop) {}
+
+    assert_equal :my_loop, f.tag
+  end
+
   def test_throttled_loop
     buffer = []
     counter = 0

data/test/test_signal.rb

@@ -36,3 +36,76 @@ class SignalTest < MiniTest::Test
     assert_equal 1, count
   end
 end
+
+class SignalTrapTest < Minitest::Test
+  def test_signal_exception_propagation
+    i, o = IO.pipe
+    pid = Polyphony.fork do
+      i.close
+      spin do
+        spin do
+          sleep 1
+        rescue ::Interrupt => e
+          o.puts "1-interrupt"
+          raise e
+        end.await
+      rescue ::Interrupt => e
+        o.puts "2-interrupt"
+        raise e
+      end.await
+    rescue ::Interrupt => e
+      o.puts "3-interrupt"
+    ensure
+      o.close
+    end
+    sleep 0.01
+    o.close
+    watcher = Gyro::Child.new(pid)
+    Process.kill('INT', pid)
+    watcher.await
+    buffer = i.read
+    assert_equal "1-interrupt\n2-interrupt\n3-interrupt\n", buffer
+  end
+
+  def test_signal_exception_possible_race_condition
+    i, o = IO.pipe
+    pid = Polyphony.fork do
+      i.close
+      f1 = nil
+      f2 = spin do
+        # this fiber will try to create a race condition by
+        # - being scheduled before f1 is scheduled with the Interrupt exception
+        # - scheduling f1 without an exception
+        suspend
+        f1.schedule
+      rescue ::Interrupt => e
+        o.puts '2-interrupt'
+        raise e
+      end
+      f1 = spin do
+        # this fiber is the one that will be current when the
+        # signal is trapped
+        sleep 1
+        o << 'boom'
+      rescue ::Interrupt => e
+        o.puts '1-interrupt'
+        raise e
+      end
+      old_trap = trap('INT') do
+        f2.schedule
+        old_trap.()
+      end
+      Fiber.current.await_all_children
+    rescue ::Interrupt => e
+      o.puts '3-interrupt'
+    ensure
+      o.close
+    end
+    o.close
+    sleep 0.1
+    Process.kill('INT', pid)
+    Gyro::Child.new(pid).await
+    buffer = i.read
+    assert_equal "1-interrupt\n3-interrupt\n", buffer
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: polyphony
 version: !ruby/object:Gem::Version
-  version: '0.30'
+  version: '0.31'
 platform: ruby
 authors:
 - Sharon Rosner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-14 00:00:00.000000000 Z
+date: 2020-02-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: modulation
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.80.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.80.0
 - !ruby/object:Gem::Dependency
   name: pg
   requirement: !ruby/object:Gem::Requirement
@@ -275,6 +275,14 @@ files:
 - docs/user-guide.md
 - docs/user-guide/all-about-timers.md
 - docs/user-guide/web-server.md
+- examples/adapters/pg_client.rb
+- examples/adapters/pg_notify.rb
+- examples/adapters/pg_pool.rb
+- examples/adapters/pg_transaction.rb
+- examples/adapters/redis_channels.rb
+- examples/adapters/redis_client.rb
+- examples/adapters/redis_pubsub.rb
+- examples/adapters/redis_pubsub_perf.rb
 - examples/core/01-spinning-up-fibers.rb
 - examples/core/02-awaiting-fibers.rb
 - examples/core/03-interrupting.rb
@@ -310,14 +318,6 @@ files:
 - examples/core/xx-trace.rb
 - examples/core/xx-using-a-mutex.rb
 - examples/core/xx-worker-thread.rb
-- examples/interfaces/pg_client.rb
-- examples/interfaces/pg_notify.rb
-- examples/interfaces/pg_pool.rb
-- examples/interfaces/pg_transaction.rb
-- examples/interfaces/redis_channels.rb
-- examples/interfaces/redis_client.rb
-- examples/interfaces/redis_pubsub.rb
-- examples/interfaces/redis_pubsub_perf.rb
 - examples/io/xx-backticks.rb
 - examples/io/xx-echo_client.rb
 - examples/io/xx-echo_client_from_stdin.rb
@@ -378,6 +378,11 @@ files:
 - ext/libev/ev_wrap.h
 - ext/libev/test_libev_win32.c
 - lib/polyphony.rb
+- lib/polyphony/adapters/fs.rb
+- lib/polyphony/adapters/irb.rb
+- lib/polyphony/adapters/postgres.rb
+- lib/polyphony/adapters/redis.rb
+- lib/polyphony/adapters/trace.rb
 - lib/polyphony/core/cancel_scope.rb
 - lib/polyphony/core/channel.rb
 - lib/polyphony/core/exceptions.rb
@@ -392,12 +397,7 @@ files:
 - lib/polyphony/extensions/openssl.rb
 - lib/polyphony/extensions/socket.rb
 - lib/polyphony/extensions/thread.rb
-- lib/polyphony/fs.rb
-- lib/polyphony/irb.rb
 - lib/polyphony/net.rb
-- lib/polyphony/postgres.rb
-- lib/polyphony/redis.rb
-- lib/polyphony/trace.rb
 - lib/polyphony/version.rb
 - polyphony.gemspec
 - test/coverage.rb

data/lib/polyphony/irb.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-require 'polyphony'
-
-# readline blocks the current thread, so we offload it to the blocking-ops
-# thread pool. That way, the reactor loop can keep running while waiting for
-# readline to return
-module ::Readline
-  alias_method :orig_readline, :readline
-
-  def readline(*args)
-    async = Gyro::Async.new
-    Thread.new do
-      result = orig_readline(*args)
-      async.signal!(result)
-    end
-    async.await
-  end
-end