polymorpheus 1.1.2 → 1.1.3

data/lib/polymorpheus/interface.rb

@@ -65,15 +65,18 @@ module Polymorpheus
 
         # Setter method
         define_method "#{polymorphic_api}=" do |polymorphic_obj|
-          possible_associations = [ polymorphic_obj.class.name.underscore,
-                                    polymorphic_obj.class.superclass.name.underscore ]
-          match = associations & possible_associations
+
+          klass_ancestors = polymorphic_obj.class
+                            .ancestors.map(&:name).compact.map(&:underscore)
+          match = associations & klass_ancestors
+
           if match.blank?
-            raise Polymorpheus::Interface::PolymorphicError, associations
+            raise Polymorpheus::Interface::InvalidTypeError, associations
           elsif match.length > 1
             raise Polymorpheus::Interface::AmbiguousTypeError
           else
-            self.send("#{match[0]}_id=", polymorphic_obj.id)
+            accessor = "#{polymorphic_obj.class.base_class.name.underscore}_id="
+            self.send(accessor, polymorphic_obj.id)
             (associations - match).each do |association_to_reset|
               self.send("#{association_to_reset}_id=", nil)
             end

data/lib/polymorpheus/version.rb

@@ -1,3 +1,3 @@
 module Polymorpheus
-  VERSION = '1.1.2'
+  VERSION = '1.1.3'
 end

data/spec/interface_spec.rb

@@ -16,6 +16,20 @@ end
 class Woman < ActiveRecord::Base
 end
 
+class Dog < ActiveRecord::Base
+end
+
+class Glove < ActiveRecord::Base
+  belongs_to_polymorphic :gentleman, :as => :wearer
+  validates_polymorph :wearer
+end
+
+class Gentleman < Man
+end
+
+class Knight < Gentleman
+end
+
 describe Shoe do
 
   let(:shoe) { Shoe.new(attributes) }
@@ -35,6 +49,59 @@ describe Shoe do
       include?(:polymorphic_wearer_relationship_is_valid).should be_true
   end
 
+  describe "dynamic generated setter" do
+    let(:attributes) { {} }
+
+    it "sets the correct attribute value for the setter" do
+      shoe.wearer = man
+      shoe.man_id.should == man.id
+      shoe.woman_id.should == nil
+    end
+
+    it "sets competing associations to nil" do
+      shoe.wearer = man
+      shoe.man_id.should == man.id
+      shoe.wearer = woman
+      shoe.woman_id.should == woman.id
+      shoe.man_id.should == nil
+    end
+
+    it "throws an error if the assigned object isn't a valid type" do
+      dog = Dog.create!
+      expect { shoe.wearer = dog }
+        .to raise_error(Polymorpheus::Interface::InvalidTypeError,
+                        "Invalid type. Must be one of {man, woman}")
+    end
+
+    it "does not throw an error if the assigned object is a subclass of a valid type" do
+      gentleman = Gentleman.create!
+      expect { shoe.wearer = gentleman }.not_to raise_error
+      shoe.man_id.should == gentleman.id
+    end
+
+    it "does not throw an error if the assigned object is a descendant of a valid type" do
+      knight = Knight.create!
+      expect { shoe.wearer = knight }.not_to raise_error
+      shoe.man_id.should == knight.id
+    end
+
+    it "does not throw an error if the association is to a parent class of
+    assigned object that is not the base" do
+      glove = Glove.new({})
+      knight = Knight.create!
+      expect { glove.wearer = knight }.not_to raise_error
+      glove.man_id.should == knight.id
+    end
+
+    it "throws an error if assigned object is a less specific instance of the association" do
+      glove = Glove.new({})
+      man = Man.create!
+      expect { glove.wearer = man }
+        .to raise_error(Polymorpheus::Interface::InvalidTypeError,
+                        "Invalid type. Must be one of {gentleman}")
+    end
+  end
+
   shared_examples_for "invalid polymorphic relationship" do
     specify { shoe.wearer.should == nil }
     specify { shoe.wearer_active_key.should == nil }

data/spec/spec_helper.rb

@@ -15,7 +15,14 @@ ActiveRecord::Schema.define do
     t.integer :man_id
     t.integer :woman_id
   end
-  create_table :men
+  create_table :gloves do |t|
+    t.integer :man_id
+    t.integer :woman_id
+  end
+  create_table :men do |t|
+    t.string :type
+  end
   create_table :women
+  create_table :dogs
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polymorpheus
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 1.1.3
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-12-23 00:00:00.000000000Z
+date: 2013-06-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foreigner
-  requirement: &70126037079580 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70126037079580
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activerecord
-  requirement: &70126037079040 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,10 +37,15 @@ dependencies:
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *70126037079040
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &70126037078620 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -43,10 +53,15 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70126037078620
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mysql2
-  requirement: &70126037078160 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -54,7 +69,12 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *70126037078160
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Provides a database-friendly method for polymorphic relationships
 email: bsingh@wegowise.com
 executables: []
@@ -104,7 +124,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.6
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.6
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Provides a database-friendly method for polymorphic relationships