polyfillrb 1.0.1 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b228511cfaa9433ee7814bde7f5ddb50fd308193
-  data.tar.gz: f7f663d58e0ba1416e2f8d8a1baa65f56d5b8545
+  metadata.gz: 83b52ea541bf7e5477966fac05ba3a4d330f8e20
+  data.tar.gz: 89bb0281f93563920c8045c9ca3f1c97c71f8e22
 SHA512:
-  metadata.gz: 2050e3d7b66491937997b585190d95ce76c3b7c900f1c0fc78c4b2cb302ee47cb50904e50b0ffc6470d3ad918ce01e0ecb25e11c515479430b7a25098894ad95
-  data.tar.gz: cde55d28a09d25f74b3e2130c69ffdff5959799ad1418af32a224266b972e202bdae1b035a3918cb33612e968179ba158dd4d34de7f7668f0bbffda5a8c13885
+  metadata.gz: 4dba32c66efc3ff13f2ef3e7d6ff5c548da9a4655bcae4bcc6b04b84cfabcd4b5d7d8d0c86e9f9d7d6a54e0e6edef3fb990b1dde847996f1b3aa307684b2713d
+  data.tar.gz: 0bdb15103e6cf9b009cd44d8970397f6751d3425f969aa871596579994ae8e2c027283725936efe9d5084c66190f3b0c1cf11253ff129199c1d228e9442b0e2d

data/README.md

@@ -1,4 +1,4 @@
-# Polyfillrb
+# Polyfillrb [![Code Climate](https://codeclimate.com/github/blainekasten/polyfillrb/badges/gpa.svg)](https://codeclimate.com/github/blainekasten/polyfillrb)
 
 A simple ruby wrapper for the phenominal [Polyfill.io Service by FTLabs](https://cdn.polyfill.io/v1/docs/) for Rails applications.
 
@@ -24,15 +24,11 @@ The library provides a simple view helper to load in the polyfills. Simply in an
 
 ### Installing
 
-Add the gem to your Gemfile: `gem "polyfillrb", "~>1.0.0"`
+Add the gem to your Gemfile: `gem "polyfillrb", "~>1.1.0"`
 
-Then you must run the command to build the polyfills. simply run:
-
-    %> polyfillrb init
 
 ### Future Plans
 
 * Cache polyfills to avoid node IO calls (especially in production)
 * Ensure we are doing the most performant javascript executions.
-* Remove the need to run `polyfillrb init` on install. It'd be best if it could all be bundled up, but that has some issues to resolve in itself.
 

data/lib/polyfill.js

@@ -0,0 +1,11 @@
+'use strict';
+
+var args = process.argv.slice(3);
+
+process.stdout.write((function(uaString, minify){
+  return require(__dirname + '/polyfill-service/lib').getPolyfillString({
+    uaString: uaString,
+    minify: !!minify,
+    features: { default: { flags: [] } }
+  });
+})(args[0], args[1]));

data/lib/polyfillrb/rails/railtie.rb

@@ -10,6 +10,20 @@ module Polyfillrb
           include ::Polyfillrb::Rails::ViewHelper
         end
       end
+
+      # Preload the application with polyfills
+      initializer "polyfillrb.configure_rails_initialization" do |app|
+
+        # clone polyfill
+        ::Rails.logger.info "Gathering Polyfill Library..."
+        %x( cd #{Polyfillrb::PROJECT_DIRECTORY} && git clone git@github.com:Financial-Times/polyfill-service.git )
+
+        # build the npm locals
+        ::Rails.logger.info "Buidling Polyfills...\n  this may take a minute"
+        %x( cd #{Polyfillrb::PROJECT_DIRECTORY}/polyfill-service && [ -d "node_modules" ] || npm install && grunt buildsources )
+
+      end
+
     end
   end
 end

data/lib/polyfillrb/rails/view_helper.rb

@@ -4,7 +4,7 @@ module Polyfillrb
     module ViewHelper
 
       def polyfills
-        polyfills = Polyfillrb.get_polyfills(
+        polyfills = ::Polyfillrb.get_polyfills(
           request.env['HTTP_USER_AGENT'],
           (::Rails.env != 'development')
         )

data/lib/polyfillrb/version.rb

@@ -1,3 +1,3 @@
 module Polyfillrb
-  VERSION = '1.0.1'
+  VERSION = '1.1.0'
 end

data/lib/polyfillrb.rb

@@ -1,66 +1,11 @@
-require 'polyfillrb/rails'
+require 'polyfillrb/rails' if defined?(Rails)
 
 module Polyfillrb
 
   PROJECT_DIRECTORY = File.expand_path(File.dirname(__FILE__))
 
   def self.get_polyfills(ua, minify=false)
-
-    # we console.log the results of the polyfillService so that we
-    # can read them from the IO instance.
-    #
-    # This feels kind of hacky, so in the future we can look into
-    # better ways to inject JS into this.
-    jscode = <<-JS
-      console.log(
-        require('#{PROJECT_DIRECTORY}/polyfill-service/lib').getPolyfillString({
-          uaString: '#{ua}',
-          minify: #{minify},
-          features: { default: { flags: [] } }
-        })
-      );
-    JS
-
-    # pump into a node runner
-    i = IO.popen('node', 'r+')
-    i.write(jscode)
-    i.close_write
-
-    # return the results
-    return i.read 
-  end
-
-
-  #
-  # loads the javascript for the application
-  def self.init
-    # check for node and npm
-
-
-    # clone polyfill
-    puts "-- Cloning Polyfill js\n"
-    #%x( cd #{PROJECT_DIRECTORY} && git clone --branch v1.2.0 git@github.com:Financial-Times/polyfill-service.git )
-    %x( cd #{PROJECT_DIRECTORY} && git clone git@github.com:Financial-Times/polyfill-service.git )
-
-    # build the npm locals
-    puts "\n-- Grabbing dependencies\n"
-    %x( cd #{PROJECT_DIRECTORY}/polyfill-service && npm install )
-
-    # build the polyfills
-    #puts "\n-- Building polyfills\n"
-    #%x( cd #{PROJECT_DIRECTORY}/polyfill-service && grunt build )
-  end
-
-  def self.build
-
-    puts "-- Building polyfills \n"
-    %x( cd #{PROJECT_DIRECTORY}/polyfill-service && grunt buildsources )
-
-  end
-
-
-  def self.method_missing(method, blah, bleh)
-    puts "Polyfillrb does not support the action '#{method}'"
+    return %x( node #{PROJECT_DIRECTORY}/polyfill.js -p "#{ua}" #{minify})
   end
 
 end

data/polyfillrb.gemspec

@@ -13,7 +13,6 @@ Gem::Specification.new do |spec|
   spec.license       = "MIT"
 
   spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polyfillrb
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.1.0
 platform: ruby
 authors:
 - Blaine Kasten
@@ -27,8 +27,7 @@ dependencies:
 description: Provides user agent specific polyfills to the browser easily in ruby
 email:
 - blainekasten@gmail.com
-executables:
-- polyfillrb
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
@@ -36,7 +35,7 @@ files:
 - Gemfile
 - README.md
 - Rakefile
-- bin/polyfillrb
+- lib/polyfill.js
 - lib/polyfillrb.rb
 - lib/polyfillrb/rails.rb
 - lib/polyfillrb/rails/railtie.rb

data/bin/polyfillrb

@@ -1,12 +0,0 @@
-#!/usr/bin/env ruby
-
-begin
-  require 'rubygems'
-  gem 'polyfillrb'
-rescue LoadError
-end
-
-require 'polyfillrb'
-
-method = ARGV[0] || 'init'
-Polyfillrb.send(method.to_sym)