polyfill-data 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 156f764bced601a2ebf8cc7a6ee095d63a4d3f813ee3e9fe7c3b273ce68f007f
-  data.tar.gz: d7425307509c331ac61c33541da58effcbbb1f5b6ce675ede734b27c2acf0ed3
+  metadata.gz: 20b2218a1dd7298ead1e7bd8f08502558a2828f7aef9a5be33424084bd2d1c9b
+  data.tar.gz: fc1c0a53cab242883ffcae75f523a959e5a9b273c14f9e8fd334f5db78875802
 SHA512:
-  metadata.gz: 76a56991f1759077af526ef30236fcde606cd7fdc4dd9b5264e6d3012ad02e5a27feafa2dcf6900a54cd47e25525ee221702e07f41b6178f5cbb3cb7c4c2abfc
-  data.tar.gz: 995d6359685044724e2fda6a31e8dab8c73cbdee97dc49034ef7c45ee39a04a3a05ab7ec3046f78705e931316e2957a0992cbe3b3a36c1fd7d43794e89ee22ca
+  metadata.gz: 9291cd87f95c34b47e5a32f87bffa79f5eca7d0419c1fc741ee88ca3e3518a7435b63c827db569a2960b7fb3d516a408058db3a7fbde49f2dc1328d8dcc5109d
+  data.tar.gz: df56331c22ecc1ce85aaf5f2e743230b944f07298b1fdc248a337c3731628152f5fffc699d4eaa6ca3490767ff71ab23ea5cb98bbe9dd3f778fbe525c46e9807

data/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.0.3
+
+### Fixed
+
+- `new` correctly raises ArugmentErrors with incorrect arguments on Data subclasses
+
 ## 1.0.2
 
 ### Fixed

data/lib/data.rb

@@ -23,8 +23,8 @@ else
       klass.define_singleton_method(:members) { args.map{ _1.intern } }
 
       klass.define_singleton_method(:new) do |*new_args, **new_kwargs, &block|
-
         init_kwargs = if new_args.any?
+          raise ArgumentError, "unknown arguments #{new_args[members.size..].join(', ')}" if new_args.size > members.size
           Hash[members.take(new_args.size).zip(new_args)]
         else
           new_kwargs
@@ -55,6 +55,17 @@ else
     end
 
     def initialize(**kwargs)
+      kwargs_size = kwargs.size
+      members_size = members.size
+
+      if kwargs_size > members_size
+        extras = kwargs.reject{|k, _v| members.include?(k) }.keys
+        raise ArgumentError, "unknown arguments #{extras.join(', ')}"
+      elsif kwargs_size < members_size
+        missing = members.select {|k, _v| !kwargs.include?(k) }
+        raise ArgumentError, "missing arguments #{missing.map{ ":#{_1}" }.join(', ')}"
+      end
+
       @attributes = Hash[members.map {|m| [m,kwargs[m]] }]
     end
 

data/lib/polyfill/data/version.rb

@@ -2,6 +2,6 @@
 
 module Polyfill
   module Data
-    VERSION = "1.0.2"
+    VERSION = "1.0.3"
   end
 end

data/test/test_data.rb

@@ -86,7 +86,7 @@ class TestData < Minitest::Test
         super(foo: 1, bar: 2) # so we can experiment with passing wrong numbers of args
       end
     end
-    # require 'debug'; debugger
+
     assert_equal([[], {foo: 1, bar: 2}], klass.new(foo: 1, bar: 2).passed)
 
     # Positional arguments are converted to keyword ones

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: polyfill-data
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - Jim Gay
@@ -34,7 +34,7 @@ cert_chain:
   dxkiKqcX+yzo9RJLD9l/E1AWX125r1Fhiif4l6ehdl7Vllc3NQUOm1abdmHtCYjw
   dG3yPWBWzzN4ovoBRqsuTJbF1wjkCjl5ex5KhfYbeDc=
   -----END CERTIFICATE-----
-date: 2023-01-21 00:00:00.000000000 Z
+date: 2023-01-22 00:00:00.000000000 Z
 dependencies: []
 description: Add the ruby 3.2 Data class to older rubies
 email: