poltergeist 1.0.0 → 1.0.1

data/README.md

@@ -1,6 +1,6 @@
 # Poltergeist - A PhantomJS driver for Capybara #
 
-Version: 1.0
+Version: 1.0.1
 
 [![Build Status](https://secure.travis-ci.org/jonleighton/poltergeist.png)](http://travis-ci.org/jonleighton/poltergeist)
 
@@ -286,6 +286,15 @@ Include as much information as possible. For example:
 
 ## Changes ##
 
+### 1.0.1 ###
+
+#### Bug fixes ####
+
+*   Don't use a fixed port number by default; find an available port.
+    The port can still be configured to a fixed value using the `:port`
+    option. The reverts the default behaviour to how it was before the
+    1.0 release. [Issue #174]
+
 ### 1.0 ###
 
 #### Features ####

data/lib/capybara/poltergeist.rb

@@ -14,6 +14,7 @@ module Capybara
     require 'capybara/poltergeist/network_traffic'
     require 'capybara/poltergeist/errors'
     require 'capybara/poltergeist/cookie'
+    require 'capybara/poltergeist/util'
   end
 end
 

data/lib/capybara/poltergeist/driver.rb

@@ -3,7 +3,6 @@ require 'uri'
 module Capybara::Poltergeist
   class Driver < Capybara::Driver::Base
     DEFAULT_TIMEOUT = 30
-    DEFAULT_PORT    = 44678 # 'GHOST' on a keypad :)
 
     attr_reader :app, :app_server, :server, :client, :browser, :options
 
@@ -29,8 +28,8 @@ module Capybara::Poltergeist
 
     def server
       @server ||= Server.new(
-        options.fetch(:port,    DEFAULT_PORT),
-        options.fetch(:timeout, DEFAULT_TIMEOUT)
+        options.fetch(:port)    { Util.find_available_port },
+        options.fetch(:timeout) { DEFAULT_TIMEOUT          }
       )
     end
 

data/lib/capybara/poltergeist/util.rb

@@ -0,0 +1,12 @@
+require 'socket'
+
+module Capybara::Poltergeist
+  module Util
+    def self.find_available_port
+      server = TCPServer.new('127.0.0.1', 0)
+      server.addr[1]
+    ensure
+      server.close if server
+    end
+  end
+end

data/lib/capybara/poltergeist/version.rb

@@ -1,5 +1,5 @@
 module Capybara
   module Poltergeist
-    VERSION = "1.0.0"
+    VERSION = "1.0.1"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: poltergeist
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-07 00:00:00.000000000 Z
+date: 2012-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -222,6 +222,7 @@ files:
 - lib/capybara/poltergeist/browser.rb
 - lib/capybara/poltergeist/inspector.rb
 - lib/capybara/poltergeist/errors.rb
+- lib/capybara/poltergeist/util.rb
 - lib/capybara/poltergeist/web_socket_server.rb
 - lib/capybara/poltergeist/json.rb
 - lib/capybara/poltergeist/network_traffic/request.rb
@@ -260,7 +261,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4328509354684293409
+      hash: 4082965460771715410
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -269,7 +270,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -4328509354684293409
+      hash: 4082965460771715410
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.24