polist 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 12c67f64ccbfd9eaed69c1790de797006a08d504
-  data.tar.gz: 8cb87aa04c3e144986410511f244eb5fe08c1e0c
+SHA256:
+  metadata.gz: 73c8e323de7cb71b6b39441dd95abf7fbccb8de9cb391790faf2fde7f7f4a20a
+  data.tar.gz: a281f80553b3db467785bd1a2c04701a428c8dac372658369b8ddae8b5cc22b3
 SHA512:
-  metadata.gz: 73407de877df7e67b866f535de2cddba82bac3f67b64d50bf36b53cc430782ecbccf79d658ce0c1af592ab61f9c0dc05daaf907709caca8ee0d1f5d9df32a91b
-  data.tar.gz: 9817ce2cd398a53339ebcde02f21801f3871aa604fafac32f33fe173b5cab9217b2da1721e658b4b26dfb443f5b540c3500e5ddce54aadc68c086ed230315313
+  metadata.gz: 6af97512d4e3f8b135369ce37dedc444758c3d060af1df1839b80a296d2305469b4399138312f31b437d993681b726e01d54054b61d753da99ce4130a085fbef
+  data.tar.gz: 99420ff893d32b0eb1b02b498e0f51dede79054e24ef4f6282bdbb029f329e7fdebf19c6263e03c0298c44f42a8613d87b564c99e71dc88270fb07d40baaf4ec

data/.rspec

@@ -1,2 +1,3 @@
 --format documentation
 --color
+--require spec_helper

data/.rubocop.yml

@@ -1,205 +1,6 @@
+inherit_gem:
+  rubocop-config-umbrellio: lib/rubocop.yml
+
 AllCops:
   DisplayCopNames: true
-  TargetRubyVersion: 2.4
-  Exclude:
-    - polist.gemspec
-
-# Layout
-
-Layout/AlignParameters:
-  Enabled: true
-
-# Layout/MultilineMethodCallIndentation:
-#   Enabled: false
-
-# Layout/MultilineOperationIndentation:
-#   Enabled: false
-
-Layout/SpaceInLambdaLiteral:
-  EnforcedStyle: require_space
-
-Layout/SpaceInsideBrackets:
-  Enabled: false
-
-Layout/IndentArray:
-  EnforcedStyle: consistent
-
-Layout/IndentHash:
-  EnforcedStyle: consistent
-
-# Lint
-
-Lint/AmbiguousBlockAssociation:
-  Enabled: false
-
-Lint/AmbiguousOperator:
-  Enabled: false
-
-Lint/NonLocalExitFromIterator:
-  Enabled: false
-
-Lint/HandleExceptions:
-  Enabled: false
-
-Lint/RescueType:
-  Enabled: true
-
-Lint/ShadowingOuterLocalVariable:
-  Enabled: false
-
-Lint/ScriptPermission:
-  Enabled: true
-
-# Metrics
-
-# Metrics/AbcSize:
-#   Enabled: false
-
-Metrics/BlockLength:
-  Exclude:
-    - spec/**/*
-
-# Metrics/ClassLength:
-#   Enabled: false
-
-# Metrics/CyclomaticComplexity:
-#   Enabled: false
-
-Metrics/LineLength:
-  Max: 100
-
-Metrics/MethodLength:
-  Max: 20
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Performance
-
-Performance/Caller:
-  Enabled: true
-
-Performance/Casecmp:
-  Enabled: false
-
-# Security
-
-Security/YAMLLoad:
-  Enabled: false
-
-# Style
-
-Style/AccessorMethodName:
-  # This cop assumes every method is accessor
-  Enabled: false
-
-Style/AndOr:
-  # `do_something and return`
-  Enabled: false
-
-Style/ClassAndModuleChildren:
-  # Enable it in non-rails projects with EnforcedStyle you prefer
-  Enabled: false
-
-Style/CommentAnnotation:
-  # Also, i think that better to use yard's `@todo` and other in ruby code
-  Enabled: false
-
-Style/ConditionalAssignment:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/DoubleNegation:
-  # Always return booleans in predicates
-  Enabled: false
-
-Style/EmptyCaseCondition:
-  Enabled: false
-
-Style/EmptyElse:
-  Enabled: false
-
-Style/Encoding:
-  Enabled: false
-
-Style/FormatStringToken:
-  Enabled: true
-
-Style/IfUnlessModifier:
-  Enabled: true
-
-Style/GuardClause:
-  Enabled: false
-
-Style/HashSyntax:
-  Exclude:
-    - Rakefile
-
-Style/LambdaCall:
-  Enabled: false
-
-Style/ModuleFunction:
-  Enabled: false
-
-Style/MultilineTernaryOperator:
-  Enabled: false
-
-Style/MultipleComparison:
-  Enabled: true
-
-Style/NumericLiterals:
-  Description: 'Use indent in groups of 3 unlesss you meet project-specific rule'
-  Enabled: false
-
-Style/ParallelAssignment:
-  Enabled: false
-
-Style/PerlBackrefs:
-  Enabled: true
-
-Style/PredicateName:
-  NamePrefixBlacklist:
-    - is_
-
-Style/RaiseArgs:
-  Description: 'Use `raise, ErrorClass` in all cases but not when you need ErrorClass constructor'
-  Enabled: false
-
-Style/RegexpLiteral:
-  EnforcedStyle: mixed
-  Enabled: true
-
-Style/RescueModifier:
-  Enabled: false
-
-
-Style/StringLiterals:
-  EnforcedStyle: double_quotes
-  ConsistentQuotesInMultiline: true
-
-Style/SignalException:
-  EnforcedStyle: only_raise
-
-Style/SingleLineBlockParams:
-  Enabled: false
-
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
-Style/SymbolArray:
-  Enabled: false
-
-Style/TrailingCommaInArguments:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrivialAccessors:
-  AllowPredicates: true
-  Enabled: false
-
-Style/YodaCondition:
-  Enabled: false
+  TargetRubyVersion: 2.5

data/.travis.yml

@@ -1,5 +1,24 @@
-sudo: false
 language: ruby
+
+sudo: false
+
 rvm:
-  - 2.4.1
-before_install: gem install bundler -v 1.15.1
+  - 2.3
+  - 2.4
+  - 2.5
+  - ruby-head
+
+before_install: gem install bundler
+
+env: SUITE="rspec"
+
+script: bundle exec $SUITE
+
+matrix:
+  fast_finish: true
+  # Only run RuboCop on the latest Ruby
+  include:
+    - rvm: 2.5
+      env: SUITE="rubocop"
+  allow_failures:
+    - rvm: ruby-head

data/README.md

@@ -1,7 +1,10 @@
-# Polist
+# Polist   [![Gem Version](https://badge.fury.io/rb/polist.svg)](https://badge.fury.io/rb/polist) [![Build Status](https://travis-ci.org/umbrellio/polist.svg?branch=master)](https://travis-ci.org/umbrellio/polist) [![Coverage Status](https://coveralls.io/repos/github/umbrellio/polist/badge.svg?branch=master)](https://coveralls.io/github/umbrellio/polist?branch=master)
 
 `Polist::Service` is a simple class designed for creating service classes.
 
+### Installation
+Juts add `gem "polist"` to your Gemfile.
+
 ### Basic usage example
 ```ruby
 class MyService < Polist::Service
@@ -81,3 +84,13 @@ end
 MyService.call(param1: "1", param2: "2") # prints false and then ["1", 2, "smth"]
 ```
 The `#form` method is there just for convinience and by default it uses what `#form_attributes` returns as the attributes for the default form class which is the services' `Form` class. You are free to use as many different form classes as you want in your service.
+
+## License
+Released under MIT License.
+
+## Authors
+Created by Yuri Smirnov.
+
+<a href="https://github.com/umbrellio/">
+<img style="float: left;" src="https://umbrellio.github.io/Umbrellio/supported_by_umbrellio.svg" alt="Supported by Umbrellio" width="439" height="72">
+</a>

data/Rakefile

@@ -5,4 +5,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/lib/polist/service.rb

@@ -48,7 +48,8 @@ module Polist
       self.params = params
     end
 
-    def call; end # Should be implemented in subclasses
+    # Should be implemented in subclasses
+    def call; end
 
     def run
       call
@@ -58,7 +59,7 @@ module Polist
     end
 
     def response
-      @response ||= {}
+      @response
     end
 
     def failure?
@@ -83,7 +84,7 @@ module Polist
       params
     end
 
-    def fail!(response = {})
+    def fail!(response = nil)
       raise self.class::Failure.new(response)
     end
 
@@ -91,7 +92,7 @@ module Polist
       fail!(error: message)
     end
 
-    def success!(response = {})
+    def success!(response = nil)
       @response = response
     end
   end

data/lib/polist/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Polist
-  VERSION = "0.3.0"
+  VERSION = "0.4.0"
 end

data/polist.gemspec

@@ -18,13 +18,15 @@ Gem::Specification.new do |spec|
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^spec/}) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "tainbox"
-  spec.add_runtime_dependency "plissken", ">= 0.3"
   spec.add_runtime_dependency "activemodel", ">= 3.0"
+  spec.add_runtime_dependency "plissken", ">= 0.3"
+  spec.add_runtime_dependency "tainbox"
 
-  spec.add_development_dependency "bundler", "~> 1.15"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "coveralls"
   spec.add_development_dependency "pry"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rubocop-config-umbrellio"
   spec.add_development_dependency "simplecov"
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: polist
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Yuri Smirnov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-22 00:00:00.000000000 Z
+date: 2018-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: tainbox
+  name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: plissken
   requirement: !ruby/object:Gem::Requirement
@@ -39,63 +39,91 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.3'
 - !ruby/object:Gem::Dependency
-  name: activemodel
+  name: tainbox
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: rubocop-config-umbrellio
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,8 +165,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- bin/console
-- bin/setup
 - lib/polist.rb
 - lib/polist/service.rb
 - lib/polist/version.rb
@@ -163,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A gem for creating simple service classes.

data/bin/console

@@ -1,15 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require "bundler/setup"
-require "polist"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here