polish_banks 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: decff735a57bec8334fad408c498eadf29409a20b2354a7cb910fdb477a9b13c
-  data.tar.gz: 38d61ccdc1f046abe281860746b8a06427b14fb0dd4cc9c28050a9b71e075bc1
+  metadata.gz: a97cbcce56873cba6b53f891adf2e52f659bdfa8c9e852b204738d03cd7352ad
+  data.tar.gz: 8908a1b4b6b6d8b6f79b1f0aa639747f9b21e71513b9d596b3027a5386ea36ac
 SHA512:
-  metadata.gz: 67a612079cd5a4fac653ce5bea83a974aca9d3dcb4612615fd359087d73d216166c33bd871b546d7f15b21970e569221f3789460d80cbe8a0e214e979f59a5cc
-  data.tar.gz: 0b35d22cf6156cfccdb269eadcdfa0f86d1bef719c1a66192a8d2e16cfdab9987ebd767bc3376f3716c2e61ae333d18701762d1129ff459e24d80d66269ae40e
+  metadata.gz: 456c01e8b6ac5287f47650bff89d2e8637172b44e6ca5989a8dbf6d29f064e24400de276dfb604a11da8b03ce8283b8d4eee5221a057d799b39c03dd55cd0ed9
+  data.tar.gz: bbc4ece64238ce6f33411d64e11b2d1d1b218e24ff0f6165751499c5bc98e76b67b94d43368d582c6da33e61e19b322af846435fb39aec839fb7295715a32f4f

data/.gitignore

@@ -1 +1,4 @@
 lib/plewibnra.txt
+lib/PlainDok.txt
+Gemfile.lock
+*.gem

data/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gemspec

data/README.md

@@ -1,6 +1,6 @@
 # PolishBanks - A Polish bank lookup Ruby gem.
 
-Polish bank name and branch can be read from the IBAN or accont number.
+Polish bank name and branch can be read from the IBAN or account number
 
 `PLkk BBBB BBBB MMMM MMMM MMMM MMMM`
 
@@ -28,13 +28,13 @@ Or install on your own to test it in irb:
 
 You can use either IBAN or just account number - as string or as integer. If you don't provide the whole account number, the gem will try to determine at least the bank name. Non-Polish ibans will raise a `UnsupportedCountry` exception.
 
-    require 'credit_card_bins'
+    require 'polish_banks'
 
     iban = "PL9912406999"
     bank = PolishBank.new(iban)
 
-    bank.name #"Bank Polska Kasa Opieki Spółka Akcyjna"
-    bank.branch #"Oddział w Tychach ul. Wyszyńskiego 27"
+    bank.name # "Bank Polska Kasa Opieki Spółka Akcyjna"
+    bank.branch # "Oddział w Tychach ul. Wyszyńskiego 27"
 
 If bank is not found, the gem will raise a `BankNotFound` exception.
 

data/Rakefile

@@ -0,0 +1,6 @@
+require 'rspec/core/rake_task'
+require 'bundler/gem_tasks'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task default: :spec

data/lib/data/6110.yml

@@ -0,0 +1,4 @@
+---
+name: VIVA PAYMENT SERVICES SPÓŁKA AKCYJNA ODDZIAŁ W POLSCE
+61100006:
+  branch: Viva Payments Poland

data/lib/data/7003.yml

@@ -1,4 +1,4 @@
 ---
-name: Spółdzielcza Kasa Oszczędnościowo-Kredytowa KOZIENICE
+name: Spółdzielcza Kasa Oszczędnościowo-Kredytowa ENERGIA
 70030006:
   branch: Centrala

data/lib/data/8441.yml

@@ -1,4 +1,4 @@
 ---
-name: Bank Spółdzielczy w Siewierzu
+name: Krakowski Bank Spółdzielczy
 84410001:
   branch: Centrala

data/lib/data/8471.yml

@@ -1,4 +1,4 @@
 ---
-name: Bank Spółdzielczy Bytom
+name: Krakowski Bank Spółdzielczy
 84710000:
   branch: Centrala

data/lib/data/9015.yml

@@ -1,4 +1,4 @@
 ---
 name: Bank Spółdzielczy w Starej Białej
 90150001:
-  branch: Centrala
+  branch: Oddział

data/lib/data_generator.rb

@@ -1,24 +1,28 @@
+#!/usr/bin/env ruby
+
 require 'fileutils'
 require 'yaml'
 
 BANK_NAME_COL = 1
 BRANCH_IDENTIFIER_COL = 4
 BRANCH_NAME_COL = 5
-DATA_DIR_NAME = 'data'.freeze
-FILE_NAME = 'plewibnra.txt'.freeze
+DATA_DIR_NAME = 'data'
+FILENAMES = ['plewibnra.txt', 'PlainDok.txt'].freeze
+
+filename = FILENAMES.detect { |file| File.exist?(file) }
 
 FileUtils.mkdir_p(DATA_DIR_NAME) unless File.directory?(DATA_DIR_NAME)
 
-file = File.open(FILE_NAME, 'r', encoding: 'CP852')
+file = File.open(filename, 'r', encoding: 'CP852')
 
 file.each_line do |row|
-  row = row.encode(Encoding.find('UTF-8'), {invalid: :replace, undef: :replace, replace: ''}).split("\t").map(&:strip)
+  row = row.encode(Encoding.find('UTF-8'), invalid: :replace, undef: :replace, replace: '').split("\t").map(&:strip)
 
   branch_identifier = row[BRANCH_IDENTIFIER_COL]
   bank_identifier = branch_identifier.slice(0, 4)
   branch_name = row[BRANCH_NAME_COL]
 
-  file_name = "#{DATA_DIR_NAME}/#{bank_identifier}.yml"
+  data_file = "#{DATA_DIR_NAME}/#{bank_identifier}.yml"
 
   content = {
     branch_identifier.to_i => {
@@ -26,19 +30,19 @@ file.each_line do |row|
     }
   }
 
-  if File.exist?(file_name)
-    yaml_string = File.read(file_name)
+  if File.exist?(data_file)
+    yaml_string = File.read(data_file)
     data = YAML.safe_load(yaml_string)
 
     content = data.merge(content)
   else
-    File.new(file_name, 'w+')
+    File.new(data_file, 'w+')
 
     bank_name = row[BANK_NAME_COL].strip
     content = { 'name' => bank_name }.merge(content)
   end
 
-  File.open(file_name, 'r+') do |f|
+  File.open(data_file, 'r+') do |f|
     f.write(content.to_yaml(line_width: -1))
   end
 end

data/lib/polish_banks.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'yaml'
 require 'errors/bank_not_found'
 require 'errors/unsupported_country'
@@ -33,6 +35,7 @@ class PolishBank
 
   def check_country
     return if integer?(country_code)
+
     raise UnsupportedCountry, "Iban #{iban} is not Polish" if country_code.casecmp('PL') != 0
   end
 

data/polish_banks.gemspec

@@ -1,7 +1,7 @@
 Gem::Specification.new do |s|
   s.name        = 'polish_banks'
-  s.version     = '1.0.2'
-  s.date        = '2019-10-07'
+  s.version     = '1.1.0'
+  s.date        = '2019-10-19'
   s.summary     = 'Polish bank detector'
   s.description = 'Get information about a Polish bank based on IBAN or account number.'
   s.authors     = ['Maciej Czuchnowski']
@@ -9,4 +9,5 @@ Gem::Specification.new do |s|
   s.files       = `git ls-files -z`.split("\x0")
   s.homepage    = 'https://github.com/mczuchnowski/polish_banks'
   s.license     = 'MIT'
+  s.add_development_dependency 'rspec', '~> 3.0'
 end

data/spec/polish_banks_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+require 'polish_banks'
+
+RSpec.describe PolishBank do
+  subject { described_class.new(iban) }
+
+  describe "standard iban check" do
+    let(:iban) { "PL9912406999" }
+
+    it "detects bank name" do
+      expect(subject.name).to be_a String
+      expect(subject.name.length).to be_positive
+    end
+
+    it "detects bank branch" do
+      expect(subject.branch).to be_a String
+      expect(subject.branch.length).to be_positive
+    end
+
+    context "with only partial match" do
+      let(:iban) { "PL9912406666" }
+
+      it "detects bank name" do
+        expect(subject.name).to be_a String
+        expect(subject.name.length).to be_positive
+      end
+
+      it "detects bank branch" do
+        expect(subject.branch).to be_a String
+        expect(subject.branch.length).to be_zero
+      end
+    end
+
+    context "with special characters" do
+      let(:iban) { "99-1240 6999" }
+
+      it "detects bank name" do
+        expect(subject.name).to be_a String
+        expect(subject.name.length).to be_positive
+      end
+
+      it "detects bank branch" do
+        expect(subject.branch).to be_a String
+        expect(subject.branch.length).to be_positive
+      end
+    end
+  end
+
+  describe "account number check" do
+    let(:iban) { "9912406999" }
+
+    it "detects bank name" do
+      expect(subject.name).to be_a String
+      expect(subject.name.length).to be_positive
+    end
+
+    it "detects bank branch" do
+      expect(subject.branch).to be_a String
+      expect(subject.branch.length).to be_positive
+    end
+  end
+
+  describe "error raising" do
+    context "foreign iban" do
+      let(:iban) { "DE9912406999" }
+
+      it "raises UnsupportedCountry error" do
+        expect { subject }.to raise_error(UnsupportedCountry, "Iban #{iban} is not Polish")
+      end
+    end
+
+    context "unknown bank" do
+      let(:iban) { "PL6666666666" }
+
+      it "raises BankNotFound error" do
+        expect { subject }.to raise_error(BankNotFound, "Polish bank not found for #{iban}")
+      end
+    end
+  end
+end

metadata

@@ -1,15 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: polish_banks
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Maciej Czuchnowski
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-10-07 00:00:00.000000000 Z
-dependencies: []
+date: 2019-10-19 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.0'
 description: Get information about a Polish bank based on IBAN or account number.
 email: maciej.czuchnowski@gmail.com
 executables: []
@@ -17,7 +31,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- Gemfile
 - README.md
+- Rakefile
 - lib/data/1010.yml
 - lib/data/1020.yml
 - lib/data/1030.yml
@@ -107,6 +123,7 @@ files:
 - lib/data/6000.yml
 - lib/data/6040.yml
 - lib/data/6070.yml
+- lib/data/6110.yml
 - lib/data/6200.yml
 - lib/data/6300.yml
 - lib/data/7003.yml
@@ -369,7 +386,6 @@ files:
 - lib/data/8597.yml
 - lib/data/8600.yml
 - lib/data/8602.yml
-- lib/data/8606.yml
 - lib/data/8612.yml
 - lib/data/8614.yml
 - lib/data/8619.yml
@@ -733,6 +749,7 @@ files:
 - lib/errors/unsupported_country.rb
 - lib/polish_banks.rb
 - polish_banks.gemspec
+- spec/polish_banks_spec.rb
 homepage: https://github.com/mczuchnowski/polish_banks
 licenses:
 - MIT
@@ -752,8 +769,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Polish bank detector

data/lib/data/8606.yml

@@ -1,4 +0,0 @@
----
-name: Bank Spółdzielczy w Raciechowicach
-86060006:
-  branch: Centrala