policy-assertions 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: f24ccf11ad4ed8b8cfbc67593fdb47ee45acee40
-  data.tar.gz: 1383189eb57f1a60a320658985f8ca7f1853289d
+SHA256:
+  metadata.gz: 2e05d231a95ef387b2eacf9fa1cd51c5a920e3425562ec6d2047d8db91469c98
+  data.tar.gz: 21bd13d4d9146cef4e13de41b7c7a5c12114a916751f414e5c820ae1bb07e13e
 SHA512:
-  metadata.gz: a5fc2eee22de0f4b9f5c0c6cb899035cef25322c09879613c83bde1b0c2e5ae943fe8f51b760223fe289889b628142e4235000fb62cceba3f5393728113d9338
-  data.tar.gz: c3dc79ede4de1fd15a5c0f2979c7c615a21f6c1d047ae29717400624881d61b062737a5489cbdf737196d77876fab87bd9fe0e899e32d0f55338d016823d5245
+  metadata.gz: 8abbbb6535264993c6f11e71535e0fa5d4c96ff40e797b6ecfeb1f20e4ff9eaf94495554a6b897c47c6283d721f3215002903d083f1f3a52848f0f9a4e68cdf8
+  data.tar.gz: cd03f84dc8d8d447f69c3e6c15f44851da05caec8cfa7aca428051d39992398a454c2a58b6c214976c1fa2bf28af4182daf2abb3c1c7f1a701ce7b23157f7b6e

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+## v0.2.0
+* [Add support for testing policies that are not of type "#{record.class}Policy" #14](https://github.com/ProctorU/policy-assertions/pull/14) - Thanks @marceloeloelo!
+
 ## v0.1.0
 * [Adds support for arrays as actions in block tests](https://github.com/ProctorU/policy-assertions/pull/10)
 * [Adds support for `assert_not_permitted`](https://github.com/ProctorU/policy-assertions/pull/12)

data/lib/policy_assertions.rb

@@ -17,7 +17,7 @@ module PolicyAssertions
   class Test < ActiveSupport::TestCase
     def assert_permit(user, record, *permissions)
       get_permissions(permissions.flatten).each do |permission|
-        policy = Pundit.policy!(user, record)
+        policy = find_policy!(user, record)
         assert policy.public_send(permission),
                "Expected #{policy.class.name} to grant #{permission} "\
                "on #{record} for #{user} but it didn't"
@@ -26,7 +26,7 @@ module PolicyAssertions
 
     def refute_permit(user, record, *permissions)
       get_permissions(permissions.flatten).each do |permission|
-        policy = Pundit.policy!(user, record)
+        policy = find_policy!(user, record)
         refute policy.public_send(permission),
                "Expected #{policy.class.name} not to grant #{permission} "\
                "on #{record} for #{user} but it did"
@@ -35,7 +35,7 @@ module PolicyAssertions
     alias assert_not_permitted refute_permit
 
     def assert_strong_parameters(user, record, params_hash, allowed_params)
-      policy = Pundit.policy!(user, record)
+      policy = find_policy!(user, record)
 
       param_key = find_param_key(record)
 
@@ -83,5 +83,10 @@ module PolicyAssertions
         caller[2][/`.*'/][1..-2]
       end
     end
+
+    def find_policy!(user, record)
+      described_policy = self.respond_to?(:described_class) ? described_class : nil
+      described_policy ? described_policy.new(user, record) : Pundit.policy!(user, record)
+    end
   end
 end

data/lib/policy_assertions/version.rb

@@ -1,3 +1,3 @@
 module PolicyAssertions
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/policy-assertions.gemspec

@@ -7,10 +7,10 @@ Gem::Specification.new do |spec|
   spec.name          = "policy-assertions"
   spec.version       = PolicyAssertions::VERSION
   spec.authors       = ['ProctorU']
-  spec.email         = ['engineering@proctoru.com']
+  spec.email         = ['engineering.team@proctoru.com']
   spec.summary       = %q{Minitest assertions for Pundit policies.}
   spec.description   = %q{Minitest assertions for Pundit policies.}
-  spec.homepage      = 'https://github.com/ksimmons/policy-assertions'
+  spec.homepage      = 'https://github.com/proctoru/policy-assertions'
   spec.license       = "MIT"
 
   spec.required_ruby_version = '>= 1.9.3'

data/test/lib/policy_assertions_test.rb

@@ -123,6 +123,21 @@ class AssertionsTest < Minitest::Test
     test_runner.run
     assert test_runner.passed?
   end
+
+  def test_described_class
+    test_runner = custom_policy_class do
+      def described_class
+        CustomPolicy
+      end
+
+      def test_new
+        assert_permit User.new(100), Article.new(100)
+      end
+    end.new :test_new
+
+    test_runner.run
+    assert test_runner.passed?
+  end
 end
 
 class StrongParametersTest < Minitest::Test

data/test/test_helper.rb

@@ -15,6 +15,15 @@ def policy_class(&block)
   klass
 end
 
+def custom_policy_class(&block)
+  klass = Class.new(PolicyAssertions::Test, &block)
+  def klass.name
+    'CustomPolicyTest'
+  end
+
+  klass
+end
+
 class User
   def self.policy_class
     PersonPolicy
@@ -93,6 +102,19 @@ class PersonPolicy
   end
 end
 
+class CustomPolicy
+  attr_reader :user, :record
+
+  def initialize(user, record)
+    @user = user
+    @record = record
+  end
+
+  def new?
+    record.is_a?(Article)
+  end
+end
+
 module Users
   class Session
     attr_accessor :id, :user_id

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: policy-assertions
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - ProctorU
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-01-23 00:00:00.000000000 Z
+date: 2018-10-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -124,7 +124,7 @@ dependencies:
         version: 3.0.0
 description: Minitest assertions for Pundit policies.
 email:
-- engineering@proctoru.com
+- engineering.team@proctoru.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -147,7 +147,7 @@ files:
 - test/lib/policy-assertions/version_test.rb
 - test/lib/policy_assertions_test.rb
 - test/test_helper.rb
-homepage: https://github.com/ksimmons/policy-assertions
+homepage: https://github.com/proctoru/policy-assertions
 licenses:
 - MIT
 metadata: {}
@@ -167,7 +167,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Minitest assertions for Pundit policies.