policial 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6b72a2344b1709d98d7dd121a15a8c8eab456961
-  data.tar.gz: 0bccb0d25295dfabd7d0636eba66c4a6ff4f02d8
+  metadata.gz: 8cc78f631ce46e67c9b73b1b07aeb12ce9e1391a
+  data.tar.gz: 0e24d6c7a9cae9b3b0d1644dcdd937a7b751301c
 SHA512:
-  metadata.gz: 2557808b3c2decb2b4a189901a4a5df6b3bede233d342134059ef02cf976621f6bbc636230a51cb37918ae800868bfb53ff9ce51495a909f5ef7a1e26d4868f1
-  data.tar.gz: 39b7666177beeee05ecee1af8268c78b8c8d75f250672bb4d8ba9d5ccd6efe85f5174dde8595ff0aef5129459f7596a428f8809269cc10c0c3d3ba3f331a6441
+  metadata.gz: 7d40ae450bcc8fa6ca1fa029b3e642eeee559aed3012321044c2e77d17fc9c202f9a1838f7a365d56b57ef5b38a306d5e7dd52b60153d6f64a26bc8403e1f246
+  data.tar.gz: e5944b150dcd32d76dc3f82e86c799b3b6e359c76f8dbd36e3d2cb50c2b9baa9c1004653e8bd8df3f42526f8bf831f3d4756a4cd70d1eabb32e742a4f0cc5686

data/README.md

@@ -7,9 +7,7 @@
 *Policial* is a gem that investigates pull requests and accuses style guide
 violations. It is based on thoughtbot's
 [Hound project](https://github.com/thoughtbot/hound).
-Currently it only investigates ruby code. You can setup your ruby code style
-rules by defining a `.rubocop.yml` file in you repo. Please see
-[RuboCop's README](https://github.com/bbatsov/rubocop).
+It currently supports Ruby, SCSS and CoffeeScript.
 
 ## Installation
 
@@ -29,53 +27,98 @@ Or install it yourself as:
 
 ## Usage
 
-1. You might need to instantiate an Octokit client with your GitHub
-  credentials. For more information on this please check the
+1. First, instantiate a new Detective:
+  ```ruby
+  detective = Policial::Detective.new
+  ```
+
+  You might need to pass an Octokit client with your GitHub credentials.
+  For more information on this please check the
   [Octokit README](https://github.com/octokit/octokit.rb).
 
   ```ruby
-  Policial.octokit = Octokit::Client.new(access_token: 'mygithubtoken666')
+  octokit = Octokit::Client.new(access_token: 'mygithubtoken666')
+  detective = Policial::Detective.new(octokit)
   ```
-  Ignore this step if you want Policial to use the global Octokit configuration.
-
+  If you don't pass an Octokit client Policial will use the global Octokit
+  configuration.
 
-2. Let's investigate! Start with a pull request which Policial will run an
-  investigation against. You can setup a pull request manually:
+2. Let's investigate! Start by briefing your detective about the pull request it
+  will run an investigation against. You can setup a pull request manually:
 
   ```ruby
-  pull_request = Policial::PullRequest.new(
+  detective.brief(
     repo: 'volmer/my_repo',
     number: 3,
     head_sha: 'headsha'
   )
   ```
 
-  Or you can extract a pull request from a
+  Or you can brief it with a
   [GitHub `pull_request` webhook](https://developer.github.com/webhooks):
 
   ```ruby
   event = Policial::PullRequestEvent.new(webhook_payload)
-  pull_request = event.pull_request
+  detective.brief(event)
   ```
 
 3. Now you can run the investigation:
 
   ```ruby
-  investigation = Policial::Investigation.new(pull_request)
-
   # Let's investigate this pull request...
-  investigation.run
+  detective.investigate
 
   # Want to know the violations found?
-  investigation.violations
+  detective.violations
   ```
 
-4. Hurry, post comments about those violations on the pull request!
+4. Want to know the violations found?
   ```ruby
-  investigation.accuse
+  violations = detective.violations
+  # => [#<Policial::Violation:0x007ff0b5abad30 @filename="lib/test.rb", @line_number=1, ...>]
+
+  violations.first.message
+  "Prefer single-quoted strings when you don't need string interpolation or special symbols."
   ```
-  The result are comments like this on each line that contains violations:
-  ![image](https://cloud.githubusercontent.com/assets/301187/5545861/d5c3da76-8afe-11e4-8c15-341b01f3b820.png)
+
+## Ruby
+
+You can setup your Ruby code style rules with a `.rubocop.yml` file in
+your repo. Please see [RuboCop's README](https://github.com/bbatsov/rubocop).
+
+## CoffeeScript
+
+You can setup your CoffeeScript code style rules with a `coffeelint.json`
+file in your repo. For more information on how customize the linter rules please
+visit the [Coffeelint website](https://coffelint.org).
+
+## SCSS
+
+SCSS linting is disabled by default. To enable it, you need to install the
+[SCSS-Lint](https://github.com/brigade/scss-lint) gem:
+
+```
+gem install scss_lint
+```
+
+Or add the following to your `Gemfile` and run `bundle install`:
+
+```ruby
+gem 'scss_lint', require: false
+```
+
+The `require: false` is necessary because `scss-lint` monkey patches `Sass`.
+More info [here](https://github.com/brigade/scss-lint#installation).
+
+Now you can enable SCSS on Policial:
+
+```ruby
+Policial.style_guides << Policial::StyleGuides::Scss
+```
+
+You can setup your SCSS code style rules with a `.scss-lint.yml` file in your
+repo. For more information on how customize the linter rules please
+read [SCSS-Lint's README](https://github.com/brigade/scss-lint#configuration).
 
 ## Contributing
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

data/lib/policial.rb

@@ -1,20 +1,21 @@
+# frozen_string_literal: true
+
 require 'octokit'
 
-require 'policial/accusation_policy'
-require 'policial/commenter'
 require 'policial/commit'
 require 'policial/commit_file'
-require 'policial/octokit_client'
-require 'policial/investigation'
+require 'policial/config_loader'
+require 'policial/detective'
 require 'policial/line'
 require 'policial/patch'
 require 'policial/pull_request'
 require 'policial/pull_request_event'
-require 'policial/repo_config'
 require 'policial/style_checker'
 require 'policial/style_guides/base'
 require 'policial/style_guides/ruby'
-require 'policial/style_guides/unsupported'
+require 'policial/style_guides/scss'
+require 'policial/style_guides/coffeescript'
+require 'policial/style_guides/javascript'
 require 'policial/unchanged_line'
 require 'policial/version'
 require 'policial/violation'
@@ -23,7 +24,23 @@ require 'policial/violation'
 # so you can configure GitHub credentials, enable/disable style guides
 # and more.
 module Policial
-  extend OctokitClient
+  DEFAULT_STYLE_GUIDES = [
+    Policial::StyleGuides::Ruby,
+    Policial::StyleGuides::CoffeeScript,
+    Policial::StyleGuides::JavaScript
+  ].freeze
+
+  OPTIONAL_STYLE_GUIDES = [
+    Policial::StyleGuides::Scss
+  ].freeze
+
+  module_function
+
+  def style_guides
+    @style_guides ||= DEFAULT_STYLE_GUIDES.dup
+  end
 
-  STYLE_GUIDES = [Policial::StyleGuides::Ruby]
+  def style_guides=(style_guides)
+    @style_guides = style_guides
+  end
 end

data/lib/policial/commit.rb

@@ -1,15 +1,18 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: A Commit in a GitHub repo.
   class Commit
     attr_reader :repo, :sha
 
-    def initialize(repo, sha)
+    def initialize(repo, sha, github_client)
       @repo = repo
       @sha  = sha
+      @github_client = github_client
     end
 
     def file_content(filename)
-      contents = Policial.octokit.contents(@repo, path: filename, ref: @sha)
+      contents = @github_client.contents(@repo, path: filename, ref: @sha)
 
       if contents && contents.content
         Base64.decode64(contents.content).force_encoding('UTF-8')

data/lib/policial/commit_file.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: A file in a commit.
   class CommitFile

data/lib/policial/config_loader.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Policial
+  # Public: Load and parse config files from GitHub repo.
+  class ConfigLoader
+    def initialize(commit)
+      @commit = commit
+    end
+
+    def raw(filename)
+      blank?(filename) ? '' : @commit.file_content(filename)
+    end
+
+    def json(filename)
+      JSON.parse(raw(filename))
+    rescue JSON::ParserError
+      {}
+    end
+
+    def yaml(filename)
+      YAML.load(raw(filename)) || {}
+    rescue Psych::SyntaxError
+      {}
+    end
+
+    private
+
+    def blank?(string)
+      string.to_s.strip.empty?
+    end
+  end
+end

data/lib/policial/detective.rb

@@ -0,0 +1,37 @@
+# frozen_string_literal: true
+
+module Policial
+  # Public: Starting with an Octokit client and a pull request,
+  # it checks all changes introduced looking for style guide violations.
+  class Detective
+    attr_accessor :violations
+    attr_reader :github_client, :pull_request
+
+    def initialize(github_client = nil)
+      @github_client = github_client || Octokit
+    end
+
+    def brief(event_or_attributes)
+      pull_request_attributes = extract_attributes(event_or_attributes)
+      return unless pull_request_attributes
+      @pull_request = PullRequest.new(
+        pull_request_attributes.merge(github_client: @github_client)
+      )
+    end
+
+    def investigate(options = {})
+      return unless pull_request
+      @violations ||= StyleChecker.new(pull_request, options).violations
+    end
+
+    private
+
+    def extract_attributes(event_or_attributes)
+      if event_or_attributes.is_a?(PullRequestEvent)
+        event_or_attributes.pull_request_attributes
+      else
+        event_or_attributes
+      end
+    end
+  end
+end

data/lib/policial/line.rb

@@ -1,7 +1,9 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: a changed line in a commit file.
   class Line
-    attr_reader :number, :patch_position
+    attr_reader :content, :number, :patch_position
 
     def initialize(number, content, patch_position)
       @number         = number

data/lib/policial/patch.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: a chunk of changed code in a commit file.
   class Patch

data/lib/policial/pull_request.rb

@@ -1,21 +1,21 @@
+# frozen_string_literal: true
+
 module Policial
-  # Public: A GibHub Pull Request.
+  # Public: A GitHub Pull Request.
   class PullRequest
     attr_reader :repo, :number, :user
+    attr_accessor :github_client
 
-    def initialize(repo:, number:, head_sha:, user: nil)
-      @repo     = repo
-      @number   = number
+    def initialize(repo:, number:, head_sha:, github_client:, user: nil)
+      @repo = repo
+      @number = number
       @head_sha = head_sha
-      @user     = user
-    end
-
-    def comments
-      @comments ||= fetch_comments
+      @user = user
+      @github_client = github_client
     end
 
     def files
-      @files ||= Policial.octokit.pull_request_files(
+      @files ||= @github_client.pull_request_files(
         @repo, @number
       ).map do |file|
         build_commit_file(file)
@@ -23,7 +23,7 @@ module Policial
     end
 
     def head_commit
-      @head_commit ||= Commit.new(@repo, @head_sha)
+      @head_commit ||= Commit.new(@repo, @head_sha, @github_client)
     end
 
     private
@@ -31,32 +31,5 @@ module Policial
     def build_commit_file(file)
       CommitFile.new(file, head_commit)
     end
-
-    def fetch_comments
-      paginate do |page|
-        Policial.octokit.pull_request_comments(
-          @repo,
-          @number,
-          page: page
-        )
-      end
-    end
-
-    private
-
-    def paginate
-      page, results, all_pages_fetched = 1, [], false
-
-      until all_pages_fetched
-        if (page_results = yield(page)).empty?
-          all_pages_fetched = true
-        else
-          results += page_results
-          page += 1
-        end
-      end
-
-      results
-    end
   end
 end

data/lib/policial/pull_request_event.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'json'
 
 module Policial
@@ -9,19 +11,19 @@ module Policial
       @payload = payload
     end
 
-    def pull_request
-      @pull_request ||= PullRequest.new(
+    def pull_request_attributes
+      {
         repo: @payload['repository']['full_name'],
         number: @payload['number'],
         head_sha: @payload['pull_request']['head']['sha'],
         user: @payload['pull_request']['user']['login']
-      )
+      }
     rescue NoMethodError
       nil
     end
 
     def should_investigate?
-      !pull_request.nil? && (
+      !pull_request_attributes.nil? && (
         @payload['action'] == 'opened' || @payload['action'] == 'synchronize'
       )
     end

data/lib/policial/style_checker.rb

@@ -1,10 +1,13 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: Filters files to reviewable subset, builds style guide based on file
   # extension and delegates to style guide for line violations.
   class StyleChecker
-    def initialize(pull_request)
+    def initialize(pull_request, options = {})
       @pull_request = pull_request
       @style_guides = {}
+      @options = options
     end
 
     def violations
@@ -13,36 +16,31 @@ module Policial
 
     private
 
-    attr_reader :pull_request, :style_guides
-
     def violations_in_checked_files
       files_to_check.flat_map do |file|
-        style_guide(file.filename).violations_in_file(file)
+        style_guides.flat_map do |style_guide|
+          if style_guide.investigate?(file.filename)
+            style_guide.violations_in_file(file)
+          else
+            []
+          end
+        end
       end
     end
 
     def files_to_check
-      pull_request.files.reject(&:removed?).select do |file|
-        style_guide(file.filename).enabled?
-      end
-    end
-
-    def style_guide(filename)
-      style_guide_class = style_guide_class(filename)
-      style_guides[style_guide_class] ||= style_guide_class.new(config)
+      @pull_request.files.reject(&:removed?)
     end
 
-    def style_guide_class(filename)
-      case filename
-      when /.+\.rb\z/
-        StyleGuides::Ruby
-      else
-        StyleGuides::Unsupported
+    def style_guides
+      Policial.style_guides.map do |klass|
+        @style_guides[klass] ||= klass.new(
+          config_loader, @options[klass::KEY] || {})
       end
     end
 
-    def config
-      @config ||= RepoConfig.new(pull_request.head_commit)
+    def config_loader
+      @config_loader ||= ConfigLoader.new(@pull_request.head_commit)
     end
   end
 end

data/lib/policial/style_guides/base.rb

@@ -1,17 +1,50 @@
+# frozen_string_literal: true
+
 module Policial
   module StyleGuides
     # Public: Base to contain common style guide logic.
     class Base
-      def initialize(repo_config)
-        @repo_config = repo_config
+      def initialize(config_loader, options = {})
+        @config_loader = config_loader
+        @options = options
+      end
+
+      def violations_in_file(_file)
+        raise NotImplementedError, "must implement ##{__method__}"
+      end
+
+      def exclude_file?(_filename)
+        raise NotImplementedError, "must implement ##{__method__}"
+      end
+
+      def filename_pattern
+        raise NotImplementedError, "must implement ##{__method__}"
       end
 
+      def default_config_file
+        raise NotImplementedError, "must implement ##{__method__}"
+      end
+
+      def config_file
+        if @options[:config_file].to_s.strip.empty?
+          default_config_file
+        else
+          @options[:config_file]
+        end
+      end
+
+      def investigate?(filename)
+        enabled? && matches_pattern?(filename) && !exclude_file?(filename)
+      end
+
+      private
+
       def enabled?
-        @repo_config.enabled_for?(self.class)
+        @options[:enabled] != false
       end
 
-      def violations_in_file(_file)
-        fail NotImplementedError, "must implement ##{__method__}"
+      def matches_pattern?(filename)
+        !(filename =~ filename_pattern).nil?
       end
     end
   end

data/lib/policial/style_guides/coffeescript.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+require 'coffeelint'
+
+module Policial
+  module StyleGuides
+    # Public: Determine CoffeeScript style guide violations per-line.
+    class CoffeeScript < Base
+      KEY = :coffeescript
+
+      def violations_in_file(file)
+        errors = Coffeelint.lint(file.content, config)
+        violations(file, errors)
+      end
+
+      def exclude_file?(_filename)
+        false
+      end
+
+      def filename_pattern
+        /.+\.coffee\z/
+      end
+
+      def default_config_file
+        'coffeelint.json'
+      end
+
+      private
+
+      def config
+        @config ||= @config_loader.json(config_file)
+      end
+
+      def violations(file, errors)
+        errors.map do |error|
+          Violation.new(
+            file, error['lineNumber'], error['message'], error['rule'])
+        end
+      end
+    end
+  end
+end

data/lib/policial/style_guides/javascript.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+require 'eslintrb'
+
+module Policial
+  module StyleGuides
+    # Public: Determine Javascript style guide violations per-line.
+    class JavaScript < Base
+      KEY = :javascript
+
+      def violations_in_file(file)
+        errors = Eslintrb.lint(file.content, config)
+        violations(file, errors)
+      end
+
+      def exclude_file?(_filename)
+        false
+      end
+
+      def filename_pattern
+        /.+\.js\z/
+      end
+
+      def default_config_file
+        '.eslintrc.json'
+      end
+
+      private
+
+      def config
+        @config ||= begin
+          content = @config_loader.json(config_file)
+          content.empty? ? :defaults : content
+        end
+      end
+
+      def violations(file, errors)
+        errors.map do |error|
+          Violation.new(
+            file, error['line'], error['message'], error['ruleId'])
+        end
+      end
+    end
+  end
+end

data/lib/policial/style_guides/ruby.rb

@@ -1,34 +1,54 @@
+# frozen_string_literal: true
+
 require 'rubocop'
 
 module Policial
   module StyleGuides
     # Public: Determine Ruby style guide violations per-line.
     class Ruby < Base
-      class << self
-        attr_writer :config_file
+      KEY = :ruby
+
+      def violations_in_file(file)
+        offenses = team.inspect_file(parsed_source(file))
 
-        def config_file
-          @config_file || RuboCop::ConfigLoader::DOTFILE
+        offenses.reject(&:disabled?).map do |offense|
+          Violation.new(file, offense.line, offense.message, offense.cop_name)
         end
       end
 
-      def violations_in_file(file)
-        if config.file_to_exclude?(file.filename)
-          []
-        else
-          offenses = team.inspect_file(parsed_source(file))
-          build_violations(offenses, file)
-        end
+      def exclude_file?(filename)
+        config.file_to_exclude?(filename)
+      end
+
+      def filename_pattern
+        /.+\.rb\z/
+      end
+
+      def default_config_file
+        RuboCop::ConfigLoader::DOTFILE
       end
 
       private
 
       def team
-        RuboCop::Cop::Team.new(RuboCop::Cop::Cop.all, config, rubocop_options)
+        cop_classes = if config['Rails']['Enabled']
+                        RuboCop::Cop::Cop.all
+                      else
+                        RuboCop::Cop::Cop.non_rails
+                      end
+
+        RuboCop::Cop::Team.new(cop_classes, config)
       end
 
       def parsed_source(file)
-        RuboCop::ProcessedSource.new(file.content, file.filename)
+        absolute_path =
+          File.join(config.base_dir_for_path_parameters, file.filename)
+
+        RuboCop::ProcessedSource.new(
+          file.content,
+          config['AllCops']['TargetRubyVersion'],
+          absolute_path
+        )
       end
 
       def config
@@ -36,31 +56,31 @@ module Policial
       end
 
       def custom_config
-        custom = @repo_config.for(self.class)
+        content = @config_loader.yaml(config_file)
+        filter(content)
 
-        if custom.is_a?(Hash)
-          RuboCop::Config.new(custom, '').tap do |config|
-            config.add_missing_namespaces
-            config.make_excludes_absolute
-          end
-        else
-          RuboCop::Config.new
+        tempfile_from(config_file, content.to_yaml) do |tempfile|
+          RuboCop::ConfigLoader.load_file(tempfile.path)
         end
       end
 
-      def rubocop_options
-        { debug: true } if config['ShowCopNames']
+      def tempfile_from(filename, content)
+        filename = File.basename(filename)
+        Tempfile.create(File.basename(filename), Dir.pwd) do |tempfile|
+          tempfile.write(content)
+          tempfile.rewind
+
+          yield(tempfile)
+        end
       end
 
-      def build_violations(offenses, file)
-        offenses.each_with_object({}) do |offense, violations|
-          if violations[offense.line]
-            violations[offense.line].add_messages([offense.message])
-          else
-            violations[offense.line] =
-              Violation.new(file, offense.line, offense.message)
+      def filter(config_hash)
+        config_hash.delete('require')
+        config_hash.delete('inherit_gem')
+        config_hash['inherit_from'] =
+          Array(config_hash['inherit_from']).select do |value|
+            value =~ /\A#{URI.regexp(%w(http https))}\z/
           end
-        end.values
       end
     end
   end

data/lib/policial/style_guides/scss.rb

@@ -0,0 +1,69 @@
+# frozen_string_literal: true
+
+module Policial
+  module StyleGuides
+    # Public: Determine SCSS style guide violations per-line.
+    class Scss < Base
+      KEY = :scss
+
+      def violations_in_file(file)
+        absolute_path = File.expand_path(file.filename)
+
+        runner = new_runner
+
+        tempfile_from(file.filename, file.content) do |tempfile|
+          runner.run([{ file: tempfile, path: absolute_path }])
+        end
+
+        violations(runner, file)
+      end
+
+      def exclude_file?(filename)
+        config.excluded_file?(File.expand_path(filename))
+      end
+
+      def filename_pattern
+        /.+\.scss\z/
+      end
+
+      def default_config_file
+        require 'scss_lint'
+        SCSSLint::Config::FILE_NAME
+      end
+
+      private
+
+      def config
+        require 'scss_lint'
+        @config ||= begin
+          content = @config_loader.raw(config_file)
+          tempfile_from(config_file, content) do |temp|
+            SCSSLint::Config.load(temp, merge_with_default: true)
+          end
+        end
+      end
+
+      def violations(runner, file)
+        runner.lints.map do |lint|
+          linter_name = lint.linter ? lint.linter.name : 'undefined'
+          Violation.new(
+            file, lint.location.line, lint.description, linter_name)
+        end
+      end
+
+      def new_runner
+        require 'scss_lint'
+        SCSSLint::Runner.new(config)
+      end
+
+      def tempfile_from(filename, content)
+        Tempfile.create(File.basename(filename), Dir.pwd) do |tempfile|
+          tempfile.write(content)
+          tempfile.rewind
+
+          yield(tempfile)
+        end
+      end
+    end
+  end
+end

data/lib/policial/unchanged_line.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Policial
   # Public: An unchanged line in a commit file.
   class UnchangedLine

data/lib/policial/version.rb

@@ -1,4 +1,6 @@
+# frozen_string_literal: true
+
 # Public: The gem version.
 module Policial
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/policial/violation.rb

@@ -1,30 +1,31 @@
+# frozen_string_literal: true
+
 module Policial
-  # Public: Hold file, line, and violation message values. Built by style
-  # guides.
+  # Public: Hold file, line, and message. Built by style guides.
   class Violation
-    attr_reader :line_number, :filename
+    attr_reader :line_number, :message, :linter
 
-    def initialize(file, line_number, message)
-      @filename    = file.filename
-      @line        = file.line_at(line_number)
+    def initialize(file, line_number, message, linter)
+      @file        = file
       @line_number = line_number
-      @messages    = [message]
+      @message     = message
+      @linter      = linter
     end
 
-    def add_messages(messages)
-      @messages += messages
+    def filename
+      @file.filename
     end
 
-    def messages
-      @messages.uniq
+    def line
+      @line ||= @file.line_at(line_number)
     end
 
     def patch_position
-      @line.patch_position
+      line.patch_position
     end
 
     def on_changed_line?
-      @line.changed?
+      line.changed?
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: policial
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Volmer Soares
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-01-05 00:00:00.000000000 Z
+date: 2016-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: octokit
@@ -16,31 +16,59 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '4.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '4.3'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.39'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0.39'
+- !ruby/object:Gem::Dependency
+  name: coffeelint
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.14'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.14'
+- !ruby/object:Gem::Dependency
+  name: eslintrb
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.0'
 description: Review pull requests for style guide violations.
 email:
-- volmerius@gmail.com
+- volmer@radicaos.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -49,21 +77,20 @@ files:
 - README.md
 - Rakefile
 - lib/policial.rb
-- lib/policial/accusation_policy.rb
-- lib/policial/commenter.rb
 - lib/policial/commit.rb
 - lib/policial/commit_file.rb
-- lib/policial/investigation.rb
+- lib/policial/config_loader.rb
+- lib/policial/detective.rb
 - lib/policial/line.rb
-- lib/policial/octokit_client.rb
 - lib/policial/patch.rb
 - lib/policial/pull_request.rb
 - lib/policial/pull_request_event.rb
-- lib/policial/repo_config.rb
 - lib/policial/style_checker.rb
 - lib/policial/style_guides/base.rb
+- lib/policial/style_guides/coffeescript.rb
+- lib/policial/style_guides/javascript.rb
 - lib/policial/style_guides/ruby.rb
-- lib/policial/style_guides/unsupported.rb
+- lib/policial/style_guides/scss.rb
 - lib/policial/unchanged_line.rb
 - lib/policial/version.rb
 - lib/policial/violation.rb
@@ -87,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Review pull requests for style guide violations

data/lib/policial/accusation_policy.rb

@@ -1,34 +0,0 @@
-module Policial
-  # Public: Checks if a given pull request should be investigated or not.
-  class AccusationPolicy
-    def initialize(pull_request)
-      @pull_request = pull_request
-    end
-
-    def allowed_for?(violation)
-      unreported_violation_messages(violation).any?
-    end
-
-    private
-
-    def unreported_violation_messages(violation)
-      violation.messages - existing_violation_messages(violation)
-    end
-
-    def existing_violation_messages(violation)
-      previous_comments_on_line(violation).map(&:body)
-        .flat_map { |body| body.split('<br>') }
-    end
-
-    def previous_comments_on_line(violation)
-      existing_comments.select do |comment|
-        comment.path == violation.filename &&
-          comment.original_position == violation.patch_position
-      end
-    end
-
-    def existing_comments
-      @existing_comments ||= @pull_request.comments
-    end
-  end
-end

data/lib/policial/commenter.rb

@@ -1,25 +0,0 @@
-module Policial
-  # Public: Comment violations on pull request.
-  class Commenter
-    def initialize(pull_request)
-      @pull_request = pull_request
-    end
-
-    def comment_violation(violation)
-      Policial.octokit.create_pull_request_comment(
-        @pull_request.repo,
-        @pull_request.number,
-        comment_body(violation),
-        @pull_request.head_commit.sha,
-        violation.filename,
-        violation.patch_position
-      )
-    end
-
-    private
-
-    def comment_body(violation)
-      violation.messages.join('<br/>')
-    end
-  end
-end

data/lib/policial/investigation.rb

@@ -1,35 +0,0 @@
-module Policial
-  # Public: Starting with unparsed data coming from a pull request event,
-  # it checks all changes introduced looking for style guide violations. It
-  # also accuse all present violations through comments on all relevant lines
-  # in the pull request.
-  class Investigation
-    attr_accessor :violations, :pull_request
-
-    def initialize(pull_request)
-      @pull_request = pull_request
-    end
-
-    def run
-      @violations ||= StyleChecker.new(@pull_request).violations
-    end
-
-    def accuse
-      return if @violations.nil?
-
-      commenter = Commenter.new(@pull_request)
-
-      @violations.each do |violation|
-        if accusation_policy.allowed_for?(violation)
-          commenter.comment_violation(violation)
-        end
-      end
-    end
-
-    private
-
-    def accusation_policy
-      @accusation_policy ||= AccusationPolicy.new(@pull_request)
-    end
-  end
-end

data/lib/policial/octokit_client.rb

@@ -1,10 +0,0 @@
-module Policial
-  # Private: wraps accessors for the inner Octokit client.
-  module OctokitClient
-    attr_writer :octokit
-
-    def octokit
-      @octokit || Octokit
-    end
-  end
-end

data/lib/policial/repo_config.rb

@@ -1,36 +0,0 @@
-module Policial
-  # Public: Load and parse config files from GitHub repo.
-  class RepoConfig
-    def initialize(commit)
-      @commit = commit
-    end
-
-    def enabled_for?(style_guide_class)
-      Policial::STYLE_GUIDES.include?(style_guide_class)
-    end
-
-    def for(style_guide_class)
-      config_file = style_guide_class.config_file
-
-      if config_file
-        load_file(config_file)
-      else
-        {}
-      end
-    end
-
-    private
-
-    def load_file(file)
-      config_file_content = @commit.file_content(file)
-
-      parse_yaml(config_file_content) || {}
-    end
-
-    def parse_yaml(content)
-      YAML.load(content)
-    rescue Psych::SyntaxError
-      {}
-    end
-  end
-end

data/lib/policial/style_guides/unsupported.rb

@@ -1,10 +0,0 @@
-module Policial
-  module StyleGuides
-    # Public: Returns empty set of violations.
-    class Unsupported < Base
-      def violations_in_file(_)
-        []
-      end
-    end
-  end
-end