poleica 0.10.0 → 0.10.1.fix1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d3b239c7ce5ff65ab699ed739529adaf38b8bae
-  data.tar.gz: 72bc48906b05ebe9a97ee6688ca9b3c939907c5a
+  metadata.gz: e1d83d3535fc8767e224ae910c97e2920ebdb1e0
+  data.tar.gz: d1d946ba9b11059b9660fbcf400f130b73677868
 SHA512:
-  metadata.gz: 87c1b7f335b5edee4ba8709b47be61c1947b85417b7ce6d91180e32d080bb4efa81388a96a6e177d58e5ddf5a0a9dcb77329c2fd4f3c3c70cc4e93326b6a2f9a
-  data.tar.gz: c434159811f12b38281c53e655938a52a6300a8ef5dd6d9c11a327391e852fdd80b0099e8593086ff01cea89f7e2abfca6ba02415883dc4e7753c1ec120773fb
+  metadata.gz: 5cf65f99778e581a3254379e8cfbde2f9ec6ca56f3bdfdc95ddf611f87bc949e76379b53e8bf0bb5c43bec69fb2caae6615f09ee1ff0a1168a0480da2f8612b4
+  data.tar.gz: 8e332e264e5795b071800806b053b77bf65bec3d341e76d5b54fbd4f37a5d832dc55fab23d2c741900fb4f52512097e1b4bc405855d2c787ea3441ed738ea6f6

data/.rubocop.yml

@@ -0,0 +1,8 @@
+AllCops:
+  Exclude:
+    - test/**/*
+    - Rakefile
+  Include:
+    - lib/**/*
+Style/MultilineOperationIndentation:
+  EnforcedStyle: indented

data/.travis.yml

@@ -2,15 +2,17 @@ language: ruby
 bundler_args: --without development
 rvm:
   - 1.9.3
-  - 2.0.0
-  - rbx-19mode
+  - 2.1
+  - 2.0
+  - 2.2
+  - rbx-2
   - jruby-19mode
 before_script:
   - sudo apt-get update -qq
   - sudo apt-get install -qq libreoffice
-  - wget http://78.108.103.11/MIRROR/ftp/GraphicsMagick/1.3/GraphicsMagick-1.3.18.tar.gz
-  - tar -xvf GraphicsMagick-1.3.18.tar.gz
-  - cd GraphicsMagick-1.3.18
+  - wget http://78.108.103.11/MIRROR/ftp/GraphicsMagick/1.3/GraphicsMagick-1.3.20.tar.gz
+  - tar -xvf GraphicsMagick-1.3.20.tar.gz
+  - cd GraphicsMagick-1.3.20
   - ./configure
   - make
   - sudo make install
@@ -20,7 +22,10 @@ script:
 matrix:
   fast_finish: true
   allow_failures:
+    - rvm: rbx-2
     - rvm: jruby-19mode
-    - rvm: rbx-19mode
 notifications:
   email: false
+addons:
+  code_climate:
+    repo_token: 6e49c9e59b6593fc1eb510222536706a1ab6fbbed3a50747f597a1d4ed74d511

data/Gemfile

@@ -11,8 +11,8 @@ end
 group :test do
   gem 'rake'
   gem 'minitest'
-  gem 'rubocop',   github:  'bbatsov/rubocop'
-  gem 'coveralls', require: false
+  gem 'rubocop'
+  gem "codeclimate-test-reporter", require: nil
 end
 
 group :development do

data/Gemfile.lock

@@ -1,116 +1,108 @@
-GIT
-  remote: git://github.com/bbatsov/rubocop.git
-  revision: 07c5d73b050e242ce17c4ee4ee5e91fdad554a18
-  specs:
-    rubocop (0.18.1)
-      json (>= 1.7.7, < 2)
-      parser (~> 2.1.7)
-      powerpack (~> 0.0.6)
-      rainbow (>= 1.99.1, < 3.0)
-      ruby-progressbar (~> 1.4)
-
 GIT
   remote: git://github.com/guard/guard-minitest.git
-  revision: b61231b06685ea0b1d480a3da11d015eb59fc7c6
+  revision: 7738c49bfe9c1a6a54181d8f413abd9633de9c2e
   specs:
-    guard-minitest (2.2.0)
-      guard (~> 2.0)
+    guard-minitest (2.4.4)
+      guard-compat (~> 1.2)
       minitest (>= 3.0)
 
 PATH
   remote: .
   specs:
-    poleica (0.9.12)
+    poleica (0.10.0)
       childprocess
 
 GEM
   remote: https://rubygems.org/
   specs:
-    ast (1.1.0)
-    byebug (2.7.0)
-      columnize (~> 0.3)
+    ast (2.0.0)
+    astrolabe (1.3.0)
+      parser (>= 2.2.0.pre.3, < 3.0)
+    byebug (3.5.1)
+      columnize (~> 0.8)
       debugger-linecache (~> 1.2)
-    celluloid (0.15.2)
-      timers (~> 1.1.0)
-    celluloid-io (0.15.0)
-      celluloid (>= 0.15.0)
-      nio4r (>= 0.5.0)
-    childprocess (0.5.1)
+      slop (~> 3.6)
+    celluloid (0.16.0)
+      timers (~> 4.0.0)
+    childprocess (0.5.5)
       ffi (~> 1.0, >= 1.0.11)
+    codeclimate-test-reporter (0.4.7)
+      simplecov (>= 0.7.1, < 1.0.0)
     coderay (1.1.0)
     columnize (0.9.0)
-    coveralls (0.7.0)
-      multi_json (~> 1.3)
-      rest-client
-      simplecov (>= 0.7)
-      term-ansicolor
-      thor
     debugger-linecache (1.2.0)
-    docile (1.1.3)
-    ffi (1.9.3)
-    formatador (0.2.4)
-    guard (2.5.1)
+    docile (1.1.5)
+    ffi (1.9.6)
+    formatador (0.2.5)
+    guard (2.12.4)
       formatador (>= 0.2.4)
-      listen (~> 2.6)
+      listen (~> 2.7)
       lumberjack (~> 1.0)
+      nenv (~> 0.1)
+      notiffany (~> 0.0)
       pry (>= 0.9.12)
+      shellany (~> 0.0)
       thor (>= 0.18.1)
-    guard-rubocop (1.0.2)
+    guard-compat (1.2.1)
+    guard-rubocop (1.2.0)
       guard (~> 2.0)
-      rubocop (~> 0.10)
-    json (1.8.1)
-    listen (2.7.0)
+      rubocop (~> 0.20)
+    hitimes (1.2.2)
+    listen (2.9.0)
       celluloid (>= 0.15.2)
-      celluloid-io (>= 0.15.0)
       rb-fsevent (>= 0.9.3)
       rb-inotify (>= 0.9)
-    lumberjack (1.0.4)
+    lumberjack (1.0.9)
     method_source (0.8.2)
-    mime-types (1.25.1)
-    minitest (5.3.0)
-    multi_json (1.9.2)
-    nio4r (1.0.0)
-    parser (2.1.7)
-      ast (~> 1.1)
-      slop (~> 3.4, >= 3.4.5)
-    powerpack (0.0.9)
-    pry (0.9.12.6)
-      coderay (~> 1.0)
-      method_source (~> 0.8)
+    minitest (5.5.1)
+    multi_json (1.11.0)
+    nenv (0.2.0)
+    notiffany (0.0.6)
+      nenv (~> 0.1)
+      shellany (~> 0.0)
+    parser (2.2.0.3)
+      ast (>= 1.1, < 3.0)
+    powerpack (0.1.0)
+    pry (0.10.1)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
       slop (~> 3.4)
-    pry-byebug (1.3.2)
-      byebug (~> 2.7)
-      pry (~> 0.9.12)
+    pry-byebug (3.0.1)
+      byebug (~> 3.4)
+      pry (~> 0.10)
     rainbow (2.0.0)
-    rake (10.3.0)
+    rake (10.4.2)
     rb-fsevent (0.9.4)
-    rb-inotify (0.9.3)
+    rb-inotify (0.9.5)
       ffi (>= 0.5.0)
-    rest-client (1.6.7)
-      mime-types (>= 1.16)
-    ruby-progressbar (1.4.2)
-    simplecov (0.8.2)
+    rubocop (0.29.1)
+      astrolabe (~> 1.3)
+      parser (>= 2.2.0.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.4)
+    ruby-progressbar (1.7.1)
+    shellany (0.0.1)
+    simplecov (0.9.2)
       docile (~> 1.1.0)
-      multi_json
-      simplecov-html (~> 0.8.0)
-    simplecov-html (0.8.0)
-    slop (3.5.0)
-    term-ansicolor (1.3.0)
-      tins (~> 1.0)
+      multi_json (~> 1.0)
+      simplecov-html (~> 0.9.0)
+    simplecov-html (0.9.0)
+    slop (3.6.0)
     thor (0.19.1)
-    timers (1.1.0)
-    tins (1.0.0)
+    timers (4.0.1)
+      hitimes
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bundler (~> 1.3)
-  coveralls
+  codeclimate-test-reporter
   guard-minitest!
   guard-rubocop
   minitest
   poleica!
   pry-byebug
   rake
-  rubocop!
+  rubocop

data/README.md

@@ -37,14 +37,14 @@ gem install poleica
 
 or in __Gemfile__ :
 
-```
+```ruby
 gem 'poleica'
 ```
 
 
 ## Usage
 
-```
+```ruby
 Poleica.new(file_path).to_png
 Poleica.new(file_path).to_pdf
 Poleica.new(file_path).to_thumbnail
@@ -55,7 +55,7 @@ Poleica.new(file_path).to_png(width: 400, weight: 400)
 
 Example : 
 
-```
+```ruby
 Poleica.configure do |config|
   config.timeout = 2 # time in secs
   config.libre_office[:bin_paths][:linux] = '/usr/local/bin/gm'

data/Rakefile

@@ -7,7 +7,7 @@ Rake::TestTask.new do |t|
   t.verbose    = true
 end
 
-Rubocop::RakeTask.new
+RuboCop::RakeTask.new
 
 task :default => [:test, :rubocop]
 

data/lib/poleica/converters/convertible.rb

@@ -2,9 +2,9 @@
 module Poleica
   # Conversion Logic, given a type it can search for compatible converters
   module Convertible
-    CONVERTERS = Poleica::Converters
-      .constants.map { |c| Poleica::Converters.const_get(c) } -
-        [Poleica::Converters::Utils]
+    CONVERTERS = Poleica::Converters.constants
+      .map { |c| Poleica::Converters.const_get(c) } -
+      [Poleica::Converters::Utils]
 
     def method_missing(method, *args, &block)
       extension, options =
@@ -28,7 +28,7 @@ module Poleica
     def compatible_converters
       @compatible_converters ||=
         compatible_converters_by_type(file_type.class) <<
-         Converters::General
+          Converters::General
     end
 
     def compatible_convert_methods

data/lib/poleica/converters/general.rb

@@ -14,7 +14,7 @@ module Poleica
         @polei = polei
       end
 
-      def to_bin(options = {})
+      def to_bin(_options = {})
         File.binread(polei.path)
       end
 

data/lib/poleica/converters/graphics_magick/convert_options_generator.rb

@@ -26,8 +26,9 @@ module Poleica
 
         def default_options
           {
+            path:   polei.path_with_md5(:png),
             height: DEFAULT_MEASURE,
-            width: DEFAULT_MEASURE,
+            width:  DEFAULT_MEASURE,
             force_resize: false,
             auto_orient: true,
             page: 0
@@ -52,15 +53,11 @@ module Poleica
         end
 
         def output_options
-          @output_path = if options[:path]
-                           if File.directory?(options[:path])
-                             name = File.basename(polei.path_with_md5(:png))
-                             File.join(options[:path], name)
-                           else
-                             options[:path]
-                           end
+          @output_path = if File.directory?(options[:path])
+                           name = File.basename(polei.path_with_md5(:png))
+                           File.join(options[:path], name)
                          else
-                           polei.path_with_md5(:png)
+                           options[:path]
                          end
         end
       end # class OptionsGenerator

data/lib/poleica/converters/graphics_magick/thumbnail_options_generator.rb

@@ -29,6 +29,7 @@ module Poleica
 
         def default_options
           {
+            path:   polei.path_with_md5(:png),
             height: DEFAULT_MEASURE,
             width:  DEFAULT_MEASURE,
             auto_orient: true
@@ -44,7 +45,7 @@ module Poleica
             [
               '-resize',
               "#{width_and_height_options}"
-          ]
+            ]
         end
 
         def width_and_height_options
@@ -91,15 +92,11 @@ module Poleica
         end
 
         def output_options
-          @output_path = if options[:path]
-                           if File.directory?(options[:path])
-                             name = File.basename(polei.path_with_md5(:png))
-                             File.join(options[:path], name)
-                           else
-                             options[:path]
-                           end
+          @output_path = if File.directory?(options[:path])
+                           name = File.basename(polei.path_with_md5(:png))
+                           File.join(options[:path], name)
                          else
-                           polei.path_with_md5(:png)
+                           options[:path]
                          end
         end
       end # class ThumbnailOptionsGenerator

data/lib/poleica/converters/libre_office.rb

@@ -20,38 +20,36 @@ module Poleica
       def to_pdf(options = {})
         opts_gen = OptionsGenerator.new(polei, options, :pdf)
         exec_with_timeout(bin_path, opts_gen.generate)
-        expected_file_path = opts_gen[:path] || polei.path_with_md5(:pdf)
+        expected_file_path = opts_gen.output_path
         File.exist?(expected_file_path) ? expected_file_path : nil
       ensure
         temp_file_path = opts_gen.temp_path
         File.delete(temp_file_path) if File.exist?(temp_file_path)
       end
 
-      private
-
       # Generate options for the soffice command
       class OptionsGenerator
-        attr_reader :options, :format, :polei
+        attr_reader :options, :format, :polei, :output_path
 
         def initialize(polei, options = {}, format = :pdf)
-          defaults = {}
-          @options = defaults.merge(options)
-          @polei   = polei
-          @format  = format
+          @polei       = polei
+          @format      = format
+          @output_path = options[:path] || polei.path_with_md5(format)
+          @options     = default_options.merge(options)
+        end
+
+        def default_options
+          { path: polei.path_with_md5 }
         end
 
         def generate
           [
-            default_options,
+            default_arguments,
             format,
             output_options
           ].flatten
         end
 
-        def [](key)
-          options[key]
-        end
-
         # Generate a temp path, and create the file this is needed in order to
         # have the right filename, LibreOffice just copy the original filename
         # in the choosen directory, it doesn't accept filename params.
@@ -65,15 +63,10 @@ module Poleica
         private
 
         def generate_temp_path
-          if options[:path]
-            if File.directory?(options[:path])
-              basename = File.basename(polei.path_with_md5)
-              return File.join(options[:path], basename)
-            end
-            extension = File.extname(polei.path)
-            return pathable_object.path_for_extension(extension[1..-1])
+          if File.directory?(options[:path])
+            File.join(options[:path], File.basename(polei.path_with_md5))
           else
-            return polei.path_with_md5(polei.file_extension)
+            pathable_object.path_for_extension(File.extname(polei.path))
           end
         end
 
@@ -82,7 +75,7 @@ module Poleica
           pathable_object.extend(Poleica::Pathable)
         end
 
-        def default_options
+        def default_arguments
           %w(
             --nologo
             --headless

data/lib/poleica/converters/utils.rb

@@ -9,15 +9,15 @@ module Poleica
       HOST_OS ||= (defined?('RbConfig') ? RbConfig : Config)::CONFIG['host_os']
 
       def windows?
-        !!HOST_OS.match(/mswin|windows|cygwin/i)
+        !HOST_OS.match(/mswin|windows|cygwin/i).nil?
       end
 
       def osx?
-        !!HOST_OS.match(/darwin/i)
+        !HOST_OS.match(/darwin/i).nil?
       end
 
       def linux?
-        !!HOST_OS.match(/linux/i)
+        !HOST_OS.match(/linux/i).nil?
       end
 
       def host_os
@@ -61,7 +61,7 @@ module Poleica
         raise Poleica::TimeoutError, e.message
       end
 
-      def map_std(process, &block)
+      def map_std(process, &_block)
         stdout, stdout_w, stderr, stderr_w = init_process_std(process)
         yield
         stderr_w.close.nil? && fail_if_error(process, stderr)
@@ -82,10 +82,9 @@ module Poleica
       end
 
       def fail_if_error(process, stderr)
-        unless process.exit_code == 0
-          message = "Code: #{process.exit_code} #{stderr.read}"
-          fail Poleica::ProcessError, message
-        end
+        return if process.exit_code == 0
+        message = "Code: #{process.exit_code} #{stderr.read}"
+        fail Poleica::ProcessError, message
       end
     end # module Utils
   end # module Converters

data/lib/poleica/types/document.rb

@@ -45,7 +45,7 @@ module Poleica
         rft
       )
 
-      def initialize(file_path)
+      def initialize(_file_path)
       end
     end # class Document
   end # module Types

data/lib/poleica/types/general.rb

@@ -7,7 +7,7 @@ module Poleica
       COMPATIBLE_MIMETYPES  = []
       COMPATIBLE_EXTENSIONS = []
 
-      def initialize(file_path)
+      def initialize(_file_path)
       end
     end # class General
   end # module Types

data/lib/poleica/types/image.rb

@@ -29,7 +29,7 @@ module Poleica
         png
       )
 
-      def initialize(file_path)
+      def initialize(_file_path)
       end
     end # class Image
   end # module Types

data/lib/poleica/types/pdf.rb

@@ -11,7 +11,7 @@ module Poleica
         pdf
       )
 
-      def initialize(file_path)
+      def initialize(_file_path)
       end
     end # class PDF
   end # module Types

data/lib/poleica/version.rb

@@ -1,5 +1,5 @@
 # -*- encoding: utf-8 -*-
 # Poleica namespace
 module Poleica
-  VERSION = '0.10.0'
+  VERSION = '0.10.1.fix1'
 end # module Poleica

data/test/test_helper.rb

@@ -1,13 +1,7 @@
 # -*- encoding: utf-8 -*-
 if ENV['COVERAGE'] || ENV['TRAVIS']
-  require 'coveralls'
-  require 'simplecov'
-
-  SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
-    SimpleCov::Formatter::HTMLFormatter,
-    Coveralls::SimpleCov::Formatter
-  ]
-  Coveralls.wear!
+  require 'codeclimate-test-reporter'
+  CodeClimate::TestReporter.start
 end
 
 Bundler.require(:default, :test)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: poleica
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.10.1.fix1
 platform: ruby
 authors:
 - Antoine Lyset
@@ -46,6 +46,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
@@ -110,9 +111,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - ">"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.3.1
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.2.2