poise 2.6.1 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e47e162a7a11083aa3e77caaae22aaf1c4e99016
-  data.tar.gz: 134c96de6e304855267955a405f8c25715b68a54
+  metadata.gz: 5c259866db8dc6ff155c572e3a1d5a237dd23e71
+  data.tar.gz: 64515ad046ac31f3c454ced2d852cafe27b029c7
 SHA512:
-  metadata.gz: 2d8c33eba4b57fe71ad2c9a1e00f8b30ec0e619ef76520efc4b21c4e0df56daad869ca6458b801f9f9cdfed313e7639380252714c3a907ff381194c03fadc364
-  data.tar.gz: f15d7623d0efcf762f728339f7d8a9403ba1a238151c7c5cdd67d55600d8610b3ad49e7ff3eebf213c684d90dc907423b424664ce937b980fd73b388b8771f58
+  metadata.gz: 89c9554bce8f2712bc0830fe8d6f1a69b7d1fd2de80e6c6d10ab51ff5cbb71234e2c50ba871657a6325a7e067efc7813d32bb4722d90b691a3f6413c0f7d3c79
+  data.tar.gz: 9c8b7865f4f36cccdb1dfc2e7db08ad99488c32e9a6eebdde4f3d7c5bb5a795652a3301ea89ac3249a0fc0edaf6ec92a05e6e4de0a14db6b2edb21cbeeeb84eb

data/.kitchen.yml

@@ -1,3 +1,6 @@
 ---
 #<% require 'poise_boiler' %>
-<%= PoiseBoiler.kitchen(platforms: 'ubuntu-14.04') %>
+<%= PoiseBoiler.kitchen(platforms: ENV['CI'] ? 'ubuntu-14.04' : %w{ubuntu-14.04 windows}) %>
+
+verifier:
+  name: inspec

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## v2.7.0
+
+* More compatibility improvements for Chef 12.9.
+* New helper: `Poise::Helpers::Win32User` to automatically convert `'root'`
+  defaults for user and group properties to more platform-appropriate values.
+* Enhanced `poise_shell_out` to better cope with Windows command parsing. Use
+  Bash-style commands and it will automatically convert.
+* Overall compatibility fixes for Windows.
+
 ## v2.6.1
 
 * Compatibility with Chef master to fix issues with `defined_in!` not ignoring

data/Gemfile

@@ -30,3 +30,6 @@ end
 dev_gem 'halite'
 dev_gem 'poise-boiler'
 dev_gem 'poise-profiler'
+
+# Pending https://github.com/customink/fauxhai/commit/d89f1e2de609478046e7a387f2b8d97729a68983
+gem 'fauxhai', github: 'customink/fauxhai'

data/lib/poise/helpers.rb

@@ -31,5 +31,6 @@ module Poise
     autoload :ResourceSubclass, 'poise/helpers/resource_subclass'
     autoload :Subresources, 'poise/helpers/subresources'
     autoload :TemplateContent, 'poise/helpers/template_content'
+    autoload :Win32User, 'poise/helpers/win32_user'
   end
 end

data/lib/poise/helpers/defined_in.rb

@@ -38,11 +38,18 @@ module Poise
     module DefinedIn
       # Path to the root of Poise's code.
       # @see #poise_defined!
+      # @api private
       POISE_LIB_ROOT = ::File.expand_path('../..', __FILE__)
 
       # Path to the root of Chef's code.
       # @see #poise_defined!
-      CHEF_LIB_ROOT = ::Gem::Specification.find_by_name('chef').gem_dir
+      # @api private
+      CHEF_LIB_ROOT = ::File.join(::Gem::Specification.find_by_name('chef').gem_dir, 'lib')
+
+      # A regex used to parse Ruby's `caller` string syntax.
+      # @see #poise_defined!
+      # @api private
+      CALLER_REGEXP = /^(.+):\d+:in `.+'/
 
       # Wrapper for {.poise_defined_in_cookbook} to pass the run context for you.
       #
@@ -88,11 +95,15 @@ module Poise
           # Only try to set this once.
           return if @poise_defined_in
           # Parse out just the filenames.
-          caller_array = caller_array.map {|line| line.split(/:/, 2).first }
+          caller_paths = caller_array.map {|line| line[CALLER_REGEXP, 1] }
           # Find the first non-poise, non-chef line. This assumes Halite
           # transformation which I'm not thrilled about.
-          caller_path = caller_array.find do |line|
-            !line.start_with?(POISE_LIB_ROOT) && !line.start_with?(CHEF_LIB_ROOT)
+          caller_path = caller_paths.find do |line|
+            line && !line.start_with?(POISE_LIB_ROOT) && !line.start_with?(CHEF_LIB_ROOT)
+          end
+          raise Poise::Error.new("Unable to find a caller path for: #{caller_array.inspect}") unless caller_path
+          if ::File::ALT_SEPARATOR
+            caller_path.gsub!(::File::ALT_SEPARATOR, ::File::SEPARATOR)
           end
           Chef::Log.debug("[#{self.name}] Recording poise_defined_in as #{caller_path}")
           @poise_defined_in = caller_path

data/lib/poise/helpers/include_recipe.rb

@@ -30,7 +30,7 @@ module Poise
       def include_recipe(*recipes)
         loaded_recipes = []
         subcontext = subcontext_block do
-          recipes.each do |recipe|
+          recipes.flatten.each do |recipe|
             case recipe
             when String
               # Process normally

data/lib/poise/helpers/win32_user.rb

@@ -0,0 +1,64 @@
+#
+# Copyright 2013-2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'poise/utils/win32'
+
+
+module Poise
+  module Helpers
+    # A resource mixin to intercept properties named `user`, `group`, or `owner`,
+    # if their default value is `'root'` and make it work on Windows (and
+    # FreeBSD, AIX).
+    #
+    # @since 2.7.0
+    # @example
+    #   class MyResource < Chef::Resource
+    #     include Poise::Helpers::Win32User
+    #     attribute(:user, default: 'root')
+    #     attribute(:group, default: 'root')
+    #   end
+    # @example Avoiding automatic translation
+    #   class MyResource < Chef::Resource
+    #     include Poise::Helpers::Win32User
+    #     attribute(:user, default: lazy { 'root' })
+    #     attribute(:group, default: lazy { 'root' })
+    #   end
+    module Win32User
+      # User-ish property names.
+      # @api private
+      USER_PROPERTIES = ['user', :user, 'owner', :owner]
+
+      # Group-ish property names.
+      # @api private
+      GROUP_PROPERTIES = ['group', :group]
+
+      # Intercept property access to swap out the default value.
+      # @api private
+      def set_or_return(symbol, arg, options={})
+        if options && options[:default] == 'root'
+          if USER_PROPERTIES.include?(symbol) && node.platform_family?('windows')
+            options = options.dup
+            options[:default] = Poise::Utils::Win32.admin_user
+          elsif GROUP_PROPERTIES.include?(symbol)
+            options = options.dup
+            options[:default] = node['root_group']
+          end
+        end
+        super(symbol, arg, options)
+      end
+    end
+  end
+end

data/lib/poise/provider.rb

@@ -33,8 +33,10 @@ module Poise
   #   end
   module Provider
     include Poise::Helpers::DefinedIn
-    include Poise::Helpers::IncludeRecipe
     include Poise::Helpers::LWRPPolyfill
+    # IncludeRecipe must come after LWRPPolyfill because that pulls in the
+    # recipe DSL which has its own #include_recipe.
+    include Poise::Helpers::IncludeRecipe
     include Poise::Helpers::NotifyingBlock
     include Poise::Utils::ShellOut
 

data/lib/poise/resource.rb

@@ -42,6 +42,7 @@ module Poise
     include Poise::Helpers::ResourceName
     include Poise::Helpers::ResourceSubclass
     include Poise::Helpers::TemplateContent
+    include Poise::Helpers::Win32User # Must be after LazyDefault.
     include Poise::Utils::ShellOut
 
     # @!classmethods

data/lib/poise/subcontext/runner.rb

@@ -36,15 +36,20 @@ module Poise
         # ever fire because the superclass re-raises if there is an error.
         return super if error
         delayed_actions.each do |notification|
-          notifications = run_context.parent_run_context.delayed_notifications(@resource)
-          if notifications.any? { |existing_notification| existing_notification.duplicates?(notification) }
-              Chef::Log.info( "#{@resource} not queuing delayed action #{notification.action} on #{notification.resource}"\
-                              " (delayed), as it's already been queued")
+          if @resource.run_context.respond_to?(:add_delayed_action)
+            @resource.run_context.add_delayed_action(notification)
           else
-            notifications << notification
+            notifications = run_context.parent_run_context.delayed_notifications(@resource)
+            if notifications.any? { |existing_notification| existing_notification.duplicates?(notification) }
+              Chef::Log.info( "#{@resource} not queuing delayed action #{notification.action} on #{notification.resource}"\
+                             " (delayed), as it's already been queued")
+            else
+              notifications << notification
+            end
           end
         end
       end
+
     end
   end
 end

data/lib/poise/utils.rb

@@ -21,6 +21,7 @@ module Poise
   module Utils
     autoload :ResourceProviderMixin, 'poise/utils/resource_provider_mixin'
     autoload :ShellOut, 'poise/utils/shell_out'
+    autoload :Win32, 'poise/utils/win32'
 
     extend self
 
@@ -51,6 +52,9 @@ module Poise
         else
           Chef::CookbookVersion::COOKBOOK_SEGMENTS.each do |seg|
             ver.segment_filenames(seg).each do |file|
+              if ::File::ALT_SEPARATOR
+                file = file.gsub(::File::ALT_SEPARATOR, ::File::SEPARATOR)
+              end
               # Put this behind an environment variable because it is verbose
               # even for normal debugging-level output.
               Poise.debug("[Poise] Checking #{seg} in #{name}: #{file.inspect}")

data/lib/poise/utils/shell_out.rb

@@ -69,6 +69,11 @@ module Poise
         end
         # Set the default group on Unix.
         options[:group] ||= ent.gid if ent
+        # Mixlib-ShellOut doesn't support array commands on Windows and has
+        # super wonky escaping for cmd.exe.
+        if respond_to?(:node) && node.platform_family?('windows')
+          command_args = [Poise::Utils::Win32.reparse_command(*command_args)]
+        end
         # Call Chef's shell_out wrapper.
         shell_out(*command_args, **options)
       end

data/lib/poise/utils/win32.rb

@@ -0,0 +1,121 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'shellwords'
+
+
+module Poise
+  module Utils
+    # Utilities for working with Windows.
+    #
+    # @since 2.7.0
+    module Win32
+      extend self
+
+      # Code borrowed from https://github.com/chef-cookbooks/chef-client/blob/master/libraries/helpers.rb
+      # Used under the terms of the Apache v2 license.
+      # Copyright 2012-2016, John Dewey
+
+      # Run a WMI query and extracts a property. This assumes Chef has already
+      # loaded the win32 libraries.
+      #
+      # @api private
+      # @param wmi_property [Symbol] Property to extract.
+      # @param wmi_query [String] Query to run.
+      # @return [String]
+      def wmi_property_from_query(wmi_property, wmi_query)
+        @wmi = ::WIN32OLE.connect('winmgmts://')
+        result = @wmi.ExecQuery(wmi_query)
+        return nil unless result.each.count > 0
+        result.each.next.send(wmi_property)
+      end
+
+      # Find the name of the Administrator user, give or take localization.
+      #
+      # @return [String]
+      def admin_user
+        wmi_property_from_query(:name, "select * from Win32_UserAccount where sid like 'S-1-5-21-%-500' and LocalAccount=True")
+      end
+
+      # Escaping that is compatible with CommandLineToArgvW. Based on
+      # https://blogs.msdn.microsoft.com/twistylittlepassagesallalike/2011/04/23/everyone-quotes-command-line-arguments-the-wrong-way/
+      #
+      # @api private
+      # @param string [String] String to escape.
+      # @return [String]
+      def argv_quote(string, force_quote: false)
+        if !force_quote && !string.empty? && string !~ /[ \t\n\v"]/
+          # Nothing fancy, no escaping needed.
+          string
+        else
+          command_line = '"'
+          i = 0
+          while true
+            number_backslashes = 0
+
+            while i != string.size && string[i] == '\\'
+              i += 1
+              number_backslashes += 1
+            end
+
+            if i == string.size
+              # Escape all backslashes, but let the terminating
+              # double quotation mark we add below be interpreted
+              # as a metacharacter.
+              command_line << '\\' * (number_backslashes * 2)
+              break
+            elsif string[i] == '"'
+              # Escape all backslashes and the following
+              # double quotation mark.
+              command_line << '\\' * ((number_backslashes * 2) + 1)
+              command_line << '"'
+            else
+              # Backslashes aren't special here.
+              command_line << '\\' * number_backslashes
+              command_line << string[i]
+            end
+            i += 1
+          end
+          command_line << '"'
+          command_line
+        end
+      end
+
+      # Take a string or array command in the format used by shell_out et al and
+      # create something we can use on Windows.
+      #
+      # @
+      def reparse_command(*args)
+        array_mode = !(args.length == 1 && args.first.is_a?(String))
+        # At some point when mixlib-shellout groks array commands on Windows,
+        # we should support that here.
+        parsed_args = array_mode ? args.flatten : Shellwords.split(args.first)
+        cmd = parsed_args.map {|s| argv_quote(s) }.join(' ')
+        if array_mode
+          # This fails on non-Windows because of win32/process.
+          require 'mixlib/shellout/windows'
+          if Mixlib::ShellOut::Windows::Utils.should_run_under_cmd?(cmd)
+            # If we are in array mode, try to make cmd.exe keep its grubby paws
+            # off our metacharacters.
+            cmd = cmd.each_char.map {|c| '^'+c }.join('')
+          end
+        end
+        cmd
+      end
+
+    end
+  end
+end

data/lib/poise/version.rb

@@ -16,5 +16,5 @@
 
 
 module Poise
-  VERSION = '2.6.1'
+  VERSION = '2.7.0'
 end

data/poise.gemspec

@@ -34,5 +34,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = %w{lib}
 
   spec.add_dependency 'halite', '~> 1.0'
-  spec.add_development_dependency 'poise-boiler', '~> 1.0'
+
+  spec.add_development_dependency 'kitchen-inspec', '~> 0.12'
+  spec.add_development_dependency 'poise-boiler', '~> 1.8'
 end

data/test/cookbook/libraries/app.rb

@@ -20,7 +20,8 @@ require 'poise'
 class Chef
   class Resource::App < Resource
     include Poise(container: true)
-    default_action(:install)
+    provides(:app)
+    actions(:install)
 
     attribute(:path, kind_of: String, name_attribute: true)
     attribute(:user, kind_of: String, default: 'root')

data/test/cookbook/libraries/app_config.rb

@@ -19,7 +19,8 @@ require_relative 'app'
 class Chef
   class Resource::AppConfig < Resource
     include Poise(App)
-    default_action(:create)
+    provides(:app_config)
+    actions(:create)
 
     attribute('', template: true, required: true)
     attribute(:config_name, kind_of: String, default: lazy { name.split('::').last })

data/test/cookbook/recipes/default.rb

@@ -14,7 +14,7 @@
 # limitations under the License.
 #
 
-app '/srv/app' do
+app '/app' do
   app_config 'defaults' do
     content 'some defaults'
   end

data/test/integration/default/{serverspec/default_spec.rb → default_spec.rb}

@@ -14,22 +14,23 @@
 # limitations under the License.
 #
 
-require 'serverspec'
-set :backend, :exec
+is_windows = os.windows?
 
-describe file('/srv/app') do
+describe file('/app') do
   it { is_expected.to be_a_directory }
-  it { is_expected.to be_owned_by 'root' }
+  it { is_expected.to be_owned_by 'root' } unless is_windows
 end
 
-describe file('/srv/app/defaults.conf') do
+describe file('/app/defaults.conf') do
   it { is_expected.to be_a_file }
-  it { is_expected.to be_owned_by 'root' }
-  its(:content) { is_expected.to eq 'some defaults' }
+  it { is_expected.to be_owned_by 'root' } unless is_windows
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^some defaults\s*$/ }
 end
 
-describe file('/srv/app/user.conf') do
+describe file('/app/user.conf') do
   it { is_expected.to be_a_file }
-  it { is_expected.to be_owned_by 'root' }
-  its(:content) { is_expected.to eq 'user config' }
+  it { is_expected.to be_owned_by 'root' } unless is_windows
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^user config\s*$/ }
 end

data/test/integration/default/{serverspec/inversion_spec.rb → inversion_spec.rb}

@@ -14,30 +14,31 @@
 # limitations under the License.
 #
 
-require 'serverspec'
-set :backend, :exec
-
 describe file('/inversion/a') do
   it { is_expected.to be_a_file }
 end
 
 describe file('/inversion/b') do
   it { is_expected.to be_a_file }
-  its(:content) { is_expected.to eq 'one' }
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^one\s*$/ }
 end
 
 describe file('/inversion/c') do
   it { is_expected.to be_a_file }
-  its(:content) { is_expected.to eq 'two' }
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^two\s*$/ }
 end
 
 describe file('/inversion/d') do
   it { is_expected.to be_a_file }
-  its(:content) { is_expected.to eq 'd-three' }
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^d-three\s*$/ }
 end
 
 describe file('/inversion/e') do
   it { is_expected.to be_a_file }
-  its(:content) { is_expected.to eq 'e-three' }
+  # Pending https://github.com/chef/train/issues/81.
+  its(:content) { is_expected.to match /^e-three\s*$/ }
 end
 

data/test/spec/helpers/include_recipe_spec.rb

@@ -18,17 +18,85 @@ require 'spec_helper'
 
 describe Poise::Helpers::IncludeRecipe do
   resource(:poise_test)
-  provider(:poise_test) do
-    include described_class
-
-    def action_run
-      expect_any_instance_of(Chef::RunContext).to receive(:include_recipe).with('other').and_return(['other::default'])
-      include_recipe 'other'
-    end
-  end
   recipe do
     poise_test 'test'
   end
 
-  it { run_chef }
+  context 'with a string' do
+    provider(:poise_test) do
+      include described_class
+
+      def action_run
+        include_recipe 'other'
+      end
+    end
+
+    it do
+      expect_any_instance_of(Chef::RunContext).to receive(:include_recipe).with('other').and_return(['other::default'])
+      run_chef
+    end
+  end # /context with a string
+
+  context 'with a proc' do
+    provider(:poise_test) do
+      include described_class
+
+      def action_run
+        include_recipe proc { node.run_state['proc1'] = true }
+      end
+    end
+
+    it do
+      run_chef
+      expect(chef_run.node.run_state['proc1']).to be true
+    end
+  end # /context with a proc
+
+  context 'with an multiple arguments' do
+    provider(:poise_test) do
+      include described_class
+
+      def action_run
+        include_recipe('other', proc { node.run_state['proc2'] = true })
+      end
+    end
+
+    it do
+      expect_any_instance_of(Chef::RunContext).to receive(:include_recipe).with('other').and_return(['other::default'])
+      run_chef
+      expect(chef_run.node.run_state['proc2']).to be true
+    end
+  end # /context with an multiple arguments
+
+  context 'with an array' do
+    provider(:poise_test) do
+      include described_class
+
+      def action_run
+        include_recipe ['other', proc { node.run_state['proc3'] = true }]
+      end
+    end
+
+    it do
+      expect_any_instance_of(Chef::RunContext).to receive(:include_recipe).with('other').and_return(['other::default'])
+      run_chef
+      expect(chef_run.node.run_state['proc3']).to be true
+    end
+  end # /context with an array
+
+  context 'via include Poise' do
+    provider(:poise_test) do
+      include Poise
+
+      def action_run
+        include_recipe ['other', proc { node.run_state['proc4'] = true }]
+      end
+    end
+
+    it do
+      expect_any_instance_of(Chef::RunContext).to receive(:include_recipe).with('other').and_return(['other::default'])
+      run_chef
+      expect(chef_run.node.run_state['proc4']).to be true
+    end
+  end # /context via include Poise
 end

data/test/spec/helpers/win32_user_spec.rb

@@ -0,0 +1,177 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+
+describe Poise::Helpers::Win32User do
+  let(:chefspec_options) { {platform: 'ubuntu', version: '14.04'} }
+  provider(:poise_test)
+  before do
+    allow(Poise::Utils::Win32).to receive(:admin_user).and_return('Administrator')
+  end
+
+  context 'user property' do
+    resource(:poise_test) do
+      include Poise::Helpers::LWRPPolyfill
+      include described_class
+      attribute(:user, default: 'root')
+    end
+
+    context 'with a default' do
+      recipe do
+        poise_test 'test'
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(user: 'root') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        it { is_expected.to run_poise_test('test').with(user: 'Administrator') }
+      end # /context on Windows
+    end # /context with a default
+
+    context 'with a value' do
+      recipe do
+        poise_test 'test' do
+          user 'other'
+        end
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(user: 'other') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        it { is_expected.to run_poise_test('test').with(user: 'other') }
+      end # /context on Windows
+    end # /context with a value
+  end # /context user property
+
+  context 'owner property' do
+    resource(:poise_test) do
+      include Poise::Helpers::LWRPPolyfill
+      include described_class
+      attribute(:owner, default: 'root')
+    end
+
+    context 'with a default' do
+      recipe do
+        poise_test 'test'
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(owner: 'root') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        it { is_expected.to run_poise_test('test').with(owner: 'Administrator') }
+      end # /context on Windows
+    end # /context with a default
+
+    context 'with a value' do
+      recipe do
+        poise_test 'test' do
+          owner 'other'
+        end
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(owner: 'other') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        it { is_expected.to run_poise_test('test').with(owner: 'other') }
+      end # /context on Windows
+    end # /context with a value
+  end # /context owner property
+
+  context 'group property' do
+    resource(:poise_test) do
+      include Poise::Helpers::LWRPPolyfill
+      include described_class
+      attribute(:group, default: 'root')
+    end
+
+    context 'with a default' do
+      recipe do
+        poise_test 'test'
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(group: 'root') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        # This test is written to be silly because Fauxhai doesn't have
+        # root_group data for Windows.
+        it { is_expected.to run_poise_test('test').with(group: chef_run.node['root_group']) }
+      end # /context on Windows
+
+      context 'on AIX' do
+        let(:chefspec_options) { {platform: 'aix', version: '6.1'} }
+        it { is_expected.to run_poise_test('test').with(group: 'system') }
+      end # /context on AIX
+    end # /context with a default
+
+    context 'with a value' do
+      recipe do
+        poise_test 'test' do
+          group 'other'
+        end
+      end
+
+      context 'on Linux' do
+        it { is_expected.to run_poise_test('test').with(group: 'other') }
+      end # /context on Linux
+
+      context 'on Windows' do
+        let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+        it { is_expected.to run_poise_test('test').with(group: 'other') }
+      end # /context on Windows
+    end # /context with a value
+  end # /context group property
+
+  describe 'interaction with lazy defaults' do
+    let(:chefspec_options) { {platform: 'windows', version: '2012R2'} }
+    recipe do
+      poise_test 'test'
+    end
+
+    context 'with a non-lazy default' do
+      resource(:poise_test) do
+        include Poise::Resource
+        attribute(:user, default: 'root')
+      end
+
+      it { is_expected.to run_poise_test('test').with(user: 'Administrator') }
+    end # /context with a non-lazy default
+
+    context 'with a lazy default' do
+      resource(:poise_test) do
+        include Poise::Resource
+        attribute(:user, default: lazy { 'root' })
+      end
+
+      it { is_expected.to run_poise_test('test').with(user: 'root') }
+    end # /context with a lazy default
+  end # /describe interaction with lazy defaults
+end

data/test/spec/spec_helper.rb

@@ -15,4 +15,10 @@
 #
 
 require 'poise_boiler/spec_helper'
+
+# If we aren't on Windows, inject our fake win32/process module.
+unless RbConfig::CONFIG['host_os'] =~ /mswin|mingw|cygwin/
+  $LOAD_PATH.insert(0, File.expand_path('../utils/win32_helper', __FILE__))
+end
+
 require 'poise'

data/test/spec/utils/win32_helper/mixlib/shellout/windows/core_ext.rb

@@ -0,0 +1,19 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# A fake module to use for mixlib/shellout/windows/core_ext on non-windows systems so the code can
+# work for testing.

data/test/spec/utils/win32_helper/win32/process.rb

@@ -0,0 +1,30 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# A fake module to use for win32/process on non-windows systems so the code can
+# work for testing.
+#
+# @api private
+module Process
+  module Functions
+    def self.method_missing(*args)
+    end
+  end
+
+  module Constants
+  end
+end

data/test/spec/utils/win32_helper/windows/handle.rb

@@ -0,0 +1,25 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# A fake module to use for windows/handle on non-windows systems so the code can
+# work for testing.
+#
+# @api private
+module Windows
+  module Handle
+  end
+end

data/test/spec/utils/win32_helper/windows/process.rb

@@ -0,0 +1,25 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# A fake module to use for windows/process on non-windows systems so the code can
+# work for testing.
+#
+# @api private
+module Windows
+  module Process
+  end
+end

data/test/spec/utils/win32_helper/windows/synchronize.rb

@@ -0,0 +1,25 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+
+# A fake module to use for windows/synchronize on non-windows systems so the code can
+# work for testing.
+#
+# @api private
+module Windows
+  module Synchronize
+  end
+end

data/test/spec/utils/win32_spec.rb

@@ -0,0 +1,86 @@
+#
+# Copyright 2016, Noah Kantrowitz
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+require 'spec_helper'
+require 'shellwords'
+
+describe Poise::Utils::Win32 do
+  describe '#argv_quote' do
+    let(:input) { }
+    let(:force_quote) { false }
+    subject { described_class.argv_quote(input, force_quote: force_quote) }
+
+    context 'with an empty string' do
+      let(:input) { '' }
+      it { is_expected.to eq '""' }
+    end # /context with an empty string
+
+    context 'with one word' do
+      let(:input) { 'foo' }
+      it { is_expected.to eq 'foo' }
+    end # /context with one word
+
+    context 'with two words' do
+      let(:input) { 'foo bar' }
+      it { is_expected.to eq '"foo bar"' }
+    end # /context with two words
+
+    context 'with a quote' do
+      let(:input) { 'foo"bar' }
+      it { is_expected.to eq '"foo\\"bar"' }
+    end # /context with a quote
+
+    context 'with an escaped quote' do
+      let(:input) { '"foo \\"bar\\""' }
+      it { is_expected.to eq '"\\"foo \\\\\\"bar\\\\\\"\\""' }
+    end # /context with an escaped quote
+  end # /describe #argv_quote
+
+  describe 'reparse_command' do
+    let(:input) { [] }
+    subject { described_class.reparse_command(*input) }
+
+    context 'with a simple string' do
+      let(:input) { ['foo bar baz'] }
+      it { is_expected.to eq 'foo bar baz' }
+    end # /context with a simple string
+
+    context 'with a more complex string' do
+      let(:input) { [Shellwords.join(['pip', 'install', 'foo==1.2.3'])] }
+      it { is_expected.to eq 'pip install foo==1.2.3' }
+    end # /context with a more complex string
+
+    context 'with a quoted string' do
+      let(:input) { [Shellwords.join(['myapp', 'create', 'a thing'])] }
+      it { is_expected.to eq 'myapp create "a thing"' }
+    end # /context with a quoted string
+
+    context 'with metacharacters' do
+      let(:input) { ['myapp > tmp'] }
+      it { is_expected.to eq 'myapp > tmp' }
+    end # /context with metacharacters
+
+    context 'with an array' do
+      let(:input) { ['myapp', 'create', 'a thing'] }
+      it { is_expected.to eq 'myapp create "a thing"' }
+    end # /context with an array
+
+    context 'with an array with metacharacters' do
+      let(:input) { ['myapp', '>', 'tmp'] }
+      it { is_expected.to eq '^m^y^a^p^p^ ^>^ ^t^m^p' }
+    end # /context with an array with metacharacters
+  end # /describe reparse_command
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: poise
 version: !ruby/object:Gem::Version
-  version: 2.6.1
+  version: 2.7.0
 platform: ruby
 authors:
 - Noah Kantrowitz
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-28 00:00:00.000000000 Z
+date: 2016-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: halite
@@ -24,20 +24,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: kitchen-inspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.12'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.12'
 - !ruby/object:Gem::Dependency
   name: poise-boiler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.8'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.8'
 description: Helpers for writing extensible Chef cookbooks.
 email:
 - noah@coderanger.net
@@ -81,6 +95,7 @@ files:
 - lib/poise/helpers/subresources/container.rb
 - lib/poise/helpers/subresources/default_containers.rb
 - lib/poise/helpers/template_content.rb
+- lib/poise/helpers/win32_user.rb
 - lib/poise/provider.rb
 - lib/poise/resource.rb
 - lib/poise/subcontext.rb
@@ -89,6 +104,7 @@ files:
 - lib/poise/utils.rb
 - lib/poise/utils/resource_provider_mixin.rb
 - lib/poise/utils/shell_out.rb
+- lib/poise/utils/win32.rb
 - lib/poise/version.rb
 - poise.gemspec
 - test/cookbook/attributes/default.rb
@@ -111,8 +127,8 @@ files:
 - test/gemfiles/chef-12.8.gemfile
 - test/gemfiles/chef-12.gemfile
 - test/gemfiles/master.gemfile
-- test/integration/default/serverspec/default_spec.rb
-- test/integration/default/serverspec/inversion_spec.rb
+- test/integration/default/default_spec.rb
+- test/integration/default/inversion_spec.rb
 - test/spec/backports/not_passed_spec.rb
 - test/spec/backports/verify_path_spec.rb
 - test/spec/helpers/chefspec_matchers_spec.rb
@@ -132,6 +148,7 @@ files:
 - test/spec/helpers/subresources/child_spec.rb
 - test/spec/helpers/subresources/container_spec.rb
 - test/spec/helpers/template_content_spec.rb
+- test/spec/helpers/win32_user_spec.rb
 - test/spec/poise_spec.rb
 - test/spec/provider_spec.rb
 - test/spec/resource_spec.rb
@@ -139,6 +156,12 @@ files:
 - test/spec/subcontext/resource_collection_spec.rb
 - test/spec/utils/resource_provider_mixin_spec.rb
 - test/spec/utils/shell_out_spec.rb
+- test/spec/utils/win32_helper/mixlib/shellout/windows/core_ext.rb
+- test/spec/utils/win32_helper/win32/process.rb
+- test/spec/utils/win32_helper/windows/handle.rb
+- test/spec/utils/win32_helper/windows/process.rb
+- test/spec/utils/win32_helper/windows/synchronize.rb
+- test/spec/utils/win32_spec.rb
 - test/spec/utils_spec.rb
 homepage: https://github.com/poise/poise
 licenses:
@@ -185,8 +208,8 @@ test_files:
 - test/gemfiles/chef-12.8.gemfile
 - test/gemfiles/chef-12.gemfile
 - test/gemfiles/master.gemfile
-- test/integration/default/serverspec/default_spec.rb
-- test/integration/default/serverspec/inversion_spec.rb
+- test/integration/default/default_spec.rb
+- test/integration/default/inversion_spec.rb
 - test/spec/backports/not_passed_spec.rb
 - test/spec/backports/verify_path_spec.rb
 - test/spec/helpers/chefspec_matchers_spec.rb
@@ -206,6 +229,7 @@ test_files:
 - test/spec/helpers/subresources/child_spec.rb
 - test/spec/helpers/subresources/container_spec.rb
 - test/spec/helpers/template_content_spec.rb
+- test/spec/helpers/win32_user_spec.rb
 - test/spec/poise_spec.rb
 - test/spec/provider_spec.rb
 - test/spec/resource_spec.rb
@@ -213,5 +237,11 @@ test_files:
 - test/spec/subcontext/resource_collection_spec.rb
 - test/spec/utils/resource_provider_mixin_spec.rb
 - test/spec/utils/shell_out_spec.rb
+- test/spec/utils/win32_helper/mixlib/shellout/windows/core_ext.rb
+- test/spec/utils/win32_helper/win32/process.rb
+- test/spec/utils/win32_helper/windows/handle.rb
+- test/spec/utils/win32_helper/windows/process.rb
+- test/spec/utils/win32_helper/windows/synchronize.rb
+- test/spec/utils/win32_spec.rb
 - test/spec/utils_spec.rb
 has_rdoc: