poetry-core 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 68f26084516bebd43571b5f687d9fb07cce952f00aba8e41448715b66b996fba
-  data.tar.gz: d1ec44154a85d4c2b4fda384432f2e73349973dfc21862aeddf06bde0d09303b
+  metadata.gz: 74940c713a7f81772d930f9581313847ec1a4044f36c3b31774efafd31bd07ef
+  data.tar.gz: 9e869c5574bef206ee03a998d31beda8cc10cf6f70e429134fb80b70fec8e2be
 SHA512:
-  metadata.gz: 65965b0865ade83c8b778c3ba773c6d1272bd4da2139e68cd8ab5b798903d12e3224d75df0f77f849cd72403e782d5da87ba470a4597d8654c7ab72a6bdc90ea
-  data.tar.gz: e3b822469b4ed1253193dd331b9b43b7923aa5626265ec9f6d1cdc6c4112a7306eb93e37f3a7670b9985da406ef804b5eb4b5174b03263004eced90e306e03c3
+  metadata.gz: 6bfcc4296038b8766014f1ed52cda1e9c365a9242aabcc0f8bac7a864e63c64a01438ec58d46c48ed1525d0191f7d1e0e9b4826932f996cb0184de123a19f856
+  data.tar.gz: c5c56a37ae235c3d88b155a9197138c9f583187814431d957f78efb430c8e925a86fc039111df305fec8d00b90e0b4cfe46eb897eca3415e8bc97b7d0182b670

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.1.3] - 2026-09-13
+
+### Fixed
+
+- `poetry check` no longer flags `with_trigger(compose: true) do |wiring|` (any composed slot) as a yieldless block: `compose: true` is the slot's other contract, and the setter yields the wiring for the caller's own control.
+- The app's own `poetry_*` helper methods are valid names for `poetry check` and the MCP `check` tool: `Poetry::Core::HostComponents.helper_methods` reads `def poetry_*` from `app/helpers` boot-free (the adapter `poetry:pagination` copies in, a wrapper the host wrote), and such a call is linted for its wiring only, since no registry describes its options or its block. A registry helper of the same name keeps the registry's contract.
+
 ## [0.1.2] - 2026-09-13
 
 ### Added

data/lib/poetry/core/check.rb

@@ -71,8 +71,8 @@ module Poetry
         # rgb(...)) - a url(#fragment) is not a color.
         STYLE_COLOR = /(?<!url\()#\h{3,8}\b|\b(?:#{COLOR_FUNCTIONS.join("|")})\([^)]*\)/i
 
-        def self.from_registry(root, helpers: nil, icon_names: nil)
-          from_registries([root], helpers: helpers, icon_names: icon_names)
+        def self.from_registry(root, helpers: nil, icon_names: nil, host_helpers: nil)
+          from_registries([root], helpers: helpers, icon_names: icon_names, host_helpers: host_helpers)
         end
 
         # A host catalog spans every installed poetry gem (ui + charts): a
@@ -82,7 +82,7 @@ module Poetry
         # host_registry: the app's own components (HostComponents.registry),
         # merged in beside the gem registries - their declared helpers join
         # the valid set and their contracts are checked like any other.
-        def self.from_registries(roots, helpers: nil, icon_names: nil, host_registry: nil)
+        def self.from_registries(roots, helpers: nil, icon_names: nil, host_registry: nil, host_helpers: nil)
           payloads = roots.map do |root|
             YAML.load_file(Pathname.new(root).join(Registry::RELATIVE_PATH), aliases: true)
           end
@@ -96,7 +96,8 @@ module Poetry
               helpers: helpers,
               helper_entries: payloads.map { |payload| payload["helpers"] || {} }.reduce({}, :merge),
               icon_names: icon_names,
-              helper_args: helper_args)
+              helper_args: helper_args,
+              host_helpers: host_helpers)
         end
 
         # helpers: the FULL set of valid poetry_* helper method names (from
@@ -110,11 +111,16 @@ module Poetry
         # helpers (poetry_input_group_addon align: et al). icon_names: the
         # active icon set's valid names - when given, icon-formatted option
         # values are checked for membership, not just shape.
-        def initialize(components, helpers: nil, helper_entries: nil, icon_names: nil, helper_args: nil)
+        def initialize(components, helpers: nil, helper_entries: nil, icon_names: nil, helper_args: nil,
+                       host_helpers: nil)
           @components = components
           @helper_entries = helper_entries || {}
           @helper_args = helper_args || {}
           @icon_names = icon_names&.to_set(&:to_s)
+          # The app's own poetry_* helper METHODS (HostComponents.helper_methods:
+          # a pagination adapter, a wrapper of the host's own) - valid by
+          # name, contracts their own.
+          @host_helpers = (host_helpers || []).to_set(&:to_s)
           # helper name -> registry path: poetry_ + the path under the gem
           # namespace (poetry/ui/command/dialog -> poetry_command_dialog,
           # avoiding the last-segment collision with poetry/ui/dialog). The
@@ -131,6 +137,7 @@ module Poetry
           end.to_h
           @helper_by_path = @path_by_helper.invert
           @helper_names = ((helpers&.map(&:to_s) || @path_by_helper.keys) + @helper_entries.keys).to_set
+          @helper_names.merge(@host_helpers)
         end
 
         attr_reader :icon_names
@@ -138,6 +145,15 @@ module Poetry
         def helper_names = @helper_names.to_a
 
         def helper?(name) = @helper_names.include?(name)
+
+        # A helper method the app defines under the prefix and no registry
+        # describes: the name is valid, its contract is the app's own. A
+        # registry entry of the same name (a gem helper the app redefines)
+        # keeps the registry's contract.
+        def host_helper?(name)
+          @host_helpers.include?(name) && !@path_by_helper.key?(name) && !@helper_entries.key?(name)
+        end
+
         def path_for(helper) = @path_by_helper[helper]
         # The helper that renders a registry path (the declared name, or the
         # poetry_ convention).
@@ -428,6 +444,14 @@ module Poetry
                                 message: "no poetry component #{helper}", line: line, suggestion: suggestion)]
           end
 
+          # A helper method of the app's own under the prefix (a pagination
+          # adapter poetry:pagination copied in, a wrapper the host wrote):
+          # no registry knows its options or whether it yields, so only the
+          # wiring rules apply.
+          if @catalog.host_helper?(helper)
+            return passthrough_findings(keyword_pairs(call), base_line) + data_findings(call, base_line, helper)
+          end
+
           # A valid helper with no component mapping (group / provider / item
           # wrapper): its registry-declared value contracts still check, and
           # NO wrapper yields anything to its block (a roster invariant) - a
@@ -854,7 +878,7 @@ module Poetry
         # WITHOUT a block (Carousel with_item).
         def setter_block_findings(entry, slot_name, call, line)
           findings = []
-          if (entry["yieldless"] || []).include?(slot_name) && block_param_name(call)
+          if (entry["yieldless"] || []).include?(slot_name) && !composed?(call) && block_param_name(call)
             findings << Finding.new(rule: "yieldless-block", severity: :error,
                                     message: "with_#{slot_name} yields nothing to its block - the param " \
                                              "will be nil; remove it and write the content directly",
@@ -924,6 +948,19 @@ module Poetry
           end
         end
 
+        # A setter called with `compose: true` is the slot's other
+        # contract: it yields the wiring for the caller's own control, so
+        # the block param is the point, not a mistake.
+        def composed?(call)
+          hash = call.arguments&.arguments&.find { |argument| argument.is_a?(Prism::KeywordHashNode) }
+          return false unless hash
+
+          hash.elements.any? do |element|
+            element.is_a?(Prism::AssocNode) && element.key.respond_to?(:unescaped) &&
+              element.key.unescaped == "compose" && element.value.is_a?(Prism::TrueNode)
+          end
+        end
+
         # [key_string, literal_value_or_nil, line] per keyword argument.
         def keyword_pairs(call)
           hash = call.arguments&.arguments&.find { |argument| argument.is_a?(Prism::KeywordHashNode) }

data/lib/poetry/core/host_components.rb

@@ -127,6 +127,40 @@ module Poetry
         end.uniq.sort
       end
 
+      # The app's own `poetry_*` view helper METHODS, boot-free: a source
+      # scan of app/helpers for instance-method definitions under the
+      # prefix (the adapter `poetry:pagination` copies in, a wrapper the
+      # host wrote). They join `poetry check`'s valid names - the MCP
+      # server's check tool and `bin/rails poetry:check` alike - with
+      # contracts of their own, which no registry describes.
+      #
+      # @param root [String, Pathname] the app root
+      # @return [Array<String>] sorted, unique
+      def helper_methods(root:)
+        Dir.glob(Pathname.new(root).join("app/helpers/**/*.rb").to_s).flat_map do |file|
+          result = Prism.parse(File.read(file))
+          result.success? ? HelperMethods.new.tap { |finder| result.value.accept(finder) }.names : []
+        end.uniq.sort
+      end
+
+      # The `def poetry_*` instance methods, from the syntax tree - a
+      # singleton method, a mention in a string or a comment is not one.
+      class HelperMethods < Prism::Visitor
+        PREFIX = "poetry_"
+
+        attr_reader :names
+
+        def initialize
+          super
+          @names = []
+        end
+
+        def visit_def_node(node)
+          @names << node.name.to_s if node.receiver.nil? && node.name.start_with?(PREFIX)
+          super
+        end
+      end
+
       # The `helper :name` / `helper("name")` calls in class bodies, from
       # the syntax tree - a mention inside a string, a heredoc or a comment
       # is not a declaration.

data/lib/poetry/core/version.rb

@@ -4,6 +4,6 @@ module Poetry
   module Core
     # The gem version. Every gem in the family carries the same version
     # and pins poetry-core to it exactly.
-    VERSION = "0.1.2"
+    VERSION = "0.1.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: poetry-core
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Matt Solt