pochette 0.2.3 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c67a840f37e1c8a8e29560276521c6a10a2edfe6
-  data.tar.gz: 5b38f917803fb98e70387de1db5753c505b3c03a
+  metadata.gz: d61a337d84f849c127e76e2d06db768306d3d050
+  data.tar.gz: 8ab1cb06f94a3bc4f88c0e641094ec8f54474d5a
 SHA512:
-  metadata.gz: 2e91fae50ed18c182a165e8020e71be01b630baa81b89d0c1f0644e91a661b743cc44a9dbe80ed7e65a599745b07504e56551586747d90d6dc1748fa73f3af05
-  data.tar.gz: baabb89ac0dde0290553376df3ebfa818454791496854050e292ec6684d80da120ca29666a306d695076fafb582d592296dac2fc1d4a95c0914ba1d66f8586b8
+  metadata.gz: 466b1a81cb4f6a2a5e302d613ddd0ddb994edc1312dc3c6d7a6bf6bcee6487956146e8645a6a0a8471b97a169daa4df9727ba7e31cf992d73ffb6d4f00c25aca
+  data.tar.gz: 54a663b538f938b1a2efc86f0d9ac46f95c454a783611b01152a3165bc4db2d01f4dcfe117a63878ddddda7caf035896ca2378f61ea9bf008a82804baa540e3f

data/README.md

@@ -291,7 +291,6 @@ A hash with
             depth: 0, 
             child_num: 0, 
             fingerprint: 0,
-            path: [],
             public_key: '03142b0a6fa6943e7276ddc42582c6b169243d289ff17e7c8101797047eed90c9b',
           }
         },
@@ -301,7 +300,6 @@ A hash with
             depth: 0, 
             child_num: 0, 
             fingerprint: 0,
-            path: [],
             public_key: '027565ceb190647ec5c566805ebc5cb6166ae2ee1d4995495f61b9eff371ec0e61',
           }
         },
@@ -311,7 +309,6 @@ A hash with
             depth: 0, 
             child_num: 0, 
             fingerprint: 0,
-            path: [],
             public_key: '028776ff18f0f3808d6d42749a6e2baee5c75c3f7ae07445403a3a5690d580a0af',
           }
         }

data/lib/pochette.rb

@@ -30,8 +30,12 @@ module Pochette
 
   module Backends
   end
+
+  class InvalidSignatureError < StandardError
+  end
 end
 
+require "pochette/backends/base"
 require "pochette/backends/bitcoin_core"
 require "pochette/backends/blockchain_info"
 require "pochette/backends/trendy"

data/lib/pochette/backends/base.rb

@@ -0,0 +1,88 @@
+# All Pochette backends must conform to this interface.
+class Pochette::Backends::Base
+  # Lists all bitcoins received by a list of addresses
+  # after a given date. Includes both confirmed and unconfirmed
+  # transactions, unconfirmed transactions have a nil block height.
+  # Returns a list of lists as following:
+  #   amount: Amount received (in satoshis)
+  #   address: Public address receiving the amount.
+  #   txid: The hash for the transaction that received it.
+  #   confirmations: Transaction confirmations
+  #   output position: To disambiguate in case address received more than once.
+  #   sender addresses: Comma separated list of input addresses,
+  #     used to identify deposits from trusted parties.
+  #     can be used to identify deposits from trusted parties.
+  def incoming_for(addresses, min_date)
+    raise NotImplementedError
+  end
+
+  # Gets the total received, spent and balance for
+  # a list of addresses. Confirmed balances are enforced to have a number
+  # of confirmation, appearing in a block is not enough.
+  # Returns a hash with:
+  # { address: [received, sent, total,
+  #             unconfirmed_received, unconfirmed_sent, unconfirmed_total],
+  #   ...}
+  def balances_for(addresses, confirmations)
+    raise NotImplementedError
+  end
+
+  # Get unspent utxos for the given addresses,
+  # returns a list of lists like so:
+  # [[address, txid, position (vout), amount (in satoshis)], ...]
+  def list_unspent(addresses)
+    raise NotImplementedError
+  end
+
+  # Gets information for the given transactions
+  # returns a list of objects, like so:
+  # [
+  #   { hash: txid,
+  #     version: 1,
+  #     lock_time: 0,
+  #     inputs: [
+  #       { prev_hash: txid,
+  #         prev_index: 0,
+  #         sequence: 0,
+  #         script_sig: hex_signature
+  #       },
+  #       ...
+  #     ],
+  #     bin_outputs: [
+  #       { amount: amount (as satoshis),
+  #         script_pubkey: hex_script
+  #       },
+  #       ...
+  #     ]
+  #   }
+  def list_transactions(txids)
+    raise NotImplementedError
+  end
+
+  def pushtx(hex, options = { })
+    verify_signatures(hex, options) if options[:verify_signatures]
+    propagate(hex)
+    Bitcoin::Protocol::Tx.new(hex.htb).hash
+  end
+
+  def propagate(hex)
+    raise NotImplementedError
+  end
+
+  def block_height
+    raise NotImplementedError
+  end
+
+  def verify_signatures(hex, options = { })
+    tx = Bitcoin::P::Tx.new(hex.htb)
+    tx.inputs.each_with_index do |input, idx|
+      prev_tx = list_transactions([ input.previous_output ]).first
+      outputs = prev_tx[:bin_outputs]
+      script_pubkey = outputs[input.prev_out_index][:script_pubkey].htb
+      unless tx.verify_input_signature(idx, script_pubkey, Time.now.to_i, options)
+        raise Pochette::InvalidSignatureError, "Signature for input #{idx} is invalid."
+      end
+    end
+    true
+  end
+end

data/lib/pochette/backends/bitcoin_core.rb

@@ -1,7 +1,7 @@
 # A bitcoin backend that uses bitcoin-core to retrieve information.
 # See Pochette::Backends::Trendy to learn more about the backend
 # interface and contract.
-class Pochette::Backends::BitcoinCore 
+class Pochette::Backends::BitcoinCore < Pochette::Backends::Base
   def initialize(rpc_url)
     @rpc_url = rpc_url
   end
@@ -103,7 +103,7 @@ class Pochette::Backends::BitcoinCore
     client.getinfo[:blocks]
   end
 
-  def pushtx(hex)
+  def propagate(hex)
     client.sendrawtransaction(hex)
   end
 end

data/lib/pochette/backends/blockchain_info.rb

@@ -3,7 +3,7 @@
 # interface and contract.
 require 'open-uri'
 
-class Pochette::Backends::BlockchainInfo
+class Pochette::Backends::BlockchainInfo < Pochette::Backends::Base
   cattr_accessor(:cooldown){1}
   attr_accessor :api_key
 
@@ -17,6 +17,13 @@ class Pochette::Backends::BlockchainInfo
       address = Bitcoin::Script.new(utxo['script'].htb).get_address
       [address, utxo['tx_hash_big_endian'], utxo['tx_output_n'].to_i, utxo['value'], utxo['script']]
     end
+  rescue OpenURI::HTTPError => e
+    # Blockchain.info returns 500 when there are no unspent outputs
+    if e.io.read == "No free outputs to spend"
+      return []
+    else
+      raise
+    end
   end
   
   def balances_for(addresses, confirmations)
@@ -85,13 +92,12 @@ class Pochette::Backends::BlockchainInfo
     get_json("latestblock", {format: 'json'})['height'].to_i
   end
 
-  def pushtx(hex)
+  def propagate(hex)
     uri = URI.parse("https://blockchain.info/pushtx")
     params = { "tx" => hex }
     params['api_code'] = api_key if api_key
     response = Net::HTTP.post_form(uri, params)
     raise StandardError.new(response) if response.code.to_i != 200
-    Bitcoin::Protocol::Tx.new(hex.htb).hash
   end
 
   def get_json(path, params={})

data/lib/pochette/backends/trendy.rb

@@ -2,87 +2,12 @@
 # to list unspent outputs, incoming payments, etcetera.
 # It chooses the backend to use based on its latest block, trying
 # to always use the most up to date one.
-# Its public instance methods are the contract to be used by any
-# other backend, all Pochette backends must define
-# thes public methods (Except for the initializer).
-class Pochette::Backends::Trendy
+class Pochette::Backends::Trendy < Pochette::Backends::Base
   def initialize(backends)
     @backends = backends
   end
-  
-  # Lists all bitcoins received by a list of addresses
-  # after a given date. Includes both confirmed and unconfirmed
-  # transactions, unconfirmed transactions have a nil block height.
-  # Returns a list of lists as following:
-  #   amount: Amount received (in satoshis)
-  #   address: Public address receiving the amount.
-  #   txid: The hash for the transaction that received it.
-  #   confirmations: Transaction confirmations
-  #   output position: To disambiguate in case address received more than once.
-  #   sender addresses: Comma separated list of input addresses,
-  #     used to identify deposits from trusted parties.
-  #     can be used to identify deposits from trusted parties.
-  def incoming_for(addresses, min_date)
-    backend.incoming_for(addresses, min_date)
-  end
-  
-  # Gets the total received, spent and balance for
-  # a list of addresses. Confirmed balances are enforced to have a number
-  # of confirmation, appearing in a block is not enough.
-  # Returns a hash with:
-  # { address: [received, sent, total,
-  #             unconfirmed_received, unconfirmed_sent, unconfirmed_total],
-  #   ...}
-  def balances_for(addresses, confirmations)
-    backend.balances_for(addresses, confirmations)
-  end
 
-  # Get unspent utxos for the given addresses,
-  # returns a list of lists like so:
-  # [[address, txid, position (vout), amount (in satoshis)], ...]
-  def list_unspent(addresses)
-    backend.list_unspent(addresses)
-  rescue OpenURI::HTTPError => e
-    # Blockchain.info returns 500 when there are no unspent outputs
-    if e.io.read == "No free outputs to spend"
-      return []
-    else
-      raise
-    end
-  end
-
-  # Gets information for the given transactions
-  # returns a list of objects, like so:
-  # [
-  #   { hash: txid,
-  #     version: 1,
-  #     lock_time: 0,
-  #     inputs: [
-  #       { prev_hash: txid,
-  #         prev_index: 0,
-  #         sequence: 0,
-  #         script_sig: hex_signature
-  #       },
-  #       ...
-  #     ],
-  #     bin_outputs: [
-  #       { amount: amount (as satoshis),
-  #         script_pubkey: hex_script
-  #       },
-  #       ...
-  #     ]
-  #   }
-  def list_transactions(txids)
-    backend.list_transactions(txids)
-  end
-
-  def pushtx(hex)
-    backend.pushtx(hex)
-  end
-
-  def block_height
-    backend.block_height
-  end
+  delegate :incoming_for, :balances_for, :list_unspent, :list_transactions, :pushtx, :block_height, to: :backend
 
 protected
 

data/lib/pochette/trezor_transaction_builder.rb

@@ -104,7 +104,6 @@ protected
                 depth: 0, 
                 child_num: 0, 
                 fingerprint: 0,
-                path: [],
                 public_key: node.public_key.key,
               }
             }

data/lib/pochette/version.rb

@@ -1,3 +1,3 @@
 module Pochette
-  VERSION = "0.2.3"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pochette
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.3.0
 platform: ruby
 authors:
 - Nubis
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-12-18 00:00:00.000000000 Z
+date: 2016-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -173,6 +173,7 @@ files:
 - bin/console
 - bin/setup
 - lib/pochette.rb
+- lib/pochette/backends/base.rb
 - lib/pochette/backends/bitcoin_core.rb
 - lib/pochette/backends/blockchain_info.rb
 - lib/pochette/backends/trendy.rb