pntfr 0.1.5 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 81121c5693dc0883a2cc0ac54c11b5e463d5c38f
-  data.tar.gz: 78fe7b37a43277c09b070fe57ea31476f9f355fc
+  metadata.gz: f221094bc8a33889ee989b9c5e0b3efa6bb6ff8b
+  data.tar.gz: c6a9e243937f0edd3156f7aa08286cf1d94df001
 SHA512:
-  metadata.gz: 3edc5e879d1f19dddad721ebe06c5256d666a997d9e20e6efc0e08f84cf526d28cb62a8352bfbfaf358a9b69e97248680406e0b93d98f65d448e3c1b5f0419bf
-  data.tar.gz: f00892e3d4d9f97447bf947c43162320c992a43ebb56da5874e48c0ccfffef6fb4c5e20896a24205504965de37a75d11334437d03964e2294e448a99a4a75605
+  metadata.gz: 9967a87ce75e3d54a592fcd3b5ffc6fd1e6abbc673793b8c71a0ead675e692629f2d121dcdfad90e3a92fd4992d8383646cdaa37afa0af38dc9b3185f76328c8
+  data.tar.gz: d65996ca9d17152d5f41cb6cf6be1a96be4a2afce06ccb27e49b9f12fbdcde55a02bc8c1472d37798a844e6617811f56142759218ee8da7b6f544b41a0bec30b

data/README.md

@@ -83,8 +83,7 @@ vsession.msg(
 )
 vsession.notify
 
-# Custom content will be found into :custom key for Android.
-# For iOS each custom key is transformed into an 'acme-' prefixed key.
+# Custom content will be found into :custom key for each platform.
 ```
 # Testing
 For testing one can check the messages to be sent to each given driver the same way

data/lib/pntfr/version.rb

@@ -1,4 +1,9 @@
 module Pntfr
-  # [FIX] Custom content is a "others" key in the content argument to APNS.
-  VERSION = '0.1.5'
+  # For IOS do not prefix custom fields with 'acme-' in the notification,
+  # instead group them all into a :custom key, like in Android.
+  #
+  # As this change doesn't break the gems API but changes device's management of
+  # received notifications, lets change only the minor version. This will also
+  # reflect the adding of the custom keys feature.
+  VERSION = '0.2.0'
 end

data/lib/pntfr/virtual_session/ios.rb

@@ -51,11 +51,7 @@ module Pntfr
         @alert= @sound= @badge= nil
       end
       def add_custom_content custom
-        @custom= {other: {}}
-        custom.each_pair { |k, v|
-          key= "acme-#{k}".to_sym
-          @custom[:other][key]= v
-        }
+        @custom= {other: {custom: custom}}
       end
     end
   end

data/test/pntfr/virtual_session/ios_test.rb

@@ -42,7 +42,7 @@ module Pntfr
         assert_equal 5, notif[:badge]
       end
 
-      def test_sending_custom_content_for_ios_should_be_added_as_acme_keys
+      def test_sending_custom_content_for_ios_should_be_added_as_custom_keys
         session= DeviceSession.new(Pntfr::Platforms::IOS, @push_id)
 
         vsession= Pntfr::Notifier.to(session)
@@ -54,10 +54,10 @@ module Pntfr
         refute_nil ios_notifs, "A notification should have been delivered for #{@push_id}"
         ios_notif= ios_notifs.last
         assert_equal 'Test Title', ios_notif[:alert]
-        other= ios_notif[:other]
-        assert_equal 'extra one', other[:'acme-extra1']
-        assert_equal 'extra 2', other[:'acme-extra_2']
-        assert_equal({lastkey: 'last value'}, other[:'acme-last-extra'])
+        custom= ios_notif[:other][:custom]
+        assert_equal 'extra one', custom[:'extra1']
+        assert_equal 'extra 2', custom[:'extra_2']
+        assert_equal({lastkey: 'last value'}, custom[:'last-extra'])
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pntfr
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.2.0
 platform: ruby
 authors:
 - oliver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-24 00:00:00.000000000 Z
+date: 2014-12-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: apns