plyushkin 0.0.4 → 0.0.5

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    plyushkin (0.0.3)
+    plyushkin (0.0.4)
       activerecord (~> 3.2.12)
 
 GEM

data/lib/plyushkin/base_value.rb

@@ -2,6 +2,8 @@ class Plyushkin::BaseValue
   include ActiveModel::Validations
 
   def initialize(attr={})
+    @new_record = attr[:new_record].nil? ? true : attr[:new_record] 
+
     attr   = attr.dup
     @date  = attr.delete(:date) || DateTime.current
     attr.each do |k,v|
@@ -9,6 +11,14 @@ class Plyushkin::BaseValue
     end
   end
 
+  def new_record?
+    @new_record
+  end
+
+  def mark_persisted
+    @new_record = false
+  end
+
   def formatters
     @formatters.dup
   end

data/lib/plyushkin/persistence.rb

@@ -11,17 +11,21 @@ class Plyushkin::Persistence
 
   def save(id)
     hash = {}
-    (@properties || {}).each do |name, property|
+    props = @properties || {}
+
+    props.each do |name, property|
       hash[name] = property.value_hashes
     end
     model.service.put(model.name, id, hash)
     model.cache.write(get_key(model.name, id), hash)
+
+    props.values.each(&:mark_persisted)
   end
 
   def load(id)
     @properties = {}
     cached(id).each do |name, values|
-      property = Plyushkin::Property.build(name, model.registered_types[name.to_sym], values,
+      property = Plyushkin::Property.load(name, model.registered_types[name.to_sym], values,
                                            :callbacks               => @callbacks[name.to_sym],
                                            :ignore_unchanged_values => @model.ignore_unchanged_values[name.to_sym] )
       @properties[name.to_sym] = property

data/lib/plyushkin/property.rb

@@ -32,7 +32,9 @@ class Plyushkin::Property
 
     @values.insert(insert_position(value.date), value)
     #write a spec for this option
-    trigger_callback(:after_create) unless attr[:without_callbacks]
+    trigger_callback(:after_create) if value.new_record?
+
+    @dirty = true
     value
   end
 
@@ -61,10 +63,10 @@ class Plyushkin::Property
     @value_type ||= Plyushkin::StringValue
   end
 
-  def self.build(name, type, values, opts={})
+  def self.load(name, type, values, opts={})
     opts[:type] = type
     prop = Plyushkin::Property.new(name, opts).tap do |p|
-      values.each { |value| p.create(value.merge(:without_callbacks => true)) }
+      values.each { |value| load_value(p, value) }
     end
 
     prop
@@ -84,4 +86,20 @@ class Plyushkin::Property
   def nil?
     last.is_a?(Plyushkin::NilValue)
   end
+
+  def dirty?
+    @dirty
+  end
+
+  def mark_persisted
+    @dirty = false
+    all.each(&:mark_persisted)
+  end
+
+  private 
+
+  def self.load_value(property, value)
+    property.create(value.merge(:new_record => false)) 
+  end
+
 end

data/lib/plyushkin/version.rb

@@ -1,3 +1,3 @@
 module Plyushkin
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/lib/base_value_spec.rb

@@ -46,6 +46,22 @@ describe Plyushkin::BaseValue do
     end
   end
 
+  describe '#new_record?' do
+    it 'should be true for a new instance' do
+      clazz = Class.new(Plyushkin::StringValue) 
+      clazz.new.should be_new_record
+    end
+  end
+
+  describe '#mark_persisted' do
+    it 'should set new_record to false' do
+      clazz = Class.new(Plyushkin::StringValue) 
+      value = clazz.new
+      value.mark_persisted
+      value.should_not be_new_record
+    end
+  end
+
   describe '##persisted_attr' do
     it 'should add attribute to persisted_attributes' do
       clazz = Class.new(Plyushkin::BaseValue) do

data/spec/lib/persistence_spec.rb

@@ -42,6 +42,14 @@ describe Plyushkin::Persistence do
       persistence.save(1)
       service.get("widget", 1)["name"].last["value"].should == "Mike"
     end
+
+    it 'should mark all properties as persisted' do
+      persistence.properties[:name].create(:value => "Mike")
+      persistence.properties[:weight].create(:value => "150")
+      persistence.save(1)
+      persistence.properties[:name].should_not be_dirty
+      persistence.properties[:weight].should_not be_dirty
+    end
   end
 
   describe '#load' do
@@ -78,6 +86,19 @@ describe Plyushkin::Persistence do
       model.register(:missing_property, Plyushkin::StringValue)
       persistence.properties[:missing_property].all.should == []
     end
+
+    it 'should mark loaded values new_record to false' do
+      persistence.properties[:name  ].last.should_not be_new_record
+      persistence.properties[:weight].last.should_not be_new_record
+      persistence.properties[:udt   ].last.should_not be_new_record
+    end
+
+    it 'should mark saved values new_record to false' do
+      persistence.properties[:name].create(:values => 'Mark')
+      persistence.properties[:name].last.should be_new_record
+      persistence.save(1)
+      persistence.properties[:name].last.should_not be_new_record
+    end
   end
 
   describe "#caching" do

data/spec/lib/property_spec.rb

@@ -1,6 +1,14 @@
 require 'spec_helper'
 
 describe Plyushkin::Property do
+  describe '##load' do
+    it 'should mark all values as not new records' do
+      property = Plyushkin::Property.load(:name, Plyushkin::StringValue,
+                                [ {:value => 'test'} ])
+      property.last.should_not be_new_record
+    end
+  end
+
   describe '#create' do
     it 'should add a StringValue' do
       property = Plyushkin::Property.new(:property_name)
@@ -43,6 +51,37 @@ describe Plyushkin::Property do
       end
     end
 
+    describe '#dirty?' do
+      let(:property) { Plyushkin::Property.new(:property_name) }
+
+      it 'should be false when the property is first created' do
+        property.should_not be_dirty
+      end
+
+      it 'should be true when a value is created' do
+        property.create(:value => 5)
+        property.should be_dirty
+      end
+    end
+
+    describe '#mark_persisted' do
+      let(:property) { Plyushkin::Property.new(:property_name) }
+
+      it 'should reset dirty? to false' do
+        property.create(:value => 5)
+        property.should be_dirty
+        property.mark_persisted
+        property.should_not be_dirty
+      end
+
+      it 'should mark all values new_record to false' do
+        property.create(:value => 5)
+        property.last.should be_new_record
+        property.mark_persisted
+        property.last.should_not be_new_record
+      end
+    end
+
     describe 'ignore_unchanged_value' do
       it 'should not add a value when ignore_unchanged_value is true and value does not change' do
         property = Plyushkin::Property.new(:property_name, :ignore_unchanged_values => true)
@@ -77,20 +116,28 @@ describe Plyushkin::Property do
       end
     end
 
-    describe 'without_callbacks' do
-      it 'should not run callbacks if option is true' do
+    describe 'new_record' do
+      it 'should not run callbacks if option is false' do
         called = 0
         callbacks = { :after_create => lambda{ called += 1 } }
         property = Plyushkin::Property.new(:property_name, :callbacks => callbacks)
-        property.create(:value => 5, :without_callbacks => true)
+        property.create(:value => 5, :new_record => false)
         called.should == 0
       end
 
-      it 'should run callbacks if option is false' do
+      it 'should run callbacks if option is true' do
+        called = 0
+        callbacks = { :after_create => lambda{ called += 1 } }
+        property = Plyushkin::Property.new(:property_name, :callbacks => callbacks)
+        property.create(:value => 5, :new_record => true)
+        called.should == 1
+      end
+
+      it 'should run callbacks if no option is provided' do
         called = 0
         callbacks = { :after_create => lambda{ called += 1 } }
         property = Plyushkin::Property.new(:property_name, :callbacks => callbacks)
-        property.create(:value => 5, :without_callbacks => false)
+        property.create(:value => 5)
         called.should == 1
       end
     end

metadata

@@ -1,7 +1,8 @@
 --- !ruby/object:Gem::Specification
 name: plyushkin
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
+  prerelease: 
 platform: ruby
 authors:
 - Craig Israel
@@ -9,11 +10,12 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-28 00:00:00.000000000 Z
+date: 2014-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -21,6 +23,7 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -28,6 +31,7 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -35,6 +39,7 @@ dependencies:
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -42,15 +47,17 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
+    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Provides active record extension to capture historical property data
@@ -109,26 +116,27 @@ files:
 homepage: http://github.com/OnlifeHealth/plyushkin
 licenses:
 - MIT
-metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
+  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.3
+rubygems_version: 1.8.23
 signing_key: 
-specification_version: 4
+specification_version: 3
 summary: Plyushkin - the attribute hoarder
 test_files:
 - spec/lib/base_value_spec.rb

checksums.yaml

@@ -1,7 +0,0 @@
----
-SHA1:
-  metadata.gz: f3ffa197a5ec8d8b23b72ba77444540524c17062
-  data.tar.gz: cfd45839d46278a89f81904eee6cc4cedb490b97
-SHA512:
-  metadata.gz: 20a5449a85d1753e8a08ec0bac1063827a1ddc3d1325edfd57d805072f9f90d4cf6bf581e2da6a51457daaf7c493543e750e9652b08e62b1f4dd1782b575ae8a
-  data.tar.gz: 0e26387d0792ec1ec44f78d8f5e1e738dd1f7c51cc1163305087dc76d52b0d6a67be1f84ad8674828452d2fcbcacb281ddebe85c113d29e0d3edcda897e9c28a