plyushkin 0.0.1 → 0.0.2

data/.gitignore

@@ -1,3 +1,4 @@
 .bundle
 .DS_Store
 *.swp
+plyushkin*.gem

data/lib/plyushkin/base_value.rb

@@ -36,7 +36,7 @@ class Plyushkin::BaseValue
     end
   end
 
- persisted_attr :date
+ persisted_attr :date, :formatter => :to_date
   validates_each :date do |record, attr_name, value|
     record.errors.add(attr_name, "cannot be in the future") unless value < DateTime.now
   end

data/lib/plyushkin/persistence.rb

@@ -12,7 +12,7 @@ class Plyushkin::Persistence
   def save(id)
     hash = {}
     (@properties || {}).each do |name, property|
-      hash[name] = [property.value_hashes]
+      hash[name] = property.value_hashes
     end
     model.service.put(id, hash.to_json)
   end

data/lib/plyushkin/property.rb

@@ -20,14 +20,19 @@ class Plyushkin::Property
   end
 
   def create(attr={})
+    #write a spec for this option
+    ignore_invalid = attr.delete(:ignore_invalid)
     value = value_type.new(attr)
     if @ignore_unchanged_values
       last = @values.last
       return last if last && last.equal_value?(value)
     end
 
+    return if !value.valid? && ignore_invalid
+
     @values.insert(insert_position(value.date), value)
-    trigger_callback(:after_create)
+    #write a spec for this option
+    trigger_callback(:after_create) unless attr[:without_callbacks]
     value
   end
 
@@ -58,9 +63,11 @@ class Plyushkin::Property
 
   def self.build(name, type, values, opts={})
     opts[:type] = type
-    Plyushkin::Property.new(name, opts).tap do |p|
-      values.each { |value| p.create(value) }
+    prop = Plyushkin::Property.new(name, opts).tap do |p|
+      values.each { |value| p.create(value.merge(:without_callbacks => true)) }
     end
+
+    prop
   end
 
   def value_hashes
@@ -71,6 +78,6 @@ class Plyushkin::Property
       end
     end
 
-    value_hashes
+    value_hashes == {} ? [] : [value_hashes]
   end
 end

data/lib/plyushkin/version.rb

@@ -1,3 +1,3 @@
 module Plyushkin
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/spec/lib/property_spec.rb

@@ -51,6 +51,49 @@ describe Plyushkin::Property do
         property.all.length.should == 1
       end
     end
+
+    describe 'ignore_invalid option' do
+      it 'should not create a value if value is invalid and option is true' do
+        property = Plyushkin::Property.new(:property_name, :type => Plyushkin::Test::PresenceTestValue)
+        property.create(:ignore_invalid => true )
+        property.all.length.should == 0
+        property.should be_valid
+      end
+
+      it 'should create a value if the value is invalid and the option is not provided' do
+        property = Plyushkin::Property.new(:property_name,
+                                          :type => Plyushkin::Test::PresenceTestValue)
+        property.create
+        property.all.length.should == 1
+        property.should_not be_valid
+      end
+
+      it 'should create a value if the value is valid and the option is true' do
+        property = Plyushkin::Property.new(:property_name,
+                                          :type => Plyushkin::Test::PresenceTestValue)
+        property.create(:value => 5, :ignore_invalid => true)
+        property.all.length.should == 1
+        property.should be_valid
+      end
+    end
+
+    describe 'without_callbacks' do
+      it 'should not run callbacks if option is true' do
+        called = 0
+        callbacks = { :after_create => lambda{ called += 1 } }
+        property = Plyushkin::Property.new(:property_name, :callbacks => callbacks)
+        property.create(:value => 5, :without_callbacks => true)
+        called.should == 0
+      end
+
+      it 'should run callbacks if option is false' do
+        called = 0
+        callbacks = { :after_create => lambda{ called += 1 } }
+        property = Plyushkin::Property.new(:property_name, :callbacks => callbacks)
+        property.create(:value => 5, :without_callbacks => false)
+        called.should == 1
+      end
+    end
   end
 
   describe '#all' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: plyushkin
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-22 00:00:00.000000000 Z
+date: 2014-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord