plutus 0.7.2 → 0.7.4

data/app/models/plutus/account.rb

@@ -32,14 +32,36 @@ module Plutus
   class Account < ActiveRecord::Base
     attr_accessible :name, :contra
     
-    has_many :credit_amounts
-    has_many :debit_amounts
+    has_many :credit_amounts, :extend => AmountsExtension
+    has_many :debit_amounts, :extend => AmountsExtension
     has_many :credit_transactions, :through => :credit_amounts, :source => :transaction
     has_many :debit_transactions, :through => :debit_amounts, :source => :transaction
 
     validates_presence_of :type, :name
     validates_uniqueness_of :name
 
+    # The credit balance for the account.
+    #
+    # @example
+    #   >> asset.credits_balance
+    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
+    #
+    # @return [BigDecimal] The decimal value credit balance
+    def credits_balance
+      credit_amounts.balance
+    end
+
+    # The debit balance for the account.
+    #
+    # @example
+    #   >> asset.debits_balance
+    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
+    #
+    # @return [BigDecimal] The decimal value credit balance
+    def debits_balance
+      debit_amounts.balance
+    end
+
     # The trial balance of all accounts in the system. This should always equal zero,
     # otherwise there is an error in the system.
     #

data/app/models/plutus/amounts_extension.rb

@@ -0,0 +1,17 @@
+module Plutus
+  # Association extension for has_many :amounts relations. Internal.
+  module AmountsExtension
+    # Returns a sum of the referenced Amount objects.
+    def balance
+      balance = BigDecimal.new('0')
+      each do |amount_record|
+        if amount_record.amount
+          balance += amount_record.amount
+        else
+          balance = nil
+        end
+      end
+      return balance
+    end
+  end
+end

data/app/models/plutus/asset.rb

@@ -9,36 +9,6 @@ module Plutus
   # @author Michael Bulat
   class Asset < Account
 
-    # The credit balance for the account.
-    #
-    # @example
-    #   >> asset.credits_balance
-    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def credits_balance
-      credits_balance = BigDecimal.new('0')
-      credit_amounts.each do |credit_amount|
-        credits_balance += credit_amount.amount
-      end
-      return credits_balance
-    end
-
-    # The debit balance for the account.
-    #
-    # @example
-    #   >> asset.debits_balance
-    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def debits_balance
-      debits_balance = BigDecimal.new('0')
-      debit_amounts.each do |debit_amount|
-        debits_balance += debit_amount.amount
-      end
-      return debits_balance
-    end
-
     # The balance of the account.
     #
     # Assets have normal debit balances, so the credits are subtracted from the debits

data/app/models/plutus/equity.rb

@@ -9,37 +9,6 @@ module Plutus
   # @author Michael Bulat
   class Equity < Account
 
-    # The credit balance for the account.
-    #
-    # @example
-    #   >> equity.credits_balance
-    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def credits_balance
-      credits_balance = BigDecimal.new('0')
-      credit_amounts.each do |credit_amount|
-        credits_balance = credits_balance + credit_amount.amount
-      end
-      return credits_balance
-    end
-
-    # The debit balance for the account.
-    #
-    # @example
-    #   >> equity.debits_balance
-    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def debits_balance
-      debits_balance = BigDecimal.new('0')
-      debit_amounts.each do |debit_amount|
-        debits_balance = debits_balance + debit_amount.amount
-      end
-      return debits_balance
-    end
-
-
     # The balance of the account.
     #
     # Equity accounts have normal credit balances, so the debits are subtracted from the credits

data/app/models/plutus/expense.rb

@@ -9,36 +9,6 @@ module Plutus
   # @author Michael Bulat
   class Expense < Account
 
-    # The credit balance for the account.
-    #
-    # @example
-    #   >> expense.credits_balance
-    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def credits_balance
-      credits_balance = BigDecimal.new('0')
-      credit_amounts.each do |credit_amount|
-        credits_balance = credits_balance + credit_amount.amount
-      end
-      return credits_balance
-    end
-
-    # The debit balance for the account.
-    #
-    # @example
-    #   >> expense.debits_balance
-    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def debits_balance
-      debits_balance = BigDecimal.new('0')
-      debit_amounts.each do |debit_amount|
-        debits_balance = debits_balance + debit_amount.amount
-      end
-      return debits_balance
-    end
-
     # The balance of the account.
     #
     # Expenses have normal debit balances, so the credits are subtracted from the debits

data/app/models/plutus/liability.rb

@@ -9,36 +9,6 @@ module Plutus
   # @author Michael Bulat
   class Liability < Account
 
-    # The credit balance for the account.
-    #
-    # @example
-    #   >> liability.credits_balance
-    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def credits_balance
-      credits_balance = BigDecimal.new('0')
-      credit_amounts.each do |credit_amount|
-        credits_balance = credits_balance + credit_amount.amount
-      end
-      return credits_balance
-    end
-
-    # The debit balance for the account.
-    #
-    # @example
-    #   >> liability.debits_balance
-    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def debits_balance
-      debits_balance = BigDecimal.new('0')
-      debit_amounts.each do |debit_amount|
-        debits_balance = debits_balance + debit_amount.amount
-      end
-      return debits_balance
-    end
-
     # The balance of the account.
     #
     # Liability accounts have normal credit balances, so the debits are subtracted from the credits

data/app/models/plutus/revenue.rb

@@ -9,36 +9,6 @@ module Plutus
   # @author Michael Bulat
   class Revenue < Account
 
-    # The credit balance for the account.
-    #
-    # @example
-    #   >> revenue.credits_balance
-    #   => #<BigDecimal:103259bb8,'0.3E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def credits_balance
-      credits_balance = BigDecimal.new('0')
-      credit_amounts.each do |credit_amount|
-        credits_balance = credits_balance + credit_amount.amount
-      end
-      return credits_balance
-    end
-
-    # The debit balance for the account.
-    #
-    # @example
-    #   >> revenue.debits_balance
-    #   => #<BigDecimal:103259bb8,'0.1E4',4(12)>
-    #
-    # @return [BigDecimal] The decimal value credit balance
-    def debits_balance
-      debits_balance = BigDecimal.new('0')
-      debit_amounts.each do |debit_amount|
-        debits_balance = debits_balance + debit_amount.amount
-      end
-      return debits_balance
-    end
-
     # The balance of the account.
     #
     # Revenue accounts have normal credit balances, so the debits are subtracted from the credits

data/app/models/plutus/transaction.rb

@@ -25,8 +25,8 @@ module Plutus
     attr_accessible :description, :commercial_document
 
     belongs_to :commercial_document, :polymorphic => true
-    has_many :credit_amounts
-    has_many :debit_amounts
+    has_many :credit_amounts, :extend => AmountsExtension
+    has_many :debit_amounts, :extend => AmountsExtension
     has_many :credit_accounts, :through => :credit_amounts, :source => :account
     has_many :debit_accounts, :through => :debit_amounts, :source => :account
 
@@ -71,13 +71,7 @@ module Plutus
       end
 
       def amounts_cancel?
-        errors[:base] << "The credit and debit amounts are not equal" if difference_of_amounts != 0
-      end
-
-      def difference_of_amounts
-        credit_amount_total = credit_amounts.inject(0) {|sum, credit_amount| sum + credit_amount.amount.to_i}
-        debit_amount_total = debit_amounts.inject(0) {|sum, debit_amount| sum + debit_amount.amount.to_i}
-        credit_amount_total - debit_amount_total  
+        errors[:base] << "The credit and debit amounts are not equal" if credit_amounts.balance != debit_amounts.balance
       end
   end
 end

data/lib/plutus/version.rb

@@ -1,3 +1,3 @@
 module Plutus
-  VERSION = "0.7.2"
+  VERSION = "0.7.4"
 end

data/spec/models/account_spec.rb

@@ -2,63 +2,69 @@ require 'spec_helper'
 
 module Plutus
   describe Account do
+    let(:account) { FactoryGirl.build(:account) }
+    subject { account }
+    
+    it { should_not be_valid }  # must construct a child type instead
 
-    it "should not allow creating an account without a subtype" do
-      account = FactoryGirl.build(:account)
-      account.should_not be_valid
+    describe "when using a child type" do
+      let(:account) { FactoryGirl.create(:account, type: "Finance::Asset") }
+      it { should be_valid }
+      
+      it "should be unique per name" do
+        conflict = FactoryGirl.build(:account, name: account.name, type: account.type)
+        conflict.should_not be_valid
+        conflict.errors[:name].should == ["has already been taken"]
+      end
     end
+    
+    it { should_not respond_to(:balance) }
+    
+    describe ".trial_balance" do
+      subject { Account.trial_balance }
+      it { should be_kind_of BigDecimal }
+      
+      context "when given no transactions" do
+        it { should == 0 }
+      end
+      
+      context "when given correct transactions" do
+        before {
+          # credit accounts
+          liability = FactoryGirl.create(:liability)
+          equity = FactoryGirl.create(:equity)
+          revenue = FactoryGirl.create(:revenue)
+          contra_asset = FactoryGirl.create(:asset, :contra => true)
+          contra_expense = FactoryGirl.create(:expense, :contra => true)
+          # credit amounts
+          ca1 = FactoryGirl.build(:credit_amount, :account => liability, :amount => 100000)
+          ca2 = FactoryGirl.build(:credit_amount, :account => equity, :amount => 1000)
+          ca3 = FactoryGirl.build(:credit_amount, :account => revenue, :amount => 40404)
+          ca4 = FactoryGirl.build(:credit_amount, :account => contra_asset, :amount => 2)
+          ca5 = FactoryGirl.build(:credit_amount, :account => contra_expense, :amount => 333)
 
-    it "should be unique per name" do
-      FactoryGirl.create(:account, :name => "Test1", :type => "Plutus::Asset")
-      account = FactoryGirl.build(:account, :name => "Test1", :type => "Plutus::Asset")
-      account.should_not be_valid
-      account.errors[:name].should == ["has already been taken"]
-    end
-
-    it "should not have a balance method" do
-      lambda{Account.balance}.should raise_error(NoMethodError)
-    end
+          # debit accounts
+          asset = FactoryGirl.create(:asset)
+          expense = FactoryGirl.create(:expense)
+          contra_liability = FactoryGirl.create(:liability, :contra => true)
+          contra_equity = FactoryGirl.create(:equity, :contra => true)
+          contra_revenue = FactoryGirl.create(:revenue, :contra => true)
+          # debit amounts
+          da1 = FactoryGirl.build(:debit_amount, :account => asset, :amount => 100000)
+          da2 = FactoryGirl.build(:debit_amount, :account => expense, :amount => 1000)
+          da3 = FactoryGirl.build(:debit_amount, :account => contra_liability, :amount => 40404)
+          da4 = FactoryGirl.build(:debit_amount, :account => contra_equity, :amount => 2)
+          da5 = FactoryGirl.build(:debit_amount, :account => contra_revenue, :amount => 333)
 
-    it "should have a trial balance" do
-      Account.should respond_to(:trial_balance)
-      Account.trial_balance.should be_kind_of(BigDecimal)
+          FactoryGirl.create(:transaction, :credit_amounts => [ca1], :debit_amounts => [da1])
+          FactoryGirl.create(:transaction, :credit_amounts => [ca2], :debit_amounts => [da2]) 
+          FactoryGirl.create(:transaction, :credit_amounts => [ca3], :debit_amounts => [da3])
+          FactoryGirl.create(:transaction, :credit_amounts => [ca4], :debit_amounts => [da4])
+          FactoryGirl.create(:transaction, :credit_amounts => [ca5], :debit_amounts => [da5])
+        }
+        
+        it { should == 0 }
+      end
     end
-
-    it "should report a trial balance of 0 with correct transactions" do
-      # credit accounts
-      liability = FactoryGirl.create(:liability)
-      equity = FactoryGirl.create(:equity)
-      revenue = FactoryGirl.create(:revenue)
-      contra_asset = FactoryGirl.create(:asset, :contra => true)
-      contra_expense = FactoryGirl.create(:expense, :contra => true)
-      # credit amounts
-      ca1 = FactoryGirl.build(:credit_amount, :account => liability, :amount => 100000)
-      ca2 = FactoryGirl.build(:credit_amount, :account => equity, :amount => 1000)
-      ca3 = FactoryGirl.build(:credit_amount, :account => revenue, :amount => 40404)
-      ca4 = FactoryGirl.build(:credit_amount, :account => contra_asset, :amount => 2)
-      ca5 = FactoryGirl.build(:credit_amount, :account => contra_expense, :amount => 333)
-
-      # debit accounts
-      asset = FactoryGirl.create(:asset)
-      expense = FactoryGirl.create(:expense)
-      contra_liability = FactoryGirl.create(:liability, :contra => true)
-      contra_equity = FactoryGirl.create(:equity, :contra => true)
-      contra_revenue = FactoryGirl.create(:revenue, :contra => true)
-      # debit amounts
-      da1 = FactoryGirl.build(:debit_amount, :account => asset, :amount => 100000)
-      da2 = FactoryGirl.build(:debit_amount, :account => expense, :amount => 1000)
-      da3 = FactoryGirl.build(:debit_amount, :account => contra_liability, :amount => 40404)
-      da4 = FactoryGirl.build(:debit_amount, :account => contra_equity, :amount => 2)
-      da5 = FactoryGirl.build(:debit_amount, :account => contra_revenue, :amount => 333)
-
-      FactoryGirl.create(:transaction, :credit_amounts => [ca1], :debit_amounts => [da1])
-      FactoryGirl.create(:transaction, :credit_amounts => [ca2], :debit_amounts => [da2]) 
-      FactoryGirl.create(:transaction, :credit_amounts => [ca3], :debit_amounts => [da3])
-      FactoryGirl.create(:transaction, :credit_amounts => [ca4], :debit_amounts => [da4])
-      FactoryGirl.create(:transaction, :credit_amounts => [ca5], :debit_amounts => [da5])
-
-      Account.trial_balance.should == 0
-    end
-
   end
 end

data/spec/models/amount_spec.rb

@@ -2,11 +2,7 @@ require 'spec_helper'
 
 module Plutus
   describe Amount do
-
-    it "should not allow creating an amount without a subtype" do
-      amount = FactoryGirl.build(:amount)
-      amount.should_not be_valid
-    end
-
+    subject { FactoryGirl.build(:amount) }
+    it { should_not be_valid }  # construct a child class instead
   end
 end

data/spec/models/asset_spec.rb

@@ -2,52 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe Asset do
-
-    it "should allow creating an asset account" do
-      asset = FactoryGirl.create(:asset)
-    end
-
-    it "should report a balance for the asset account" do
-      asset = FactoryGirl.create(:asset)
-      FactoryGirl.create(:debit_amount, :account => asset)
-      asset.balance.should > 0
-      asset.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should report a balance for the class of accounts" do
-      asset = FactoryGirl.create(:asset)
-      FactoryGirl.create(:debit_amount, :account => asset)
-      Asset.should respond_to(:balance)
-      Asset.balance.should > 0
-      Asset.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should not report a trial balance" do
-      lambda{Asset.trial_balance}.should raise_error(NoMethodError)
-    end
-
-    it "should not be valid without a name" do
-      asset = FactoryGirl.build(:asset, :name => nil)
-      asset.should_not be_valid
-    end
-
-    it "should have many credit transactions" do
-      asset = Factory(:asset)
-      asset.should respond_to(:credit_transactions)
-    end
-
-    it "should have many debit transactions" do
-      asset = Factory(:asset)
-      asset.should respond_to(:debit_transactions)
-    end
-
-    it "a contra account should reverse the normal balance" do
-      contra_asset = Factory(:asset, :contra => true)
-      # the odd amount below is because factories create an asset debit_amount
-      FactoryGirl.create(:credit_amount, :account => contra_asset, :amount => 473) 
-      contra_asset.balance.should > 0
-      Asset.balance.should == 0 
-    end
-
+    it_behaves_like 'a Plutus::Account subtype', kind: :asset, normal_balance: :debit
   end
 end

data/spec/models/credit_amount_spec.rb

@@ -2,21 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe CreditAmount do
-
-    it "should be invalid without an amount" do
-      credit_amount = FactoryGirl.build(:credit_amount, :amount => nil)
-      credit_amount.should_not be_valid
-    end
-
-    it "should not be valid without a transaction" do
-      credit_amount = FactoryGirl.build(:credit_amount, :transaction => nil)
-      credit_amount.should_not be_valid
-    end
-
-    it "should not be valid without an account" do
-      credit_amount = FactoryGirl.build(:credit_amount, :account => nil)
-      credit_amount.should_not be_valid
-    end
-
+    it_behaves_like 'a Plutus::Amount subtype', kind: :credit_amount
   end
 end

data/spec/models/debit_amount_spec.rb

@@ -2,21 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe DebitAmount do
-
-    it "should be invalid without an amount" do
-      debit_amount = FactoryGirl.build(:debit_amount, :amount => nil)
-      debit_amount.should_not be_valid
-    end
-
-    it "should not be valid without a transaction" do
-      debit_amount = FactoryGirl.build(:debit_amount, :transaction => nil)
-      debit_amount.should_not be_valid
-    end
-
-    it "should not be valid without an account" do
-      debit_amount = FactoryGirl.build(:debit_amount, :account => nil)
-      debit_amount.should_not be_valid
-    end
-
+    it_behaves_like 'a Plutus::Amount subtype', kind: :debit_amount
   end
 end

data/spec/models/equity_spec.rb

@@ -2,53 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe Equity do
-
-    it "should allow creating an equity account" do
-      equity = FactoryGirl.create(:equity)
-    end
-
-    it "should report a balance for the equity account" do
-      equity = FactoryGirl.create(:equity)
-      FactoryGirl.create(:credit_amount, :account => equity)
-      equity.balance.should > 0
-      equity.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should report a balance for the class of accounts" do
-      equity = FactoryGirl.create(:equity)
-      FactoryGirl.create(:credit_amount, :account => equity)
-      Equity.should respond_to(:balance)
-      Equity.balance.should > 0
-      Equity.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should not report a trial balance" do
-      lambda{Equity.trial_balance}.should raise_error(NoMethodError)
-    end
-
-    it "should not be valid without a name" do
-      equity = FactoryGirl.build(:equity, :name => nil)
-      equity.should_not be_valid
-    end
-
-    it "should have many credit transactions" do
-      equity = Factory(:equity)
-      equity.should respond_to(:credit_transactions)
-    end
-
-    it "should have many debit transactions" do
-      equity = Factory(:equity)
-      equity.should respond_to(:debit_transactions)
-    end
-
-    it "a contra account should reverse the normal balance" do
-      equity = FactoryGirl.create(:equity)
-      contra_equity = Factory(:equity, :contra => true)
-      FactoryGirl.create(:credit_amount, :account => equity)
-      FactoryGirl.create(:debit_amount, :account => contra_equity)
-      contra_equity.balance.should > 0
-      Equity.balance.should == 0
-    end
-
+    it_behaves_like 'a Plutus::Account subtype', kind: :equity, normal_balance: :credit
   end
 end

data/spec/models/expense_spec.rb

@@ -2,53 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe Expense do
-
-    it "should allow creating an expense account" do
-      expense = FactoryGirl.create(:expense)
-    end
-
-    it "should report a balance for the expense account" do
-      expense = FactoryGirl.create(:expense)
-      FactoryGirl.create(:debit_amount, :account => expense)
-      expense.balance.should > 0
-      expense.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should report a balance for the class of accounts" do
-      expense = FactoryGirl.create(:expense)
-      FactoryGirl.create(:debit_amount, :account => expense)
-      Expense.should respond_to(:balance)
-      Expense.balance.should > 0
-      Expense.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should not report a trial balance" do
-      lambda{Expense.trial_balance}.should raise_error(NoMethodError)
-    end
-
-    it "should not be valid without a name" do
-      expense = FactoryGirl.build(:expense, :name => nil)
-      expense.should_not be_valid
-    end
-
-    it "should have many credit transactions" do
-      expense = Factory(:expense)
-      expense.should respond_to(:credit_transactions)
-    end
-
-    it "should have many debit transactions" do
-      expense = Factory(:expense)
-      expense.should respond_to(:debit_transactions)
-    end
-
-    it "a contra account should reverse the normal balance" do
-      expense = FactoryGirl.create(:expense)
-      contra_expense = Factory(:expense, :contra => true)
-      FactoryGirl.create(:debit_amount, :account => expense)
-      FactoryGirl.create(:credit_amount, :account => contra_expense)
-      contra_expense.balance.should > 0
-      Expense.balance.should == 0
-    end
-
+    it_behaves_like 'a Plutus::Account subtype', kind: :expense, normal_balance: :debit
   end
 end

data/spec/models/liability_spec.rb

@@ -2,53 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe Liability do
-
-    it "should allow creating an liability account" do
-      liability = FactoryGirl.create(:liability)
-    end
-
-    it "should report a balance for the liability account" do
-      liability = FactoryGirl.create(:liability)
-      FactoryGirl.create(:credit_amount, :account => liability)
-      liability.balance.should > 0
-      liability.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should report a balance for the class of accounts" do
-      liability = FactoryGirl.create(:liability)
-      FactoryGirl.create(:credit_amount, :account => liability)
-      Liability.should respond_to(:balance)
-      Liability.balance.should > 0
-      Liability.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should not report a trial balance" do
-      lambda{Liability.trial_balance}.should raise_error(NoMethodError)
-    end
-
-    it "should not be valid without a name" do
-      liability = FactoryGirl.build(:liability, :name => nil)
-      liability.should_not be_valid
-    end
-
-    it "should have many credit transactions" do
-      liability = Factory(:liability)
-      liability.should respond_to(:credit_transactions)
-    end
-
-    it "should have many debit transactions" do
-      liability = Factory(:liability)
-      liability.should respond_to(:debit_transactions)
-    end
-
-    it "a contra account should reverse the normal balance" do
-      liability = FactoryGirl.create(:liability)
-      contra_liability = Factory(:liability, :contra => true)
-      FactoryGirl.create(:credit_amount, :account => liability)
-      FactoryGirl.create(:debit_amount, :account => contra_liability)
-      contra_liability.balance.should > 0
-      Liability.balance.should == 0
-    end
-
+    it_behaves_like 'a Plutus::Account subtype', kind: :liability, normal_balance: :credit
   end
 end

data/spec/models/revenue_spec.rb

@@ -2,52 +2,6 @@ require 'spec_helper'
 
 module Plutus
   describe Revenue do
-
-    it "should allow creating an revenue account" do
-      revenue = FactoryGirl.create(:revenue)
-    end
-
-    it "should report a balance for the revenue account" do
-      revenue = FactoryGirl.create(:revenue)
-      FactoryGirl.create(:credit_amount, :account => revenue)
-      revenue.balance.should > 0
-      revenue.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should report a balance for the class of accounts" do
-      revenue = FactoryGirl.create(:revenue)
-      FactoryGirl.create(:credit_amount, :account => revenue)
-      Revenue.should respond_to(:balance)
-      Revenue.balance.should > 0
-      Revenue.balance.should be_kind_of(BigDecimal)
-    end
-
-    it "should not report a trial balance" do
-      lambda{Revenue.trial_balance}.should raise_error(NoMethodError)
-    end
-
-    it "should not be valid without a name" do
-      revenue = FactoryGirl.build(:revenue, :name => nil)
-      revenue.should_not be_valid
-    end
-
-    it "should have many credit transactions" do
-      revenue = Factory(:revenue)
-      revenue.should respond_to(:credit_transactions)
-    end
-
-    it "should have many debit transactions" do
-      revenue = Factory(:revenue)
-      revenue.should respond_to(:debit_transactions)
-    end
-
-    it "a contra account should reverse the normal balance" do
-      contra_revenue = Factory(:revenue, :contra => true)
-      # the odd amount below is because factories create an revenue debit_amount
-      FactoryGirl.create(:debit_amount, :account => contra_revenue, :amount => 473) 
-      contra_revenue.balance.should > 0
-      Revenue.balance.should == 0 
-    end
-
+    it_behaves_like 'a Plutus::Account subtype', kind: :revenue, normal_balance: :credit
   end
 end

data/spec/models/transaction_spec.rb

@@ -2,68 +2,76 @@ require 'spec_helper'
 
 module Plutus
   describe Transaction do
+    let(:transaction) { FactoryGirl.build(:transaction) }
+    subject { transaction }
 
-    it "should create a transaction" do
-      transaction = FactoryGirl.build(:transaction_with_credit_and_debit)
-      transaction.save!
-    end
+    it { should_not be_valid }
 
-    it "should not be valid without a credit amount" do
-      transaction = FactoryGirl.build(:transaction)
-      transaction.debit_amounts << FactoryGirl.build(:debit_amount, :transaction => transaction)
-      transaction.should_not be_valid
-      transaction.errors['base'].should include("Transaction must have at least one credit amount")
+    context "with credit and debit" do
+      let(:transaction) { FactoryGirl.build(:transaction_with_credit_and_debit) }
+      it { should be_valid }
+      
+      it "should require a description" do
+        transaction.description = nil
+        transaction.should_not be_valid
+      end
     end
 
-    it "should not be valid with an invalid credit amount" do
-      transaction = FactoryGirl.build(:transaction)
-      transaction.debit_amounts << FactoryGirl.build(:debit_amount, :transaction => transaction)
-      transaction.credit_amounts << FactoryGirl.build(:credit_amount, :transaction => transaction, :amount => nil)
-      transaction.should_not be_valid
-      transaction.errors[:credit_amounts].should == ["is invalid"]
-    end
+    context "with a debit" do
+      before {
+        transaction.debit_amounts << FactoryGirl.build(:debit_amount, transaction: transaction)
+      }
+      it { should_not be_valid }
 
-    it "should not be valid without a debit amount" do
-      transaction = FactoryGirl.build(:transaction)
-      transaction.credit_amounts << FactoryGirl.build(:credit_amount, :transaction => transaction)
-      transaction.should_not be_valid
-      transaction.errors['base'].should include("Transaction must have at least one debit amount")
+      context "with an invalid credit" do
+        before {
+          transaction.credit_amounts << FactoryGirl.build(:credit_amount, transaction: transaction, amount: nil)
+        }
+        it { should_not be_valid }
+      end
     end
 
-    it "should not be valid with an invalid debit amount" do
-      transaction = FactoryGirl.build(:transaction)
-      transaction.credit_amounts << FactoryGirl.build(:credit_amount, :transaction => transaction)
-      transaction.debit_amounts << FactoryGirl.build(:debit_amount, :transaction => transaction, :amount => nil)
-      transaction.should_not be_valid
-      transaction.errors[:debit_amounts].should == ["is invalid"]
-    end
+    context "with a credit" do
+      before {
+        transaction.credit_amounts << FactoryGirl.build(:credit_amount, transaction: transaction)
+      }
+      it { should_not be_valid }
 
-    it "should not be valid without a description" do
-      transaction = FactoryGirl.build(:transaction_with_credit_and_debit, :description => nil)
-      transaction.should_not be_valid
-      transaction.errors[:description].should == ["can't be blank"]
+      context "with an invalid debit" do
+        before {
+          transaction.debit_amounts << FactoryGirl.build(:debit_amount, transaction: transaction, amount: nil)
+        }
+        it { should_not be_valid }
+      end
     end
 
     it "should require the debit and credit amounts to cancel" do
-      transaction = FactoryGirl.build(:transaction)
       transaction.credit_amounts << FactoryGirl.build(:credit_amount, :amount => 100, :transaction => transaction)
       transaction.debit_amounts << FactoryGirl.build(:debit_amount, :amount => 200, :transaction => transaction)
       transaction.should_not be_valid
       transaction.errors['base'].should == ["The credit and debit amounts are not equal"]
     end
 
+    it "should require the debit and credit amounts to cancel even with fractions" do
+      transaction = FactoryGirl.build(:transaction)
+      transaction.credit_amounts << FactoryGirl.build(:credit_amount, :amount => 100.1, :transaction => transaction)
+      transaction.debit_amounts << FactoryGirl.build(:debit_amount, :amount => 100.2, :transaction => transaction)
+      transaction.should_not be_valid
+      transaction.errors['base'].should == ["The credit and debit amounts are not equal"]
+    end
+
     it "should have a polymorphic commercial document associations" do
       mock_document = FactoryGirl.create(:asset) # one would never do this, but it allows us to not require a migration for the test
-      transaction = FactoryGirl.build(:transaction_with_credit_and_debit, :commercial_document => mock_document)
-      transaction.save
+      transaction = FactoryGirl.build(:transaction_with_credit_and_debit, commercial_document: mock_document)
+      transaction.save!
       saved_transaction = Transaction.find(transaction.id)
       saved_transaction.commercial_document.should == mock_document
     end
 
     it "should allow building a transaction and credit and debits with a hash" do
-      FactoryGirl.create(:asset, :name => "Accounts Receivable")
-      FactoryGirl.create(:revenue, :name => "Sales Revenue")
-      FactoryGirl.create(:liability, :name =>  "Sales Tax Payable")
+      FactoryGirl.create(:asset, name: "Accounts Receivable")
+      FactoryGirl.create(:revenue, name: "Sales Revenue")
+      FactoryGirl.create(:liability, name: "Sales Tax Payable")
       mock_document = FactoryGirl.create(:asset)
       transaction = Transaction.build(
         description: "Sold some widgets",
@@ -73,8 +81,8 @@ module Plutus
         credits: [
           {account: "Sales Revenue", amount: 45},
           {account: "Sales Tax Payable", amount: 5}])
-      transaction.should be_valid
-      transaction.save
+      transaction.save!
+
       saved_transaction = Transaction.find(transaction.id)
       saved_transaction.commercial_document.should == mock_document
     end

data/spec/spec_helper.rb

@@ -9,6 +9,7 @@ $: << File.expand_path(File.dirname(__FILE__) + '/../lib/')
 require 'plutus'
 
 Dir[File.expand_path(File.join(File.dirname(__FILE__),'factories','**','*.rb'))].each {|f| require f}
+Dir[File.expand_path(File.join(File.dirname(__FILE__),'support','**','*.rb'))].each {|f| require f}
 
 RSpec.configure do |config|
   config.use_transactional_fixtures = true

data/spec/support/account_shared_examples.rb

@@ -0,0 +1,56 @@
+shared_examples_for 'a Plutus::Account subtype' do |elements|
+  let(:contra) { false }
+  let(:account) { FactoryGirl.create(elements[:kind], contra: contra)}
+  subject { account }
+
+  describe "class methods" do
+    subject { account.class }
+    its(:balance) { should be_kind_of(BigDecimal) }
+    describe "trial_balance" do
+      it "should raise NoMethodError" do
+        lambda { subject.trial_balance }.should raise_error NoMethodError
+      end
+    end
+  end
+
+  describe "instance methods" do
+    its(:balance) { should be_kind_of(BigDecimal) }
+
+    it { should respond_to(:credit_transactions) }
+    it { should respond_to(:debit_transactions) }
+  end
+
+  it "requires a name" do
+    account.name = nil
+    account.should_not be_valid
+  end
+
+  # Figure out which way credits and debits should apply
+  if elements[:normal_balance] == :debit
+     debit_condition = :>
+    credit_condition = :<
+  else
+    credit_condition = :>
+     debit_condition = :<
+  end
+
+  describe "when given a debit" do
+    before { FactoryGirl.create(:debit_amount, account: account) }
+    its(:balance) { should be.send(debit_condition, 0) }
+
+    describe "on a contra account" do
+      let(:contra) { true }
+      its(:balance) { should be.send(credit_condition, 0) }
+    end
+  end
+
+  describe "when given a credit" do
+    before { FactoryGirl.create(:credit_amount, account: account) }
+    its(:balance) { should be.send(credit_condition, 0) }
+
+    describe "on a contra account" do
+      let(:contra) { true }
+      its(:balance) { should be.send(debit_condition, 0) }
+    end
+  end
+end

data/spec/support/amount_shared_examples.rb

@@ -0,0 +1,21 @@
+shared_examples_for 'a Plutus::Amount subtype' do |elements|
+  let(:amount) { FactoryGirl.build(elements[:kind]) }
+  subject { amount }
+  
+  it { should be_valid }
+  
+  it "should require an amount" do
+    amount.amount = nil
+    amount.should_not be_valid
+  end
+
+  it "should require a transaction" do
+    amount.transaction = nil
+    amount.should_not be_valid
+  end
+  
+  it "should require an account" do
+    amount.account = nil
+    amount.should_not be_valid
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: plutus
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.4
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-05 00:00:00.000000000 Z
+date: 2013-04-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -167,62 +167,65 @@ extra_rdoc_files:
 - LICENSE
 - README.markdown
 files:
-- app/assets/javascripts/plutus/application.js
-- app/assets/stylesheets/plutus/application.css
-- app/assets/stylesheets/plutus/main.css.scss
-- app/controllers/plutus/accounts_controller.rb
-- app/controllers/plutus/transactions_controller.rb
-- app/models/plutus/account.rb
-- app/models/plutus/amount.rb
 - app/models/plutus/asset.rb
-- app/models/plutus/credit_amount.rb
-- app/models/plutus/debit_amount.rb
 - app/models/plutus/equity.rb
-- app/models/plutus/expense.rb
+- app/models/plutus/debit_amount.rb
 - app/models/plutus/liability.rb
-- app/models/plutus/revenue.rb
+- app/models/plutus/amount.rb
+- app/models/plutus/amounts_extension.rb
+- app/models/plutus/credit_amount.rb
+- app/models/plutus/account.rb
+- app/models/plutus/expense.rb
 - app/models/plutus/transaction.rb
-- app/views/plutus/accounts/index.html.erb
-- app/views/plutus/accounts/show.html.erb
+- app/models/plutus/revenue.rb
 - app/views/plutus/transactions/index.html.erb
 - app/views/plutus/transactions/show.html.erb
-- config/backtrace_silencers.rb
+- app/views/plutus/accounts/index.html.erb
+- app/views/plutus/accounts/show.html.erb
+- app/assets/javascripts/plutus/application.js
+- app/assets/stylesheets/plutus/main.css.scss
+- app/assets/stylesheets/plutus/application.css
+- app/controllers/plutus/accounts_controller.rb
+- app/controllers/plutus/transactions_controller.rb
+- config/session_store.rb
+- config/secret_token.rb
 - config/database.yml
 - config/inflections.rb
-- config/mime_types.rb
+- config/backtrace_silencers.rb
 - config/routes.rb
-- config/secret_token.rb
-- config/session_store.rb
-- lib/generators/plutus/plutus_generator.rb
-- lib/generators/plutus/templates/migration.rb
-- lib/generators/plutus/USAGE
-- lib/plutus/version.rb
+- config/mime_types.rb
 - lib/plutus.rb
+- lib/plutus/version.rb
+- lib/generators/plutus/USAGE
+- lib/generators/plutus/templates/migration.rb
+- lib/generators/plutus/plutus_generator.rb
 - LICENSE
 - Rakefile
 - README.markdown
-- spec/controllers/accounts_controller_spec.rb
-- spec/controllers/transactions_controller_spec.rb
-- spec/factories/account_factory.rb
-- spec/factories/amount_factory.rb
-- spec/factories/transaction_factory.rb
-- spec/lib/plutus_spec.rb
+- spec/spec_helper.rb
+- spec/models/transaction_spec.rb
+- spec/models/equity_spec.rb
 - spec/models/account_spec.rb
-- spec/models/amount_spec.rb
-- spec/models/asset_spec.rb
+- spec/models/revenue_spec.rb
 - spec/models/credit_amount_spec.rb
-- spec/models/debit_amount_spec.rb
-- spec/models/equity_spec.rb
 - spec/models/expense_spec.rb
+- spec/models/debit_amount_spec.rb
 - spec/models/liability_spec.rb
-- spec/models/revenue_spec.rb
-- spec/models/transaction_spec.rb
-- spec/rcov.opts
-- spec/routing/accounts_routing_spec.rb
-- spec/routing/transactions_routing_spec.rb
+- spec/models/asset_spec.rb
+- spec/models/amount_spec.rb
+- spec/support/amount_shared_examples.rb
+- spec/support/account_shared_examples.rb
 - spec/schema.rb
+- spec/routing/transactions_routing_spec.rb
+- spec/routing/accounts_routing_spec.rb
+- spec/rcov.opts
+- spec/factories/transaction_factory.rb
+- spec/factories/amount_factory.rb
+- spec/factories/account_factory.rb
+- spec/controllers/accounts_controller_spec.rb
+- spec/controllers/transactions_controller_spec.rb
+- spec/lib/plutus_spec.rb
 - spec/spec.opts
-- spec/spec_helper.rb
 homepage: http://github.com/mbulat/plutus
 licenses: []
 post_install_message: 
@@ -248,26 +251,28 @@ signing_key:
 specification_version: 3
 summary: A Plugin providing a Double Entry Accounting Engine for Rails
 test_files:
-- spec/controllers/accounts_controller_spec.rb
-- spec/controllers/transactions_controller_spec.rb
-- spec/factories/account_factory.rb
-- spec/factories/amount_factory.rb
-- spec/factories/transaction_factory.rb
-- spec/lib/plutus_spec.rb
+- spec/spec_helper.rb
+- spec/models/transaction_spec.rb
+- spec/models/equity_spec.rb
 - spec/models/account_spec.rb
-- spec/models/amount_spec.rb
-- spec/models/asset_spec.rb
+- spec/models/revenue_spec.rb
 - spec/models/credit_amount_spec.rb
-- spec/models/debit_amount_spec.rb
-- spec/models/equity_spec.rb
 - spec/models/expense_spec.rb
+- spec/models/debit_amount_spec.rb
 - spec/models/liability_spec.rb
-- spec/models/revenue_spec.rb
-- spec/models/transaction_spec.rb
-- spec/rcov.opts
-- spec/routing/accounts_routing_spec.rb
-- spec/routing/transactions_routing_spec.rb
+- spec/models/asset_spec.rb
+- spec/models/amount_spec.rb
+- spec/support/amount_shared_examples.rb
+- spec/support/account_shared_examples.rb
 - spec/schema.rb
+- spec/routing/transactions_routing_spec.rb
+- spec/routing/accounts_routing_spec.rb
+- spec/rcov.opts
+- spec/factories/transaction_factory.rb
+- spec/factories/amount_factory.rb
+- spec/factories/account_factory.rb
+- spec/controllers/accounts_controller_spec.rb
+- spec/controllers/transactions_controller_spec.rb
+- spec/lib/plutus_spec.rb
 - spec/spec.opts
-- spec/spec_helper.rb
 has_rdoc: