pluto-models 1.2.3 → 1.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 655a0dd8f07d85aca47f4e60daf6fd994b089ef6
-  data.tar.gz: 2babdba51c354d42457844f4ff34d0cde087baba
+  metadata.gz: 0f17253773a7629dbd311e1d3aecb9babfbf50cd
+  data.tar.gz: 57f21b6e70a575e104bbf9d8fbf57cde52148d92
 SHA512:
-  metadata.gz: e24ff26b7b9cfc8d851159c7aa7348be236e5790747ab6e251ca7131179c7893e359372d36441bfe291f92741d3facf15b48f5b9d575e1b3731b8260bed11c58
-  data.tar.gz: 0e84028a50c42762f7cc5968c12940821132591a96edb12045b2cfd3a8c3b0ae8288ba931f360bc7b5a862c9fc7e163890b13acdaecaf9321ab7d798cf02af55
+  metadata.gz: e56ba1c10d02aeec5807a7cc5527711729b74300d4d0b11d472dfc710d5d0338a7d1c2deb348dee41bdcffe7a33f267515aa76b2170b46a83a01580e8af6ef4e
+  data.tar.gz: d3372c8160a1401ae7da82c739348e672aa138a99d1d2b69bdf7374f7c0691dbae7b583fc0a6d6b35f3175055bc0193121018f4bcf0c49c580d85c79cfa3dcc7

data/lib/pluto/models/feed.rb

@@ -12,6 +12,11 @@ class Feed < ActiveRecord::Base
   has_many :sites, :through => :subscriptions
 
 
+  ## todo/fix:
+  ##  use a module ref or something; do NOT include all methods - why? why not? 
+  include TextUtils::HypertextHelper   ## e.g. lets us use strip_tags( ht )
+
+
   def self.latest
     # note: order by first non-null datetime field
     #   coalesce - supported by sqlite (yes), postgres (yes)
@@ -95,6 +100,17 @@ class Feed < ActiveRecord::Base
       generator_full = nil
     end
 
+##
+# todo:
+##  strip all tags from title2
+##  limit to 255 chars
+## e.g. title2 such as this exist
+##  This is a low-traffic announce-only list for people interested
+##  in hearing news about Polymer (<a href="http://polymer-project.org">http://polymer-project.org</a>).
+## The higher-traffic mailing list for all kinds of discussion is
+##  <a href="https://groups.google.com/group/polymer-dev">https://groups.google.com/group/polymer-dev</a>
+
+
     feed_attribs = {
         format:       data.format,
         published:    data.published,
@@ -105,7 +121,7 @@ class Feed < ActiveRecord::Base
         # auto_title:     ???,
         # auto_url:       ???,
         # auto_feed_url:  ???,
-        auto_title2:  data.title2,
+        auto_title2:  data.title2 ? strip_tags(data.title2)[0...255] : data.title2,   # limit to 255 chars; strip tags
         generator:    generator_full
       }
 

data/lib/pluto/models/item.rb

@@ -8,6 +8,11 @@ class Item < ActiveRecord::Base
 
   belongs_to :feed
 
+  ## todo/fix:
+  ##  use a module ref or something; do NOT include all methods - why? why not? 
+  include TextUtils::HypertextHelper   ## e.g. lets us use strip_tags( ht )
+
+
   ##################################
   # attribute reader aliases
   def name()        title;    end  # alias for title
@@ -45,7 +50,7 @@ class Item < ActiveRecord::Base
 
     item_attribs = {
       guid:         data.guid,   # todo: only add for new records???
-      title:        data.title,
+      title:        data.title ? strip_tags(data.title)[0...255] : data.title,   ## limit to 255 chars; strip tags
       url:          data.url,
       summary:      data.summary,
       content:      data.content,

data/lib/pluto/schema.rb

@@ -109,13 +109,15 @@ class CreateDb < ActiveRecord::Migration
       t.string   :guid
       t.string   :url
 
-      ## note: title may contain more than 255 chars!! use text for sure!
+      ## note: title may contain more than 255 chars!!
       ## e.g. Rails Girls blog has massive titles in feed
-      
-      t.text     :title   # todo: add some :null => false ??
+      ## cut-off/limit to 255
+      ##  also strip tags in titles - why? why not?? - see feed.title2/auto_title2
+
+      t.string   :title   # todo: add some :null => false ??
       t.text     :summary  # e.g. description (rss), summary (atom)
       t.text     :content
-      
+
       t.datetime :published   # from feed (published)  + pubDate(rss)
       t.datetime :touched     # from feed updated (atom)
 

data/lib/pluto/version.rb

@@ -4,7 +4,7 @@ module Pluto
 
   MAJOR = 1
   MINOR = 2
-  PATCH = 3
+  PATCH = 4
   VERSION = [MAJOR,MINOR,PATCH].join('.')
 
   def self.version

data/test/test_helpers.rb

@@ -34,4 +34,21 @@ class TestHelper < MiniTest::Test
     assert true   ## if we get here it should workd
   end
 
+
+   include TextUtils::HypertextHelper   ## e.g. lets us use strip_tags( ht )
+
+  def test_feed_title2_sanitize
+##
+# todo:
+##  strip all tags from title2
+##  limit to 255 chars
+## e.g. title2 such as this exist
+
+    title2_in  = %Q{This is a low-traffic announce-only list for people interested in hearing news about Polymer (<a href="http://polymer-project.org">http://polymer-project.org</a>). The higher-traffic mailing list for all kinds of discussion is <a href="https://groups.google.com/group/polymer-dev">https://groups.google.com/group/polymer-dev</a>}
+    title2_out = %Q{This is a low-traffic announce-only list for people interested in hearing news about Polymer (http://polymer-project.org). The higher-traffic mailing list for all kinds of discussion is https://groups.google.com/group/polymer-dev}
+
+    assert_equal title2_out, strip_tags( title2_in )
+    assert_equal 229, strip_tags( title2_in )[0...255].length
+  end
+
 end # class TestHelper

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pluto-models
 version: !ruby/object:Gem::Version
-  version: 1.2.3
+  version: 1.2.4
 platform: ruby
 authors:
 - Gerald Bauer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-13 00:00:00.000000000 Z
+date: 2014-12-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: props