plus_codes 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1da7f815765ecb2206cb0649c9aa38dd3fa74f02
-  data.tar.gz: 31e1d4218ecd47d5430e73b47760ae8acda9d163
+  metadata.gz: 69d6043d4051f33ae155cb1659af7e8e533054ae
+  data.tar.gz: 2eddbf67c2fd1e8ae3b230150868a074d173d41a
 SHA512:
-  metadata.gz: dde33abf4454355f14b1497c82266e97c2e8cfe5b7a6cf0a8567f133ed0d5d225c433cd8a87029a5c8aab87f10f524095254b08f00e035f97c4224c4f92bb192
-  data.tar.gz: 6e01e7ed5b9bfe233a819a6195122e7d5b0af0f7ef53ae3c5f5d962b9d9d8c67e4165c10e1e201a7fdd4cc48851dbc0aa1c057246d3671646d7e93934049f214
+  metadata.gz: 3a1d9f99221ae07169b7dcd1145b7a0a2a863636043fa5f6d602abd919c992e614cd9a2c2f332abd7feb5abb2267406816f4632273f6c93948055c3bb76c632c
+  data.tar.gz: d81015cd0361126dc140b86590bdd28bee3a6f6f26caff6a78a9ef77154c6ced5ebf5992b2b9366a74be16cf56a638b014daa287524feee91fd7c3c30ff4f752

data/lib/plus_codes/open_location_code.rb

@@ -25,16 +25,13 @@ module PlusCodes
       # We can have an even number of padding characters before the separator,
       # but then it must be the final character.
       if code.include?(PADDING)
-        # Not allowed to start with them!
         return false if code.start_with?(PADDING)
-
-        # There can only be one group and it must have even length.
-        pad_match = /(#{PADDING}+)/.match(code).to_a
-        return false if pad_match.length != 2
-        match = pad_match[1]
-        return false if match.length.odd? || match.length > SEPARATOR_POSITION - 2
-
-        # If the code is long enough to end with a separator, make sure it does.
+        pad_match = code.scan(/#{PADDING}+/)
+        return false unless pad_match.one?
+        padding = pad_match[0]
+        return false if padding.length.odd?
+        return false if padding.length > SEPARATOR_POSITION - 2
+        return false if code[-2] != PADDING
         return false if code[-1] != SEPARATOR
       end
 
@@ -312,7 +309,7 @@ module PlusCodes
       lng_place_value = GRID_SIZE_DEGREES
       (0...code.length).each do |i|
         code_index = DECODE[code[i].ord]
-        row = (code_index / GRID_COLUMNS).floor()
+        row = (code_index / GRID_COLUMNS).floor
         col = code_index % GRID_COLUMNS
 
         lat_place_value /= GRID_ROWS

data/lib/plus_codes/version.rb

@@ -1,3 +1,3 @@
 module PlusCodes
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/test/plus_codes_test.rb

@@ -18,7 +18,7 @@ class PlusCodesTest < Test::Unit::TestCase
       is_valid_olc = @olc.valid?(code)
       is_short_olc = @olc.short?(code)
       is_full_olc = @olc.full?(code)
-      result = is_full == is_full_olc && is_short_olc == is_short && is_valid_olc == is_valid
+      result = is_valid_olc == is_valid && is_short_olc == is_short && is_full_olc == is_full
       assert_true(result)
     end
   end
@@ -74,6 +74,10 @@ class PlusCodesTest < Test::Unit::TestCase
     @olc.recover_nearest('9C3W9QCJ+2VX', 51.3708675, -1.217765625)
   end
 
+  def test_valid?_with_speacial_case
+    assert_false(@olc.valid?('3W00CJJJ+'))
+  end
+
   def read_csv_lines(csv_file)
     f = File.open(File.join(@test_data_folder_path, csv_file), 'r')
     f.each_line.lazy.select { |line| line !~ /^\s*#/ }.map { |line| line.chop }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: plus_codes
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Wei-Ming Wu