plurky 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1e3653b3e77fb39e242f9acdd7ab436e0c1d5145
-  data.tar.gz: 770c3bc16d9eec76592317d6f0483bc1d7b5ac9e
+  metadata.gz: affb4e7ec7a48a10738ad091a74854036152f2c1
+  data.tar.gz: da49cd20f548798bad06215c03233d2a02263471
 SHA512:
-  metadata.gz: 3144972a478ce0bed3c6464ca5276d4ee74e1e4cee5d370fe42d1c06eb09e824a2a5424195b7cfd3a36ee5d16168d7e621ac5c213e0fc837d231b6eaec04f0ce
-  data.tar.gz: 00a813bcbbbd046bcf531bef4bcfc52141d77d3634fd2622b8deb7d92b5fa50d22b2583363f4ed86e92b8ea755f2488fddc7e61c89c68b39691db9404c206d1a
+  metadata.gz: 07365e2b2057b6e5bf220d8a62ff1db54456eca470732f881a02cdc4cb485b9daff18242157a76216148e26ccbfbc2ffde5157aecdd0511ec058fcabd25fbf4c
+  data.tar.gz: fee12dc511e6387c2e154b626b694f42ac80b35638911c24d5ce69d0478332c7c5eb2f796a4419398d80a054e0f1fe1f37041b4a50f65fec678ec4b714f089dc

data/README.md

@@ -85,6 +85,8 @@ You can get it from the [test console][].
 
 * Improve test coverage.
 * Add APIs.
+* Catch errors from Plurk.
+* APIs should return consistent data. (e.g. status & update.)
 
 ## Credits
 

data/lib/plurky/api/timeline.rb

@@ -6,21 +6,24 @@ module Plurky
       # @see http://www.plurk.com/API#/APP/Timeline/getPlurk
       # @return [Hashie::Mash] The requested status.
       # @param id [Integer] A status ID.
+      # @param options [Hash] A customizable set of options.
       # @example Return the status with the ID 1001647781
       #   Plurky.status(1001647781)
-      def status(id)
-        object_from_response(:get, "/APP/Timeline/getPlurk", { :plurk_id => id }).plurk
+      def status(id, options = {})
+        get("/APP/Timeline/getPlurk", options.merge(:plurk_id => id))
       end
 
-      private
-
-      # @param method [Symbol]
-      # @param url [String]
-      # @param params [Hash]
-      # @return [Hashie::Mash]
-      def object_from_response(method, url, params = {})
-        response = send(method, url, params)
-        response[:body]
+      # Updates the authenticating user's status
+      #
+      # @see http://www.plurk.com/API#/APP/Timeline/plurkAdd
+      # @return [Hashie::Mash] The created status.
+      # @param content [String] The content of the status update, up to 140 characters.
+      # @param qualifier [String] The qualifier of the status update.
+      # @param options [Hash] A customizable set of options.
+      # @example Update the authenticating user's status
+      #   Plurky.update("I'm plurking with Plurky!", "says")
+      def update(content, qualifier, options = {})
+        post("/APP/Timeline/plurkAdd", options.merge(:content => content, :qualifier => qualifier))
       end
     end
   end

data/lib/plurky/client.rb

@@ -58,7 +58,7 @@ module Plurky
           end
         end
       end
-      response.env
+      response.body
     end
 
     def auth_header(method, uri, params = {})

data/lib/plurky/version.rb

@@ -1,3 +1,3 @@
 module Plurky
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

data/spec/fixtures/update.json

@@ -0,0 +1 @@
+{"replurkers": [], "responses_seen": 0, "qualifier": "says", "replurkers_count": 0, "plurk_id": 1132701414, "response_count": 0, "anonymous": false, "replurkable": true, "limited_to": null, "favorite_count": 0, "is_unread": 0, "lang": "en", "favorers": [], "content_raw": "I'm plurking with Plurky!", "user_id": 5621917, "plurk_type": 0, "replurked": false, "favorite": false, "no_comments": 0, "content": "I'm plurking with Plurky!", "replurker_id": null, "posted": "Sun, 09 Jun 2013 14:37:02 GMT", "owner_id": 5621917}

data/spec/plurky/api/timeline_spec.rb

@@ -17,7 +17,25 @@ describe Plurky::API::Timeline do
     it "returns a correct Hashie::Mash" do
       status = client.status(1001647781)
       expect(status).to be_a Hashie::Mash
-      expect(status.content_raw).to eq "http://ridiculousfish.com/shell/index.html (Finally, a command line shell for the 90s) http://emos.plurk.com/b6ebb0a088fa352ee03ed6f760fb319d_w16_h16.png"
+      expect(status.plurk.content_raw).to eq "http://ridiculousfish.com/shell/index.html (Finally, a command line shell for the 90s) http://emos.plurk.com/b6ebb0a088fa352ee03ed6f760fb319d_w16_h16.png"
+    end
+  end
+
+  describe "#update" do
+    before do
+      stub_post("/APP/Timeline/plurkAdd", :content => "I'm plurking with Plurky!", :qualifier => "says").
+        to_return(json_response("update.json"))
+    end
+
+    it "requests the correct resource" do
+      client.update("I'm plurking with Plurky!", "says")
+      expect(a_post("/APP/Timeline/plurkAdd", :content => "I'm plurking with Plurky!", :qualifier => "says")).to have_been_made
+    end
+
+    it "returns a correct Hashie::Mash" do
+      status = client.update("I'm plurking with Plurky!", "says")
+      expect(status).to be_a Hashie::Mash
+      expect(status.content_raw).to eq "I'm plurking with Plurky!"
     end
   end
 

data/spec/spec_helper.rb

@@ -20,10 +20,18 @@ def a_get(path, query = {})
   a_request(:get, plurk_url(path)).with(:query => query)
 end
 
+def a_post(path, data = {})
+  a_request(:post, plurk_url(path)).with(:body => data)
+end
+
 def stub_get(path, query = {})
   stub_request(:get, plurk_url(path)).with(:query => query)
 end
 
+def stub_post(path, data = {})
+  stub_request(:post, plurk_url(path)).with(:body => data)
+end
+
 def fixtures_path
   File.expand_path("../fixtures", __FILE__)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: plurky
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Chun-wei Kuo
@@ -162,6 +162,7 @@ files:
 - lib/plurky/version.rb
 - plurky.gemspec
 - spec/fixtures/status.json
+- spec/fixtures/update.json
 - spec/plurky/api/timeline_spec.rb
 - spec/plurky/client_spec.rb
 - spec/plurky_spec.rb
@@ -191,6 +192,7 @@ specification_version: 4
 summary: Yet another Plurk API wrapper
 test_files:
 - spec/fixtures/status.json
+- spec/fixtures/update.json
 - spec/plurky/api/timeline_spec.rb
 - spec/plurky/client_spec.rb
 - spec/plurky_spec.rb