pluginator 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a5f89e736b2a03c5c15a34e795805bf9b7bb65de
-  data.tar.gz: 8bffb346e9161538eaddc7387ab0899e485fc927
+  metadata.gz: b6ff46b640ad85f210acebe6882c7ea4cbdf1c0c
+  data.tar.gz: 447d3308d735dd4383a3300294c67ba065d7b986
 SHA512:
-  metadata.gz: 8f3878958c681e05d883c2ee0aace907b31d9500be9ca2fa2f1596bf3bcb2cc582818aae0bc860dd9fd96228fd808050be8357d485aefea81c751439f8d2c0b3
-  data.tar.gz: f112ef035f0632413082f639c29ad89b3e2e1e2324c7ae8cbcfcb718f6faafb198c255d7654b78828c81ea7465c2e19c7cfaf1f73c118527b19074dd054d01a9
+  metadata.gz: 40ea8041c8c585023ef5bc68c623765ca25dc4f002f851bd7a4308f78fd9f6e8865f57f0c6d934720009594e5c6bb05bb2fc4f5539c1f274961212e41e13ce66
+  data.tar.gz: 83d9f189e3b9ab2beb65d87b6da06198a191bdf6e3e5841260295273c08180aaa1e783a4c241ba69810de86989e687d820bb05cd6868cecb8c0cd3d122c0fff7

data/Guardfile

@@ -9,9 +9,9 @@ guard :minitest, :include => %w[lib test], :bundler => false do
     "test/#{m[1]}#{m[2]}_test.rb"
   }
   watch(%r{^test/(.*)\/?(.*)_test\.rb$})
-  watch(%r{^test/test_helper\.rb$})  { 'test' }
+  watch(%r{^test/test_helper\.rb$})  { "test" }
 end
 
-guard 'yard' do
+guard "yard" do
   watch(%r{^lib/.+\.rb})
 end

data/README.md

@@ -2,13 +2,15 @@
 
 [![Gem Version](https://badge.fury.io/rb/pluginator.png)](http://rubygems.org/gems/pluginator)
 [![Code Climate](https://codeclimate.com/github/rvm/pluginator.png)](https://codeclimate.com/github/rvm/pluginator)
-[![Coverage Status](https://coveralls.io/repos/rvm/pluginator/badge.png?branch=master)](https://coveralls.io/r/rvm/pluginator?branch=master)
-[![Build Status](https://travis-ci.org/rvm/pluginator.png?branch=master)](https://travis-ci.org/rvm/pluginator)
+[![Coverage Status](https://coveralls.io/repos/rvm/pluginator/badge.png)](https://coveralls.io/r/rvm/pluginator)
+[![Build Status](https://travis-ci.org/rvm/pluginator.png)](https://travis-ci.org/rvm/pluginator)
 [![Dependency Status](https://gemnasium.com/rvm/pluginator.png)](https://gemnasium.com/rvm/pluginator)
-[![Documentation](http://b.repl.ca/v1/yard-docs-blue.png)](http://rubydoc.info/gems/pluginator/frames)
+[![Inline docs](http://inch-ci.org/github/rvm/pluginator.png)](http://inch-ci.org/github/rvm/pluginator)
+[![Yard Docs](http://img.shields.io/badge/yard-docs-blue.svg)](http://rubydoc.info/github/rvm/pluginator/master/frames)
+[![Github Code](http://img.shields.io/badge/github-code-blue.svg)](https://github.com/rvm/pluginator)
 
 Gem plugin system management, detects plugins using `Gem.find_file`.
-Is only supposed with ruby 1.9.3+ (some tests fail on 1.9.2)
+Is only supposed to work with ruby 1.9.3+ (some tests fail on 1.9.2)
 
 Pluginator tries to stay out of your way, you do not have to include or inherit anything.
 Pluginator only finds and groups plugins, rest is up to you,
@@ -42,7 +44,7 @@ types = rvm2plugins.types
 
 ```ruby
 Pluginator.find("<group>") => Pluginator object
-plugins = Pluginator.find("<group>", type: "<type>", extends: %i{<extensions>})
+plugins = Pluginator.find("<group>", type: "<type>", extends: %i[<extensions>])
 plugins["<type>"] => Array of plugins
 plugins.type      => Array of plugins for type defined with `type: "<type>"`
 plugins.types     => Array of types
@@ -50,7 +52,7 @@ plugins.types     => Array of types
 
 - `"<group>"` - Load plugins for given group.
 - `type: "<type>"` - Load plugins only of given type, makes `type` method accessible.
-- `extends: %i{<extensions>}` - Extend pluginator with given extensions.
+- `extends: %i[<extensions>]` - Extend pluginator with given extensions.
 
 ## Extensions
 
@@ -61,8 +63,8 @@ Pluginator comes with few handful extensions.
 Check if plugin with given class name exists.
 
 ```ruby
-plugins = Pluginator.find("<group>", extends: %i{class_exist})
-plugins.class_exist?( "<type>", "<name>") => true or false
+plugins = Pluginator.find("<group>", extends: %i[class_exist]})
+plugins.class_exist?("<type>", "<name>") => true or false
 ```
 
 ### First ask
@@ -70,7 +72,7 @@ plugins.class_exist?( "<type>", "<name>") => true or false
 Call a method on plugin and return first one that returns `true`.
 
 ```ruby
-plugins = Pluginator.find("<group>", extends: %i{first_ask})
+plugins = Pluginator.find("<group>", extends: %i[first_ask])
 plugins.first_ask( "<type>", "method_to_call", *params) => plugin or nil
 plugins.first_ask!("<type>", "method_to_call", *params) => plugin or exception PluginatorError
 ```
@@ -80,7 +82,7 @@ plugins.first_ask!("<type>", "method_to_call", *params) => plugin or exception P
 Find first plugin that class matches the given name.
 
 ```ruby
-plugins = Pluginator.find("<group>", extends: %i{first_class})
+plugins = Pluginator.find("<group>", extends: %i[first_class])
 plugins.first_class( "<type>", "<name>") => plugin or nil
 plugins.first_class!("<type>", "<name>") => plugin or exception PluginatorError
 ```
@@ -90,7 +92,7 @@ plugins.first_class!("<type>", "<name>") => plugin or exception PluginatorError
 Map array of names to available plugins.
 
 ```ruby
-plugins = Pluginator.find("<group>", extends: %i{matching})
+plugins = Pluginator.find("<group>", extends: %i[matching])
 plugins.matching( "<type>", [<array_of_names>]) => [plugins] # nil for missing ones
 plugins.matching!("<type>", [<array_of_names>]) => [plugins] or exception PluginatorError
 ```
@@ -118,7 +120,7 @@ end
 And now you can use it:
 
 ```ruby
-plugins = Pluginator.find("<group>", extends: %i{first_one})
+plugins = Pluginator.find("<group>", extends: %i[first_one])
 plugins.first_one("<type>") => first_plugin # nil when none
 ```
 
@@ -163,11 +165,11 @@ where `question?` and `answer` are user defined methods
 Now the plugin can be used:
 
 ```ruby
-require 'pluginator'
+require "pluginator"
 
 rvm2plugins = Pluginator.find("rvm2")
 plugin = rvm2plugins["cli"].first{ |plugin|
-  plugin.question?('echo')
+  plugin.question?("echo")
 }
 plugin.new.answer("Hello world")
 ```
@@ -175,9 +177,9 @@ plugin.new.answer("Hello world")
 Or using extensions:
 
 ```ruby
-require 'pluginator'
+require "pluginator"
 
-plugin = Pluginator.find("rvm2", extends: %i{first_ask}).first_ask("cli", &:question?, 'echo')
+plugin = Pluginator.find("rvm2", extends: %i[first_ask]).first_ask("cli", &:question?, "echo")
 plugin.new.answer("Hello world")
 ```
 
@@ -188,7 +190,7 @@ plugin.new.answer("Hello world")
 ```ruby
 class Rvm2::Hooks::AfterInstall::Show
   def self.execute name, path
-    puts "Ruby '#{name}' was installed in '#{path}'."
+    puts "Ruby #{name.inspect} was installed in #{path.inspect}."
   end
 end
 ```
@@ -196,7 +198,7 @@ end
 and using hooks:
 
 ```ruby
-require 'pluginator'
+require "pluginator"
 
 Pluginator.find("rvm2", type: "hooks/after_install").type.each{ |plugin|
   plugin.execute(name, path)

data/lib/pluginator.rb

@@ -24,10 +24,11 @@ require "pluginator/version"
 module Pluginator
   # Find plugins for the given group
   #
-  # @param group [String] name of plugins group
-  # @option type [String] name of type to load
-  # @option extend [Array of/or Symbol] list of extension to extend into pluginator instance
-  # @return instance of Pluginator
+  # @param group   [String] name of plugins group
+  # @param options [Hash]   options to pass to creating Pluginator instance
+  # @option type   [String] name of type to load
+  # @option extend [Array<Symbol>|Symbol] list of extension to extend into pluginator instance
+  # @return [Pluginator::ExtendableAutodetect] instance of Pluginator
   def self.find(group, options = {})
     Pluginator::ExtendableAutodetect.new(group, options)
   end

data/lib/pluginator/autodetect.rb

@@ -28,8 +28,9 @@ module Pluginator
 
     # Automatically load plugins for given group (and type)
     #
-    # @param group [String] name of the plugins group
-    # @option type [String] name of the plugin type
+    # @param group   [String] name of the plugins group
+    # @param options [Hash]   options to pass to creating Pluginator instance
+    # @option type   [String] name of the plugin type
     def initialize(group, options = {})
       super(group)
       setup_autodetect(options[:type])
@@ -67,16 +68,22 @@ module Pluginator
 
     def unique_gemspec_paths(file_names)
       all = gemspec_and_paths(file_names)
-      gemspecs = all.map(&:first)
-      selected =
-      gemspecs.group_by{|spec| spec.name}.map(&:last).map do |specs|
-        activated = specs.find(&:activated?)
-        activated || specs.sort.last
+      selected = active_or_latest_gems_matching(all.map(&:first))
+      all.select do |gemspec, path, name, type|
+        selected.include?(gemspec)
       end
-      all.map do |gemspec, path, name, type|
-        found = selected.find{|spec| spec == gemspec}
-        [found, path, name, type] if found
-      end.compact
+    end
+
+    # filter active / latest gem versions
+    def active_or_latest_gems_matching(specifications)
+      specifications.group_by(&:name).map do |name, specifications|
+        active_or_latest_gemspec(specifications.sort)
+      end
+    end
+
+    # find active or latest gem in given set
+    def active_or_latest_gemspec(specifications)
+      specifications.find(&:activated) || specifications.last
     end
 
     def gemspec_and_paths(file_names)
@@ -107,22 +114,19 @@ module Pluginator
     end
 
     def find_latest_plugin_version(gemspecs, path)
-      gemspecs  = gemspecs.sort_by{|spec| [((spec.metadata||{})[path]||"0").to_i, spec.name, spec.version]}
-      last      = gemspecs.last
-      return last if gemspecs.size == 1
-
-      activated = gemspecs.find(&:activated?)
-      best      = Gem::Specification.find_by_path(path)
-      if
-        (activated.nil? || last == activated) &&
-        !best.activated?
-      then
-        last
-      else
-        best
+      active_or_latest_gemspec(gemspecs_sorted_by_metadata_and_version(gemspecs, path))
+    end
+
+    def gemspecs_sorted_by_metadata_and_version(gemspecs, path)
+      gemspecs.sort_by do |spec|
+        [calculate_plugin_version(spec.metadata, path), spec.name, spec.version]
       end
     end
 
+    def calculate_plugin_version(metadata, path)
+      ((metadata||{})[path]||"0").to_i
+    end
+
     def load_plugin(path)
       require path
       true

data/lib/pluginator/errors.rb

@@ -23,26 +23,28 @@ module Pluginator
   class PluginatorError < RuntimeError
   private
     def list_to_s(list)
-      list.map{|e| "'#{e}'" }.join(", ")
+      list.map{|e| e.to_s.inspect }.join(", ")
     end
   end
 
   # raised when plugin can not be found, generated by `*!` methods
   class MissingPlugin < PluginatorError
+    # initialize new error
     # @param type [String] type of the loaded plugin
     # @param name [String] name of the loaded plugin
     # @param list [Array]  list of available plugins
     def initialize(type, name, list)
-      super("Can not find plugin '#{name}' in #{list_to_s(list)} for type '#{type}'.")
+      super("Can not find plugin #{name.inspect} in #{list_to_s(list)} for type #{type.inspect}.")
     end
   end
 
   # raised when type can not be found, generated by `*!` methods
   class MissingType < PluginatorError
+    # initialize new error
     # @param type [String] type of the loaded plugin
     # @param list [Array]  list of available types
     def initialize(type, list)
-      super("Can not find type '#{type}' in #{list_to_s(list)}.")
+      super("Can not find type #{type.inspect} in #{list_to_s(list)}.")
     end
   end
 end

data/lib/pluginator/extendable_autodetect.rb

@@ -34,9 +34,10 @@ module Pluginator
     # Automatically load plugins for given group (and type)
     # Extend instance with extensions if given.
     #
-    # @param group [String] name of the plugins group
-    # @option type [String] name of type to load
-    # @option extends [Array of/or Symbol] list of extension to extend into pluginator instance
+    # @param group    [String] name of the plugins group
+    # @param options  [Hash]   options to pass to creating Pluginator instance
+    # @option type    [String] name of type to load
+    # @option extends [Array<Symbol>|Symbol] list of extension to extend into pluginator instance
     def initialize(group, options = {})
       super(group, options)
       extend_plugins(options[:extends]||[])
@@ -44,7 +45,7 @@ module Pluginator
 
     # Extend pluginator instance with given extensions
     #
-    # @param extends list of extension to extend into pluginator instance
+    # @param extends [Array<Symbol>|Symbol] list of extension to extend into pluginator instance
     def extend_plugins(extends)
       extensions_matching(extends).each do |plugin|
         extend plugin

data/lib/pluginator/group.rb

@@ -23,6 +23,7 @@ module Pluginator
     # Group name used for plugins
     attr_reader :group
 
+    # sets up new instance and initial configuration
     # @param group [String] name of the plugins group
     def initialize(group)
       setup_group(group)

data/lib/pluginator/version.rb

@@ -19,5 +19,5 @@ along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 
 module Pluginator
   # Version of Pluginator
-  VERSION = "1.2.0"
+  VERSION = "1.3.0"
 end

data/lib/plugins/pluginator/extensions/conversions.rb

@@ -22,18 +22,24 @@ module Pluginator::Extensions
   module Conversions
 
     # converts class name to a file name
+    # @param klass [String] class like string
+    # @return      [String] file like string
     def class2string( klass )
       klass.to_s.gsub(/([A-Z])/m){|match| "_#{$1.downcase}" }[1..-1]
     end
 
     # converts file name to a class name
+    # @param str [String] file like string
+    # @return    [String] class like string
     def string2class( str )
       str.to_s.capitalize.gsub(/_(.)/){ $1.upcase }
     end
 
     # gets class name last part
+    # @param klass [Class]  class to read
+    # @return      [String] the class name only without nesting
     def class2name(klass)
-      klass.name.split('::').last
+      klass.name.split("::").last
     end
 
   end

data/lib/plugins/pluginator/extensions/first_ask.rb

@@ -30,7 +30,7 @@ module Pluginator::Extensions
     # @param type [String] name of type to search for plugins
     # @param method_name [Symbol] name of the method to execute
     # @param params [Array] params to pass to the called method
-    # @return The first plugin that method call returns true
+    # @return [Class] The first plugin that method call returns true
     def first_ask(type, method_name, *params)
       @plugins[type] or return nil
       try_to_find(type, method_name, params)
@@ -38,6 +38,11 @@ module Pluginator::Extensions
 
     # Call a method on plugin and return first one that returns `true`.
     # Behaves like `first_ask` but throws exceptions if can not find anything.
+    # @param type [String] name of type to search for plugins
+    # @param method_name [Symbol] name of the method to execute
+    # @param params [Array] params to pass to the called method
+    # @return [Class] The first plugin that method call returns true
+    # @raise [Pluginator::MissingPlugin] when can not find plugin
     def first_ask!(type, method_name, *params)
       @plugins[type] or raise Pluginator::MissingType.new(type, @plugins.keys)
       try_to_find(type, method_name, params) or

data/lib/plugins/pluginator/extensions/first_class.rb

@@ -29,15 +29,19 @@ module Pluginator::Extensions
 
     # Find first plugin that clas matches the given name.
     #
-    # @param type [String] name of type to search for plugins
-    # @param klass [Symbol or String] name of the searched class
-    # @return The first plugin that matches the klass
+    # @param type  [String] name of type to search for plugins
+    # @param klass [Symbol|String] name of the searched class
+    # @return      [Class] The first plugin that matches the klass
     def first_class(type, klass)
       (plugins_map(type) || {})[string2class(klass)]
     end
 
     # Find first plugin that clas matches the given name.
     # Behaves like `first_class` but throws exceptions if can not find anything.
+    # @param type  [String] name of type to search for plugins
+    # @param klass [Symbol|String] name of the searched class
+    # @return      [Class] The first plugin that matches the klass
+    # @raise [Pluginator::MissingPlugin] when can not find plugin
     def first_class!(type, klass)
       @plugins[type] or raise Pluginator::MissingType.new(type, @plugins.keys)
       klass = string2class(klass)

data/lib/plugins/pluginator/extensions/matching.rb

@@ -29,8 +29,8 @@ module Pluginator::Extensions
     # Map array of names to available plugins.
     #
     # @param type [String] name of type to search for plugins
-    # @param list [Array] list of plugin names to load
-    # @return [Array] list of loaded plugins
+    # @param list [Array]  list of plugin names to load
+    # @return     [Array]  list of loaded plugins
     def matching(type, list)
       list.map do |plugin|
         (plugins_map(type) || {})[string2class(plugin)]
@@ -39,6 +39,10 @@ module Pluginator::Extensions
 
     # Map array of names to available plugins.
     # Behaves like `matching` but throws exceptions if can not find anything.
+    # @param type [String] name of type to search for plugins
+    # @param list [Array]  list of plugin names to load
+    # @return     [Array]  list of loaded plugins
+    # @raise [Pluginator::MissingPlugin] when can not find plugin
     def matching!(type, list)
       @plugins[type] or raise Pluginator::MissingType.new(type, @plugins.keys)
       list.map do |plugin|

data/pluginator.gemspec

@@ -23,7 +23,7 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "pluginator/version"
 

data/test/gems/gems/fake-gem-name-activated-1.0.0/lib/fake-gem-name-activated.rb

@@ -0,0 +1 @@
+

data/test/gems/gems/fake-gem-name-activated-1.0.0/lib/plugins/activated/version1/max.rb

@@ -0,0 +1,29 @@
+=begin
+Copyright 2013 Michal Papis <mpapis@gmail.com>
+
+This file is part of pluginator.
+
+pluginator is free software: you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published
+by the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+pluginator is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
+=end
+
+class Activated::Version1::Max
+
+  def self.handles?(what)
+    %w{ max maximum }.include?(what)
+  end
+
+  def self.action
+    41
+  end
+end

data/test/gems/gems/fake-gem-name-activated-2.0.0/lib/fake-gem-name-activated.rb

@@ -0,0 +1 @@
+

data/test/gems/gems/fake-gem-name-activated-2.0.0/lib/plugins/activated/version1/max.rb

@@ -0,0 +1,29 @@
+=begin
+Copyright 2013 Michal Papis <mpapis@gmail.com>
+
+This file is part of pluginator.
+
+pluginator is free software: you can redistribute it and/or modify
+it under the terms of the GNU Lesser General Public License as published
+by the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+pluginator is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU Lesser General Public License for more details.
+
+You should have received a copy of the GNU Lesser General Public License
+along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
+=end
+
+class Activated::Version1::Max
+
+  def self.handles?(what)
+    %w{ max maximum }.include?(what)
+  end
+
+  def self.action
+    42
+  end
+end

data/test/gems/specifications/fake-gem-name-activated-1.0.0.gemspec

@@ -0,0 +1,21 @@
+# -*- encoding: utf-8 -*-
+# stub: fake-gem-name-activated 1.0.0 ruby lib
+
+Gem::Specification.new do |s|
+  s.name = "fake-gem-name-activated"
+  s.version = "1.0.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
+  s.authors = ["Michal Papis"]
+  s.date = "2014-09-21"
+  s.description = "Do nothing"
+  s.email = ["mpapis@gmail.com"]
+  s.files = Dir["../../gems/#{s.name}-#{s.version}/lib/**/*.rb"]
+  s.homepage = "https://rvm.io"
+  s.licenses = ["LGPL v3"]
+  s.rubygems_version = "2.2.2"
+  s.summary = "Do Nothing"
+
+  s.installed_by_version = "2.2.2" if s.respond_to? :installed_by_version
+end

data/test/gems/specifications/fake-gem-name-activated-2.0.0.gemspec

@@ -0,0 +1,21 @@
+# -*- encoding: utf-8 -*-
+# stub: fake-gem-name-activated 2.0.0 ruby lib
+
+Gem::Specification.new do |s|
+  s.name = "fake-gem-name-activated"
+  s.version = "2.0.0"
+
+  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib"]
+  s.authors = ["Michal Papis"]
+  s.date = "2014-09-21"
+  s.description = "Do nothing"
+  s.email = ["mpapis@gmail.com"]
+  s.files = Dir["../../gems/#{s.name}-#{s.version}/lib/**/*.rb"]
+  s.homepage = "https://rvm.io"
+  s.licenses = ["LGPL v3"]
+  s.rubygems_version = "2.2.2"
+  s.summary = "Do Nothing"
+
+  s.installed_by_version = "2.2.2" if s.respond_to? :installed_by_version
+end

data/test/pluginator/autodetect_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'pluginator/autodetect'
+require "test_helper"
+require "pluginator/autodetect"
 
 def gem_file(path, options = {})
   options.merge!({
@@ -87,19 +87,38 @@ describe Pluginator::Autodetect do
 
     it "loads files" do
       @pluginator.send(:load_files, @math_files)
-      @pluginator.types.must_include('math')
+      @pluginator.types.must_include("math")
       plugins = @pluginator["math"].map(&:to_s)
       plugins.size.must_equal(2)
       plugins.must_include("Something::Math::Increase")
       plugins.must_include("Something::Math::Decrease")
       plugins.wont_include("Something::Math::Substract")
     end
+
+    it "finds unique gems for paths" do
+      @pluginator.send(:gemspec_and_paths, @math_files).map{ |gemspec, path, name, type|
+        [gemspec.name, gemspec.version.to_s, path, name, type]
+      }.must_equal([
+        ["fake-gem-name-a", "1.0.0", "plugins/something/math/decrease.rb", "something/math/decrease", "math"],
+        ["fake-gem-name-a", "1.0.0", "plugins/something/math/increase.rb", "something/math/increase", "math"],
+      ])
+    end
+
+    it "finds unique gems for paths" do
+      @pluginator.send(:unique_gemspec_paths, @math_files).map{ |gemspec, path, name, type|
+        [gemspec.name, gemspec.version.to_s, path, name, type]
+      }.must_equal([
+        ["fake-gem-name-a", "1.0.0", "plugins/something/math/decrease.rb", "something/math/decrease", "math"],
+        ["fake-gem-name-a", "1.0.0", "plugins/something/math/increase.rb", "something/math/increase", "math"],
+      ])
+    end
+
   end
 
   it "loads plugins automatically for group" do
     pluginator = Pluginator::Autodetect.new("something")
-    pluginator.types.must_include('stats')
-    pluginator.types.must_include('math')
+    pluginator.types.must_include("stats")
+    pluginator.types.must_include("math")
     pluginator.types.size.must_equal(3)
     plugins = pluginator["math"].map(&:to_s)
     plugins.size.must_equal(2)
@@ -110,13 +129,13 @@ describe Pluginator::Autodetect do
 
   it "loads plugins automatically for group/type" do
     pluginator = Pluginator::Autodetect.new("something", :type => "stats")
-    pluginator.types.must_include('stats')
+    pluginator.types.must_include("stats")
     pluginator.types.size.must_equal(1)
   end
 
   it "makes group plugins work" do
     pluginator = Pluginator::Autodetect.new("something")
-    pluginator.types.must_include('math')
+    pluginator.types.must_include("math")
     pluginator["math"].detect{|plugin| plugin.type == "increase" }.action(2).must_equal(3)
     pluginator["math"].detect{|plugin| plugin.type == "decrease" }.action(5).must_equal(4)
   end
@@ -130,13 +149,13 @@ describe Pluginator::Autodetect do
   end
 
   it "defines type method dynamically" do
-    pluginator = Pluginator::Autodetect.new("something", :type => 'math')
-    pluginator.type.must_equal(pluginator['math'])
+    pluginator = Pluginator::Autodetect.new("something", :type => "math")
+    pluginator.type.must_equal(pluginator["math"])
   end
 
   it "loads self" do
     pluginator = Pluginator::Autodetect.new("pluginator")
-    pluginator.types.must_include('extensions')
+    pluginator.types.must_include("extensions")
     pluginator.types.size.must_equal(1)
     pluginator["extensions"].map(&:to_s).sort.must_equal([
       "Pluginator::Extensions::ClassExist",

data/test/pluginator/extendable_autodetect_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'pluginator/extendable_autodetect'
+require "test_helper"
+require "pluginator/extendable_autodetect"
 
 describe Pluginator::ExtendableAutodetect do
   it "loads existing extensions - array" do

data/test/pluginator/group_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'pluginator/group'
+require "test_helper"
+require "pluginator/group"
 
 describe Pluginator::Group do
   it "has name" do

data/test/pluginator/name_converter_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'pluginator/name_converter'
+require "test_helper"
+require "pluginator/name_converter"
 
 class Converter
   extend Pluginator::NameConverter

data/test/pluginator_test.rb

@@ -17,15 +17,15 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'pluginator'
+require "test_helper"
+require "pluginator"
 
 describe Pluginator do
   it "loads_plugins_automatically_for_group" do
     pluginator = Pluginator.find("something")
-    pluginator.types.must_include('stats')
-    pluginator.types.must_include('math')
-    pluginator.types.must_include('nested/structure')
+    pluginator.types.must_include("stats")
+    pluginator.types.must_include("math")
+    pluginator.types.must_include("nested/structure")
     pluginator.types.size.must_equal(3)
     plugins = pluginator["math"].map(&:to_s)
     plugins.size.must_equal(2)
@@ -36,7 +36,7 @@ describe Pluginator do
 
   it "loads_plugins_automatically_for_group_type" do
     pluginator = Pluginator.find("something", :type => "stats")
-    pluginator.types.must_include('stats')
+    pluginator.types.must_include("stats")
     pluginator.types.size.must_equal(1)
   end
 
@@ -49,7 +49,7 @@ describe Pluginator do
 
   it "loads_nested_plugins" do
     pluginator = Pluginator.find("something")
-    pluginator.types.must_include('nested/structure')
+    pluginator.types.must_include("nested/structure")
     pluginator["nested/structure"].map(&:to_s).must_equal(["Something::Nested::Structure::Test"])
   end
 
@@ -67,12 +67,31 @@ describe Pluginator do
     active_gems.wont_include("fake-gem-name-latest-1.0.0")
     active_gems.must_include("fake-gem-name-latest-2.0.0")
 
-    pluginator.types.must_include('version2')
-    pluginator.types.wont_include('version1')
+    pluginator.types.must_include("version2")
+    pluginator.types.wont_include("version1")
     pluginator.types.size.must_equal(1)
     pluginator["version2"].map(&:to_s).must_equal(["Latest::Version2::Max"])
   end
 
+  it "loads_only_plugins_from_activated_version_of_gem" do
+    all_gems = Gem::Specification._all.map{|s| "#{s.name}-#{s.version}" }
+    all_gems.must_include("fake-gem-name-activated-1.0.0")
+    all_gems.must_include("fake-gem-name-activated-2.0.0")
+    Gem::Specification._all.find{|s| [s.name, s.version.to_s] == ["fake-gem-name-activated", "1.0.0"] }.activate
+    active_gems = Gem::Specification._all.map{|s| "#{s.name}-#{s.version}" if s.activated? }.compact
+    active_gems.must_include("fake-gem-name-activated-1.0.0")
+    active_gems.wont_include("fake-gem-name-activated-2.0.0")
+
+    pluginator = Pluginator.find("activated")
+
+    active_gems = Gem::Specification._all.map{|s| "#{s.name}-#{s.version}" if s.activated? }.compact
+    active_gems.must_include("fake-gem-name-activated-1.0.0")
+
+    pluginator.types.must_include("version1")
+    pluginator.types.size.must_equal(1)
+    pluginator["version1"].map(&:to_s).must_equal(["Activated::Version1::Max"])
+  end
+
   it "loads_latest_version_of_plugin_from_two_gems_v1" do
     all_gems = Gem::Specification._all.map{|s| "#{s.name}-#{s.version}" }
     all_gems.must_include("fake-gem-name-v1a-1.0.0")
@@ -86,7 +105,7 @@ describe Pluginator do
     active_gems.wont_include("fake-gem-name-v1a-1.0.0")
     active_gems.must_include("fake-gem-name-v1b-1.0.0")
 
-    pluginator.types.must_include('stats')
+    pluginator.types.must_include("stats")
     pluginator.types.size.must_equal(1)
     pluginator["stats"].map(&:to_s).must_equal(["V1test::Stats::Max"])
     pluginator["stats"].first.action.must_equal(42)
@@ -105,7 +124,7 @@ describe Pluginator do
     active_gems.must_include("fake-gem-name-v2a-1.0.0")
     active_gems.wont_include("fake-gem-name-v2b-1.0.0")
 
-    pluginator.types.must_include('stats')
+    pluginator.types.must_include("stats")
     pluginator.types.size.must_equal(1)
     pluginator["stats"].map(&:to_s).must_equal(["V2test::Stats::Max"])
     pluginator["stats"].first.action.must_equal(41)

data/test/plugins_test/extensions/class_exist_test.rb

@@ -17,9 +17,9 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/class_exist'
-require 'plugins/something/stats/max'
+require "test_helper"
+require "plugins/pluginator/extensions/class_exist"
+require "plugins/something/stats/max"
 
 class ClassExistTester
   attr_accessor :plugins

data/test/plugins_test/extensions/conversions_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/conversions'
+require "test_helper"
+require "plugins/pluginator/extensions/conversions"
 
 class ConversionsTester
   extend Pluginator::Extensions::Conversions
@@ -26,9 +26,9 @@ end
 
 describe Pluginator::Extensions::Conversions do
   it "class2string" do
-    ConversionsTester.class2string('SomethingLong').must_match('something_long')
+    ConversionsTester.class2string("SomethingLong").must_match("something_long")
   end
   it "string2class" do
-    ConversionsTester.string2class('something_long').must_match('SomethingLong')
+    ConversionsTester.string2class("something_long").must_match("SomethingLong")
   end
 end

data/test/plugins_test/extensions/first_ask_test.rb

@@ -17,9 +17,9 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/first_ask'
-require 'plugins/something/stats/max'
+require "test_helper"
+require "plugins/pluginator/extensions/first_ask"
+require "plugins/something/stats/max"
 
 class FirstAskTester
   attr_accessor :plugins

data/test/plugins_test/extensions/first_class_test.rb

@@ -17,9 +17,9 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/first_class'
-require 'plugins/something/stats/max'
+require "test_helper"
+require "plugins/pluginator/extensions/first_class"
+require "plugins/something/stats/max"
 
 class FirstClassTester
   attr_accessor :plugins

data/test/plugins_test/extensions/matching_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/matching'
+require "test_helper"
+require "plugins/pluginator/extensions/matching"
 
 class MatchingTester
   attr_accessor :plugins

data/test/plugins_test/extensions/plugins_map_test.rb

@@ -17,8 +17,8 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'test_helper'
-require 'plugins/pluginator/extensions/plugins_map'
+require "test_helper"
+require "plugins/pluginator/extensions/plugins_map"
 
 class PluginsMapTester
   attr_accessor :plugins

data/test/test_helper.rb

@@ -19,11 +19,11 @@ You should have received a copy of the GNU Lesser General Public License
 along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
 =end
 
-require 'rubygems'
-require 'minitest'
+require "rubygems"
+require "minitest"
 
 # fix lib in LOAD_PATH and load version for gems manipulation
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "pluginator/version"
 
@@ -42,7 +42,7 @@ Gem.refresh
 
 # make sure pluginator is available as gem for tests of pluginator plugins
 #Gem::Specification.add_spec(Gem::Specification.load(File.expand_path("../gems/specifications/pluginator-#{Pluginator::VERSION}.gemspec", __FILE__)))
-gem 'pluginator'
+gem "pluginator"
 
 if
   RUBY_VERSION == "2.0.0" && # check Gemfile
@@ -60,7 +60,7 @@ then
     add_filter "/test/"
   end
 
-  Coveralls.noisy = true unless ENV['CI']
+  Coveralls.noisy = true unless ENV["CI"]
 end
 
 module Something
@@ -70,6 +70,9 @@ module Something
     module Structure; end
   end
 end
+module Activated
+  module Version1; end
+end
 module Latest
   module Version1; end
   module Version2; end
@@ -81,5 +84,5 @@ module V2test
   module Stats; end
 end
 
-require 'minitest/autorun' unless $0=="-e" # skip in guard
-require 'minitest/unit'
+require "minitest/autorun" unless $0=="-e" # skip in guard
+require "minitest/unit"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pluginator
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Michal Papis
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-24 00:00:00.000000000 Z
+date: 2014-10-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -78,6 +78,10 @@ files:
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/math/increase.rb
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/nested/structure/test.rb
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/stats/max.rb
+- test/gems/gems/fake-gem-name-activated-1.0.0/lib/fake-gem-name-activated.rb
+- test/gems/gems/fake-gem-name-activated-1.0.0/lib/plugins/activated/version1/max.rb
+- test/gems/gems/fake-gem-name-activated-2.0.0/lib/fake-gem-name-activated.rb
+- test/gems/gems/fake-gem-name-activated-2.0.0/lib/plugins/activated/version1/max.rb
 - test/gems/gems/fake-gem-name-latest-1.0.0/lib/fake-gem-name-latest.rb
 - test/gems/gems/fake-gem-name-latest-1.0.0/lib/plugins/latest/version1/max.rb
 - test/gems/gems/fake-gem-name-latest-2.0.0/lib/fake-gem-name-latest.rb
@@ -91,13 +95,14 @@ files:
 - test/gems/gems/fake-gem-name-v2b-1.0.0/lib/fake-gem-name-v2b.rb
 - test/gems/gems/fake-gem-name-v2b-1.0.0/lib/plugins/v2test/stats/max.rb
 - test/gems/specifications/fake-gem-name-a-1.0.0.gemspec
+- test/gems/specifications/fake-gem-name-activated-1.0.0.gemspec
+- test/gems/specifications/fake-gem-name-activated-2.0.0.gemspec
 - test/gems/specifications/fake-gem-name-latest-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-latest-2.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v1a-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v1b-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v2a-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v2b-1.0.0.gemspec
-- test/gems/specifications/pluginator-1.1.0.gemspec
 - test/pluginator/autodetect_test.rb
 - test/pluginator/extendable_autodetect_test.rb
 - test/pluginator/group_test.rb
@@ -140,6 +145,10 @@ test_files:
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/math/increase.rb
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/nested/structure/test.rb
 - test/gems/gems/fake-gem-name-a-1.0.0/lib/plugins/something/stats/max.rb
+- test/gems/gems/fake-gem-name-activated-1.0.0/lib/fake-gem-name-activated.rb
+- test/gems/gems/fake-gem-name-activated-1.0.0/lib/plugins/activated/version1/max.rb
+- test/gems/gems/fake-gem-name-activated-2.0.0/lib/fake-gem-name-activated.rb
+- test/gems/gems/fake-gem-name-activated-2.0.0/lib/plugins/activated/version1/max.rb
 - test/gems/gems/fake-gem-name-latest-1.0.0/lib/fake-gem-name-latest.rb
 - test/gems/gems/fake-gem-name-latest-1.0.0/lib/plugins/latest/version1/max.rb
 - test/gems/gems/fake-gem-name-latest-2.0.0/lib/fake-gem-name-latest.rb
@@ -153,13 +162,14 @@ test_files:
 - test/gems/gems/fake-gem-name-v2b-1.0.0/lib/fake-gem-name-v2b.rb
 - test/gems/gems/fake-gem-name-v2b-1.0.0/lib/plugins/v2test/stats/max.rb
 - test/gems/specifications/fake-gem-name-a-1.0.0.gemspec
+- test/gems/specifications/fake-gem-name-activated-1.0.0.gemspec
+- test/gems/specifications/fake-gem-name-activated-2.0.0.gemspec
 - test/gems/specifications/fake-gem-name-latest-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-latest-2.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v1a-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v1b-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v2a-1.0.0.gemspec
 - test/gems/specifications/fake-gem-name-v2b-1.0.0.gemspec
-- test/gems/specifications/pluginator-1.1.0.gemspec
 - test/pluginator/autodetect_test.rb
 - test/pluginator/extendable_autodetect_test.rb
 - test/pluginator/group_test.rb

data/test/gems/specifications/pluginator-1.1.0.gemspec

@@ -1,44 +0,0 @@
-#!/usr/bin/env ruby
-# -*- encoding: utf-8 -*-
-# stub: PLUGINATOR ruby lib
-
-=begin
-Copyright 2013
-- Michal Papis <mpapis@gmail.com>
-- Jordon Bedwell <envygeeks@gmail.com>
-
-This file is part of pluginator.
-
-pluginator is free software: you can redistribute it and/or modify
-it under the terms of the GNU Lesser General Public License as published
-by the Free Software Foundation, either version 3 of the License, or
-(at your option) any later version.
-
-pluginator is distributed in the hope that it will be useful,
-but WITHOUT ANY WARRANTY; without even the implied warranty of
-MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-GNU Lesser General Public License for more details.
-
-You should have received a copy of the GNU Lesser General Public License
-along with pluginator.  If not, see <http://www.gnu.org/licenses/>.
-=end
-
-lib = File.expand_path('../lib', __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "pluginator/version"
-
-Gem::Specification.new do |s|
-  s.email = ["mpapis@gmail.com", "envygeeks@gmail.com", "mose@mose.com"]
-  s.authors = ["Michal Papis", "Jordon Bedwell", "Mose"]
-  s.name = "pluginator"
-  s.version = Pluginator::VERSION
-  s.license = "LGPL v3"
-  s.files = `git ls-files`.split("\n")
-  s.required_ruby_version = ">= 1.8.7"
-  s.add_development_dependency("rake")
-  s.add_development_dependency("minitest")
-  # s.add_development_dependency("smf-gem")
-  s.homepage = "https://github.com/rvm/pluginator"
-  s.summary = "Rubygems plugin system using Gem.find_files."
-  s.test_files = `git ls-files -- {test,spec,features}/*`.split("\n")
-end