pluginator 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
----
-SHA1:
-  metadata.gz: b70400f4d804c2f5916e9e68056db1287345f508
-  data.tar.gz: 5ebb958035ec8e95699a3ce44b86327acd8276c4
-SHA512:
-  metadata.gz: 6c51706e34d5d00c1e60406cb5c897d4e726159ee368aa7929ecd8cf2a08c911e5c05e79acc603e8eedcd63a21e2491e30e07320ae423e102e2a1d4e3335ce3d
-  data.tar.gz: 3f19a9c45614acaa882c289155cf0686970fbeda14390483f526573fcf87c61b4baf9547c9e15ccd5c7c1b2cf11662859d067ec8bce792154dd9e048cde0986d
+--- 
+SHA512: 
+  data.tar.gz: 8978e772d2d9611da6f0237fceff4349308c1b882d9a677a1b7a98f03671e1b9c2d130656c9283027bddcc4e28a03ac092fdb27e020ef04deb4eaf4aa650c36a
+  metadata.gz: 9d61123257259cdd06fa87e89063aebb068bef8611ba0bdb2838e93580dec662e9a79423c42f832781e54a8000d061aa408fa683e5703d7ab1794aa9967470c9
+SHA1: 
+  data.tar.gz: 5681dfc0f9982ecb005834e0aa96fa832895bdda
+  metadata.gz: 3e87d0ef8aa32713ffc2e72eae88224c5f1cf227

data/Changelog.md

@@ -0,0 +1,12 @@
+# Changelog
+
+## 1.0.1
+date: 2013-12-25
+
+- divide first_ask code into smaller methods, remove duplication
+- add conversiosn helper class2name
+
+## 1.0.0
+date: 2013-12-20
+
+- Stable version released

data/lib/pluginator/version.rb

@@ -1,4 +1,4 @@
 module Pluginator
   # Version of Pluginator
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/plugins/pluginator/extensions/conversions.rb

@@ -12,5 +12,10 @@ module Pluginator::Extensions
       str.to_s.capitalize.gsub(/_(.)/){ $1.upcase }
     end
 
+    # gets class name last part
+    def class2name(klass)
+      klass.name.split('::').last
+    end
+
   end
 end

data/lib/plugins/pluginator/extensions/first_ask.rb

@@ -14,21 +14,29 @@ module Pluginator::Extensions
     # @return The first plugin that method call returns true
     def first_ask(type, method_name, *params)
       @plugins[type] or return nil
-      @plugins[type].detect do |plugin|
-        plugin.public_methods.map(&:to_sym).include?(method_name.to_sym) &&
-        plugin.send(method_name.to_sym, *params)
-      end
+      try_to_find(type, method_name, params)
     end
 
     # Call a method on plugin and return first one that returns `true`.
     # Behaves like `first_ask` but throws exceptions if can not find anything.
     def first_ask!(type, method_name, *params)
       @plugins[type] or raise Pluginator::MissingType.new(type, @plugins.keys)
+      try_to_find(type, method_name, params) or
+      raise Pluginator::MissingPlugin.new(type, "first_ask: #{method_name}", plugins_map(type).keys)
+    end
+
+  private
+
+    def try_to_find(type, method_name, params)
       @plugins[type].detect do |plugin|
-        plugin.public_methods.map(&:to_sym).include?(method_name.to_sym) &&
-        plugin.send(method_name, *params)
-      end or
-        raise Pluginator::MissingPlugin.new(type, "first_ask: #{method_name}", plugins_map(type).keys)
+        has_public_method?(plugin, method_name) &&
+        plugin.send(method_name.to_sym, *params)
+      end
+    end
+
+    # need to use this trick because of old rubies support
+    def has_public_method?(plugin, method_name)
+      plugin.public_methods.map(&:to_sym).include?(method_name.to_sym)
     end
 
   end

data/lib/plugins/pluginator/extensions/plugins_map.rb

@@ -1,6 +1,10 @@
+require "plugins/pluginator/extensions/conversions"
+
 module Pluginator::Extensions
   # extend Pluginator with map of plugins: name => klass
   module PluginsMap
+    include Conversions
+
     # provide extra map of plugins with symbolized names as keys
     #
     # @param type [String] name of type to generate the map for
@@ -8,7 +12,7 @@ module Pluginator::Extensions
     def plugins_map( type )
       @plugins_map ||= {}
       type = type.to_s
-      @plugins_map[type] ||= Hash[ @plugins[type].map{|plugin| [plugin.name.split('::').last, plugin] } ]
+      @plugins_map[type] ||= Hash[ @plugins[type].map{|plugin| [class2name(plugin), plugin] } ]
     end
   end
 end

metadata

@@ -1,52 +1,48 @@
---- !ruby/object:Gem::Specification
+--- !ruby/object:Gem::Specification 
 name: pluginator
-version: !ruby/object:Gem::Version
-  version: 1.0.0
+version: !ruby/object:Gem::Version 
+  version: 1.0.1
 platform: ruby
-authors:
+authors: 
 - Michal Papis
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-20 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
+
+date: 2013-12-25 00:00:00 Z
+dependencies: 
+- !ruby/object:Gem::Dependency 
   name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    requirements: 
+    - &id002 
+      - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
   type: :development
+  version_requirements: *id001
+- !ruby/object:Gem::Dependency 
+  name: minitest
   prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    requirements: 
+    - *id002
+  type: :development
+  version_requirements: *id003
 description: 
-email:
+email: 
 - mpapis@gmail.com
 executables: []
+
 extensions: []
+
 extra_rdoc_files: []
-files:
+
+files: 
 - .gitignore
 - .travis.yml
+- Changelog.md
 - Gemfile
 - README.md
 - Rakefile
@@ -82,28 +78,30 @@ files:
 - test/test_helper.rb
 homepage: https://github.com/rvm/pluginator
 licenses: []
+
 metadata: {}
+
 post_install_message: 
 rdoc_options: []
-require_paths:
+
+require_paths: 
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement
-  requirements:
-  - - '>='
-    - !ruby/object:Gem::Version
+required_ruby_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - - ">="
+    - !ruby/object:Gem::Version 
       version: 1.8.7
-required_rubygems_version: !ruby/object:Gem::Requirement
-  requirements:
-  - - '>='
-    - !ruby/object:Gem::Version
-      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements: 
+  - *id002
 requirements: []
+
 rubyforge_project: 
 rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: Rubygems plugin system using Gem.find_files.
-test_files:
+test_files: 
 - test/pluginator/autodetect_test.rb
 - test/pluginator/extendable_autodetect_test.rb
 - test/pluginator/group_test.rb