plug 0.1.23 → 0.1.24

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: eb469dfe189640aa012dfba0b1784b6b58af48ab0a72f43f86e18aa9557cf342
-  data.tar.gz: b0ecc6ea23fdbfc103e4b66fbd7ac98c6acbad94e580e2b9372cbc5aa4445607
+  metadata.gz: b83146ab631927c0756e4f9e1db5224b731e7ff6f3cb34504cc52f687c0294de
+  data.tar.gz: 8cb113cc3497c15054b62198c7fb8ab66583ace08b346481eac56e6d467b36eb
 SHA512:
-  metadata.gz: 88ed333f9efd4189debd2e8b892d3da8a33775a1d47919bab8819314b5b0860bb76f0892cb97dee6b93771a5dc543c6c528f3216d42872f5054f0313a5e9840a
-  data.tar.gz: ca7f17e98fc0902191b0734b61c6cb69a4adff7ca3ba7ba1eee7342b0d049793bc06c8022ebf421f1fab2b813ea847432d62f429f2518f44718a8aa41ae2847f
+  metadata.gz: 0a1fc2650f634afa48066f635f1c911248a684074243afdacb27a679191a7ad8d6330c8c479825b7a5cdfd59d70409430d4ea615ed426bf0475d48bfba88a3ea
+  data.tar.gz: b7cc1b56cd7d2da25f23012f76ecf773b59366fdb37bb5614cb08b5e1391982e0e38d8abe33efee817c7b6b03a05b5e4d0a0e5ea55b039e1c39f7d781de267cf

data/README.md

@@ -1,4 +1,4 @@
-# Plug [![Maintainability](https://api.codeclimate.com/v1/badges/6246b1cd8e42603c42f6/maintainability)](https://codeclimate.com/github/DigitalNZ/plug/maintainability) [![Build Status](https://travis-ci.org/DigitalNZ/plug.svg?branch=master)](https://travis-ci.org/DigitalNZ/plug)
+# Plug [![Maintainability](https://api.codeclimate.com/v1/badges/6246b1cd8e42603c42f6/maintainability)](https://codeclimate.com/github/DigitalNZ/plug/maintainability)
 
 A Rails engine to turn on/off features (Feature flipper).
 

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 begin
   require 'bundler/setup'
 rescue LoadError
@@ -14,7 +16,7 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-APP_RAKEFILE = File.expand_path('../spec/dummy/Rakefile', __FILE__)
+APP_RAKEFILE = File.expand_path('spec/dummy/Rakefile', __dir__)
 load 'rails/tasks/engine.rake'
 
 load 'rails/tasks/statistics.rake'

data/app/controllers/plug/api/api_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   module Api
     class ApiController < ActionController::Base

data/app/controllers/plug/api/site_notices_controller.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_dependency 'plug/application_controller'
 
 module Plug

data/app/controllers/plug/application_controller.rb

@@ -1,11 +1,11 @@
+# frozen_string_literal: true
+
 module Plug
   class ApplicationController < ActionController::Base
     protect_from_forgery with: :exception
 
     content_security_policy false
 
-    if Plug.auth_user.present? && Plug.auth_password.present?
-      http_basic_authenticate_with name: Plug.auth_user, password: Plug.auth_password
-    end
+    http_basic_authenticate_with name: Plug.auth_user, password: Plug.auth_password if Plug.auth_user.present? && Plug.auth_password.present?
   end
 end

data/app/controllers/plug/features_controller.rb

@@ -1,12 +1,10 @@
+# frozen_string_literal: true
+
 require_dependency 'plug/application_controller'
 
 module Plug
   class FeaturesController < ApplicationController
-    if Rails.version.to_i < 5
-      before_filter :set_feature, only: [:edit, :update, :destroy]
-    else
-      before_action :set_feature, only: [:edit, :update, :destroy]
-    end
+    before_action :set_feature, only: %i[edit update destroy]
 
     # GET /features
     def index
@@ -37,7 +35,7 @@ module Plug
 
     # PATCH/PUT /features/1
     def update
-      if @feature.update_attributes(feature_params)
+      if @feature.update(feature_params)
         redirect_to features_path, notice: 'Feature was successfully updated.'
       else
         render :edit
@@ -65,19 +63,15 @@ module Plug
     end
 
     private
-      # Use callbacks to share common setup or constraints between actions.
-      def set_feature
-        @feature = Feature.find(params[:id])
-      end
 
-      # Only allow a trusted parameter "white list" through.
-      # TODO: Strong params not available for older Rails
-      def feature_params
-        if Rails.version.to_i < 5
-          ActiveSupport::HashWithIndifferentAccess.new(params[:feature])
-        else
-          params.require(:feature).permit(:name, :description, :state, :notice)
-        end
-      end
+    # Use callbacks to share common setup or constraints between actions.
+    def set_feature
+      @feature = Feature.find(params[:id])
+    end
+
+    # Only allow a trusted parameter "white list" through.
+    def feature_params
+      params.require(:feature).permit(:name, :description, :state, :notice)
+    end
   end
 end

data/app/controllers/plug/site_notices_controller.rb

@@ -1,12 +1,10 @@
+# frozen_string_literal: true
+
 require_dependency 'plug/application_controller'
 
 module Plug
   class SiteNoticesController < ApplicationController
-    if Rails.version.to_i < 5
-      before_filter :set_site_notice, only: [:edit, :update, :destroy]
-    else
-      before_action :set_site_notice, only: [:edit, :update, :destroy]
-    end
+    before_action :set_site_notice, only: %i[edit update destroy]
 
     # GET /site_notices
     def index
@@ -37,7 +35,7 @@ module Plug
 
     # PATCH/PUT /site_notices/1
     def update
-      if @site_notice.update_attributes(site_notice_params)
+      if @site_notice.update(site_notice_params)
         redirect_to site_notices_path, notice: 'Site Notice was successfully updated.'
       else
         render :edit
@@ -51,19 +49,15 @@ module Plug
     end
 
     private
-      # Use callbacks to share common setup or constraints between actions.
-      def set_site_notice
-        @site_notice = SiteNotice.find(params[:id])
-      end
 
-      # Only allow a trusted parameter "white list" through.
-      # TODO: Strong params not available for older Rails
-      def site_notice_params
-        if Rails.version.to_i < 5
-          ActiveSupport::HashWithIndifferentAccess.new(params[:site_notice])
-        else
-          params.require(:site_notice).permit(:name, :notice, :state, :theme)
-        end
-      end
+    # Use callbacks to share common setup or constraints between actions.
+    def set_site_notice
+      @site_notice = SiteNotice.find(params[:id])
+    end
+
+    # Only allow a trusted parameter "white list" through.
+    def site_notice_params
+      params.require(:site_notice).permit(:name, :notice, :state, :theme)
+    end
   end
 end

data/app/helpers/plug/application_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   module ApplicationHelper
   end

data/app/mailers/plug/application_mailer.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   class ApplicationMailer < ActionMailer::Base
     default from: 'from@example.com'

data/app/models/plug/application_record.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   class ApplicationRecord < ActiveRecord::Base
     self.abstract_class = true

data/app/models/plug/concerns/model_helpers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'active_support/concern'
 
 module Plug
@@ -9,9 +11,9 @@ module Plug
         include AASM
 
         # Validations
-        validates :name, presence: { message: "#{self.humanized_class_name} name is required" },
-                         uniqueness: { message: "#{self.humanized_class_name} name must be unique", case_sensitive: false }
-        validates :state, presence: { message: "#{self.humanized_class_name} state is required" }
+        validates :name, presence: { message: "#{humanized_class_name} name is required" },
+                         uniqueness: { message: "#{humanized_class_name} name must be unique", case_sensitive: false }
+        validates :state, presence: { message: "#{humanized_class_name} state is required" }
 
         # Callbacks
         before_save { self.slug = name.parameterize }
@@ -32,12 +34,11 @@ module Plug
             transitions from: :enabled, to: :disabled
           end
         end
-
       end
 
       module ClassMethods
         def humanized_class_name
-          self.name.demodulize.underscore.humanize.capitalize
+          name.demodulize.underscore.humanize.capitalize
         end
       end
     end

data/app/models/plug/feature.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   class Feature < ApplicationRecord
     include AASM

data/app/models/plug/resources/site_notice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   module Resources
     class SiteNotice < ActiveResource::Base

data/app/models/plug/site_notice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
   class SiteNotice < ApplicationRecord
     include AASM

data/app/services/plug/task_execution_service.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rake'
 
 module Plug

data/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 Plug::Engine.routes.draw do
   root to: 'features#index'
 

data/db/migrate/20180424015828_add_theme_to_plug_site_notice.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class AddThemeToPlugSiteNotice < ActiveRecord::Migration[5.1]
   def change
     add_column :plug_site_notices, :theme, :string

data/lib/generators/plug/install_generator.rb

@@ -1,6 +1,8 @@
+# frozen_string_literal: true
+
 module Plug
   class InstallGenerator < Rails::Generators::Base
-    source_root File.expand_path('../templates', __FILE__)
+    source_root File.expand_path('templates', __dir__)
 
     def copy_initializer_file
       copy_file 'plug.rb', 'config/initializers/plug.rb'

data/lib/plug.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'plug/engine'
 require 'plug/configuration'
 require 'plug/constraint'
@@ -12,9 +14,9 @@ module Plug
   #
   # @return [Boolean] true - Feature found and enabled | true - Feature not found (We don't want to block) | false - Feature was set to disabled
   def enabled?(arg)
-    return get_feature(arg).enabled?
-  rescue
-    return true
+    get_feature(arg).enabled?
+  rescue StandardError
+    true
   end
 
   #
@@ -27,21 +29,21 @@ module Plug
     feature = get_feature(arg)
 
     render_notice(feature.notice, &block) unless feature.enabled? || feature.notice.blank?
-  rescue
-    return nil
+  rescue StandardError
+    nil
   end
 
   private
 
-    def get_feature(arg)
-      arg = arg.to_s if arg.is_a? Symbol
+  def get_feature(arg)
+    arg = arg.to_s if arg.is_a? Symbol
 
-      return Plug::Feature.slug_and_name(arg).first
-    end
+    return Plug::Feature.slug_and_name(arg).first
+  end
 
-    def render_notice(notice, &block)
-      return notice unless block_given?
+  def render_notice(notice, &block)
+    return notice unless block_given?
 
-      yield(notice)
-    end
+    yield(notice)
+  end
 end

data/lib/plug/configuration.rb

@@ -1,26 +1,28 @@
+# frozen_string_literal: true
+
 module Plug
   module Configuration
     AUTH_USER         = ''
     AUTH_PASSWORD     = ''
     ALLOW_DELETE      = true
 
-    VALID_OPTIONS_KEYS = [
-      :auth_user,
-      :auth_password,
-      :allow_delete,
-      :buttons,
-      :api_path,
-      :themes
+    VALID_OPTIONS_KEYS = %i[
+      auth_user
+      auth_password
+      allow_delete
+      buttons
+      api_path
+      themes
     ].freeze
 
-    attr_accessor *VALID_OPTIONS_KEYS
+    attr_accessor(*VALID_OPTIONS_KEYS)
 
     def configure
       yield self
     end
 
     def options
-      Hash[ * VALID_OPTIONS_KEYS.map { |key| [key, send(key)] }.flatten ]
+      Hash[* VALID_OPTIONS_KEYS.map { |key| [key, send(key)] }.flatten]
     end
   end
 end

data/lib/plug/constraint.rb

@@ -1,12 +1,14 @@
+# frozen_string_literal: true
+
 module Plug
   class Constraint
     def initialize(feature)
       @feature = feature
     end
 
-    def matches?(request)
+    def matches?(_request)
       Plug.enabled?(@feature)
-    rescue
+    rescue StandardError
       true
     end
   end

data/lib/plug/engine.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # Require engine dependencies
 require 'haml-rails'
 require 'aasm'
@@ -9,6 +11,8 @@ module Plug
 
     config.generators do |g|
       g.test_framework :rspec
+      g.fixture_replacement :factory_bot
+      g.factory_bot dir: 'spec/factories'
     end
   end
 end

data/lib/plug/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Plug
-  VERSION = '0.1.23'
+  VERSION = '0.1.24'
 end

data/lib/tasks/plug_tasks.rake

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 # desc "Explaining what the task does"
 # task :plug do
 #   # Task goes here

metadata

@@ -1,18 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: plug
 version: !ruby/object:Gem::Version
-  version: 0.1.23
+  version: 0.1.24
 platform: ruby
 authors:
-- Ben
 - Boost
+- DNZ
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-16 00:00:00.000000000 Z
+date: 2021-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rails
+  name: aasm
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -26,7 +26,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sass-rails
+  name: activeresource
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -40,7 +40,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: jquery-rails
+  name: haml-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -54,7 +54,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: haml-rails
+  name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -68,21 +68,21 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: aasm
+  name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
-  name: activeresource
+  name: sass-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -96,7 +96,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -110,35 +110,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rspec-rails
+  name: factory_bot_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.7.1
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rails-controller-testing
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: factory_bot_rails
+  name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -152,7 +152,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: capybara
+  name: selenium-webdriver
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -166,7 +166,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: selenium-webdriver
+  name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -180,7 +180,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: shoulda-matchers
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -193,9 +193,8 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: Rails engine that can plug/unplug features with notice (WIP)
+description: Rails engine that can plug/unplug features with notice
 email:
-- benedict@boost.co.nz
 - info@boost.co.nz
 executables: []
 extensions: []
@@ -267,7 +266,7 @@ files:
 - lib/plug/engine.rb
 - lib/plug/version.rb
 - lib/tasks/plug_tasks.rake
-homepage: https://github.com/hapiben/plug
+homepage: https://github.com/digitalnz/plug
 licenses:
 - MIT
 metadata: {}