pluckit 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7587bb8c7e758bd2badc023cf95087b397386c67
-  data.tar.gz: 0e230a36351043c05e174d0971ab28b259fca86f
+  metadata.gz: 1bd175a9c3fc863b62c01f1ef2b2a502f6c48f8f
+  data.tar.gz: 310068b14b9decdbfd8a49d3791b7427e135d2e8
 SHA512:
-  metadata.gz: 1c0fd9d9d4e9dfaf4ffbf4699ba33105e027392b9f7a484519aacf3c065482adf6ab4e2e3979e5dfa0b6f3f2906f7890eb46ed8a5194f3301343a5a923d2a699
-  data.tar.gz: 7989512d5bb2373eacdef52c87c011c7953a9350472e795fee65a5f7f61c04c1155efd71b9bbdbed760635fc07d98515813ccf70072baefaa958dd58aaffc3ab
+  metadata.gz: 35b8e21af1bcdb9b53dd9a42948b8716e1aca1cdf17a1d9623f9813b41526386d200999d5e97a7f2cdb0ad7403c8baa2948919f0093bc175b387f6b37fd1c213
+  data.tar.gz: 27e5d57fbdee0b69dfb8eeddd28304d1b76776ed42270e968a81240d3236a663f4c978c67f6c3e7904db1d997efa1673e4dd0118bbd39114f8e69937dd2ea321

data/lib/pluckit.rb

@@ -1,33 +1,27 @@
 require_relative 'pluckit/pluck.rb'
 
 module PluckIt
-  VERSION = '1.0.0'
+  VERSION = '1.1.0'
 end
 
 
 
 class Array
   def pluck *handles
-    each_with_object(clone.clear) do |val, res|
-      res << PluckIt.pluck(val, *handles)
-    end
+    PluckIt.pluck self, *handles
   end
 end
 
 
 class Hash
   def pluck *handles
-    each_with_object(clone.clear) do |(key, val), res|
-      res[key] = PluckIt.pluck(val, *handles)
-    end
+    PluckIt.pluck self, *handles
   end
 end
 
 
 class Set
   def pluck *handles
-    each_with_object(clone.clear) do |val, res|
-      res.add PluckIt.pluck(val, *handles)
-    end
+    PluckIt.pluck self, *handles
   end
 end

data/lib/pluckit/pluck.rb

@@ -1,18 +1,41 @@
 module PluckIt
   class << self
 
-    def pluck v, *handles
+
+    def pluck enumerable, *handles
+      items = enumerable.each_with_object(
+        enumerable.clone.clear
+      )
+      # TODO: if no clone / clear, use new
+
+      if enumerable.is_a?(Hash)
+        items.each do |(key, val), res|
+          res[key] = pluckit(val, *handles)
+        end
+      elsif enumerable.is_a?(Set)
+        items.each do |val, res|
+          res.add pluckit(val, *handles)
+        end
+      else
+        items.each do |val, res|
+          res << pluckit(val, *handles)
+        end
+      end
+    end
+
+
+    def pluckit v, *handles
       if handles.count > 1
-        handles.map {|h| pluck_single v, h }
+        handles.map {|h| pluckit_single v, h }
       else
-        pluck_single v, handles.first
+        pluckit_single v, handles.first
       end
     end
 
 
     private
 
-    def pluck_single v, handle
+    def pluckit_single v, handle
       if v.is_a? Hash
         v[handle]
       elsif ([Symbol, String].include? handle.class) and v.respond_to? handle

data/test/test_monkey_patching.rb

@@ -0,0 +1,36 @@
+require 'minitest/autorun'
+require 'set'
+
+$LOAD_PATH.unshift 'lib'
+require 'pluckit/pluck'
+
+
+class MonkeyPatchingTest < Minitest::Test
+  def test_not_installed
+    if defined? PluckIt::VERSION
+      # entire library was loaded, so these tests are invalid.
+      # this happens when run through `rake`
+      skip
+    end
+
+    # `require 'pluckit/pluck'` should load PluckIt
+    assert PluckIt
+
+    # but no monkey patching
+    assert_raises NoMethodError do
+      [ 1, 2, 3 ].pluck 0
+    end
+
+    assert_raises NoMethodError do
+      { a: 1 }.pluck 0
+    end
+
+    assert_raises NoMethodError do
+      Set.new([ 1, 2, 3 ]).pluck 0
+    end
+
+    puts 'yay, no monkey patching'
+  end
+
+
+end

data/test/test_pluck.rb

@@ -1,147 +1,52 @@
 require 'minitest/autorun'
 require 'set'
 
-$LOAD_PATH.unshift 'lib'
 require 'pluckit/pluck'
 
 
-class PluckItTest < Minitest::Test
+"""
+basic sanity check, since other tests will
+probe much more extensively
+"""
 
-  def test_array
-    data = [ 1, 2, 3 ]
+class PluckTest < Minitest::Test
 
+  def test_basic
+    data = [
+      { k: 'a', v: 1 },
+      { k: 'b', v: 2 },
+      { k: 'c', v: 3 },
+    ]
     assert_equal(
-      1,
-      PluckIt.pluck(data, 0)
+      [ 'a', 'b', 'c' ],
+      PluckIt.pluck(data, :k)
     )
 
-    assert_equal(
-      2,
-      PluckIt.pluck(data, 1)
-    )
-
-    assert_equal(
-      3,
-      PluckIt.pluck(data, :last)
-    )
-
-    assert_equal(
-      3,
-      PluckIt.pluck(data, :count)
-    )
-
-    assert_equal(
-      [ 1, 2 ],
-      PluckIt.pluck(data, 0..1)
-    )
-
-    assert_equal(
-      [ 'a', 'ba', 'ca' ],
-      PluckIt.pluck(
-        [ 'a', 'ba', 'bb', 'bc', 'ca' ],
-        /a/
-      )
-    )
 
-    assert_equal(
-      [ 1, 2 ],
-      PluckIt.pluck(data, 0, 1)
-    )
-  end
-
-
-  def test_hash
-    data = {
-      a: 1,
-      b: 2,
-      c: 3,
+    temp = {
+      june: [ 78, 82, 80 ],
+      july: [ 80, 83, 86 ],
+      august: [ 80, 76, 79 ],
     }
-
-    assert_equal(
-      2,
-      PluckIt.pluck(data, :b)
-    )
-
-    assert_nil(
-      PluckIt.pluck(data, :z)
-    )
-
-    assert_nil(
-      PluckIt.pluck(data, :count)
-    )
-
     assert_equal(
-      [ 1, 2 ],
-      PluckIt.pluck(data, :a, :b)
-    )
-  end
-
-
-  class ABC
-    def foo() 123 end
-    def bar() 456 end
-  end
-
-  def test_obj
-    assert_equal(
-      123,
-      PluckIt.pluck(ABC.new, :foo)
+      {
+        june: 82,
+        july: 86,
+        august: 80,
+      },
+      PluckIt.pluck(temp, :max)
     )
 
-    assert_equal(
-      self.class.const_get(:ABC),
-      PluckIt.pluck(ABC.new, :class)
-    )
 
+    people = Set.new([
+      {name: 'dpepper', age: 31},
+      {name: 'josh', age: 30},
+    ])
     assert_equal(
-      [ 123, 456 ],
-      PluckIt.pluck(ABC.new, :foo, :bar)
+      Set.new(['dpepper', 'josh']),
+      PluckIt.pluck(people, :name)
     )
   end
 
 
-  def test_set
-    data = Set.new [ 1, 2, 3 ]
-
-    assert_equal(
-      1,
-      PluckIt.pluck(data, :first)
-    )
-
-    assert_equal(
-      3,
-      PluckIt.pluck(data, :count)
-    )
-
-    assert_equal(
-      [ 1, 3 ],
-      PluckIt.pluck(data, :first, :count)
-    )
-  end
-
-
-  def test_not_installed
-    if defined? PluckIt::VERSION
-      # entire library was loaded, so these tests are invalid.
-      # this happens when run through `rake`
-      return
-    end
-
-    # `require 'pluckit/pluck'` should load PluckIt
-    # but not monkey patch
-    assert_raises NoMethodError do
-      [ 1, 2, 3 ].pluck 0
-    end
-
-    assert_raises NoMethodError do
-      { a: 1 }.pluck 0
-    end
-
-    assert_raises NoMethodError do
-      Set.new([ 1, 2, 3 ]).pluck 0
-    end
-
-    puts 'no monkey patching'
-  end
-
 end

data/test/test_pluckit.rb

@@ -0,0 +1,122 @@
+require 'minitest/autorun'
+require 'set'
+
+require 'pluckit/pluck'
+
+
+class PluckItTest < Minitest::Test
+
+  def test_array
+    data = [ 1, 2, 3 ]
+
+    assert_equal(
+      1,
+      PluckIt.pluckit(data, 0)
+    )
+
+    assert_equal(
+      2,
+      PluckIt.pluckit(data, 1)
+    )
+
+    assert_equal(
+      3,
+      PluckIt.pluckit(data, :last)
+    )
+
+    assert_equal(
+      3,
+      PluckIt.pluckit(data, :count)
+    )
+
+    assert_equal(
+      [ 1, 2 ],
+      PluckIt.pluckit(data, 0..1)
+    )
+
+    assert_equal(
+      [ 'a', 'ba', 'ca' ],
+      PluckIt.pluckit(
+        [ 'a', 'ba', 'bb', 'bc', 'ca' ],
+        /a/
+      )
+    )
+
+    assert_equal(
+      [ 1, 2 ],
+      PluckIt.pluckit(data, 0, 1)
+    )
+  end
+
+
+  def test_hash
+    data = {
+      a: 1,
+      b: 2,
+      c: 3,
+    }
+
+    assert_equal(
+      2,
+      PluckIt.pluckit(data, :b)
+    )
+
+    assert_nil(
+      PluckIt.pluckit(data, :z)
+    )
+
+    assert_nil(
+      PluckIt.pluckit(data, :count)
+    )
+
+    assert_equal(
+      [ 1, 2 ],
+      PluckIt.pluckit(data, :a, :b)
+    )
+  end
+
+
+  class ABC
+    def foo() 123 end
+    def bar() 456 end
+  end
+
+  def test_obj
+    assert_equal(
+      123,
+      PluckIt.pluckit(ABC.new, :foo)
+    )
+
+    assert_equal(
+      self.class.const_get(:ABC),
+      PluckIt.pluckit(ABC.new, :class)
+    )
+
+    assert_equal(
+      [ 123, 456 ],
+      PluckIt.pluckit(ABC.new, :foo, :bar)
+    )
+  end
+
+
+  def test_set
+    data = Set.new [ 1, 2, 3 ]
+
+    assert_equal(
+      1,
+      PluckIt.pluckit(data, :first)
+    )
+
+    assert_equal(
+      3,
+      PluckIt.pluckit(data, :count)
+    )
+
+    assert_equal(
+      [ 1, 3 ],
+      PluckIt.pluckit(data, :first, :count)
+    )
+  end
+
+
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pluckit
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Daniel Pepper
@@ -48,7 +48,9 @@ files:
 - lib/pluckit/pluck.rb
 - test/test_array.rb
 - test/test_hash.rb
+- test/test_monkey_patching.rb
 - test/test_pluck.rb
+- test/test_pluckit.rb
 - test/test_set.rb
 homepage: https://github.com/dpep/rb_pluckit
 licenses:
@@ -77,5 +79,7 @@ summary: PluckIt
 test_files:
 - test/test_array.rb
 - test/test_hash.rb
+- test/test_monkey_patching.rb
 - test/test_pluck.rb
+- test/test_pluckit.rb
 - test/test_set.rb