pluck_map 0.6.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b299dd06b71f709f45a8b9df4e52b20c70785976a3502f5b2402f0f340da8160
-  data.tar.gz: d4d4e2f78031b5fe3fa8c6492885bc2bfa17b73f30825c60fede8f10fec2e13c
+  metadata.gz: 719535934f95bc4fe3db48d59fb8f8c762f23260c6438763672612d82ea12feb
+  data.tar.gz: ada8d0481118adc7d04f47b3b801e826e4b07a60d07d0d063ef10a652c891568
 SHA512:
-  metadata.gz: b6da4c576698798f98ac790f81a8dd4ff4f4b07b27212ef3c43f4d54966d04d139ff082f79b86a163abcaf3d3d64a27119c5cd84705baa32c7c39a7b3c369979
-  data.tar.gz: 9862dd28a87a7e82385f14eeb3a055672aac462cf0f2496ec8a189fa476d51c74a24711780ab1c84640c568f92053cb872d75c88834f094a6dd7399ca948e836
+  metadata.gz: 9d35814e0ef40d24e7ff441250c692880116540f6668ef79ce047da3424e7ff98203964e013f81c4d32d100d4f29e3e3995beb74f7f166ffa4597e5653e893f3
+  data.tar.gz: c887937585d78ef34a9d44e7fedf9ad7810ba9dd5d54525b90c577ca77eaef9450575986adb43c5f9d97d874903a688bf3f81ab538f03b520d4fa849ce0bef7f

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v0.6.1 (2019 May 12)
+
+* FIX: Aliased SQL expressions to work-around a bug with Rails Postgres adapter (@kobsy)
+
 ## v0.6.0 (2019 May 5)
 
 * REFACTOR: Deprecated `Presenter#no_map?` and introduced `Attributes#will_map?` to replace it (@boblail)

data/lib/pluck_map/presenter.rb

@@ -1,5 +1,6 @@
 require "pluck_map/attribute_builder"
 require "pluck_map/presenters"
+require "active_record"
 
 module PluckMap
   class Presenter
@@ -56,7 +57,32 @@ module PluckMap
     end
 
     def selects
-      attributes.selects
+      @selects ||= attributes.selects.map.with_index { |select, index|
+
+        # Workaround for a bug that exists in Rails at the time of this commit.
+        # See:
+        #
+        #    https://github.com/rails/rails/pull/36186
+        #
+        # Prior to the PR above, Rails will treat two results that have the
+        # same name as having the same type. On Postgres, values that are the
+        # result of an expression are given the name of the last function
+        # called in the expression. For example:
+        #
+        #    psql> SELECT COALESCE(NULL, 'four'), COALESCE(NULL, 4);
+        #     coalesce | coalesce
+        #    ----------+----------
+        #     four     |        4
+        #    (1 row)
+        #
+        # This patch mitigates that problem by aliasing SQL expressions before
+        # they are used in select statements.
+        select = select.as("__pluckmap_#{index}") if select.respond_to?(:as)
+
+        # On Rails 4.2, `pluck` can't accept Arel nodes
+        select = Arel.sql(select.to_sql) if ActiveRecord.version.segments.take(2) == [4,2] && select.respond_to?(:to_sql)
+        select
+      }
     end
 
     def attributes_by_id

data/lib/pluck_map/version.rb

@@ -1,3 +1,3 @@
 module PluckMapPresenter
-  VERSION = "0.6.0"
+  VERSION = "0.6.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: pluck_map
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.6.1
 platform: ruby
 authors:
 - Bob Lail
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-06 00:00:00.000000000 Z
+date: 2019-05-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord