pling 0.3.1 → 0.4.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 14d000e78a057ba2db7a60c0a235d1f3f09b63c2
+  data.tar.gz: 890d8ed20c079f8e8f41ad3bc36b7d50e7b2f711
+SHA512:
+  metadata.gz: a51e7f0552197e83caffc20d94f383da8437228a65fe650acc505f02fa3cf07cbbcae2ba47f705c6829a4e58fbd1340c3156966483f55596f438386b07e5f9e6
+  data.tar.gz: ff10429ead2557b0f681c52093a5340614599e0dd16ba2fb3665021f95043efd2806487cbaff833274277623f955aa3a1adeabeb0bc6defaed3e3de88b06f17c

data/.travis.yml

@@ -5,11 +5,9 @@ language: ruby
 rvm:
   - ruby-head
   - 1.9.3
-  - 1.8.7
-  - ree
   - jruby
   - jruby-19mode
-  - rbx-19mode
+  - rbx-2
 matrix:
   allow_failures:
-    - rvm: ruby-head
+    - rvm: ruby-head

data/Gemfile

@@ -6,5 +6,4 @@ gemspec
 gem 'guard'
 gem 'guard-rspec'
 gem 'guard-yard', :platform => :ruby_19
-gem 'growl_notify' if RUBY_PLATFORM =~ /darwin/
 gem 'rdiscount', ">= 1.6.8", :platform => :ruby

data/lib/pling/apn/gateway.rb

@@ -1,6 +1,7 @@
 require 'socket'
 require 'openssl'
 require 'json'
+require 'connection_pool'
 
 module Pling
   module APN
@@ -33,10 +34,10 @@ module Pling
         setup!
       end
 
-      ## 
+      ##
       # Establishes a new connection if connection is not available or closed
       def setup!
-        connection.reopen if connection.closed?
+        setup_connection_pool
       end
 
       ##
@@ -57,9 +58,9 @@ module Pling
 
         data = data.to_json
 
-        if data.bytesize > 256
+        if data.bytesize > 2048
           raise Pling::DeliveryFailed.new(
-            "Payload size of #{data.bytesize} exceeds allowed size of 256 bytes.",
+            "Payload size of #{data.bytesize} exceeds allowed size of 2048 bytes.",
             message,
           device)
         end
@@ -75,18 +76,33 @@ module Pling
           super.merge(
             :host => 'gateway.push.apple.com',
             :port => 2195,
-            :payload => false
+            :payload => false,
+            :pool_size => 3,
+            :timeout => 5
           )
         end
 
         def connection
-          @connection ||= Connection.new(
+          @connection
+        end
+
+        def setup_connection_pool
+          @connection ||= connection_pool
+        end
+
+        def new_connection
+          Connection.new(
             :host        => configuration[:host],
             :port        => configuration[:port],
             :certificate => configuration[:certificate]
           )
         end
 
+        def connection_pool
+          ConnectionPool::Wrapper.new(size: configuration[:pool_size], timeout: configuration[:timeout]) do
+            new_connection
+          end
+        end
     end
   end
 end

data/lib/pling/c2dm/gateway.rb

@@ -104,7 +104,7 @@ module Pling
         end
 
         def connection
-          @connection ||= Faraday.new(configuration[:connection]) do |builder|
+          Faraday.new(configuration[:connection]) do |builder|
             builder.use Faraday::Request::UrlEncoded
             builder.use Faraday::Response::Logger if configuration[:debug]
             builder.adapter(configuration[:adapter])

data/lib/pling/gcm/gateway.rb

@@ -75,7 +75,7 @@ module Pling
       end
 
       def connection
-        @connection ||= Faraday.new(configuration[:connection]) do |builder|
+        Faraday.new(configuration[:connection]) do |builder|
           builder.use FaradayMiddleware::EncodeJson
           builder.use FaradayMiddleware::ParseJson, :content_type => /\bjson$/
           builder.use Faraday::Response::Logger if configuration[:debug]

data/lib/pling/version.rb

@@ -1,3 +1,3 @@
 module Pling
-  VERSION = "0.3.1"
+  VERSION = "0.4.0"
 end

data/pling.gemspec

@@ -19,6 +19,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency "faraday", "~> 0.7"
   s.add_runtime_dependency "faraday_middleware", "~> 0.8"
   s.add_runtime_dependency "json", "~> 1.4"
+  s.add_runtime_dependency "connection_pool", "~> 2.0.0"
   s.add_runtime_dependency("jruby-openssl") if RUBY_PLATFORM == 'java'
 
   s.add_development_dependency "rspec", "~> 2.7"

data/spec/pling/apn/gateway_spec.rb

@@ -18,6 +18,21 @@ describe Pling::APN::Gateway do
     Pling::APN::Gateway.handled_types.should =~ [:apple, :apn, :ios, :ipad, :iphone, :ipod]
   end
 
+  describe '#setup!' do
+    before do
+      valid_configuration.merge!(pool_size: 99, timeout: 55)
+    end
+
+    subject { Pling::APN::Gateway.new(valid_configuration) }
+
+    let(:connection_pool) { double(:connection_pool_double) }
+
+    it 'initializes a new connection pool for the APN connection' do
+      ConnectionPool::Wrapper.should_receive(:new).with(size: 99, timeout: 55).and_return(connection_pool)
+      subject.setup!
+    end
+  end
+
   describe '#deliver' do
     subject { Pling::APN::Gateway.new(valid_configuration) }
 
@@ -29,6 +44,14 @@ describe Pling::APN::Gateway do
       expect { subject.deliver(message, nil) }.to raise_error
     end
 
+    it 'should initialize a new APN connection if none is established' do
+      Pling::APN::Connection.should_receive(:new).and_return(connection)
+      subject.deliver(message, device)
+
+      Pling::APN::Connection.should_not_receive(:new)
+      subject.deliver(message, device)
+    end
+
     it 'should call #to_pling_message on the given message' do
       message.should_receive(:to_pling_message).and_return(message)
       subject.deliver(message, device)
@@ -39,9 +62,9 @@ describe Pling::APN::Gateway do
       subject.deliver(message, device)
     end
 
-    it 'should raise an exception when the payload exceeds 256 bytes' do
-      message.body = "X" * 256
-      expect { subject.deliver(message, device) }.to raise_error(Pling::DeliveryFailed, /Payload size of \d+ exceeds allowed size of 256 bytes/)
+    it 'should raise an exception when the payload exceeds 2048 bytes' do
+      message.body = "X" * 3000
+      expect { subject.deliver(message, device) }.to raise_error(Pling::DeliveryFailed, /Payload size of \d+ exceeds allowed size of 2048 bytes/)
     end
 
     it 'should try to deliver the given message' do
@@ -138,4 +161,4 @@ describe Pling::APN::Gateway do
       end
     end
   end
-end
+end

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pling
 version: !ruby/object:Gem::Version
-  version: 0.3.1
-  prerelease: 
+  version: 0.4.0
 platform: ruby
 authors:
 - Benedikt Deicke
@@ -11,102 +10,104 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-05 00:00:00.000000000 Z
+date: 2015-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
   name: json
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.4'
+- !ruby/object:Gem::Dependency
+  name: connection_pool
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.7'
 - !ruby/object:Gem::Dependency
   name: yard
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.9'
 description: Pling is a notification framework that supports multiple gateways. Currently
@@ -119,8 +120,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Gemfile
 - Guardfile
 - LICENSE
@@ -162,27 +163,26 @@ files:
 - spec/spec_helper.rb
 homepage: http://flinc.github.com/pling
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.4.6
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Pling is a notification framework that supports multiple gateways
 test_files:
 - spec/pling/.DS_Store