plenty_client 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 468471d1063a081184202e28692e3b8f6f2a8f99011cbcd52ad11dcc57a2dff3
-  data.tar.gz: 8b3dfd65b46808a089ec788576d9d1d0db196148d032d6c977e3f53d27f03ffb
+  metadata.gz: 3b1ce1f9899a6d120944ae078627fe676c3af95c773c3aa2c0a9d347a4727b33
+  data.tar.gz: c96480546c1ce74d997439685960918f9ceed35d2ad78fa403b105d3be0dfa99
 SHA512:
-  metadata.gz: 40c8107ab4b4e6d46f5fff6bcaa008e7c587f875955e8cd42977d8e8f313d833791a57d48f4dcf0c04d509eabebed3221ce9acdb0cffd52804a7fab31118f6ce
-  data.tar.gz: d13f2f3ac98937ade8439d9fac70374869c831f4675cbc1b51cd86b98edfe90c8e20e9c158199be84207a4963dede77cb39efb16abf968ec29b9fe4afb567941
+  metadata.gz: 63da84709428e75cc89b05079e5fcc81e8b083f5be250fe62c398232e4e073fb73b14f6c5cf122a1ebb7a5e2d8b61bedda96d53c6bd9e5b7a962e6e16951806e
+  data.tar.gz: f2bdee10c09c20eae6b332045b327db9fe22632931f5c6340396f7f956d889cdedcb6a6c49cff03c93b203b98eb6de3f41341008d3b6644e388d80365d7494bb

data/lib/plenty_client.rb

@@ -1,8 +1,11 @@
 require 'json'
 
 module PlentyClient
-  class ResponseError < StandardError; end
-  class AttemptsExceeded < StandardError; end
+  class ConnectionError < StandardError; end
+  class ClientError < ConnectionError; end
+  class RedirectionError < ConnectionError; end
+  class ServerError < ConnectionError; end
+  class ResponseError < ConnectionError; end
   class NotFound < ResponseError; end
 
   autoload :Config,       'plenty_client/config'

data/lib/plenty_client/document/order.rb

@@ -21,12 +21,12 @@ module PlentyClient
           get(build_endpoint(DOWNLOAD_ORDER_DOCUMENTS_BY_TYPE, type_string: type_string), headers, &block)
         end
 
-        def list(order_id, type_sting = nil, headers = {}, &block)
-          get(build_endpoint(LIST_ORDER_DOCUMENTS, order: order_id, type_sting: type_sting), headers, &block)
+        def list(order_id, type_string = nil, headers = {}, &block)
+          get(build_endpoint(LIST_ORDER_DOCUMENTS, order: order_id, type_string: type_string), headers, &block)
         end
 
-        def list_by_type(order_id, type_sting = nil, headers = {}, &block)
-          get(build_endpoint(LIST_ORDER_DOCUMENTS_BY_TYPE, order: order_id, type_sting: type_sting), headers, &block)
+        def list_by_type(type_string = nil, headers = {}, &block)
+          get(build_endpoint(LIST_ORDER_DOCUMENTS_BY_TYPE, type_string: type_string), headers, &block)
         end
 
         def upload(order_id, type_string, body = {})

data/lib/plenty_client/request.rb

@@ -5,22 +5,16 @@ module PlentyClient
   module Request
     module ClassMethods
       def request(http_method, path, params = {})
-        return false if http_method.nil? || path.nil?
-        return false unless %w[post put patch delete get].include?(http_method.to_s)
+        raise ArgumentError, "http_method or path is missing" if http_method.nil? || path.nil?
+        unless %w[post put patch delete get].include?(http_method.to_s)
+          raise ArgumentError, "unsupported http_method: #{http_method}"
+        end
 
         login_check unless PlentyClient::Config.tokens_valid?
 
         params = stringify_symbol_keys(params) if params.is_a?(Hash)
 
-        attempts = PlentyClient::Config.attempt_count
-        attempts.times do
-          begin
-            response = perform(http_method, path, params)
-            return response if response
-          rescue Faraday::ConnectionFailed => e
-          end
-        end
-        raise PlentyClient::AttemptsExceeded, "unable to get valid response after #{attempts} attempts"
+        perform(http_method, path, params)
       end
 
       def post(path, body = {})
@@ -84,11 +78,13 @@ module PlentyClient
               logger.filter(/password=([^&]+)/, 'password=[FILTERED]')
             end
           end
+        faraday.request :retry, max: PlentyClient::Config.attempt_count
         end
         conn.adapter :typhoeus
         verb = http_method.to_s.downcase
         params = params.to_json unless %w[get delete].include?(verb)
         response = conn.send(verb, base_url(path), params)
+        assert_success_status_code(response)
         parse_body(response)
       end
 
@@ -119,6 +115,7 @@ module PlentyClient
       end
 
       def parse_body(response)
+        return nil if response.body.strip == ""
         content_type = response.env.response_headers['Content-Type']
         case content_type
         when %r{(?:application|text)/json}
@@ -129,6 +126,8 @@ module PlentyClient
           json
         when %r{application/pdf}
           response.body
+        else
+          raise PlentyClient::ResponseError, "unsupported response Content-Type: #{content_type}"
         end
       rescue JSON::ParserError
         raise PlentyClient::ResponseError, 'invalid response'
@@ -156,6 +155,17 @@ module PlentyClient
           response.dig('error', 'message')
         end
       end
+
+      def assert_success_status_code(response)
+        case response.status
+        when 300..399
+          raise RedirectionError, "Invalid response: HTTP status: #{response.status}"
+        when 400..499
+          raise ClientError, "Invalid response: HTTP status: #{response.status}"
+        when 500..599
+          raise ServerError, "Invalid response: HTTP status: #{response.status}"
+        end
+      end
     end
 
     def self.included(base)

data/lib/plenty_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PlentyClient
-  VERSION = '0.1.1'
+  VERSION = '0.1.2'
 end

data/plenty_client.gemspec

@@ -20,14 +20,15 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.13'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '~> 1.16'
+  spec.add_development_dependency 'rake', '~> 12.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'webmock', '~> 3.0'
   spec.add_development_dependency 'guard-rspec', '~> 4.7'
   spec.add_development_dependency 'pry', '~> 0.11'
+  spec.add_development_dependency 'byebug'
 
-  spec.add_runtime_dependency 'json', '~> 1.8', '>= 1.8.0'
-  spec.add_runtime_dependency 'faraday', '~> 0.9'
-  spec.add_runtime_dependency 'typhoeus', '~> 1.3', '>= 1.3.0'
+  spec.add_runtime_dependency 'json', '>= 1.8.0'
+  spec.add_runtime_dependency 'faraday', '>= 0.9'
+  spec.add_runtime_dependency 'typhoeus', '>= 1.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: plenty_client
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Dariusch Ochlast
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-26 00:00:00.000000000 Z
+date: 2019-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '1.16'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.13'
+        version: '1.16'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -95,12 +95,23 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.11'
 - !ruby/object:Gem::Dependency
-  name: json
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.8.0
@@ -108,9 +119,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.8'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.8.0
@@ -118,23 +126,20 @@ dependencies:
   name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.9'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
@@ -142,9 +147,6 @@ dependencies:
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.3.0
@@ -317,7 +319,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 2.7.7
 signing_key: 
 specification_version: 4
 summary: This the first draft of a PlentyMarkets Rest Client for Ruby.