playbook_ui 16.8.0.pre.alpha.play301316889 → 16.8.0.pre.alpha.tablewidths16466

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: edb2d6b1943796215222f43d5a667089909a292040708c227c91967e72f6f0bc
-  data.tar.gz: 1762487740450da1b7b322409360bdaefb03cf1c4b7f14b500817a5374453fd2
+  metadata.gz: 0f46fd7de41487efa37647c36cc3d1d55e2260ccda34ff0f094dc4f3c21608c4
+  data.tar.gz: 60e1b0388423c2a75088ba9210b0e9456c27fb7a7b5822b5753f1c46f1abfa53
 SHA512:
-  metadata.gz: e5e4c4a11408e787aa02ecf02ae3a815b92eb4c8010b1da263ae2a266da889d6b0364d38ee2471b58c9be08df653ee84d2999deed123f4979df84b15fe8c7c72
-  data.tar.gz: 3b23460679cd966247435ff055de878cdaceab02e5b6279bc8c8cb6bfd0071718f77bcfb82c710d4cdc7ed72a7607d272a78305d48b1b6bb079cc6f6559c735e
+  metadata.gz: 236bb6ec1f254c88d37bfa99aa2bb530aba234550a5635bfd19c9bb76fe0240bf818ccd4f2b859424662c2e15d1f31cae47d0831e172a9c2926e1eaa4cf3ade7
+  data.tar.gz: 63776f5d3b77b41da7a95ad4d67e89d244a0981fb8cc2220c3fc8996f5506eb2b4f94cf30989d848afc83d2104dbe17092e00851e4b4cd46ebd5a63985ddb543

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_sticky_header.jsx

@@ -1,21 +1,13 @@
 import React from "react"
 import AdvancedTable from '../../pb_advanced_table/_advanced_table'
-
-const tableData = Array.from({ length: 15 }, (_, index) => ({
-  year: String(2020 + index),
-  newEnrollments: String(20 + index),
-  scheduledMeetings: String(10 + index),
-  attendanceRate: `${50 + index}%`,
-  completedClasses: String(3 + index),
-  classCompletionRate: `${30 + index}%`,
-  graduatedStudents: String(19 + index),
-}))
+import MOCK_DATA from "./advanced_table_mock_data.json"
 
 const AdvancedTableStickyHeader = (props) => {
   const columnDefinitions = [
     {
       accessor: "year",
       label: "Year",
+      cellAccessors: ["quarter", "month", "day"],
     },
     {
       accessor: "newEnrollments",
@@ -48,11 +40,11 @@ const AdvancedTableStickyHeader = (props) => {
   }
 
   return (
-    <div style={{ maxHeight: "320px", overflowY: "auto" }}>
+    <div>
       <AdvancedTable
           columnDefinitions={columnDefinitions}
           responsive="none"
-          tableData={tableData}
+          tableData={MOCK_DATA}
           tableProps={tableProps}
           {...props}
       />

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_sticky_header.md

@@ -1,7 +1,3 @@
 The `TableProps` prop can also be used to render a sticky header for the Advanced Table.
 
-This doc example uses a scroll container with flat rows so sticky behavior is visible in the docs without expanding subrows. Scroll inside the preview to see the header stick.
-
-This example builds flat table data inline for the docs preview. For typical `tableData` setup, see [Default (Required Props)](/kits/advanced_table/default/react#advanced_table_default).
-
 This doc example showcases how to set a sticky header for a nonresponsive table (see the `responsive` prop set to "none"). To achieve sticky header AND responsive functionality, see the "Sticky Header for Responsive Table" doc example below.

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_sticky_header_rails.html.erb

@@ -2,6 +2,7 @@
     {
       accessor: "year",
       label: "Year",
+      cellAccessors: ["quarter", "month", "day"],
     },
     {
       accessor: "newEnrollments",
@@ -29,19 +30,4 @@
     }
 ] %>
 
-<% table_data = 15.times.map do |index|
-  {
-    year: (2020 + index).to_s,
-    id: (2020 + index).to_s,
-    newEnrollments: (20 + index).to_s,
-    scheduledMeetings: (10 + index).to_s,
-    attendanceRate: "#{50 + index}%",
-    completedClasses: (3 + index).to_s,
-    classCompletionRate: "#{30 + index}%",
-    graduatedStudents: (19 + index).to_s,
-  }
-end %>
-
-<div style="max-height: 320px; overflow-y: auto;">
-  <%= pb_rails("advanced_table", props: { id: "sticky_header_table", table_data: table_data, column_definitions: column_definitions, responsive: "none", table_props: { sticky: true }}) %>
-</div>
+<%= pb_rails("advanced_table", props: { id: "sticky_header_table", table_data: @table_data, column_definitions: column_definitions, responsive: "none", table_props: { sticky: true }}) %>

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_sticky_header_rails.md

@@ -1,7 +1,3 @@
 The `table_props` prop can also be used to render a sticky header for the Advanced Table.
 
-This doc example uses a scroll container with flat rows so sticky behavior is visible in the docs without expanding subrows. Scroll inside the preview to see the header stick.
-
-This example builds flat table data inline for the docs preview. For typical `table_data` setup, see [Default (Required Props)](/kits/advanced_table/default/rails#advanced_table_beta).
-
 This doc example showcases how to set a sticky header for a nonresponsive table (see the `responsive` prop set to "none"). To achieve sticky header AND responsive functionality, see the "[Sticky Header for Responsive Table](https://playbook.powerapp.cloud/kits/advanced_table/react#sticky-header-for-responsive-table)" doc example below.

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header.html.erb

@@ -2,6 +2,7 @@
     {
       accessor: "year",
       label: "Year",
+      cellAccessors: ["quarter", "month", "day"],
     },
     {
       accessor: "newEnrollments",
@@ -29,19 +30,4 @@
     }
 ] %>
 
-<% table_data = 15.times.map do |index|
-  {
-    year: (2020 + index).to_s,
-    id: (2020 + index).to_s,
-    newEnrollments: (20 + index).to_s,
-    scheduledMeetings: (10 + index).to_s,
-    attendanceRate: "#{50 + index}%",
-    completedClasses: (3 + index).to_s,
-    classCompletionRate: "#{30 + index}%",
-    graduatedStudents: (19 + index).to_s,
-  }
-end %>
-
-<div style="max-height: 320px; overflow-y: auto;">
-  <%= pb_rails("advanced_table", props: { id: "table_props_sticky_table", table_data: table_data, column_definitions: column_definitions, table_props: { sticky: true }}) %>
-</div>
+<%= pb_rails("advanced_table", props: { id: "table_props_sticky_table", table_data: @table_data, column_definitions: column_definitions, max_height: "xs", table_props: { sticky: true }}) %>

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header.jsx

@@ -1,21 +1,13 @@
 import React from "react"
 import AdvancedTable from '../../pb_advanced_table/_advanced_table'
-
-const tableData = Array.from({ length: 15 }, (_, index) => ({
-  year: String(2020 + index),
-  newEnrollments: String(20 + index),
-  scheduledMeetings: String(10 + index),
-  attendanceRate: `${50 + index}%`,
-  completedClasses: String(3 + index),
-  classCompletionRate: `${30 + index}%`,
-  graduatedStudents: String(19 + index),
-}))
+import MOCK_DATA from "./advanced_table_mock_data.json"
 
 const AdvancedTableTablePropsStickyHeader = (props) => {
   const columnDefinitions = [
     {
       accessor: "year",
       label: "Year",
+      cellAccessors: ["quarter", "month", "day"],
     },
     {
       accessor: "newEnrollments",
@@ -48,10 +40,11 @@ const AdvancedTableTablePropsStickyHeader = (props) => {
   }
 
   return (
-    <div style={{ maxHeight: "320px", overflowY: "auto" }}>
+    <div>
       <AdvancedTable
           columnDefinitions={columnDefinitions}
-          tableData={tableData}
+          maxHeight="xs"
+          tableData={MOCK_DATA}
           tableProps={tableProps}
           {...props}
       />

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header_rails.md

@@ -2,10 +2,6 @@ Create a sticky header that works for responsive Advanced Tables by setting `sti
 
 **NOTE**: This behavior requires a `max_height` to work. The header is sticky within the table container, allowing for it to work along with the first column stickiness of a responsive table on smaller screen sizes.
 
-Scroll inside the table preview to see the header stick.
-
-This example builds flat table data inline for the docs preview. For typical `table_data` setup, see [Default (Required Props)](/kits/advanced_table/default/rails#advanced_table_beta).
-
 Expand the table above to see this in action.
 
 A sticky header on a nonresponsive table is demonstrated in the ["Sticky Header"](https://playbook.powerapp.cloud/kits/advanced_table#sticky-header) doc example above.

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_table_props_sticky_header_react.md

@@ -1,9 +1,7 @@
-Create a sticky header that works for responsive Advanced Tables by setting `sticky: true` via `tableProps` and wrapping the table in a scroll container (or using `maxHeight`).
+Create a sticky header that works for responsive Advanced Tables by setting `sticky: true` via `tableProps` and giving the AdvancedTable a `maxHeight` using our [Max Height](https://playbook.powerapp.cloud/global_props/max_height) global prop. 
 
-**NOTE**: The header is sticky within the table scroll area. The live example uses flat rows so you can scroll inside the preview without expanding subrows.
+**NOTE**: This behavior requires a `maxHeight` to work. The header is sticky within the table container, allowing for it to work along with the first column stickiness of a responsive table on smaller screen sizes.
 
-This example builds flat table data inline for the docs preview. For typical `tableData` setup, see [Default (Required Props)](/kits/advanced_table/default/react#advanced_table_default).
-
-Expand the table above to see responsive behavior in action.
+Expand the table above to see this in action.
 
 A sticky header on a nonresponsive table is demonstrated in the ["Sticky Header"](https://playbook.powerapp.cloud/kits/advanced_table/react#sticky-header) doc example above.

data/app/pb_kits/playbook/pb_advanced_table/docs/example.yml

@@ -3,7 +3,6 @@ examples:
   - advanced_table_beta: Default (Required Props)
   - advanced_table_loading: Loading State
   - advanced_table_beta_subrow_headers: SubRow Headers
-  - advanced_table_enable_toggle_expansion_rails: Enable Toggle Expansion
   - advanced_table_collapsible_trail_rails: Collapsible Trail
   - advanced_table_table_props: Table Props
   - advanced_table_sticky_header_rails: Sticky Header
@@ -53,7 +52,6 @@ examples:
   - advanced_table_table_props_sticky_header: Sticky Header for Responsive Table
   - advanced_table_sticky_columns: Sticky Columns
   - advanced_table_sticky_columns_and_header: Sticky Columns with Sticky Header
-  - advanced_table_sticky_scroll_limitation: Sticky Header and Column Scroll Limitation
   - advanced_table_responsive: Responsive Tables
   - advanced_table_custom_cell: Custom Components for Cells
   - advanced_table_with_custom_header: Custom Header Cell

data/app/pb_kits/playbook/pb_advanced_table/docs/index.js

@@ -27,7 +27,6 @@ export { default as AdvancedTableFullscreen } from './_advanced_table_fullscreen
 export { default as AdvancedTableStickyColumns } from './_advanced_table_sticky_columns.jsx'
 export { default as AdvancedTableStickyHeader } from './_advanced_table_sticky_header.jsx'
 export { default as AdvancedTableStickyColumnsAndHeader } from './_advanced_table_sticky_columns_and_header.jsx'
-export { default as AdvancedTableStickyScrollLimitation } from './_advanced_table_sticky_scroll_limitation.jsx'
 export { default as AdvancedTableExpandByDepth } from './_advanced_table_expand_by_depth.jsx'
 export { default as AdvancedTableColumnBorderColor} from './_advanced_table_column_border_color.jsx'
 export { default as AdvancedTableColumnVisibility } from './_advanced_table_column_visibility.jsx'

data/app/pb_kits/playbook/pb_card/_card.tsx

@@ -162,7 +162,7 @@ const Card = (props: CardPropTypes): React.ReactElement => {
           {
             dragHandle ? (
               <Flex>
-                <span className="card_draggable_handle pb_draggable_handle">
+                <span className="card_draggable_handle">
                   <Icon
                       icon="grip-dots-vertical"
                       paddingRight="xs"

data/app/pb_kits/playbook/pb_card/card.html.erb

@@ -4,7 +4,7 @@
             <% if object.draggable_item %>
                 <%= pb_rails("flex", props: { align: "center" }) do %>
                     <% if object.drag_handle %>
-                        <span class="card_draggable_handle pb_draggable_handle">
+                        <span classname="card_draggable_handle">
                             <%= pb_rails("icon", props: { icon: "grip-dots-vertical", padding_right: "xs" }) %>
                         </span>
                     <% end %>

data/app/pb_kits/playbook/pb_currency/_currency.tsx

@@ -59,13 +59,12 @@ const Currency = (props: CurrencyProps): React.ReactElement => {
     commaSeparator = false,
   } = props
 
-  const isAmountEmpty = (value: string | number): boolean => (
-    value === '' || value == null || (typeof value === 'string' && value.trim() === '')
-  )
-
   // Convert numeric input to string format
   const convertAmount = (input: string | number): string => {
     if (typeof input === 'number') {
+      if (input === 0 && !nullDisplay) {
+        return ""
+      }
       return input.toFixed(2)
     }
     return input
@@ -82,9 +81,7 @@ const Currency = (props: CurrencyProps): React.ReactElement => {
     variantClass = '_bold'
   }
 
-  const [wholePart, decimalPart = '00'] = currencyAmount ? currencyAmount.split('.') : ['', '00']
-  const decimal = (decimalPart || '00').padEnd(2, '0').slice(0, 2)
-  const whole = currencyAmount === '' ? '' : (wholePart === '' ? '0' : wholePart)
+  const [whole, decimal = '00'] = currencyAmount.split('.')
   const ariaProps = buildAriaProps(aria)
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
@@ -138,7 +135,7 @@ const Currency = (props: CurrencyProps): React.ReactElement => {
       <Caption dark={dark}>{label}</Caption>
       <div className={`pb_currency_wrapper${variantClass || emphasizedClass}`}>
         {unstyled ? (
-          nullDisplay && isAmountEmpty(amount) ? (
+          nullDisplay && !amount ? (
             <div>{nullDisplay}</div>
           ) : (
             <>
@@ -151,7 +148,7 @@ const Currency = (props: CurrencyProps): React.ReactElement => {
             </>
           )
         ) : (
-          nullDisplay && isAmountEmpty(amount) ? (
+          nullDisplay && !amount ? (
             <Title
                 className="pb_currency_value"
                 dark={dark}

data/app/pb_kits/playbook/pb_currency/currency.rb

@@ -68,7 +68,7 @@ module Playbook
       end
 
       def title_text
-        if null_display && amount.blank?
+        if null_display
           null_display
         elsif swap_negative
           absolute_amount(abbr_or_format_amount)
@@ -125,7 +125,14 @@ module Playbook
       # Convert numeric input to string format
       def convert_amount(input)
         if input.is_a?(Numeric)
-          Kernel.format("%.2f", input)
+          if input.zero? && null_display.nil?
+            ""
+          else
+            format("%.2f", input)
+          end
+        # Handle string representations of zero
+        elsif input.to_s.strip.match?(/^-?0+(\.0+)?$/) && null_display.nil?
+          ""
         else
           input.to_s
         end
@@ -135,7 +142,6 @@ module Playbook
         return "" if currency_amount.blank?
 
         value = currency_amount.split(".").first
-        value = "0" if value.blank?
         if comma_separator
           number_with_delimiter(value.gsub(",", ""))
         else
@@ -146,8 +152,7 @@ module Playbook
       def decimal_value
         return "00" if currency_amount.blank?
 
-        fraction = currency_amount.split(".")[1] || "00"
-        fraction.ljust(2, "0")[0, 2]
+        currency_amount.split(".")[1] || "00"
       end
 
       def units_element

data/app/pb_kits/playbook/pb_currency/currency.test.js

@@ -178,48 +178,5 @@ test('handles numeric amounts correctly', () => {
   expect(screen.getByTestId('test-numeric-no-symbol')).toHaveTextContent('400.50')
   expect(screen.getByTestId('test-numeric-medium-size')).toHaveTextContent('$500.55')
   expect(screen.getByTestId('test-numeric-negative')).toHaveTextContent('-$600.70')
-  expect(screen.getByTestId('test-numeric-null')).toHaveTextContent('$0.00')
-})
-
-test('renders zero values with leading digit', () => {
-  render(
-    <>
-      <Currency
-          amount="0"
-          data={{ testid: 'test-string-zero' }}
-      />
-      <Currency
-          amount={0}
-          data={{ testid: 'test-numeric-zero' }}
-      />
-    </>
-  )
-
-  expect(screen.getByTestId('test-string-zero')).toHaveTextContent('$0.00')
-  expect(screen.getByTestId('test-numeric-zero')).toHaveTextContent('$0.00')
-})
-
-test('normalizes string zero with single decimal digit to .00', () => {
-  render(
-    <Currency
-        amount="0.0"
-        commaSeparator
-        data={{ testid: 'test-string-zero-single-decimal' }}
-    />
-  )
-
-  expect(screen.getByTestId('test-string-zero-single-decimal')).toHaveTextContent('$0.00')
-})
-
-test('nullDisplay only applies when amount is empty', () => {
-  render(
-    <Currency
-        amount="-.53"
-        data={{ testid: 'test-null-display-negative' }}
-        nullDisplay="$0.00"
-    />
-  )
-
-  expect(screen.getByTestId('test-null-display-negative')).toHaveTextContent('-$')
-  expect(screen.getByTestId('test-null-display-negative')).not.toHaveTextContent('$0.00')
+  expect(screen.getByTestId('test-numeric-null')).toHaveTextContent('$.00')
 })

data/app/pb_kits/playbook/pb_date_picker/_date_picker.tsx

@@ -12,41 +12,6 @@ import Caption from '../pb_caption/_caption'
 import Body from '../pb_body/_body'
 import colors from "../tokens/exports/_colors.module.scss"
 
-function isValidDateInstance(value: Date): boolean {
-  return !Number.isNaN(value.getTime())
-}
-
-function normalizeDefaultDate<T>(defaultDate: T): T {
-  if (defaultDate instanceof Date) {
-    return (isValidDateInstance(defaultDate) ? defaultDate : '') as unknown as T
-  }
-  if (Array.isArray(defaultDate)) {
-    const normalized = defaultDate.filter(
-      (d) => !(d instanceof Date) || isValidDateInstance(d)
-    )
-    return (normalized.length ? normalized : '') as unknown as T
-  }
-  return defaultDate
-}
-
-function serializeDefaultDateForFilterReset(defaultDate: unknown): string | undefined {
-  if (defaultDate === '' || defaultDate == null) return undefined
-  if (Array.isArray(defaultDate)) {
-    const parts = defaultDate.map((d) => {
-      if (d == null || d === '') return ''
-      if (d instanceof Date) {
-        return isValidDateInstance(d) ? d.toISOString() : ''
-      }
-      return String(d)
-    }).filter(Boolean)
-    return parts.length ? parts.join(',') : undefined
-  }
-  if (defaultDate instanceof Date) {
-    return isValidDateInstance(defaultDate) ? defaultDate.toISOString() : undefined
-  }
-  return String(defaultDate)
-}
-
 type DatePickerProps = {
   allowInput?: boolean,
   aria?: { [key: string]: string },
@@ -148,12 +113,7 @@ const DatePicker = (props: DatePickerProps): React.ReactElement => {
   } = props
 
   const ariaProps = buildAriaProps(aria)
-  const normalizedDefaultDate = normalizeDefaultDate(defaultDate)
-  const filterResetDefaultSerialized = serializeDefaultDateForFilterReset(normalizedDefaultDate)
-  const dataProps = buildDataProps({
-    ...data,
-    ...(filterResetDefaultSerialized ? { 'default-value': filterResetDefaultSerialized } : {}),
-  })
+  const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
   const inputAriaProps = buildAriaProps(inputAria)
   const inputDataProps = buildDataProps(inputData)
@@ -176,7 +136,7 @@ const DatePicker = (props: DatePickerProps): React.ReactElement => {
     datePickerHelper({
       allowInput,
       customQuickPickDates,
-      defaultDate: normalizedDefaultDate,
+      defaultDate,
       disableDate,
       disableRange,
       disableWeekdays,

data/app/pb_kits/playbook/pb_date_picker/date_picker.html.erb

@@ -1,11 +1,8 @@
-<% date_picker_root_attrs = {
-  class: object.classname + object.error_class,
-  'data-pb-date-picker' => true,
-  'data-validation-message' => object.validation_message,
-}
-  date_picker_root_attrs['data-default-value'] = object.serialized_default_date_for_dom if object.serialized_default_date_for_dom.present?
-%>
-<%= pb_content_tag(:div, date_picker_root_attrs) do %>
+<%= pb_content_tag(:div,
+    class: object.classname + object.error_class,
+    'data-pb-date-picker' => true,
+    'data-validation-message' => object.validation_message,
+      ) do %>
   <div class="input_wrapper">
     <% if !object.hide_label && object.label %>
       <label for="<%= object.picker_id %>">
@@ -82,57 +79,42 @@
 
   <%= javascript_tag do %>
     (function() {
-      const initQuickPickChangeListener = (input) => {
-        if (!<%= object.selection_type == "quickpick" %>) return
-        if (input.dataset.quickpickInitialized) return
-
-        input.dataset.quickpickInitialized = "true"
-        input.addEventListener("change", ({ target }) => {
-          const startDate = document.getElementById("<%= object.start_date_id %>")
-          const endDate = document.getElementById("<%= object.end_date_id %>")
-          const splittedValue = target.value.split(" to ")
-          startDate.value = splittedValue[0]
-          endDate.value = splittedValue[1] ? splittedValue[1] : splittedValue[0]
-        })
-      }
-
       const loadDatePicker = () => {
-        const input = document.getElementById("<%= object.picker_id %>")
-
-        if (!input || input._flatpickr) return true
-        if (typeof window.datePickerHelper !== "function") return false
-
-        window.datePickerHelper(<%= object.date_picker_config %>, "<%= object.scroll_container %>")
-        initQuickPickChangeListener(input)
-
-        return true
-      }
-
-      let attempts = 0
-      const retryLoad = () => {
-        if (loadDatePicker()) return
+        const input = document.getElementById("<%= object.picker_id %>");
+        if (input && !input._flatpickr) {
+          datePickerHelper(<%= object.date_picker_config %>, "<%= object.scroll_container %>")
 
-        if (attempts++ < 20) {
-          setTimeout(retryLoad, 100)
+          if (<%= object.selection_type == "quickpick" %>) {
+            document.getElementById("<%= object.picker_id %>").addEventListener("change", ({ target }) => {
+              const startDate = document.getElementById("<%= object.start_date_id %>")
+              const endDate = document.getElementById("<%= object.end_date_id %>")
+              const splittedValue = target.value.split(" to ")
+              startDate.value = splittedValue[0]
+              endDate.value = splittedValue[1] ? splittedValue[1] : splittedValue[0]
+            })
+          }
         }
       }
 
+      // Try to initialize immediately if DOM is ready
       if (document.readyState === "loading") {
-        window.addEventListener("DOMContentLoaded", retryLoad)
+        window.addEventListener("DOMContentLoaded", loadDatePicker)
       } else {
-        retryLoad()
+        loadDatePicker()
       }
 
       // For dynamically added content (modals, etc.), check again after a brief delay
       setTimeout(() => {
-        const input = document.getElementById("<%= object.picker_id %>")
+        const input = document.getElementById("<%= object.picker_id %>");
         if (input && !input._flatpickr) {
-          retryLoad()
+          loadDatePicker();
         }
-      }, 100)
+      }, 100);
 
       if (<%= !object.custom_event_type.empty? %>) {
-        window.addEventListener("<%= object.custom_event_type %>", retryLoad)
+        window.addEventListener("<%= object.custom_event_type %>", () => {
+          loadDatePicker()
+        })
       }
     })()
   <% end %>

data/app/pb_kits/playbook/pb_date_picker/date_picker.rb

@@ -145,18 +145,6 @@ module Playbook
       def angle_down_path
         "app/pb_kits/playbook/utilities/icons/angle-down.svg"
       end
-
-      # Serialized business default for opt-in smart filter reset (Nitro / data-default-value).
-      def serialized_default_date_for_dom
-        case default_date
-        when nil, ""
-          nil
-        when Array
-          default_date.compact_blank.map(&:to_s).join(",")
-        else
-          default_date.to_s.presence
-        end
-      end
     end
   end
 end

data/app/pb_kits/playbook/pb_date_picker/date_picker.test.js

@@ -40,66 +40,6 @@ describe('DatePicker Kit', () => {
     expect(kit).toHaveClass('pb_date_picker_kit mb_sm')
   })
 
-  test('exposes data-default-value on kit root when defaultDate is set', () => {
-    const testId = 'datepicker-def-attr'
-    render(
-      <DatePicker
-          data={{ testid: testId }}
-          defaultDate={DEFAULT_DATE}
-          pickerId="date-picker-def-attr"
-      />
-    )
-    const kit = screen.getByTestId(testId)
-    expect(kit).toHaveAttribute('data-default-value', DEFAULT_DATE.toISOString())
-  })
-
-  test('omits data-default-value when defaultDate is empty', () => {
-    const testId = 'datepicker-no-def-attr'
-    render(
-      <DatePicker
-          data={{ testid: testId }}
-          defaultDate=""
-          pickerId="date-picker-no-def-attr"
-      />
-    )
-    const kit = screen.getByTestId(testId)
-    expect(kit).not.toHaveAttribute('data-default-value')
-  })
-
-  test('renders without error when defaultDate is an invalid Date', () => {
-    const testId = 'datepicker-invalid-date'
-    const invalidDate = new Date('UndefinedT00:00')
-
-    expect(() => {
-      render(
-        <DatePicker
-            data={{ testid: testId }}
-            defaultDate={invalidDate}
-            pickerId="date-picker-invalid-date"
-        />
-      )
-    }).not.toThrow()
-
-    const kit = screen.getByTestId(testId)
-    expect(kit).not.toHaveAttribute('data-default-value')
-  })
-
-  test('omits data-default-value when defaultDate is constructed from undefined', () => {
-    const testId = 'datepicker-undefined-date'
-    const invalidDate = new Date(undefined + 'T00:00')
-
-    render(
-      <DatePicker
-          data={{ testid: testId }}
-          defaultDate={invalidDate}
-          pickerId="date-picker-undefined-date"
-      />
-    )
-
-    const kit = screen.getByTestId(testId)
-    expect(kit).not.toHaveAttribute('data-default-value')
-  })
-
   test('inLine alone adds inline-date-picker class and inline control icons, not the calendar icon', () => {
     const testId = 'datepicker-inline-only'
     render(