playbook_ui 16.3.0.pre.alpha.play284214735 → 16.3.0.pre.alpha.play284214748

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a6c968cf90d1de383e97877c72e6031bb5ecd84104d27959adcc57036fb3415b
-  data.tar.gz: f18f7076471dc7eb3b6b220c267bb39071ac36cf5ccc17bef6e94e3b96cc11c5
+  metadata.gz: 791fad49e5fd8c5c144cbbd18e58035c12bf1d46557e21eeacd9f26e1322c4ba
+  data.tar.gz: b3a105c74f8dd3366d4b286bd2fb1f23212c325b738b927649ddfc492d3415e0
 SHA512:
-  metadata.gz: a4514506ebbfa43307f3cde9b73f213252d9ecdd9703a90877a715175e30f13235f97ad99f208e876a405ffa4048d1a1557e4cf0f714dacd0ea00379cd55fba1
-  data.tar.gz: 9c83ff2b3d78ccea736dcc216c733f9398f42bfca39e34e8964e6802a53cba10314f188837c2bc6bada4be3b14357220bcd2f7e6f07c2dbc8a39c42823f5b304
+  metadata.gz: f1504b82ec481292f7636fb0e750125926f6c2bdb3041ea6dc8ac410f45b942de27222635e64ba6f62bda605de8ae5cc590e11c41935b64948ebf342ef0ee410
+  data.tar.gz: 9e01a49770efddb8de575ed2f3924029f80e84a3b796ec5619b6353c82bdd60cd33b3183a0c7763005fca8e9bc6333625e3c95d4551ba39dd4b0419ced36cdc2

data/app/pb_kits/playbook/pb_multi_level_select/_multi_level_select.tsx

@@ -179,6 +179,7 @@ const MultiLevelSelect = forwardRef<HTMLInputElement, MultiLevelSelectProps>(
       parent_id: string | null = null,
       depth = 0,
       parentDisabled = false,
+      ancestorChecked = false
     ) => {
       if (!Array.isArray(treeData)) {
         return;
@@ -188,30 +189,36 @@ const MultiLevelSelect = forwardRef<HTMLInputElement, MultiLevelSelectProps>(
         const isDisabled =
           item.disabled || (parentDisabled && !returnAllSelected);
 
+          const explicitlySelected = Boolean(
+            selectedIds && selectedIds?.length && selectedIds.includes(item.id)
+          );
+
+          const checked =
+          !isDisabled &&
+          (explicitlySelected || (ancestorChecked && !returnAllSelected && variant !== "single"))
+
         const newItem = {
           ...item,
-          checked: Boolean(
-            selectedIds && selectedIds.length && selectedIds.includes(item.id),
-          ),
+          checked: checked,
           parent_id,
           depth,
           disabled: isDisabled,
         };
         if (newItem.children && newItem.children.length > 0) {
-        const shouldCascade =
-        newItem.checked && !returnAllSelected && variant !== "single";
-          const children =
-            shouldCascade
-              ? modifyRecursive(cloneDeep(newItem.children), true)
-              : item.children;
-          newItem.children = addCheckedAndParentProperty(
-            children,
-            selectedIds,
-            newItem.id,
-            depth + 1,
-            isDisabled,
-          );
-        }
+        // if this node is checked (by explicit selection or ancestor cascade),
+        // and we're in default, cascade to descendants
+        const cascadeToChildren =
+        checked && !returnAllSelected && variant !== "single"
+
+        newItem.children = addCheckedAndParentProperty(
+          newItem.children,
+          selectedIds,
+          newItem.id,
+          depth + 1,
+          isDisabled,
+          cascadeToChildren
+        )
+      }
         return newItem;
       });
     };