playbook_ui 16.0.0.pre.alpha.play267313765 → 16.0.0.pre.alpha.tempotextareasentry13639

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ac10d2ec1ccce77a839f88b0a14f4328c5f382e44f1f722e4e789f0cdc3a51c9
-  data.tar.gz: a23d74c5d2ad1c2d34953893a56b29e21f631cd9e862200b56241cee51e68c71
+  metadata.gz: da5469a3149a33e109e887283501bcb0470422e970cf1960d0f2b71e32a5f351
+  data.tar.gz: ccee25c3f7ee00d748a5d4f95222989dd04726379705380337f09ea0c85bc62c
 SHA512:
-  metadata.gz: fb2fd3f590838627a23827456229e0fb206cb673e7eddc07c4f27fb94bd5a071735aeeacab49749f3e9d30563b419357829bf41e3ce4287811bffaa0efd5588e
-  data.tar.gz: 2fa1d34d4e0c34afc990271677363268025f48851db9bb0967bbd19d99719ae5a9818c4ce716bf37236f14ae50f02b151dd0d43a2553785d825ee83a176fc15f
+  metadata.gz: 772b0891d17001f8cd2e5f18c70f3dae1c89f67d63233452bb5b773d973f1a51c9680585ab4de122d9d6cb81782e22964a99a90510984fa849b87a8267de2725
+  data.tar.gz: c70d0c3ae0b96251eb359c5abb623477b5f3cf91ce9aabc91bcb76cfbe521e84b65351fbe4216996df33145a0b45ed8e0bdac3fa28876a03b1abc61ee7ad2d76

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.html.erb

@@ -11,8 +11,8 @@
     <% if content.present? %>
       <% content.presence %>
     <% else %>
-      <%= pb_rails("advanced_table/table_header", props: { table_id: object.id, column_definitions: object.column_definitions, enable_toggle_expansion: object.enable_toggle_expansion, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, show_actions_bar: object.show_actions_bar, inline_row_loading: object.inline_row_loading, persist_toggle_expansion_button: object.persist_toggle_expansion_button, table_data: object.table_data }) %>
-      <%= pb_rails("advanced_table/table_body", props: { table_id: object.id, table_data: object.table_data, column_definitions: object.column_definitions, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, enable_toggle_expansion: object.enable_toggle_expansion, row_styling: object.row_styling, inline_row_loading: object.inline_row_loading }) %>
+      <%= pb_rails("advanced_table/table_header", props: { table_id: object.id, column_definitions: object.column_definitions, enable_toggle_expansion: object.enable_toggle_expansion, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, show_actions_bar: object.show_actions_bar }) %>
+      <%= pb_rails("advanced_table/table_body", props: { table_id: object.id, table_data: object.table_data, column_definitions: object.column_definitions, responsive: object.responsive, loading: object.loading, selectable_rows: object.selectable_rows, enable_toggle_expansion: object.enable_toggle_expansion, row_styling: object.row_styling }) %>
     <% end %>
   <% end %>
 <% end %>

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.rb

@@ -33,10 +33,6 @@ module Playbook
                              default: false
       prop :row_styling, type: Playbook::Props::Array,
                          default: []
-      prop :inline_row_loading, type: Playbook::Props::Boolean,
-                                default: false
-      prop :persist_toggle_expansion_button, type: Playbook::Props::Boolean,
-                                             default: false
 
       def classname
         additional_classes = [

data/app/pb_kits/playbook/pb_advanced_table/docs/_advanced_table_inline_row_loading.md

@@ -6,9 +6,9 @@ In the first Advanced Table in this code example, 2021 has an empty children arr
 This prop is set to `false` by default. 
 
 
-### persistToggleExpansionButton
+### persistToggleExpansion
 The `persistToggleExpansionButton` is a boolean prop that renders the toggle-all icon in the top left header cell for complex datasets with empty `children` arrays and advanced querying logic explained in the preceeding doc example. Your logic may require an additional query helper file to update data specifically from requerying via toggle all buttons.
 
 In the second and third Advanced Tables in this code example, all 3 rows have empty children arrays. The second Advanced Table demonstrates that the toggle all button does not render (prior to an initial row expansion) without `persistToggleExpansionButton` in place. The third Advanced Table shows the toggle all button due to `persistToggleExpansionButton`. 
 
-This prop is set to `false` by default and should only be used in conjunction with `inlineRowLoading`.
+This prop is set to false by default and should only be used in conjunction with `inlineRowLoading`.

data/app/pb_kits/playbook/pb_advanced_table/docs/example.yml

@@ -29,7 +29,6 @@ examples:
   - advanced_table_background_control_rails: Column Styling Background Color
   - advanced_table_background_colors_rails: Column Styling Individual Cell Background Color
   - advanced_table_column_border_color_rails: Column Group Border Color
-  - advanced_table_inline_row_loading_rails: Inline Row Loading
 
 
   react:

data/app/pb_kits/playbook/pb_advanced_table/table_body.rb

@@ -25,8 +25,6 @@ module Playbook
                              default: false
       prop :row_styling, type: Playbook::Props::Array,
                          default: []
-      prop :inline_row_loading, type: Playbook::Props::Boolean,
-                                default: false
 
       def flatten_columns(columns)
         columns.flat_map do |col|
@@ -71,24 +69,7 @@ module Playbook
                                   end
 
         # Additional class and data attributes needed for toggle logic
-        output << pb_rails("advanced_table/table_row", props: { table_id: table_id, row: row, column_definitions: leaf_columns, depth: current_depth, collapsible_trail: collapsible_trail, classname: additional_classes, table_data_attributes: current_data_attributes, responsive: responsive, loading: loading, selectable_rows: selectable_rows, row_id: row[:id], enable_toggle_expansion: enable_toggle_expansion, row_styling: row_styling, last_row: last_row, immediate_parent_row_id: immediate_parent_row_id, inline_row_loading: inline_row_loading })
-
-        # Render inline loading row when inline_row_loading is enabled and row has empty children
-        if inline_row_loading
-          children = row_children_for(row)
-          if children.is_a?(::Array) && children.empty?
-            max_depth = cell_accessors_length(column_definitions)
-            if current_depth < max_depth
-              loading_row_data_attributes = {
-                advanced_table_content: "#{new_ancestor_ids.join('-')}-loading",
-                row_depth: current_depth + 1,
-                row_parent: "#{table_id}_#{row.object_id}",
-                inline_loading_row: true,
-              }
-              output << render_inline_loading_row(leaf_columns.length, current_depth, loading_row_data_attributes)
-            end
-          end
-        end
+        output << pb_rails("advanced_table/table_row", props: { table_id: table_id, row: row, column_definitions: leaf_columns, depth: current_depth, collapsible_trail: collapsible_trail, classname: additional_classes, table_data_attributes: current_data_attributes, responsive: responsive, loading: loading, selectable_rows: selectable_rows, row_id: row[:id], enable_toggle_expansion: enable_toggle_expansion, row_styling: row_styling, last_row: last_row, immediate_parent_row_id: immediate_parent_row_id })
 
         if row[:children].present?
           row[:children].each do |child_row|
@@ -123,37 +104,6 @@ module Playbook
         ""
       end
 
-      # 3 helper methods for inline row loading
-      def render_inline_loading_row(column_count, depth, data_attributes)
-        padding_left = depth.zero? ? "0.5em" : "#{(depth + 1) * 2}em"
-
-        content_tag(:tr, class: "toggle-content inline-loading-row", data: data_attributes) do
-          content_tag(:td, colspan: column_count, style: "padding-left: #{padding_left}") do
-            pb_rails("loading_inline")
-          end
-        end
-      end
-
-      def row_children_for(row)
-        if row.respond_to?(:children)
-          row.children
-        elsif row.respond_to?(:[])
-          row[:children] || row["children"]
-        end
-      end
-
-      def cell_accessors_length(col_defs)
-        first_col = col_defs.first
-        return 0 unless first_col
-
-        accessors = if first_col.respond_to?(:cellAccessors)
-                      first_col.cellAccessors
-                    elsif first_col.respond_to?(:[])
-                      first_col[:cellAccessors] || first_col["cellAccessors"]
-                    end
-        accessors&.length || 0
-      end
-
     private
 
       def has_grouped_headers?

data/app/pb_kits/playbook/pb_advanced_table/table_header.html.erb

@@ -14,7 +14,7 @@
                   <%= object.render_select_all_checkbox %>
                 <% end %>
               <% end %>
-              <% if object.show_toggle_all_button? %>
+              <% if object.enable_toggle_expansion == "header" || object.enable_toggle_expansion == "all" %>
                 <% if loading %>
                   <div class="<%= object.loading ? 'loading-toggle-icon' : '' %>"></div>
                 <% else %>

data/app/pb_kits/playbook/pb_advanced_table/table_header.rb

@@ -19,12 +19,6 @@ module Playbook
                              default: false
       prop :show_actions_bar, type: Playbook::Props::Boolean,
                               default: true
-      prop :inline_row_loading, type: Playbook::Props::Boolean,
-                                default: false
-      prop :persist_toggle_expansion_button, type: Playbook::Props::Boolean,
-                                             default: false
-      prop :table_data, type: Playbook::Props::Array,
-                        default: []
 
       def classname
         additional_classes = []
@@ -141,20 +135,6 @@ module Playbook
         original_def.dig(:column_styling, :header_font_color)
       end
 
-      # Check if any row in the table has children
-      def has_any_sub_rows?
-        return false if table_data.blank?
-
-        table_data.any? { |row| row_has_children?(row) }
-      end
-
-      # Determines if the toggle-all button should be shown in the header based on inline row loading and persist toggle expansion button props
-      def show_toggle_all_button?
-        return false unless enable_toggle_expansion == "header" || enable_toggle_expansion == "all"
-
-        has_any_sub_rows? || (inline_row_loading && persist_toggle_expansion_button)
-      end
-
       # Check if header has custom background color
       def has_custom_header_background_color?(cell)
         cell[:header_background_color].present?
@@ -337,20 +317,6 @@ module Playbook
         end
         nil
       end
-
-      # 2 inline row loading helper methods
-      def row_has_children?(row)
-        children = row_children_for(row)
-        children.present? && children.is_a?(::Array) && !children.empty?
-      end
-
-      def row_children_for(row)
-        if row.respond_to?(:children)
-          row.children
-        elsif row.respond_to?(:[])
-          row[:children] || row["children"]
-        end
-      end
     end
   end
 end

data/app/pb_kits/playbook/pb_advanced_table/table_row.html.erb

@@ -32,7 +32,7 @@
                                     <%= object.render_row_checkbox %>
                                 <% end %>
                             <% end %>
-                            <% if object.show_expand_button? %>
+                            <% if object.row[:children].present? %>
                                 <button
                                     id="<%= "#{object.table_id}_#{object.row.object_id}" %>"
                                     class="gray-icon expand-toggle-icon"

data/app/pb_kits/playbook/pb_advanced_table/table_row.rb

@@ -33,8 +33,6 @@ module Playbook
                       default: false
       prop :immediate_parent_row_id, type: Playbook::Props::String,
                                      default: ""
-      prop :inline_row_loading, type: Playbook::Props::Boolean,
-                                default: false
 
       def data
         Hash(prop(:data)).merge(table_data_attributes)
@@ -188,23 +186,6 @@ module Playbook
         end
       end
 
-      # Determines if the row should show an expand button (true if row has children or inline_row_loading true and row has empty children array)
-      def show_expand_button?
-        children = row_children
-        return true if children.present?
-        return true if inline_row_loading && children.is_a?(::Array) && children.empty?
-
-        false
-      end
-
-      def row_children
-        if row.respond_to?(:children)
-          row.children
-        elsif row.respond_to?(:[])
-          row[:children] || row["children"]
-        end
-      end
-
     private
 
       def custom_renderer_value(column, index)

data/app/pb_kits/playbook/pb_background/docs/example.yml

@@ -20,4 +20,3 @@ examples:
   - background_category: Category
   - background_size: Size
   - background_overlay: Overlay
-  - background_responsive: Responsive

data/app/pb_kits/playbook/pb_background/docs/index.js

@@ -7,4 +7,3 @@ export { default as BackgroundStatusSubtle } from './_background_status_subtle.j
 export { default as BackgroundCategory } from './_background_category.jsx'
 export { default as BackgroundSize } from './_background_size.jsx'
 export { default as BackgroundOverlay } from './_background_overlay.jsx'
-export { default as BackgroundResponsive } from './_background_responsive.jsx'

data/app/pb_kits/playbook/pb_form/docs/_form_with_required_indicator.html.erb

@@ -1,8 +1,6 @@
 <%= pb_form_with(scope: :example, url: "", method: :get, validate: true) do |form| %>
   <%= form.text_field :example_text_field, props: { label: true, required: true, required_indicator: true } %>
   <%= form.text_field :example_text_field_2, props: { label: "Text Field Custom Label", required: true, required_indicator: true } %>
-  <%= form.text_area :example_text_area, props: { label: true, required: true, required_indicator: true } %>
-  <%= form.text_area :example_text_area_2, props: { label: "Textarea Custom Label", required: true, required_indicator: true } %>
   <%= form.email_field :example_email_field, props: { label: true, required: true, required_indicator: true } %>
   <%= form.number_field :example_number_field, props: { label: true, required: true, required_indicator: true } %>
   <%= form.search_field :example_search_field, props: { label: true, required: true, required_indicator: true } %>
@@ -13,4 +11,4 @@
     <%= action.submit %>
     <%= action.button props: { type: "reset", text: "Cancel", variant: "secondary" } %>
   <% end %>
-<% end %>
+<% end %>

data/app/pb_kits/playbook/pb_multi_level_select/docs/example.yml

@@ -1,39 +1,37 @@
 examples:
   rails:
-    - multi_level_select_default: Default
-    - multi_level_select_single: Single Select
-    - multi_level_select_single_children_only: Single Select w/ Hidden Radios
-    - multi_level_select_return_all_selected: Return All Selected
-    - multi_level_select_input_display: With Input Display None
-    - multi_level_select_selected_ids: Selected Ids
-    - multi_level_select_with_form: With Form
-    - multi_level_select_color: With Pills (Custom Color)
-    - multi_level_select_reset: Reset Selection
-    - multi_level_select_label: With Label
-    - multi_level_select_error: Error
-    - multi_level_select_disabled: Disabled Input
-    - multi_level_select_disabled_options_default: Disabled Options (Default)
-    - multi_level_select_disabled_options: Disabled Options (Return All Selected)
-    - multi_level_select_disabled_options_parent_default: Disabled Parent Option (Default)
-    - multi_level_select_disabled_options_parent: Disabled Parent Option (Return All Selected)
-    - multi_level_select_single_disabled: Disabled Options (Single Select)
+  - multi_level_select_default: Default
+  - multi_level_select_single: Single Select
+  - multi_level_select_single_children_only: Single Select w/ Hidden Radios
+  - multi_level_select_return_all_selected: Return All Selected
+  - multi_level_select_selected_ids: Selected Ids
+  - multi_level_select_with_form: With Form
+  - multi_level_select_color: With Pills (Custom Color)
+  - multi_level_select_reset: Reset Selection
+  - multi_level_select_label: With Label
+  - multi_level_select_error: Error
+  - multi_level_select_disabled: Disabled Input
+  - multi_level_select_disabled_options_default: Disabled Options (Default)
+  - multi_level_select_disabled_options: Disabled Options (Return All Selected)
+  - multi_level_select_disabled_options_parent_default: Disabled Parent Option (Default)
+  - multi_level_select_disabled_options_parent: Disabled Parent Option (Return All Selected)
+  - multi_level_select_single_disabled: Disabled Options (Single Select)
 
   react:
-    - multi_level_select_default: Default
-    - multi_level_select_react_hook: React Hook
-    - multi_level_select_single: Single Select
-    - multi_level_select_single_children_only: Single Select w/ Hidden Radios
-    - multi_level_select_return_all_selected: Return All Selected
-    - multi_level_select_input_display: With Input Display None
-    - multi_level_select_selected_ids_react: Selected Ids
-    - multi_level_select_color: With Pills (Custom Color)
-    - multi_level_select_with_children: Checkboxes With Children
-    - multi_level_select_with_children_with_radios: Single Select With Children
-    - multi_level_select_label: With Label
-    - multi_level_select_error: Error
-    - multi_level_select_disabled: Disabled Input
-    - multi_level_select_disabled_options_default: Disabled Options (Default)
-    - multi_level_select_disabled_options: Disabled Options (Return All Selected)
-    - multi_level_select_disabled_options_parent_default: Disabled Parent Option (Default)
-    - multi_level_select_disabled_options_parent: Disabled Parent Option (Return All Selected)
-    - multi_level_select_single_disabled: Disabled Options (Single Select)
+  - multi_level_select_default: Default
+  - multi_level_select_react_hook: React Hook
+  - multi_level_select_single: Single Select
+  - multi_level_select_single_children_only: Single Select w/ Hidden Radios
+  - multi_level_select_return_all_selected: Return All Selected
+  - multi_level_select_selected_ids_react: Selected Ids
+  - multi_level_select_color: With Pills (Custom Color)
+  - multi_level_select_with_children: Checkboxes With Children
+  - multi_level_select_with_children_with_radios: Single Select With Children
+  - multi_level_select_label: With Label
+  - multi_level_select_error: Error
+  - multi_level_select_disabled: Disabled Input
+  - multi_level_select_disabled_options_default: Disabled Options (Default)
+  - multi_level_select_disabled_options: Disabled Options (Return All Selected)
+  - multi_level_select_disabled_options_parent_default: Disabled Parent Option (Default)
+  - multi_level_select_disabled_options_parent: Disabled Parent Option (Return All Selected)
+  - multi_level_select_single_disabled: Disabled Options (Single Select)

data/app/pb_kits/playbook/pb_multi_level_select/docs/index.js

@@ -4,7 +4,6 @@ export { default as MultiLevelSelectSingleChildrenOnly } from './_multi_level_se
 export { default as MultiLevelSelectReturnAllSelected } from './_multi_level_select_return_all_selected.jsx'
 export { default as MultiLevelSelectSelectedIdsReact } from "./_multi_level_select_selected_ids_react.jsx"
 export { default as MultiLevelSelectColor } from './_multi_level_select_color.jsx'
-export { default as MultiLevelSelectInputDisplay } from './_multi_level_select_input_display.jsx'
 export { default as MultiLevelSelectWithChildren } from './_multi_level_select_with_children.jsx'
 export { default as MultiLevelSelectWithChildrenWithRadios } from './_multi_level_select_with_children_with_radios.jsx'
 export { default as MultiLevelSelectDisabled } from './_multi_level_select_disabled.jsx'

data/app/pb_kits/playbook/pb_rich_text_editor/_rich_text_editor.tsx

@@ -4,8 +4,6 @@ import { TrixEditor } from 'react-trix'
 
 import inlineFocus from './inlineFocus'
 import useFocus from './useFocus'
-import Caption from '../pb_caption/_caption'
-import colors from '../tokens/exports/_colors.module.scss'
 import { globalProps, GlobalProps } from '../utilities/globalProps'
 import { buildAriaProps, buildDataProps, noop, buildHtmlProps } from '../utilities/props'
 
@@ -42,14 +40,12 @@ type RichTextEditorProps = {
   inputOptions?: { [key: string]: string | number | boolean | (() => void) },
   id?: string,
   inline?: boolean,
-  label?: string,
   extensions?: { [key: string]: string }[],
   name?: string,
   onChange: (html: string, text: string) => void,
   placeholder?: string,
   inputHeight?: "sm" | "md" | "lg",
   inputMinHeight?: "sm" | "md" | "lg",
-  requiredIndicator?: boolean,
   simple?: boolean,
   sticky?: boolean,
   template: string,
@@ -68,7 +64,6 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
     data = {},
     focus = false,
     htmlOptions = {},
-    id,
     inputOptions = {},
     inline = false,
     extensions,
@@ -81,9 +76,7 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
     sticky = false,
     template = '',
     value = '',
-    maxWidth = "md",
-    requiredIndicator = false,
-    label,
+    maxWidth = "md"
   } = props
 
   const ariaProps = buildAriaProps(aria),
@@ -93,7 +86,7 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
     containerRef = useRef<HTMLDivElement>(null)
 
   const htmlProps = buildHtmlProps(htmlOptions)
-
+  
   const handleOnEditorReady = (editorInstance: Editor) => {
     setEditor(editorInstance)
     setTimeout(() => {
@@ -101,7 +94,7 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
       if (oldId) {
         const hiddenInput = document.getElementById(oldId)
         if (hiddenInput) {
-          const newId = (inputOptions.id as string) || oldId
+          const newId = (inputOptions.id as string) || oldId  
           hiddenInput.id = newId
           editorInstance.element.setAttribute('input', newId)
 
@@ -126,7 +119,7 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
       // set button attributes
       inlineCodeButton.dataset.trixAttribute = 'inlineCode'
       blockCodeButton.insertAdjacentElement('afterend', inlineCodeButton)
-    }
+    } 
 
     if (toolbarBottom) editor.element.after(toolbarElement)
 
@@ -154,7 +147,7 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
     if (!advancedEditor || !focus) return
 
     const handleFocus = () => setShowToolbarOnFocus(true)
-
+    
     const handleClickOutside = (event: Event) => {
       if (isClickInContainer(event) || isClickInPopover(event)) return
       setShowToolbarOnFocus(false)
@@ -222,29 +215,9 @@ const RichTextEditor = (props: RichTextEditorProps): React.ReactElement => {
         className={css}
         ref={focus ? containerRef : undefined}
     >
-    {label && (
-      <label  htmlFor={id}>
-        {
-          requiredIndicator ? (
-            <Caption className="pb_text_input_kit_label"
-                marginBottom="xs"
-            >
-              {label} <span style={{ color: `${colors.error}` }}>*</span>
-            </Caption>
-          ) : (
-            <Caption
-                className="pb_text_input_kit_label"
-                marginBottom="xs"
-                text={label}
-            />
-          )
-        }
-
-      </label>
-    )}
       {
         advancedEditor ? (
-          <div
+          <div 
               className={classnames(
                 "pb_rich_text_editor_advanced_container",
                 { [`input_height_${inputHeight}`]: !!inputHeight,[`input_min_height_${inputMinHeight}`]: !!inputMinHeight ,["toolbar-active"]: shouldShowToolbar }

data/app/pb_kits/playbook/pb_rich_text_editor/docs/example.yml

@@ -9,7 +9,6 @@ examples:
   - rich_text_editor_templates: Templates
   # - rich_text_editor_toolbar_bottom: Toolbar Bottom
   - rich_text_editor_inline: Inline
-  - rich_text_editor_required_indicator: Required Indicator
   - rich_text_editor_preview: Preview
 
   react:
@@ -32,7 +31,5 @@ examples:
   - rich_text_editor_advanced_inline: Advanced (Inline)
   - rich_text_editor_advanced_height: Advanced Height
   - rich_text_editor_advanced_min_height: Advanced Min Height
-  - rich_text_editor_required_indicator: Required Indicator
-  - rich_text_editor_advanced_required_indicator: Advanced Required Indicator
   - rich_text_editor_preview: Preview
   - rich_text_editor_advanced_preview: Advanced Preview

data/app/pb_kits/playbook/pb_rich_text_editor/docs/index.js

@@ -19,5 +19,3 @@ export { default as RichTextEditorAdvancedSticky } from './_rich_text_editor_adv
 export { default as RichTextEditorAdvancedInline } from './_rich_text_editor_advanced_inline.jsx'
 export { default as RichTextEditorAdvancedHeight } from './_rich_text_editor_advanced_height.jsx'
 export { default as RichTextEditorAdvancedMinHeight } from './_rich_text_editor_advanced_min_height.jsx'
-export { default as RichTextEditorRequiredIndicator } from './_rich_text_editor_required_indicator.jsx'
-export { default as RichTextEditorAdvancedRequiredIndicator } from './_rich_text_editor_advanced_required_indicator.jsx'

data/app/pb_kits/playbook/pb_rich_text_editor/rich_text_editor.rb

@@ -21,9 +21,6 @@ module Playbook
       prop :template
       prop :placeholder
       prop :input_options
-      prop :label
-      prop :required_indicator, type: Playbook::Props::Boolean,
-                                default: false
 
       def classname
         generate_classname("pb_rich_text_editor_kit", simple_class, focus_class, sticky_class, separator: " ")
@@ -54,8 +51,6 @@ module Playbook
           template: template,
           placeholder: placeholder,
           inputOptions: input_options,
-          label: label,
-          requiredIndicator: required_indicator,
         }
       end
     end

data/app/pb_kits/playbook/pb_rich_text_editor/rich_text_editor.test.js

@@ -1,5 +1,5 @@
 import React from 'react'
-import { render, screen, fireEvent, waitFor, within } from '../utilities/test-utils'
+import { render, screen, fireEvent, waitFor } from '../utilities/test-utils'
 import { useEditor, EditorContent } from "@tiptap/react"
 import StarterKit from "@tiptap/starter-kit"
 
@@ -89,14 +89,14 @@ const TestAdvancedEditor = ({ toolbarOnFocus = false, ...props }) => {
 describe('Advanced TipTap Editor works as expected', () => {
   test('renders advanced editor with toolbar', () => {
     render(<TestAdvancedEditor />)
-
+    
     const kit = screen.getByTestId(testId)
     expect(kit).toHaveClass(kitClass)
-
+    
     // Check for advanced container
     const advancedContainer = kit.querySelector('.pb_rich_text_editor_advanced_container')
     expect(advancedContainer).toBeInTheDocument()
-
+    
     // Check for toolbar
     const toolbar = kit.querySelector('.toolbar')
     expect(toolbar).toBeInTheDocument()
@@ -104,7 +104,7 @@ describe('Advanced TipTap Editor works as expected', () => {
 
   test('renders advanced editor without toolbar when advancedEditorToolbar is false', () => {
     render(<TestAdvancedEditor advancedEditorToolbar={false} />)
-
+    
     const kit = screen.getByTestId(testId)
     const toolbar = kit.querySelector('.toolbar')
     expect(toolbar).not.toBeInTheDocument()
@@ -112,17 +112,17 @@ describe('Advanced TipTap Editor works as expected', () => {
 
   test('shows/hides toolbar on focus when focus is enabled', async () => {
     render(<TestAdvancedEditor focus />)
-
+    
     const kit = screen.getByTestId(testId)
-
+    
     // Initially toolbar should be hidden
     let toolbar = kit.querySelector('.toolbar')
     expect(toolbar).not.toBeInTheDocument()
-
+    
     const editorElement = kit.querySelector('.ProseMirror')
     // Focus the editor
     fireEvent.focus(editorElement)
-
+    
     // Toolbar should now be visible
     await waitFor(() => {
       toolbar = kit.querySelector('.toolbar')
@@ -133,7 +133,7 @@ describe('Advanced TipTap Editor works as expected', () => {
 
   test('supports simple prop with advanced editor', () => {
     render(<TestAdvancedEditor simple />)
-
+    
     const kit = screen.getByTestId(testId)
     const toolbar = kit.querySelector('.toolbar')
     expect(toolbar).toBeInTheDocument()
@@ -144,7 +144,7 @@ describe('Advanced TipTap Editor works as expected', () => {
 
     test('supports sticky prop with advanced editor', () => {
     render(<TestAdvancedEditor sticky />)
-
+    
     const kit = screen.getByTestId(testId)
     const stickyToolbar = kit.querySelector('.pb_rich_text_editor_tiptap_toolbar_sticky')
     expect(stickyToolbar).toBeInTheDocument()
@@ -154,52 +154,37 @@ describe('Advanced TipTap Editor works as expected', () => {
   test('applies aria-label when provided', () => {
     const ariaLabel = 'Rich Text Editor'
     render(<TestAdvancedEditor aria={{ label: ariaLabel }} />)
-
+    
     const kit = screen.getByTestId(testId)
     expect(kit).toHaveAttribute('aria-label', ariaLabel)
   })
 
   test('supports inline prop with advanced editor', () => {
     render(<TestAdvancedEditor inline />)
-
+    
     const kit = screen.getByTestId(testId)
     const toolbar = kit.querySelector('.toolbar')
     expect(toolbar).toBeInTheDocument()
     expect(kit).toHaveClass(`${kitClass} inline`)
   })
 
-  test('renders required indicator asterisk when requiredIndicator is true', () => {
-    render(
-      <RichTextEditor
-          data={{ testid: testId }}
-          label="Label"
-          requiredIndicator
-      />
-    )
-
-    const kit = screen.getByTestId(testId)
-    const label = within(kit).getByText(/Label/)
-
-    expect(label).toBeInTheDocument()
-    expect(kit).toHaveTextContent('*')
-  })
-
 describe('TipTap Editor Functionality', () => {
   test('can type and update content', async () => {
     render(<TestAdvancedEditor />)
-
+    
     const kit = screen.getByTestId(testId)
     const editorContent = kit.querySelector('.ProseMirror')
-
+    
     // Focus and type in the editor
     fireEvent.focus(editorContent)
-    fireEvent.input(editorContent, {
+    fireEvent.input(editorContent, { 
       target: { textContent: 'New content' }
     })
-
+    
     await waitFor(() => {
       expect(editorContent).toHaveTextContent('New content')
     })
   })
 })
 })
+