playbook_ui 15.0.0.pre.alpha.PLAY2453formtextfieldtextinputprops10419 → 15.0.0.pre.alpha.PLAY2467contactkitinternational10329

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (50) hide show
  1. checksums.yaml +4 -4
  2. data/app/pb_kits/playbook/pb_circle_icon_button/_circle_icon_button.tsx +0 -2
  3. data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.html.erb +0 -1
  4. data/app/pb_kits/playbook/pb_collapsible/__snapshots__/collapsible.test.js.snap +0 -1
  5. data/app/pb_kits/playbook/pb_contact/_contact.tsx +5 -0
  6. data/app/pb_kits/playbook/pb_contact/contact.rb +4 -0
  7. data/app/pb_kits/playbook/pb_contact/contact.test.js +21 -1
  8. data/app/pb_kits/playbook/pb_contact/docs/_contact_default.html.erb +16 -1
  9. data/app/pb_kits/playbook/pb_contact/docs/_contact_default.jsx +15 -0
  10. data/app/pb_kits/playbook/pb_contact/docs/_contact_default.md +5 -0
  11. data/app/pb_kits/playbook/pb_contact/docs/_contact_with_detail.html.erb +6 -0
  12. data/app/pb_kits/playbook/pb_contact/docs/_contact_with_detail.jsx +6 -0
  13. data/app/pb_kits/playbook/pb_date_picker/date_picker_helper.ts +4 -48
  14. data/app/pb_kits/playbook/pb_dialog/_close_icon.tsx +1 -5
  15. data/app/pb_kits/playbook/pb_dialog/_dialog.tsx +8 -6
  16. data/app/pb_kits/playbook/pb_dialog/dialog.html.erb +1 -1
  17. data/app/pb_kits/playbook/pb_dialog/dialogHelper.js +65 -0
  18. data/app/pb_kits/playbook/pb_dialog/dialog_header.html.erb +2 -2
  19. data/app/pb_kits/playbook/pb_icon/_icon.tsx +2 -13
  20. data/app/pb_kits/playbook/pb_icon/icon.rb +1 -9
  21. data/app/pb_kits/playbook/pb_icon_circle/icon_circle.html.erb +1 -1
  22. data/app/pb_kits/playbook/pb_loading_inline/_loading_inline.tsx +1 -3
  23. data/app/pb_kits/playbook/pb_loading_inline/docs/example.yml +0 -2
  24. data/app/pb_kits/playbook/pb_loading_inline/docs/index.js +0 -1
  25. data/app/pb_kits/playbook/pb_loading_inline/loading_inline.html.erb +1 -1
  26. data/app/pb_kits/playbook/pb_loading_inline/loading_inline.rb +0 -11
  27. data/app/pb_kits/playbook/pb_text_input/_text_input.tsx +0 -3
  28. data/app/pb_kits/playbook/pb_text_input/docs/example.yml +0 -3
  29. data/app/pb_kits/playbook/pb_text_input/docs/index.js +0 -1
  30. data/app/pb_kits/playbook/pb_text_input/text_input.rb +3 -2
  31. data/app/pb_kits/playbook/pb_text_input/text_input.test.js +0 -38
  32. data/dist/chunks/{_line_graph-B-n_nsLR.js → _line_graph-CApw7aQD.js} +1 -1
  33. data/dist/chunks/_typeahead-J1_avqdO.js +6 -0
  34. data/dist/chunks/_weekday_stacked-BSRRJewP.js +37 -0
  35. data/dist/chunks/{lib-BTs5acfO.js → lib-CY5ZPzic.js} +1 -1
  36. data/dist/chunks/{pb_form_validation-CKkaQFX3.js → pb_form_validation-D3b0JKHH.js} +1 -1
  37. data/dist/chunks/vendor.js +1 -1
  38. data/dist/playbook-doc.js +2 -2
  39. data/dist/playbook-rails-react-bindings.js +1 -1
  40. data/dist/playbook-rails.js +1 -1
  41. data/lib/playbook/forms/builder/form_field_builder.rb +1 -28
  42. data/lib/playbook/version.rb +1 -1
  43. metadata +9 -12
  44. data/app/pb_kits/playbook/pb_loading_inline/docs/_loading_inline_variant.html.erb +0 -5
  45. data/app/pb_kits/playbook/pb_loading_inline/docs/_loading_inline_variant.jsx +0 -24
  46. data/app/pb_kits/playbook/pb_text_input/docs/_text_input_autocomplete.html.erb +0 -41
  47. data/app/pb_kits/playbook/pb_text_input/docs/_text_input_autocomplete.jsx +0 -80
  48. data/app/pb_kits/playbook/pb_text_input/docs/_text_input_autocomplete.md +0 -1
  49. data/dist/chunks/_typeahead-CS9PvM1x.js +0 -6
  50. data/dist/chunks/_weekday_stacked-DaFBilv5.js +0 -37
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 54fcd1f906850aef4a0cb6bed59528aba515ecad3d77d7b683aec6ad648c35f7
4
- data.tar.gz: 44872dba3a60477e53e025edbede11499ebfb6222726bcd75c1182ba240f4b87
3
+ metadata.gz: 5f20e205eef51d77bf9ce4b5694d675e30bfbe4ef8107c96b016868302ccaba3
4
+ data.tar.gz: 89c8ffe59230989390b0cb8031a47b3191bd5463b190f62465b10679a2dbf531
5
5
  SHA512:
6
- metadata.gz: 73dca3aa1816d3ff4bc58fe03c114d7e82a76d48fec71fa41944f483dfc825d21f8bae7a3ba68dfe66f82edc77971c753b8101f3fe6bf16231912ec15b21f105
7
- data.tar.gz: 5a3824c690ae7f0fb824d02fafb68c7efce49b3bd84ee494c69e1ab9aa871f473ba05962eb041a4bcba1a8cb51d858a43140ed989d455e10d94d61f19e02352b
6
+ metadata.gz: 6c25d0d330b79ffdc47501616db7bdbe0577c48ce9fa5d33b8ea7d6058c9ce98674d72664ca312f6d79ddaf59b662701b8a136bb0ca589447c4ea8b72bbf97a8
7
+ data.tar.gz: f42561f7ad3f69134d46779d00d75c0aff2998c042a0c6ef5839131c80f788559de516772297a606049a2827222b863d0b434febf32ca28d0aadca4cb8e7b0c4
@@ -65,7 +65,6 @@ const CircleIconButton = (props: CircleIconButtonProps): React.ReactElement => {
65
65
  id={id}
66
66
  >
67
67
  <Button
68
- aria={aria}
69
68
  dark={dark}
70
69
  disabled={disabled}
71
70
  htmlType={type}
@@ -79,7 +78,6 @@ const CircleIconButton = (props: CircleIconButtonProps): React.ReactElement => {
79
78
  >
80
79
  <Icon
81
80
  fixedWidth
82
- htmlOptions={{'aria-hidden': true}}
83
81
  icon={icon}
84
82
  />
85
83
  </Button>
@@ -1,6 +1,5 @@
1
1
  <%= pb_content_tag do %>
2
2
  <%= pb_rails("button", props: {
3
- aria: object.aria,
4
3
  type: object.type,
5
4
  loading: object.loading,
6
5
  link: object.link,
@@ -28,7 +28,6 @@ exports[`html structure is correct 1`] = `
28
28
  style="vertical-align: middle; color: rgb(193, 205, 214);"
29
29
  >
30
30
  <svg
31
- aria-label="chevron-down icon"
32
31
  class="pb_custom_icon svg-inline--fa svg_lg svg_fw"
33
32
  color="currentColor"
34
33
  fill="none"
@@ -17,6 +17,7 @@ const contactTypeMap: { [key: string]: string } = {
17
17
  'work': 'phone-office',
18
18
  'work-cell': 'phone-laptop',
19
19
  'wrong-phone': 'phone-slash',
20
+ 'international': 'globe',
20
21
  }
21
22
 
22
23
  const envelopeIcon = getAllIcons()["envelope"].icon as unknown as { [key: string]: SVGElement }
@@ -24,6 +25,10 @@ const envelopeIcon = getAllIcons()["envelope"].icon as unknown as { [key: string
24
25
  const formatContact = (contactString: string, contactType: string) => {
25
26
  if (contactType === 'email') return contactString
26
27
 
28
+ // International phone numbers are unformatted
29
+ if (contactType === 'international') return contactString
30
+
31
+ // Format US numbers
27
32
  const cleaned = contactString.replace(/\D/g, '')
28
33
  const phoneNumber = cleaned.match(/^(1|)?(\d{3})(\d{3})(\d{4})$/)
29
34
 
@@ -29,6 +29,8 @@ module Playbook
29
29
  "phone-slash"
30
30
  when "extension"
31
31
  "phone-plus"
32
+ when "international"
33
+ "globe"
32
34
  else # "unknown" || "other"
33
35
  "phone"
34
36
  end
@@ -39,6 +41,8 @@ module Playbook
39
41
  contact_value
40
42
  elsif contact_type == "extension" && contact_value.match(/^\d{4}$/)
41
43
  contact_value
44
+ elsif contact_type == "international"
45
+ contact_value
42
46
  else
43
47
  number_to_phone(formatted_value, area_code: true)
44
48
  end
@@ -66,6 +66,12 @@ test('returns correct icon', () => {
66
66
  contactValue="1234"
67
67
  data={{ testid: 'test-extension' }}
68
68
  />
69
+ <Contact
70
+ contactDetail="International"
71
+ contactType="international"
72
+ contactValue="+44 20 7946 0958"
73
+ data={{ testid: 'test-international' }}
74
+ />
69
75
  <Contact
70
76
  contactDetail=""
71
77
  contactType=""
@@ -83,10 +89,11 @@ test('returns correct icon', () => {
83
89
  expect(screen.getByTestId('test-wrong-phone').querySelector('.pb_custom_icon')).toBeInTheDocument()
84
90
  expect(screen.getByTestId('test-wrong-type').querySelector('.pb_custom_icon')).toBeInTheDocument()
85
91
  expect(screen.getByTestId('test-extension').querySelector('.pb_custom_icon')).toBeInTheDocument()
92
+ expect(screen.getByTestId('test-international').querySelector('.pb_custom_icon')).toBeInTheDocument()
86
93
  expect(screen.getByTestId('test-empty').querySelector('.pb_custom_icon')).toBeInTheDocument()
87
94
  })
88
95
 
89
- test("not compliant values return null in phone related contact types", () => {
96
+ test("not compliant values return null in US phone related contact types", () => {
90
97
  const notCompliantValues = [
91
98
  "349-185-998223",
92
99
  "349-1858",
@@ -129,3 +136,16 @@ test("not compliant values return null in phone related contact types", () => {
129
136
  )
130
137
  })
131
138
  })
139
+
140
+ test('international contact type preserves original format', () => {
141
+ render(
142
+ <Contact
143
+ contactType="international"
144
+ contactValue="+44 20 7946 0958"
145
+ data={{ testid: 'test-international-format' }}
146
+ />
147
+ )
148
+
149
+ const kit = screen.getByTestId('test-international-format')
150
+ expect(kit).toHaveTextContent('+44 20 7946 0958')
151
+ })
@@ -13,7 +13,7 @@
13
13
  }) %>
14
14
 
15
15
  <%= pb_rails("contact", props: {
16
- contact_type: "wrong number",
16
+ contact_type: "work",
17
17
  contact_value: "3245627482",
18
18
  }) %>
19
19
 
@@ -21,3 +21,18 @@
21
21
  contact_type: "work-cell",
22
22
  contact_value: "349-185-9988",
23
23
  }) %>
24
+
25
+ <%= pb_rails("contact", props: {
26
+ contact_type: "wrong-phone",
27
+ contact_value: "2124396666",
28
+ }) %>
29
+
30
+ <%= pb_rails("contact", props: {
31
+ contact_type: "extension",
32
+ contact_value: "1233",
33
+ }) %>
34
+
35
+ <%= pb_rails("contact", props: {
36
+ contact_type: "international",
37
+ contact_value: "+44 7700 900461",
38
+ }) %>
@@ -28,6 +28,21 @@ const ContactDefault = (props) => {
28
28
  contactValue="3245627482"
29
29
  {...props}
30
30
  />
31
+ <Contact
32
+ contactType="wrong-phone"
33
+ contactValue="2124396666"
34
+ {...props}
35
+ />
36
+ <Contact
37
+ contactType='extension'
38
+ contactValue="1234"
39
+ {...props}
40
+ />
41
+ <Contact
42
+ contactType="international"
43
+ contactValue="+44 7700 900461"
44
+ {...props}
45
+ />
31
46
  </div>
32
47
  )
33
48
  }
@@ -0,0 +1,5 @@
1
+ The Contact kit automatically formats US phone numbers when the `contactType` / `contact_type` is one of: `home` (default), `work`, `cell`, `work-cell`, `wrong-phone`.
2
+
3
+ - Use `email` to display emails.
4
+ - Use `international` to display International phone numbers exactly as provided (no formatting applied).
5
+ - Use `extension` to display four digit phone extensions.
@@ -26,3 +26,9 @@
26
26
  contact_value: "1233",
27
27
  contact_detail: "Ext",
28
28
  }) %>
29
+
30
+ <%= pb_rails("contact", props: {
31
+ contact_type: "international",
32
+ contact_value: "+44 7700 900461",
33
+ contact_detail: "International",
34
+ }) %>
@@ -33,6 +33,12 @@ const ContactDefault = (props) => {
33
33
  contactValue="1234"
34
34
  {...props}
35
35
  />
36
+ <Contact
37
+ contactDetail="International"
38
+ contactType="international"
39
+ contactValue="+44 7700 900461"
40
+ {...props}
41
+ />
36
42
  </div>
37
43
  )
38
44
  }
@@ -89,48 +89,6 @@ const datePickerHelper = (config: DatePickerConfig, scrollContainer: string | HT
89
89
  }
90
90
  }
91
91
 
92
- // Helper function to get min/max years based on yearRange. If minDate/maxDate provided, grab year from those values
93
- const getMinMaxYears = () => {
94
- const [minYear, maxYear] = yearRange;
95
-
96
- const extractYear = (dateOption: typeof minDate | typeof maxDate): number | null => {
97
- if (!dateOption) return null;
98
-
99
- // If it's already a number, assume it's a year
100
- if (typeof dateOption === 'number') {
101
- return dateOption;
102
- }
103
-
104
- // If it's a string, extract year with regex
105
- if (typeof dateOption === 'string') {
106
- const match = dateOption.match(/\b(19|20)\d{2}\b/);
107
- return match ? parseInt(match[0], 10) : null;
108
- }
109
-
110
- // If it's a Date object, get the year directly
111
- if (dateOption instanceof Date) {
112
- return dateOption.getFullYear();
113
- }
114
-
115
- return null;
116
- };
117
-
118
- const setMinYear = minDate ? (extractYear(minDate) ?? minYear) : minYear;
119
- const setMaxYear = maxDate ? (extractYear(maxDate) ?? maxYear) : maxYear;
120
-
121
- return { setMinYear, setMaxYear };
122
- };
123
-
124
- const { setMinYear, setMaxYear } = getMinMaxYears()
125
-
126
- // Helper function to get min/max dates based on yearRange
127
- const getMinMaxDates = () => {
128
- const setMinDate = minDate || `01/01/${setMinYear}`
129
- const setMaxDate = maxDate || `12/31/${setMaxYear}`
130
-
131
- return { setMinDate, setMaxDate }
132
- }
133
-
134
92
  const disabledWeekDays = () => {
135
93
  return (
136
94
  [
@@ -243,8 +201,6 @@ const datePickerHelper = (config: DatePickerConfig, scrollContainer: string | HT
243
201
  // | Flatpickr initializer w/ config |
244
202
  // ===========================================================
245
203
 
246
- const { setMinDate, setMaxDate } = getMinMaxDates()
247
-
248
204
  flatpickr(`#${pickerId}`, {
249
205
  allowInput,
250
206
  closeOnSelect,
@@ -256,8 +212,8 @@ const datePickerHelper = (config: DatePickerConfig, scrollContainer: string | HT
256
212
  locale: {
257
213
  rangeSeparator: ' to '
258
214
  },
259
- maxDate: setMaxDate,
260
- minDate: setMinDate,
215
+ maxDate,
216
+ minDate,
261
217
  mode,
262
218
  nextArrow: '<i class="far fa-angle-right"></i>',
263
219
  onOpen: [() => {
@@ -294,7 +250,7 @@ const datePickerHelper = (config: DatePickerConfig, scrollContainer: string | HT
294
250
 
295
251
  // create html option tags for desired years
296
252
  let years = ''
297
- for (let year = setMaxYear; year >= setMinYear; year--) {
253
+ for (let year = yearRange[1]; year >= yearRange[0]; year--) {
298
254
  years += `<option value="${year}">${year}</option>`
299
255
  }
300
256
 
@@ -367,7 +323,7 @@ const datePickerHelper = (config: DatePickerConfig, scrollContainer: string | HT
367
323
  }
368
324
  // === End of Automatic Sync Logic ===
369
325
 
370
-
326
+
371
327
  // Adding dropdown icons to year and month select
372
328
  dropdown.insertAdjacentHTML('afterend', `<i class="year-dropdown-icon">${angleDown}</i>`)
373
329
  if (picker.monthElements[0].parentElement) {
@@ -12,14 +12,10 @@ export const CloseIcon = (props: CloseIconProps): React.ReactElement => {
12
12
  const timesIcon = getAllIcons()["times"]
13
13
  return (
14
14
  <div
15
- aria-label="Close Dialog"
16
15
  className="pb_dialog_close_icon"
17
- onClick={onClose}
18
- role="button"
19
- tabIndex={0}
16
+ onClick={onClose}
20
17
  >
21
18
  <Icon
22
- aria={{ "hidden": true }}
23
19
  className="svg-inline--fa"
24
20
  customIcon={timesIcon.icon as unknown as { [key: string]: SVGElement }}
25
21
  fixedWidth
@@ -73,8 +73,8 @@ const Dialog = (props: DialogProps): React.ReactElement => {
73
73
  const ariaProps = buildAriaProps(aria);
74
74
  const dataProps = buildDataProps(data)
75
75
  const htmlProps = buildHtmlProps(htmlOptions);
76
- const classes = {
77
- base: classnames("pb_dialog", buildCss("pb_dialog", size, placement), globalProps(props), className),
76
+ const dialogClassNames = {
77
+ base: classnames("pb_dialog", buildCss("pb_dialog", size, placement)),
78
78
  afterOpen: "pb_dialog_after_open",
79
79
  beforeClose: "pb_dialog_before_close",
80
80
  };
@@ -93,8 +93,10 @@ const Dialog = (props: DialogProps): React.ReactElement => {
93
93
 
94
94
  const dynamicInlineProps = globalInlineProps(props);
95
95
 
96
- const wrapperClasses = classnames(
96
+ const classes = classnames(
97
97
  buildCss("pb_dialog_wrapper"),
98
+ globalProps(props),
99
+ className
98
100
  );
99
101
 
100
102
  const [triggerOpened, setTriggerOpened] = useState(false),
@@ -171,13 +173,13 @@ const Dialog = (props: DialogProps): React.ReactElement => {
171
173
  {...ariaProps}
172
174
  {...dataProps}
173
175
  {...htmlProps}
174
- className={wrapperClasses}
176
+ className={classes}
175
177
  >
176
178
  <Modal
177
179
  ariaHideApp={false}
178
- className={classes}
180
+ className={dialogClassNames}
179
181
  closeTimeoutMS={200}
180
- contentLabel="Dialog"
182
+ contentLabel="Minimal Modal Example"
181
183
  id={id}
182
184
  isOpen={modalIsOpened}
183
185
  onRequestClose={onClose}
@@ -12,7 +12,7 @@
12
12
  data-cancel-button-id="<%= object.cancel_button_id %>"
13
13
  <% end %>
14
14
  >
15
- <%= pb_content_tag(:dialog, role: "dialog", "aria-modal": "true", "aria-label": "Dialog") do %>
15
+ <%= pb_content_tag(:dialog) do %>
16
16
  <% if object.status === "" && object.title %>
17
17
  <%= pb_rails("dialog/dialog_header", props: { title: object.title, id: object.id }) %>
18
18
  <% end %>
@@ -0,0 +1,65 @@
1
+ // Three places in Nitro depend on this function inside the window scope.
2
+ // We will keep this file until we remove this dependency from Nitro.
3
+ const dialogHelper = () => {
4
+ const openTrigger = document.querySelectorAll("[data-open-dialog]");
5
+ const closeTrigger = document.querySelectorAll("[data-close-dialog]");
6
+ const dialogs = document.querySelectorAll(".pb_dialog_rails")
7
+
8
+ const loadingButton = document.querySelector('[data-disable-with="Loading"]');
9
+ if (loadingButton) {
10
+ loadingButton.addEventListener("click", function() {
11
+ const okayLoadingButton = document.querySelector('[data-disable-with="Loading"]');
12
+ const cancelButton = document.querySelector('[data-disable-cancel-with="Loading"]');
13
+ let currentClass = okayLoadingButton.className;
14
+ let cancelClass = cancelButton ? cancelButton.className : "";
15
+
16
+ let newClass = currentClass.replace("_enabled", "_disabled_loading");
17
+ let newCancelClass = cancelClass.replace("_enabled", "_disabled");
18
+
19
+ // Disable the buttons
20
+ okayLoadingButton.disabled = true;
21
+ if (cancelButton) cancelButton.disabled = true;
22
+
23
+ okayLoadingButton.className = newClass;
24
+ if (cancelButton) cancelButton.className = newCancelClass;
25
+ });
26
+ }
27
+
28
+
29
+ openTrigger.forEach((open) => {
30
+ open.addEventListener("click", () => {
31
+ var openTriggerData = open.dataset.openDialog;
32
+ var targetDialog = document.getElementById(openTriggerData)
33
+ if (targetDialog.open) return;
34
+ targetDialog.showModal();
35
+ });
36
+ });
37
+
38
+ closeTrigger.forEach((close) => {
39
+ close.addEventListener("click", () => {
40
+ var closeTriggerData = close.dataset.closeDialog;
41
+ document.getElementById(closeTriggerData).close();
42
+ });
43
+ });
44
+
45
+ // Close dialog box on outside click
46
+ dialogs.forEach((dialogElement) => {
47
+ dialogElement.addEventListener("mousedown", (event) => {
48
+ const dialogParentDataset = dialogElement.parentElement.dataset
49
+ if (dialogParentDataset.overlayClick === "overlay_close") return
50
+
51
+ const dialogModal = event.target.getBoundingClientRect()
52
+ const clickedOutsideDialogModal = event.clientX < dialogModal.left ||
53
+ event.clientX > dialogModal.right ||
54
+ event.clientY < dialogModal.top ||
55
+ event.clientY > dialogModal.bottom
56
+
57
+ if (clickedOutsideDialogModal) {
58
+ dialogElement.close()
59
+ event.stopPropagation()
60
+ }
61
+ })
62
+ })
63
+ };
64
+
65
+ export default dialogHelper;
@@ -2,8 +2,8 @@
2
2
  <%= pb_rails("flex", props: {classname:object.classname, spacing:"between", padding:"sm", align:"center"}) do %>
3
3
  <%= content.presence || object.title %>
4
4
 
5
- <button class="dialog-button-class pb_dialog_close_icon" type="button" data-close-dialog= <%= object.id %> aria-label="Close Dialog" >
6
- <%= pb_rails("icon", props: { custom_icon: Playbook::Engine::root.join(times_icon), aria: { hidden: true } }) %>
5
+ <button class="dialog-button-class pb_dialog_close_icon" type="button" data-close-dialog= <%= object.id %> >
6
+ <%= pb_rails("icon", props: { custom_icon: Playbook::Engine::root.join(times_icon) }) %>
7
7
  </button>
8
8
  <% end %>
9
9
  <%= pb_rails("section_separator") %>
@@ -20,7 +20,7 @@ export type IconSizes = "lg"
20
20
  | ""
21
21
 
22
22
  type IconProps = {
23
- aria?: { [key: string]: string | boolean }
23
+ aria?: {[key: string]: string},
24
24
  border?: string,
25
25
  className?: string,
26
26
  color?: string,
@@ -211,15 +211,7 @@ const Icon = (props: IconProps) => {
211
211
  )
212
212
 
213
213
  aria.label ? null : aria.label = `${icon} icon`
214
-
215
- const normalizedAria: { [key: string]: string } = Object.fromEntries(
216
- Object.entries(aria).map(([key, value]) => [
217
- key,
218
- typeof value === "boolean" ? String(value) : value,
219
- ])
220
- )
221
-
222
- const ariaProps = buildAriaProps(normalizedAria)
214
+ const ariaProps: {[key: string]: any} = buildAriaProps(aria)
223
215
  const dataProps: {[key: string]: any} = buildDataProps(data)
224
216
  const htmlProps = buildHtmlProps(htmlOptions)
225
217
 
@@ -230,7 +222,6 @@ const Icon = (props: IconProps) => {
230
222
  <>
231
223
  {
232
224
  React.cloneElement(iconElement || customIcon, {
233
- ...ariaProps,
234
225
  ...dataProps,
235
226
  ...htmlProps,
236
227
  className: classes,
@@ -246,7 +237,6 @@ const Icon = (props: IconProps) => {
246
237
  return (
247
238
  <>
248
239
  <span
249
- {...ariaProps}
250
240
  {...dataProps}
251
241
  {...htmlProps}
252
242
  className={classesEmoji}
@@ -260,7 +250,6 @@ const Icon = (props: IconProps) => {
260
250
  return (
261
251
  <>
262
252
  <i
263
- {...ariaProps}
264
253
  {...dataProps}
265
254
  {...htmlProps}
266
255
  className={classes}
@@ -110,20 +110,12 @@ module Playbook
110
110
  svg["class"] = %w[pb_custom_icon svg-inline--fa].concat([object.custom_icon_classname]).join(" ")
111
111
  svg["id"] = object.id
112
112
  svg["data"] = object.data
113
+ svg["aria"] = object.aria
113
114
  svg["height"] = "auto"
114
115
  svg["width"] = "auto"
115
116
  svg["tabindex"] = object.tabindex
116
117
  fill_color = object.color || "currentColor"
117
118
  doc.at_css("path")["fill"] = fill_color
118
-
119
- if object.aria.present?
120
- object.aria.each do |key, value|
121
- k = key.to_s
122
- attr = k.start_with?("aria-") ? k : "aria-#{k.tr('_', '-')}"
123
- svg[attr] = value
124
- end
125
- end
126
-
127
119
  raw doc
128
120
  rescue OpenURI::HTTPError, StandardError
129
121
  # Handle any exceptions and return an empty string
@@ -1,3 +1,3 @@
1
1
  <%= pb_content_tag do %>
2
- <%= pb_rails("icon", props: { dark: object.dark, icon: object.icon, fixed_width: true, aria: { "aria-label": "#{object.icon} icon" } }) %>
2
+ <%= pb_rails("icon", props: { dark: object.dark, icon: object.icon, fixed_width: true }) %>
3
3
  <% end %>
@@ -16,7 +16,6 @@ type LoadingInlineProps = {
16
16
  htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
17
17
  id?: string,
18
18
  text?: string,
19
- variant?: "dotted" | "solid" ,
20
19
  }
21
20
 
22
21
  const LoadingInline = (props: LoadingInlineProps) => {
@@ -29,7 +28,6 @@ const LoadingInline = (props: LoadingInlineProps) => {
29
28
  htmlOptions = {},
30
29
  id,
31
30
  text = ' Loading',
32
- variant = 'dotted',
33
31
  } = props
34
32
 
35
33
  const ariaProps = buildAriaProps(aria)
@@ -56,7 +54,7 @@ const LoadingInline = (props: LoadingInlineProps) => {
56
54
  <Icon
57
55
  aria={{ label: 'loading icon' }}
58
56
  fixedWidth
59
- icon={variant === 'dotted' ? 'spinner' : variant === 'solid' ? 'spinner-solid' : undefined}
57
+ icon="spinner"
60
58
  pulse
61
59
  />
62
60
  {text}
@@ -3,11 +3,9 @@ examples:
3
3
  rails:
4
4
  - loading_inline_default: Default
5
5
  - loading_inline_custom: Custom Text
6
- - loading_inline_variant: Variant
7
6
 
8
7
 
9
8
 
10
9
  react:
11
10
  - loading_inline_default: Default
12
11
  - loading_inline_custom: Custom Text
13
- - loading_inline_variant: Variant
@@ -1,3 +1,2 @@
1
1
  export { default as LoadingInlineDefault } from './_loading_inline_default.jsx'
2
2
  export { default as LoadingInlineCustom } from './_loading_inline_custom.jsx'
3
- export { default as LoadingInlineVariant } from './_loading_inline_variant.jsx'
@@ -1,6 +1,6 @@
1
1
  <%= pb_content_tag do %>
2
2
 
3
3
  <%= pb_rails("body", props: { color: "light", dark: object.dark }) do %>
4
- <%= pb_rails("icon", props: { aria: { label: "loading icon" }, fixed_width: true, icon: object.spinner_icon, pulse: true }) %> <%= object.text %>
4
+ <%= pb_rails("icon", props: { aria: { label: "loading icon" }, fixed_width: true, icon: "spinner", pulse: true }) %> <%= object.text %>
5
5
  <% end %>
6
6
  <% end %>
@@ -8,21 +8,10 @@ module Playbook
8
8
  default: "left"
9
9
  prop :dark, type: Playbook::Props::Boolean, default: false
10
10
  prop :text, type: Playbook::Props::String, default: "Loading"
11
- prop :variant, type: Playbook::Props::Enum,
12
- values: %w[dotted solid],
13
- default: "dotted"
14
11
 
15
12
  def classname
16
13
  generate_classname("pb_loading_inline_kit", align)
17
14
  end
18
-
19
- def spinner_icon
20
- if variant == "dotted"
21
- "spinner"
22
- elsif variant == "solid"
23
- "spinner-solid"
24
- end
25
- end
26
15
  end
27
16
  end
28
17
  end
@@ -36,7 +36,6 @@ type TextInputProps = {
36
36
  alignment?: "right" | "left",
37
37
  border?: boolean,
38
38
  },
39
- autoComplete?: boolean | string,
40
39
  } & GlobalProps
41
40
 
42
41
  const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>) => {
@@ -60,7 +59,6 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
60
59
  type = 'text',
61
60
  value = '',
62
61
  children = null,
63
- autoComplete = true,
64
62
  } = props
65
63
 
66
64
  const ariaProps = buildAriaProps(aria)
@@ -144,7 +142,6 @@ const TextInput = (props: TextInputProps, ref: React.LegacyRef<HTMLInputElement>
144
142
  childInput ? React.cloneElement(children, { className: "text_input" }) :
145
143
  (<input
146
144
  {...domSafeProps(props)}
147
- autoComplete={typeof autoComplete === "string" ? autoComplete : ( autoComplete ? undefined : "off" )}
148
145
  className="text_input"
149
146
  disabled={disabled}
150
147
  id={id}
@@ -9,8 +9,6 @@ examples:
9
9
  - text_input_no_label: No Label
10
10
  - text_input_options: Input Options
11
11
  - text_input_mask: Mask
12
- - text_input_autocomplete: Autocomplete
13
-
14
12
  react:
15
13
  - text_input_default: Default
16
14
  - text_input_error: With Error
@@ -21,7 +19,6 @@ examples:
21
19
  - text_input_no_label: No Label
22
20
  - text_input_mask: Mask
23
21
  - text_input_sanitize: Sanitized Masked Input
24
- - text_input_autocomplete: Autocomplete
25
22
 
26
23
 
27
24
  swift:
@@ -7,4 +7,3 @@ export { default as TextInputInline } from './_text_input_inline.jsx'
7
7
  export { default as TextInputNoLabel } from './_text_input_no_label.jsx'
8
8
  export { default as TextInputMask } from './_text_input_mask.jsx'
9
9
  export { default as TextInputSanitize } from './_text_input_sanitize.jsx'
10
- export { default as TextInputAutocomplete } from './_text_input_autocomplete.jsx'
@@ -15,7 +15,8 @@ module Playbook
15
15
  "cvv" => '\d{3,4}',
16
16
  }.freeze
17
17
 
18
- prop :autocomplete, default: true
18
+ prop :autocomplete, type: Playbook::Props::Boolean,
19
+ default: true
19
20
  prop :disabled, type: Playbook::Props::Boolean,
20
21
  default: false
21
22
  prop :error
@@ -68,7 +69,7 @@ module Playbook
68
69
 
69
70
  def all_input_options
70
71
  {
71
- autocomplete: autocomplete == true ? nil : (autocomplete.presence || "off"),
72
+ autocomplete: autocomplete ? nil : "off",
72
73
  class: "text_input #{input_options.dig(:classname) || ''}",
73
74
  data: validation_data,
74
75
  disabled: disabled,