playbook_ui 14.3.0.pre.alpha.revert3654PBNTR479removeextraspacingfromradiochildren3734 → 14.3.0.pre.rc.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b861b308f5b72f96eef50aec3bbdd59b377091d82766a2a494425c483e930472
-  data.tar.gz: 0113bca621569af9ae171149beb961330cad59d299c3831218d62a0b499426de
+  metadata.gz: 4daa4bafdd35c3b83a98323eaa16e7edca9e4bb963f961663a5f2edeca3f7814
+  data.tar.gz: 36ea0641461016941eaced65696528dd29ec39976de03491359742ee34e0f29e
 SHA512:
-  metadata.gz: 0bc05d0bc6a8bd697898a74eb9d1ba9cf48c33e39b7fb634a5dc8dd06d6a12e21efaaaccce4e0003780d7eb8b51d53545fb477f4fc9fdbca930ab8870a5b7eef
-  data.tar.gz: dabc33f130e3ef9ed3dc083157ebcb9069a50d2a00b3e2a1ea59138581888ee58ebf85426a8693eb1d159b18e2739ce6d862ca1d2e6a9cc28d8b7ccf685ed55a
+  metadata.gz: d37e0a7b3fc4d054b5ebebbbbe4f26d3866760ccbbffc771eebd6159e3dc87400b109195814c1a3144b82e682fec154166f69f167ef20d842eedab09c6967df8
+  data.tar.gz: 0e89c8c1158d343ff42e84c1a16f1c7093d220d0f126dd48d1226d6b869900e7d5f7f6c3e7b4b60e04524d9bf25847a34e61fea9b1150a4f2e07619105f5c8a4

data/app/pb_kits/playbook/pb_avatar_action_button/_avatar_action_button.scss

@@ -35,8 +35,8 @@
     &[class*=_#{$name}] {
       
       $avatar_size: map-get($avatar-sizes, $name);
-      $icon_size: $avatar_size / 2;
-      $border_size: $icon_size / 10;
+      $icon_size: calc($avatar_size / 2);
+      $border_size: calc($icon_size / 10);
 
       position: relative;
       width: $avatar_size * 1.25;
@@ -59,7 +59,7 @@
         left: $icon_size * 1.5;
       }
       &[class*=_left] [class^=pb_avatar_kit] {
-        padding-left: $icon_size / 2;
+        padding-left: calc($icon_size / 2);
       }
     }
   }

data/app/pb_kits/playbook/pb_badge/_badge.scss

@@ -11,7 +11,7 @@
   align-items: center;
   justify-content: center;
   border-radius: $border_rad_light;
-  padding: 0 $space_xs/2;
+  padding: 0 calc($space_xs/2);
   border-width: 1px;
   border-style: solid;
   border-color: $card_light;
@@ -34,7 +34,7 @@
     height: $pb_badge_height;
     min-height: $pb_badge_height;
     min-width: $pb_badge_height;
-    border-radius: $pb_badge_height / 2;
+    border-radius: calc($pb_badge_height / 2);
   }
 
   &[class*=_notification] {

data/app/pb_kits/playbook/pb_bread_crumbs/_bread_crumbs.scss

@@ -9,7 +9,7 @@
   display: inline-flex;
   align-items: center;
   justify-content: center;
-  padding: 0 $space_xs/2;
+  padding: 0 calc($space_xs/2);
 
   svg {
    margin-right: 8px;

data/app/pb_kits/playbook/pb_button/_button.scss

@@ -17,7 +17,7 @@ $pb_button_sizes: (
   @each $name, $size in $pb_button_sizes {
     &[class*=size_#{$name}] {
       font-size: $size;
-      padding: $size / 2 $size * 2.42;
+      padding: calc(#{$size} / 2) calc(#{$size} * 2.42);
       @if $name == "sm" {
         min-height: 0;
       }

data/app/pb_kits/playbook/pb_button_toolbar/_button_toolbar_mixins.scss

@@ -11,13 +11,13 @@ $secondary_dark:      rgba($bg_dark, $opacity_2);
     @if $horizontal == true {
         height: 2px;
         width: calc(100% + #{$space_md} + #{$space_md});
-        top: -$space_xs - 1px;
+        top: calc(-#{$space_xs} - 1px);
         left: -$space_md;
     } @else {
         width: 2px;
         height: $space_md;
         top: 0;
-        right: $space_lg + 2px;
+        right: calc(#{$space_lg} + 2px);
     }
     background-color: $color;
     content: '';

data/app/pb_kits/playbook/pb_circle_icon_button/_circle_icon_button.scss

@@ -16,7 +16,7 @@ $pb_button_styles: (
   flex-grow: 0;
   width: $pb_button_size;
   height: $pb_button_size;
-  border-radius: $pb_button_size / 2;
+  border-radius: calc($pb_button_size/2);
   line-height: $pb_button_size;
   flex-basis: $pb_button_size;
   min-width: $pb_button_size;

data/app/pb_kits/playbook/pb_circle_icon_button/_circle_icon_button.tsx

@@ -16,7 +16,6 @@ type CircleIconButtonProps = {
   htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
   id?: string,
   link?: string,
-  loading?: boolean,
   onClick?: React.MouseEventHandler<HTMLElement>,
   newWindow?: boolean,
   type?: 'button' | 'submit' | 'reset' | undefined,
@@ -33,7 +32,6 @@ const CircleIconButton = (props: CircleIconButtonProps): React.ReactElement => {
     htmlOptions = {},
     icon,
     id,
-    loading = false,
     onClick = noop,
     type,
     link,
@@ -63,7 +61,6 @@ const CircleIconButton = (props: CircleIconButtonProps): React.ReactElement => {
           disabled={disabled}
           htmlType={type}
           link={link}
-          loading={loading}
           newWindow={newWindow}
           onClick={onClick}
           text={null}

data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.html.erb

@@ -1,5 +1,5 @@
 <%= pb_content_tag do %>
-  <%= pb_rails("button", props: {type: object.type, loading: object.loading, link: object.link, new_window:object.new_window, variant: object.variant, disabled: object.disabled, dark: object.dark}) do %>
+  <%= pb_rails("button", props: {type: object.type, link: object.link, new_window:object.new_window, variant: object.variant, disabled: object.disabled, dark: object.dark}) do %>
     <%= pb_rails("icon", props: {icon: object.icon, fixed_width: true, dark: object.dark}) %>
   <% end %>
 <% end %>

data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.rb

@@ -12,8 +12,6 @@ module Playbook
       prop :disabled, type: Playbook::Props::Boolean,
                       default: false
       prop :icon, required: true
-      prop :loading, type: Playbook::Props::Boolean,
-                     default: false
       prop :link
       prop :new_window, type: Playbook::Props::Boolean,
                         default: false

data/app/pb_kits/playbook/pb_circle_icon_button/circle_icon_button.test.js

@@ -15,18 +15,3 @@ test('default test', () => {
 
   expect(kit).toHaveClass('pb_circle_icon_button_kit')
 })
-
-test('passes loading prop to button', () => {
-  render(
-    <CircleIconButton
-        data={{ testid: 'loading-test' }}
-        icon="plus"
-        loading
-    />
-  )
-
-  const kit = screen.getByTestId('loading-test')
-  const button = kit.querySelector('.pb_button_kit_primary_inline_enabled_loading')
-  
-  expect(button).toBeInTheDocument()
-})

data/app/pb_kits/playbook/pb_circle_icon_button/docs/example.yml

@@ -3,10 +3,8 @@ examples:
   rails:
   - circle_icon_button_default: Default
   - circle_icon_button_link: Link
-  - circle_icon_button_loading: Loading
   
   react:
   - circle_icon_button_default: Default
   - circle_icon_button_click: Click Handler
   - circle_icon_button_link: Link
-  - circle_icon_button_loading: Loading

data/app/pb_kits/playbook/pb_circle_icon_button/docs/index.js

@@ -1,4 +1,3 @@
 export { default as CircleIconButtonDefault } from './_circle_icon_button_default.jsx'
 export { default as CircleIconButtonClick } from './_circle_icon_button_click.jsx'
 export { default as CircleIconButtonLink } from './_circle_icon_button_link.jsx'
-export { default as CircleIconButtonLoading } from './_circle_icon_button_loading.jsx'

data/app/pb_kits/playbook/pb_collapsible/child_kits/CollapsibleIcon.tsx

@@ -45,9 +45,7 @@ const CollapsibleIcon = ({
   const color = colorMap[iconColor];
 
   const showIcon = (icon: string | string[]) => {
-    if (icon === "none") {
-      return []
-    } else if (typeof icon === "string") {
+    if (typeof icon === "string") {
       return [icon, icon];
     }
     return icon;
@@ -62,34 +60,30 @@ const CollapsibleIcon = ({
 
   return (
     <>
-      {(icon !== "none") ? (  
-        collapsed ? (
-          <div
-              className="icon_wrapper"
-              key={icon ? showIcon(icon)[0] : "chevron-down"}
-              onClick={(e) => handleIconClick(e)}
-              style={{ verticalAlign: "middle", color: color }}
-          >
-            <Icon
-                icon={icon ? showIcon(icon)[0] : "chevron-down"}
-                size={iconSize}
-            />
-          </div>
-        ) : (
-          <div
-              className="icon_wrapper"
-              key={icon ? showIcon(icon)[1] : "chevron-up"}
-              onClick={(e) => handleIconClick(e)}
-              style={{ verticalAlign: "middle", color: color }}
-          >
-            <Icon
-                icon={icon ? showIcon(icon)[1] : "chevron-up"}
-                size={iconSize}
-            />
-          </div>
-        )
+      {collapsed ? (
+        <div
+            className="icon_wrapper"
+            key={icon ? showIcon(icon)[0] : "chevron-down"}
+            onClick={(e) => handleIconClick(e)}
+            style={{ verticalAlign: "middle", color: color }}
+        >
+          <Icon
+              icon={icon ? showIcon(icon)[0] : "chevron-down"}
+              size={iconSize}
+          />
+        </div>
       ) : (
-        <div/>
+        <div
+            className="icon_wrapper"
+            key={icon ? showIcon(icon)[1] : "chevron-up"}
+            onClick={(e) => handleIconClick(e)}
+            style={{ verticalAlign: "middle", color: color }}
+        >
+          <Icon
+              icon={icon ? showIcon(icon)[1] : "chevron-up"}
+              size={iconSize}
+          />
+        </div>
       )}
     </>
   );

data/app/pb_kits/playbook/pb_collapsible/collapsible_main.html.erb

@@ -5,19 +5,15 @@
         <%= content.presence %>
       <% end %>
       <%= pb_rails("flex/flex_item") do %>
-        <% if object.icon == "none" %>
-          <div></div>
+        <div style="color: <%= object.icon_color %>" class="icon_wrapper" >
+        <% if object.icon.present? %>
+          <%= pb_rails("icon", props: { icon: object.show_icon(object.icon)[0], id:"collapsible_open_icon", size: object.size }) %>
+          <%= pb_rails("icon", props: { icon: object.show_icon(object.icon)[1], id:"collapsible_close_icon", size: object.size }) %>
         <% else %>
-          <div style="color: <%= object.icon_color %>" class="icon_wrapper" >
-          <% if object.icon.present? %>
-            <%= pb_rails("icon", props: { icon: object.show_icon(object.icon)[0], id:"collapsible_open_icon", size: object.size }) %>
-            <%= pb_rails("icon", props: { icon: object.show_icon(object.icon)[1], id:"collapsible_close_icon", size: object.size }) %>
-          <% else %>
-            <%= pb_rails("icon", props: { icon: "chevron-down", id:"collapsible_open_icon", size: object.size }) %>
-            <%= pb_rails("icon", props: { icon: "chevron-up", id:"collapsible_close_icon", size: object.size }) %>
-          <% end %>
-          </div>
+          <%= pb_rails("icon", props: { icon: "chevron-down", id:"collapsible_open_icon", size: object.size }) %>
+          <%= pb_rails("icon", props: { icon: "chevron-up", id:"collapsible_close_icon", size: object.size }) %>
         <% end %>
+        </div>
       <% end %>
     <% end %>
 <% end %>

data/app/pb_kits/playbook/pb_collapsible/collapsible_main.rb

@@ -20,8 +20,6 @@ module Playbook
 
       def show_icon(icon)
         case icon
-        when "none"
-          []
         when ::String
           [icon, icon]
         when ::Array

data/app/pb_kits/playbook/pb_collapsible/docs/example.yml

@@ -9,7 +9,6 @@ examples:
   - collapsible_external_controls_multiple: Toggle All Collapsibles With One Control
   - collapsible_custom_main_rails: Custom Main Section
   - collapsible_custom_main_with_icon_rails: Custom Main Section With Icon
-  - collapsible_no_icon: No Icon
 
 
   react:
@@ -20,7 +19,6 @@ examples:
   - collapsible_state: useCollapsible Hook
   - collapsible_custom_main: Custom Main Section
   - collapsible_custom_main_with_icon: Custom Main Section With Icon
-  - collapsible_no_icon: No Icon
 
 
 

data/app/pb_kits/playbook/pb_collapsible/docs/index.js

@@ -4,5 +4,4 @@ export { default as CollapsibleColor } from './_collapsible_color.jsx'
 export { default as CollapsibleIcons } from './_collapsible_icons.jsx'
 export { default as CollapsibleState } from './_collapsible_state.jsx'
 export { default as CollapsibleCustomMain } from './_collapsible_custom_main.jsx'
-export { default as CollapsibleCustomMainWithIcon } from './_collapsible_custom_main_with_icon.jsx'
-export { default as CollapsibleNoIcon } from './_collapsible_no_icon.jsx'
+export { default as CollapsibleCustomMainWithIcon } from './_collapsible_custom_main_with_icon.jsx'

data/app/pb_kits/playbook/pb_date_picker/sass_partials/_input_styles.scss

@@ -41,7 +41,7 @@
   &.error {
     .date_picker_input_wrapper {
       [class*=pb_body_kit] {
-        margin-top: $space_xs / 2;
+        margin-top: calc($space_xs / 2);
       }
 
       input,

data/app/pb_kits/playbook/pb_date_picker/sass_partials/_overrides.scss

@@ -6,8 +6,8 @@
     width: 315.88px
   }
   .flatpickr-months {
-    margin-left: $space_xs / 4;
-    margin-top: $space_xs / 3;
+    margin-left: calc($space_xs / 4);
+    margin-top: calc($space_xs / 3);
   }
 }
 @media (max-width: 499px) {

data/app/pb_kits/playbook/pb_date_range_inline/_date_range_inline.scss

@@ -21,14 +21,14 @@
     display: flex;
     align-items: center;
     [class*=pb_date_range_inline_arrow] {
-      margin-left: $space_xs/2;
-      margin-right: $space_xs/2;
+      margin-left: calc($space_xs/2);
+      margin-right: calc($space_xs/2);
     }
     [class*=pb_date_range_inline_timezone] {
-      margin-left: $space_xs/2;
+      margin-left: calc($space_xs/2);
     }
     [class*=pb_date_range_inline_icon] {
-      margin-right: $space_xs/2;
+      margin-right: calc($space_xs/2);
     }
   }
 }

data/app/pb_kits/playbook/pb_date_time_stacked/_date_time_stacked.scss

@@ -1,11 +1,11 @@
 [class^=pb_date_time_stacked] {
 
   [class^=padding_month] {
-    padding-bottom: $space_xs + 2px !important;
+    padding-bottom: calc($space_xs + 2px) !important;
     }
 
   [class^=padding_day] {
-    padding-bottom: $space_xs + 2px !important;
+    padding-bottom: calc($space_xs + 2px) !important;
   }
 
   &[class*=_dark] {
@@ -19,7 +19,7 @@
 
 }
 .date-time-padding {
-  padding-right: $space_xs / 2;
-  padding-left: $space_xs / 2;
+  padding-right: calc($space_xs / 2);
+  padding-left: calc($space_xs / 2);
 }
 

data/app/pb_kits/playbook/pb_dialog/dialog.html.erb

@@ -22,11 +22,8 @@
             <% if object.cancel_button && object.confirm_button %>
                         <%= pb_rails("dialog/dialog_footer", props: {
                             cancel_button: object.cancel_button,
-                            cancel_button_id: object.cancel_button_id,
                             confirm_button: object.confirm_button,
-                            confirm_button_id: object.confirm_button_id,
-                            id: object.id,
-                            loading: object.loading
+                            id: object.id
                         }) %>
             <% end %>
 

data/app/pb_kits/playbook/pb_dialog/dialog.rb

@@ -13,11 +13,8 @@ module Playbook
       prop :should_close_on_overlay_click, type: Playbook::Props::Boolean, default: true
       prop :title
       prop :text
-      prop :loading
       prop :confirm_button
-      prop :confirm_button_id
       prop :cancel_button
-      prop :cancel_button_id
       prop :status, type: Playbook::Props::Enum,
                     values: ["info", "caution", "delete", "error", "success", "default", ""],
                     default: ""

data/app/pb_kits/playbook/pb_dialog/dialogHelper.js

@@ -3,27 +3,6 @@ const dialogHelper = () => {
   const closeTrigger = document.querySelectorAll("[data-close-dialog]");
   const dialogs = document.querySelectorAll(".pb_dialog_rails")
 
-  const loadingButton = document.querySelector('[data-disable-with="Loading"]');
-  if (loadingButton) {
-    loadingButton.addEventListener("click", function() {
-      const okayLoadingButton = document.querySelector('[data-disable-with="Loading"]');
-      const cancelButton = document.querySelector('[data-disable-cancel-with="Loading"]');
-      let currentClass = okayLoadingButton.className;
-      let cancelClass = cancelButton ? cancelButton.className : "";
-
-      let newClass = currentClass.replace("_enabled", "_disabled_loading");
-      let newCancelClass = cancelClass.replace("_enabled", "_disabled");
-
-      // Disable the buttons
-      okayLoadingButton.disabled = true;
-      if (cancelButton) cancelButton.disabled = true;
-
-      okayLoadingButton.className = newClass;
-      if (cancelButton) cancelButton.className = newCancelClass;
-    });
-  }
-
-
   openTrigger.forEach((open) => {
     open.addEventListener("click", () => {
       var openTriggerData = open.dataset.openDialog;

data/app/pb_kits/playbook/pb_dialog/dialog_footer.html.erb

@@ -3,12 +3,10 @@
     <% if object.confirm_button && object.cancel_button %>
         <div class="dialog-pseudo-footer"></div>
         <%= pb_rails("flex", props: { classname:object.classname, spacing:"between", padding_x:"sm", padding:"sm", padding_bottom:"sm" }) do %>
-            
-          <%= pb_rails("button", props: { type: "submit", id: object.confirm_button_id, data: loading_data,
-            }) do %>
+            <%= pb_rails("button", props: { type: "submit", id: object.confirm_button_id }) do %>
                 <%= object.confirm_button %>
             <% end %>
-            <%= pb_rails("button", props: { type: "button", data: {"close-dialog": "#{object.id}", "disable_cancel_with": cancel_loading }, id: object.cancel_button_id, variant: "link" }) do %>
+            <%= pb_rails("button", props: { type: "button", data: {"close-dialog": "#{object.id}" }, id: object.cancel_button_id, variant: "link"}) do %>
                 <%= object.cancel_button %>
             <% end %>
         <% end %>

data/app/pb_kits/playbook/pb_dialog/dialog_footer.rb

@@ -4,22 +4,13 @@ module Playbook
   module PbDialog
     class DialogFooter < Playbook::KitBase
       prop :cancel_button
-      prop :cancel_button_id
       prop :confirm_button
       prop :confirm_button_id
-      prop :loading
+      prop :cancel_button_id
 
       def classname
         generate_classname("dialog_footer")
       end
-
-      def cancel_loading
-        loading ? "Loading" : ""
-      end
-
-      def loading_data
-        loading ? { disable_with: "Loading" } : {}
-      end
     end
   end
 end

data/app/pb_kits/playbook/pb_dialog/docs/example.yml

@@ -10,7 +10,6 @@ examples:
   - dialog_stacked_alert: Stacked Button Alert
   - dialog_full_height: Full Height
   - dialog_full_height_placement: Full Height Placement
-  - dialog_loading: Loading
 
 
   react:

data/app/pb_kits/playbook/pb_dropdown/_dropdown.scss

@@ -115,7 +115,7 @@
 
     &.error {
       [class*=pb_body_kit] {
-        margin-top: $space_xs / 2;
+        margin-top: calc($space_xs / 2);
       }
 
       [class*="dropdown_trigger_wrapper"] {

data/app/pb_kits/playbook/pb_form_pill/_form_pill.scss

@@ -17,9 +17,9 @@ $form_pill_colors: (
   display: inline-flex;
   justify-content: center;
   align-items: center;
-  padding: 0 $space-md/2;
+  padding: 0 calc($space-md/2);
   height: $pb_form_pill_height;
-  border-radius: $pb_form_pill_height/2;
+  border-radius: calc($pb_form_pill_height/2);
   margin-bottom: 2px;
   margin-top: 2px;
   cursor: pointer;

data/app/pb_kits/playbook/pb_hashtag/_hashtag.tsx

@@ -1,5 +1,5 @@
 /* eslint-disable react/jsx-no-target-blank */
-/* eslint-disable react/no-multi-comp */
+/* eslint-disable react/no-multi-comp, flowtype/space-before-type-colon */
 
 import React from 'react'
 import classnames from 'classnames'
@@ -18,7 +18,6 @@ type HashtagProps = {
   id?: string,
   newWindow?: boolean,
   rel?: string,
-  target?: string,
   text?: string,
   type: "default" | "home" | "project" | "appointment",
   url?: string,
@@ -41,7 +40,6 @@ const Hashtag = (props: HashtagProps) => {
     id,
     newWindow,
     rel,
-    target,
     text,
     type = 'default',
     url,
@@ -52,18 +50,6 @@ const Hashtag = (props: HashtagProps) => {
   const htmlProps = buildHtmlProps(htmlOptions)
   const classes = classnames(buildCss('pb_hashtag_kit'), globalProps(props), className)
 
-  const getTargetAttribute = () => {
-    if (target && url) {
-      return target
-    } else if (newWindow) {
-      return '_blank'
-    } else {
-      return '_self'
-    }
-
-    return null
-  }
-
   return (
     <span
         {...ariaProps}
@@ -75,7 +61,7 @@ const Hashtag = (props: HashtagProps) => {
       <a
           href={url}
           rel={(newWindow ? "noreferrer" : rel)}
-          target={getTargetAttribute()}
+          target={(newWindow ? '_blank' : '_self')}
       >
         <Badge
             dark={dark}

data/app/pb_kits/playbook/pb_hashtag/docs/_hashtag_link.html.erb

@@ -2,4 +2,4 @@
 
 <br/><br/>
 
-<%= pb_rails("hashtag", props: {text: "Open in a new Window", url: "https://google.com", type: "project", target: "_blank"}) %>
+<%= pb_rails("hashtag", props: {text: "Open in a new Window", url: "https://google.com", type: "project", new_window: true}) %>

data/app/pb_kits/playbook/pb_hashtag/docs/_hashtag_link.jsx

@@ -13,7 +13,7 @@ const HashtagLink = (props) => {
       <br />
       <br />
       <Hashtag
-          target="_blank"
+          newWindow
           text="Open in a new window"
           type="project"
           url="https://google.com"

data/app/pb_kits/playbook/pb_hashtag/docs/_hashtag_link.md

@@ -1 +1 @@
-Use the `target` prop to control whether the link opens on the same or a new tab (same page is the default behavior). You can use any [web/standard](https://www.w3schools.com/tags/att_a_target.asp) values or a custom string to specify your link target.
+Use the newWindow/new_window prop to control whether the link opens on the same page or a new tab (same page is the default behavior)

data/app/pb_kits/playbook/pb_hashtag/hashtag.html.erb

@@ -1,5 +1,5 @@
 <%= pb_content_tag(:span) do %>
-  <%= link_to object.url, target: object.target_option do %>
+  <%= link_to object.url, target: object.link_option do %>
     <%= pb_rails("badge", props: { dark: object.dark, variant: "primary", text: object.hashtag_text }) %>
   <% end %>
 <% end %>

data/app/pb_kits/playbook/pb_hashtag/hashtag.rb

@@ -10,7 +10,6 @@ module Playbook
                   values: %w[default project home appointment],
                   default: "default"
       prop :url
-      prop :target
 
       def classname
         generate_classname("pb_hastag_kit")
@@ -20,14 +19,8 @@ module Playbook
         type_text + text
       end
 
-      def target_option
-        if target && url
-          target
-        elsif new_window
-          "_blank"
-        else
-          "_self"
-        end
+      def link_option
+        new_window ? "_blank" : "_self"
       end
 
     private