playbook_ui 14.24.0.pre.alpha.PLAY2343maketiptapreactexternalvitedep9501 → 14.24.0.pre.alpha.PLAY2346reactpaginationexternalcontrol9346

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aefe64c417d003b148d45f6dca657db7f55e5099b469c430e49ea006c3b126f1
-  data.tar.gz: f87f98719b2fb8fb9ae337acc7dde26a8408cc6fd2649822b9cb0750b7f9dfb0
+  metadata.gz: 8edce6a5514c3dbb1f02cbdd36cbfd71e8c76d4459fc1980feaa0a9012e93aa2
+  data.tar.gz: 737cefb1d8700dfda12e8c4c6b03d229c2795b92d1bd407c2ac9f460f1ac14db
 SHA512:
-  metadata.gz: 125341f9f6a5e24bc71e22691b22cd5840004ace9e0d85d954dc3b74a2ca00a27886753ff8ee7ef81bc9c72f9cd744199965e9be77103c4f26b153b8c9ce736c
-  data.tar.gz: c5a55495d4f9a17dbad9a9b99508904b8ee6b4d6123c7c8cb4270b80ee6442b97c657940ad36795030b9ea7223409372bd5af1f38964e1a1c283dca2a0a54b9f
+  metadata.gz: b7543b3fbbc89b7014c95200b8ecccd6802061cae1a8546b09c112e42d091e9e2e82094805ff086b186bfc11aeae3162546fbe6c8961ddcc160968e1fea72b9e
+  data.tar.gz: 548956a9452a94b4525ace4c5488558edeac006084671038cf07140bf636db8bea74768d0b3f7e57976c77b739b17634aba927f94df27a50b26d5d1bf0b78b8a

data/app/pb_kits/playbook/pb_advanced_table/Components/RegularTableView.tsx

@@ -58,9 +58,7 @@ const TableCellRenderer = ({
         // Find the “owning” colDefinition by accessor. Needed for multi column logic
         const colDef = findColumnDefByAccessor(columnDefinitions ?? [], column.id)
         const cellAlignment = colDef?.columnStyling?.cellAlignment ?? "right"
-        const paddingValue = colDef?.columnStyling?.cellPadding ?? customRowStyle?.cellPadding
-        const paddingClass = paddingValue ? `p_${paddingValue}` : undefined
-        
+
         return (
           <td
               align={cellAlignment}
@@ -70,7 +68,6 @@ const TableCellRenderer = ({
                 isPinnedLeft && 'pinned-left',
                 stickyLeftColumn && stickyLeftColumn.length > 0 && isPinnedLeft && 'sticky-left',
                 isLastCell && 'last-cell',
-                paddingClass
               )}
               key={`${cell.id}-data`}
               style={{

data/app/pb_kits/playbook/pb_advanced_table/Components/TableHeaderCell.tsx

@@ -113,6 +113,7 @@ export const TableHeaderCell = ({
     return visibleSiblings.at(-1) === header.column;
   })();
 
+
 const cellClassName = classnames(
   "table-header-cells",
   `${showActionsBar && isActionBarVisible && "header-cells-with-actions"}`,
@@ -121,7 +122,7 @@ const cellClassName = classnames(
   { "pinned-left": responsive === "scroll" && isPinnedLeft },
    isLastHeaderCell ? "last-header-cell" : "",
   stickyLeftColumn && stickyLeftColumn.length > 0 && isPinnedLeft ? 'sticky-left' : "",
-  colDef?.columnStyling?.headerPadding && `p_${colDef?.columnStyling?.headerPadding}`
+
 ); 
 
 const cellId = `${loading ? 

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.scss

@@ -971,40 +971,6 @@
       }
     }
   }
-
-  // Firefox-specific fix for last-header-cell and last-cell vertical borders
-  @-moz-document url-prefix() {
-    .pb_advanced_table_header {
-      .last-header-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    .pb_advanced_table_body {
-      .last-cell {
-        border-right: none !important;
-        box-shadow: 1px 0 0 0 $border_light !important;
-      }
-    }
-
-    // Dark mode Firefox fixes
-    &.dark {
-      .pb_advanced_table_header {
-        .last-header-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-
-      .pb_advanced_table_body {
-        .last-cell {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_dark !important;
-        }
-      }
-    }
-  }
 }
 
 // Outside of the pb_advanced_table class for popover

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.test.jsx

@@ -651,36 +651,6 @@ test("columnStyling.cellAlignment sets each <td> align attribute as expected", (
   expect(firstEnrollmentCell).toHaveAttribute("align", "left");
 });
 
-test("columnStyling.cellPadding sets cell padding", () => {
-  const styledColumnDefs = [
-    {
-      accessor: "year",
-      label: "Year",
-      cellAccessors: ["quarter", "month", "day"],
-    },
-    {
-      accessor: "newEnrollments",
-      label: "New Enrollments",
-      columnStyling: { cellPadding: "none" },
-    },
-    {
-      accessor: "scheduledMeetings",
-      label: "Scheduled Meetings",
-    },
-  ];
-
-  render(
-    <AdvancedTable
-        columnDefinitions={styledColumnDefs}
-        data={{ testid: testId }}
-        tableData={MOCK_DATA}
-    />
-  );
-
-  const firstEnrollmentCell = screen.getAllByText("20")[0].closest("td");
-  expect(firstEnrollmentCell).toHaveClass('p_none')
-});
-
 test("renders virtualized table rows and header", () => {
   render(
     <AdvancedTable
@@ -724,32 +694,6 @@ test("rowStyling prop works as expected", () => {
   expect(row1).toHaveStyle({backgroundColor: colors.white, color: colors.black})
 })
 
-test("rowStyling prop to allow padding control", () => {
-  const rowStyling = [
-  {
-    rowId: "1",
-    cellPadding: "lg"
-  },
-];
-
-  render(
-    <AdvancedTable
-        columnDefinitions={columnDefinitions}
-        data={{ testid: testId }}
-        rowStyling={rowStyling}
-        tableData={MOCK_DATA_WITH_ID}
-    />
-  )
-
-  const kit = screen.getByTestId(testId)
-  const tableBody = kit.querySelector('tbody')
-  const row1 = tableBody.querySelector('tr:nth-child(1)') 
-   const cells = row1.querySelectorAll("td");
-  cells.forEach((cell) => {
-    expect(cell.classList.contains("p_lg")).toBe(true);
-  });
-})
-
 test("Sort icon renders with enableSort on individual columns", () => {
   render(
     <AdvancedTable

data/app/pb_kits/playbook/pb_advanced_table/docs/example.yml

@@ -13,7 +13,6 @@ examples:
   - advanced_table_with_custom_header_rails: Custom Header Cell
   - advanced_table_column_headers: Multi-Header Columns
   - advanced_table_column_headers_multiple: Multi-Header Columns (Multiple Levels)
-  - advanced_table_column_headers_vertical_border: Multi-Header Columns with Vertical Borders
   - advanced_table_no_subrows: Table with No Subrows or Expansion
   - advanced_table_selectable_rows_rails: Selectable Rows
   - advanced_table_selectable_rows_no_subrows_rails: Selectable Rows (No Subrows)
@@ -54,7 +53,6 @@ examples:
   - advanced_table_column_headers: Multi-Header Columns
   - advanced_table_column_headers_multiple: Multi-Header Columns (Multiple Levels)
   - advanced_table_column_headers_custom_cell: Multi-Header Columns with Custom Cells
-  - advanced_table_column_headers_vertical_border: Multi-Header Columns with Vertical Borders
   - advanced_table_no_subrows: Table with No Subrows or Expansion
   - advanced_table_pinned_rows: Pinned Rows
   - advanced_table_selectable_rows: Selectable Rows
@@ -68,10 +66,8 @@ examples:
   - advanced_table_column_visibility_multi: Column Visibility Control with Multi-Header Columns
   - advanced_table_scrollbar_none: Advanced Table Scrollbar None
   - advanced_table_row_styling: Row Styling
-  - advanced_table_padding_control_per_row: Padding Control using Row Styling
   - advanced_table_column_styling: Column Styling
   - advanced_table_column_styling_column_headers: Column Styling with Multiple Headers
-  - advanced_table_padding_control: Padding Control using Column Styling
   - advanced_table_column_border_color: Column Group Border Color
   - advanced_table_fullscreen: Fullscreen
   - advanced_table_infinite_scroll: Infinite Scroll

data/app/pb_kits/playbook/pb_advanced_table/docs/index.js

@@ -21,7 +21,6 @@ export { default as AdvancedTableSelectableRowsHeader } from './_advanced_table_
 export { default as AdvancedTableSelectableRowsActions } from './_advanced_table_selectable_rows_actions.jsx'
 export { default as AdvancedTableTablePropsStickyHeader } from './_advanced_table_table_props_sticky_header.jsx'
 export { default as AdvancedTableColumnHeadersCustomCell } from './_advanced_table_column_headers_custom_cell.jsx'
-export { default as AdvancedTableColumnHeadersVerticalBorder } from './_advanced_table_column_headers_vertical_border.jsx'
 export { default as AdvancedTableInlineEditing } from './_advanced_table_inline_editing.jsx'
 export { default as AdvancedTableFullscreen } from './_advanced_table_fullscreen.jsx'
 export { default as AdvancedTableStickyColumns } from './_advanced_table_sticky_columns.jsx'
@@ -43,6 +42,4 @@ export {default as AdvancedTableWithCustomHeader} from './_advanced_table_with_c
 export { default as AdvancedTableCustomSort } from './_advanced_table_custom_sort.jsx'
 export { default as AdvancedTableWithCustomHeaderMultiHeader } from './_advanced_table_with_custom_header_multi_header.jsx'
 export { default as AdvancedTableSortPerColumn } from './_advanced_table_sort_per_column.jsx'
-export { default as AdvancedTableSortPerColumnForMultiColumn } from './_advanced_table_sort_per_column_for_multi_column.jsx'
-export { default as AdvancedTablePaddingControl } from './_advanced_table_padding_control.jsx'
-export { default as AdvancedTablePaddingControlPerRow } from './_advanced_table_padding_control_per_row.jsx'
+export { default as AdvancedTableSortPerColumnForMultiColumn } from './_advanced_table_sort_per_column_for_multi_column.jsx'

data/app/pb_kits/playbook/pb_advanced_table/table_row.rb

@@ -43,7 +43,7 @@ module Playbook
       end
 
       def td_classname(column, index)
-        classes = %w[id-cell]
+        classes = %w[id-cell chrome-styles]
         classes << "last-cell" if column[:is_last_in_group]
         classes << "pinned-left" if index.zero? && is_pinned_left && responsive == "scroll"
         classes.join(" ")

data/app/pb_kits/playbook/pb_advanced_table/table_subrow_header.rb

@@ -29,7 +29,7 @@ module Playbook
       end
 
       def td_classname(index)
-        classes = %w[id-cell]
+        classes = %w[id-cell chrome-styles]
         classes << "pinned-left" if index.zero? && responsive == "scroll"
         classes.join(" ")
       end

data/app/pb_kits/playbook/pb_date/_date.tsx

@@ -19,7 +19,6 @@ type PbDateProps = {
   htmlOptions?: { [key: string]: string | number | boolean | (() => void) };
   id?: string;
   showDayOfWeek?: boolean;
-  showCurrentYear?: boolean;
   showIcon?: boolean;
   size?: "sm" | "md" | "lg";
   unstyled?: boolean;
@@ -36,7 +35,6 @@ const PbDate = (props: PbDateProps): React.ReactElement => {
     htmlOptions = {},
     id,
     showDayOfWeek = false,
-    showCurrentYear = false,
     showIcon = false,
     size = "md",
     unstyled = false,
@@ -92,7 +90,7 @@ const PbDate = (props: PbDateProps): React.ReactElement => {
                 {month} {day}
               </span>
 
-              {(currentYear !== year || showCurrentYear) && <span>{`, ${year}`}</span>}
+              {currentYear != year && <span>{`, ${year}`}</span>}
             </span>
           </>
         : size == "md" || size == "lg"
@@ -126,7 +124,7 @@ const PbDate = (props: PbDateProps): React.ReactElement => {
               <span>
                 {month} {day}
               </span>
-              {(currentYear !== year || showCurrentYear) && <span>{`, ${year}`}</span>}
+              {currentYear != year && <span>{`, ${year}`}</span>}
             </Title>
             )
           : (
@@ -160,7 +158,7 @@ const PbDate = (props: PbDateProps): React.ReactElement => {
                 <Caption dark={dark}
                     tag="span">
                   {month} {day}
-                  {(currentYear !== year || showCurrentYear) && <>{`, ${year}`}</>}
+                  {currentYear != year && <>{`, ${year}`}</>}
                 </Caption>
               </>
             )}

data/app/pb_kits/playbook/pb_date/date.html.erb

@@ -13,8 +13,8 @@
     <% end %>
 
     <!-- month day, year -->
-    <%# if not current year or show_current_year is false %>
-    <% if object.year.to_s == DateTime.now.year.to_s && !object.show_current_year %>
+    <%# if not current year %>
+    <% if object.year.to_s == DateTime.now.year.to_s %>
       <span><%= "#{object.month} #{object.day}" %></span>
     <%# if is current year %>
     <% else %>
@@ -44,8 +44,8 @@
 
     <!-- month day, year -->
 
-    <%# if not current year or show_current_year is false %>
-    <% if object.year.to_s == DateTime.now.year.to_s  && !object.show_current_year  %>
+    <%# if not current year %>
+    <% if object.year.to_s == DateTime.now.year.to_s %>
       <%= pb_rails("title", props: { tag: "div", text: "#{object.month} #{object.day}", size: 4 }) %>
     <%# if is current year %>
     <% else %>
@@ -74,8 +74,8 @@
 
     <!-- month day, year -->
 
-    <%# if not current year or show_current_year is false %>
-    <% if object.year.to_s == DateTime.now.year.to_s  && !object.show_current_year %>
+    <%# if not current year %>
+    <% if object.year.to_s == DateTime.now.year.to_s %>
       <%= pb_rails("caption", props: { tag: "span", text: "#{object.month} #{object.day}" }) %>
     <%# if is current year %>
     <% else %>

data/app/pb_kits/playbook/pb_date/date.rb

@@ -11,8 +11,6 @@ module Playbook
                        default: false
       prop :show_day_of_week, type: Playbook::Props::Boolean,
                               default: false
-      prop :show_current_year, type: Playbook::Props::Boolean,
-                               default: false
       prop :size, type: Playbook::Props::Enum,
                   values: %w[lg md sm xs],
                   default: "md"

data/app/pb_kits/playbook/pb_date/docs/example.yml

@@ -5,14 +5,12 @@ examples:
   - date_variants: Variants
   - date_alignment: Alignment
   - date_timezone: Timezones
-  - date_with_show_current_year: Show Current Year
   - date_unstyled: Unstyled
 
   react:
   - date_default: Default
   - date_variants: Variants
   - date_alignment: Alignment
-  - date_with_show_current_year: Show Current Year
   - date_unstyled: Unstyled
 
   swift:

data/app/pb_kits/playbook/pb_date/docs/index.js

@@ -2,4 +2,3 @@ export { default as DateDefault } from './_date_default.jsx'
 export { default as DateVariants } from './_date_variants.jsx'
 export { default as DateAlignment } from './_date_alignment.jsx'
 export { default as DateUnstyled } from './_date_unstyled.jsx'
-export { default as DateWithShowCurrentYear } from './_date_with_show_current_year.jsx'

data/app/pb_kits/playbook/pb_table/styles/_vertical_border.scss

@@ -7,7 +7,7 @@
     thead tr:not(:first-child) th {
       border-right: 1px solid $border_light !important;
     }
-
+    
     @media screen and (min-width: $screen-xs-min) {
       tr:hover, .pb_table_tr:hover {
         td:last-child, .pb_table_td:last-child {
@@ -15,53 +15,5 @@
         }
       }
     }
-
-    // Firefox-specific fix for sticky elements
-    @-moz-document url-prefix() {
-      // Target sticky headers
-      &.sticky-header {
-        th:not(:last-child) {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-
-        .pb_advanced_table_body {
-          .pinned-row {
-            td:not(:first-child):not(:last-child) {
-              border-right: none !important;
-              box-shadow: 1px 0 0 0 $border_light !important;
-            }
-          }
-        }
-      }
-
-      // Target sticky left columns
-      &.sticky-left-column {
-        td[style="left"], th[style="left"] {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-      }
-
-      // Target sticky right columns
-      &.sticky-right-column {
-        td[style="right"], th[style="right"] {
-          border-right: none !important;
-          box-shadow: 1px 0 0 0 $border_light !important;
-        }
-      }
-
-      // Handle hover states in Firefox
-      @media screen and (min-width: $screen-xs-min) {
-        tr:hover, .pb_table_tr:hover {
-          td:last-child, .pb_table_td:last-child {
-            &[style="left"], &[style="right"] {
-              border-right: none !important;
-              box-shadow: 1px 0 0 0 darken($border_light, 10%) !important;
-            }
-          }
-        }
-      }
-    }
   }
 }