playbook_ui 13.24.0.pre.alpha.PLAY998backgroundkitremoveemptyinlinline2666 → 13.24.0.pre.alpha.PLAY1181circleiconkitfixsizingerrorglobalspacingprops2675

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d91c1689890fbb2e1392ecc83ad7b869eea650744de932d645ed6ea4e566d161
-  data.tar.gz: e53e677351b6221797ed074c4cfdcb6ea842c33af17060167257101af7978db2
+  metadata.gz: 64d3b88ddbf80e9899ea2149fe1105a42a170483991d306eb8cc544ee5aa46a2
+  data.tar.gz: 16554c57ae51a485f41faa858384c2d477c3e65da1a750d6a4c18f9987fe2c4e
 SHA512:
-  metadata.gz: da048d8e1f09cb0d4640c8a1f50e6a1acaf5bb05707d9a843dc011b963b683e8931ec13f80d3f4c98a320addbacd3ca3e9c2a9eca20ff3242d05f4336362f156
-  data.tar.gz: 19a49a4274d753b4b496e8299df73a224ad6356f3ba2bf04d0817d9a69272b48f0c41eab40cb05a46a3dd041ce38a8f67b6cfaffdcf4a7c9092143b1e91950d4
+  metadata.gz: cb7566ccb322412f6e3a3648fe738df099de01d39af408cb166676b8e9f05a85f4bd348b9b94928ff78950870ddc3487638d9b5eb32a62037d8834b599dacf96
+  data.tar.gz: 3a6a4e0eb09706caddde216f771833ae19ddc180ce82324e584a669c6edc2b6e5bc85e56454fb99282b417a0ff9c1efbdad96b1e7b783f0163e662e3a9faa495

data/app/pb_kits/playbook/pb_background/_background.tsx

@@ -65,7 +65,7 @@ const getResponsiveValue = <T extends string | undefined>(prop: ResponsiveProp<T
 
 const Background = (props: BackgroundProps): React.ReactElement => {
   const {
-    alt = undefined,
+    alt = '',
     aria = {},
     backgroundColor = 'light',
     backgroundPosition = '',
@@ -130,13 +130,11 @@ const Background = (props: BackgroundProps): React.ReactElement => {
   );
 
   const backgroundStyle = {
+    backgroundImage: resImageUrl ? `url(${resImageUrl})` : undefined,
+    backgroundRepeat: resBackgroundRepeat || undefined,
+    backgroundSize: resBackgroundSize || undefined,
+    backgroundPosition: resBackgroundPosition || undefined,
     backgroundColor: customColor || undefined,
-    ...(resImageUrl !== '' ? {
-      backgroundImage: resImageUrl ? `url(${resImageUrl})` : undefined,
-      backgroundRepeat: resBackgroundRepeat || undefined,
-      backgroundPosition: resBackgroundPosition || undefined,
-      backgroundSize: resBackgroundSize || undefined,
-    } : {})
   };
 
   const Tag: React.ReactElement | any = `${tag}`;

data/app/pb_kits/playbook/pb_icon_circle/_icon_circle.scss

@@ -51,7 +51,7 @@ $pb_icon_circle_sizes: (
   }
 
   @each $name, $size in $pb_icon_circle_sizes {
-    &[class*=_#{$name}] {
+    &[class*=_size_#{$name}] {
       width: $size;
       height: $size;
       border-radius: $size/2;

data/app/pb_kits/playbook/pb_icon_circle/_icon_circle.tsx

@@ -43,7 +43,7 @@ const IconCircle = (props: IconCircleProps) => {
   const ariaProps = buildAriaProps(aria)
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions)
-  const classes = classnames(buildCss('pb_icon_circle_kit', size, variant), globalProps(props), className)
+  const classes = classnames(buildCss('pb_icon_circle_kit', `size_${size}`, variant), globalProps(props), className)
 
 
   return (

data/app/pb_kits/playbook/pb_icon_circle/icon_circle.rb

@@ -14,7 +14,7 @@ module Playbook
                      default: "default"
 
       def classname
-        generate_classname("pb_icon_circle_kit", size, variant)
+        generate_classname("pb_icon_circle_kit", "size_#{size}", variant)
       end
     end
   end

data/app/pb_kits/playbook/pb_icon_circle/icon_circle.test.js

@@ -16,7 +16,7 @@ describe("IconCircle Kit", () => {
         )
 
         const kit = screen.getByTestId(testId)
-        expect(kit).toHaveClass("pb_icon_circle_kit_md_default")
+        expect(kit).toHaveClass("pb_icon_circle_kit_size_md_default")
     })
 
     test("renders icon", () => {
@@ -66,7 +66,7 @@ describe("IconCircle Kit", () => {
             />
           )
           const kit = screen.getByTestId(testId)
-          expect(kit).toHaveClass(`pb_icon_circle_kit_sm_${colorVariant}`)
+          expect(kit).toHaveClass(`pb_icon_circle_kit_size_sm_${colorVariant}`)
       
           cleanup()
         })
@@ -89,7 +89,7 @@ describe("IconCircle Kit", () => {
             />
           )
           const kit = screen.getByTestId(testId)
-          expect(kit).toHaveClass(`pb_icon_circle_kit_${sizeVariant}_default`)
+          expect(kit).toHaveClass(`pb_icon_circle_kit_size_${sizeVariant}_default`)
       
           cleanup()
         })