playbook_ui 13.23.0.pre.alpha.PLAY1284investigation2657 → 13.23.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f32666e4b2500b014dc2554c3ebf3f5f4e3695cc726a3fc1d53bf5b332455a5
-  data.tar.gz: ff93821e0818cfbf57b09ece3fe03ce0c5459e4d29161f896d5771a3e8eb3761
+  metadata.gz: 452a03b346d2fe5cd79019537fb3bc6ac4bfbdaa621b3e552d898bdaaf1e7c00
+  data.tar.gz: fd5127e3deb4e55449b11d1d989335e3b48cfda1d0064b353d615749eef417c6
 SHA512:
-  metadata.gz: 93c9e3de45864e757c047b19dd7eeed12610d97f234a160183143155ab0dbb88ea6087414e212ffd1037eff4064b239ba7eecfbb30627753f4b4ab1bfcacf1a9
-  data.tar.gz: a5264af573a6eac322795be8739d2a3974a72085e3d5d163b79f4b1882899483b5e82f5205c1ced23c85d1dcc10f53d67570c3067645169fe9cf41f08062eca6
+  metadata.gz: 48edcdfd01a13c5082b670efa0a5d689cd3e3793ce9adacb1789f047bc1514f8f428194d2ea43e1e9bdef4b11d62a496a0b064d6009fed455287ca770ddb81fa
+  data.tar.gz: 37f2323fd3f2a3b4ea76822e139a9bc2c627f7c3bc6817f1f6092c7d9ea9159db7c9916bd0737baab951f7b4aeae28f17dfe5025282ad678898b5eb40bf05ffb

data/app/pb_kits/playbook/pb_avatar/avatar.html.erb

@@ -1,4 +1,9 @@
-<%= object.pb_content_tag(:div, data: object.data.merge(initials: object.initials)) do %>
+<%= content_tag(:div,
+    id: object.id,
+    data: object.data.merge(initials: object.initials),
+    class: object.classname,
+    aria: object.aria,
+    **combined_html_options) do %>
   <%= content_tag(:div, data: { initials: object.initials }, class: "avatar_wrapper") do %>
     <%= pb_rails("image", props: { alt: object.alt_text, url: object.image_url, on_error: object.handle_img_error }) if object.image_url.present? %>
   <% end %>

data/app/pb_kits/playbook/pb_bar_graph/_bar_graph.tsx

@@ -13,12 +13,12 @@ import classnames from "classnames";
 
 type BarGraphProps = {
   align?: "left" | "right" | "center";
-  axisTitle: { name: string; }[] | string;
+  axisTitle: string;
   dark?: boolean;
   xAxisCategories: [];
   yAxisMin: number;
   yAxisMax: number;
-  chartData: { name: string; data: number[], yAxis: number }[];
+  chartData: { name: string; data: number[] }[];
   className?: string;
   customOptions?: Partial<Highcharts.Options>;
   id: string;
@@ -37,7 +37,6 @@ type BarGraphProps = {
   y?: number;
   aria?: { [key: string]: string };
   data?: { [key: string]: string };
-  axisFormat?: { format: string; }[] | string;
 };
 
 
@@ -52,7 +51,6 @@ const BarGraph = ({
   colors,
   htmlOptions = {},
   customOptions = {},
-  axisFormat,
   id,
   pointStart,
   subTitle,
@@ -69,7 +67,7 @@ const BarGraph = ({
   x = 0,
   y = 0,
   ...props
-}: BarGraphProps): React.ReactElement => { 
+}: BarGraphProps): React.ReactElement => {
   const ariaProps = buildAriaProps(aria);
   const dataProps = buildDataProps(data)
   const htmlProps = buildHtmlProps(htmlOptions);
@@ -91,18 +89,13 @@ const BarGraph = ({
     subtitle: {
       text: subTitle,
     },
-    yAxis: [{
-      labels: {
-        format: typeof axisFormat === 'string' ? axisFormat : (axisFormat && axisFormat[0] ? axisFormat[0].format : "")
-
-      },
+    yAxis: {
       min: yAxisMin,
       max: yAxisMax,
-      opposite: false,
       title: {
-        text: typeof axisTitle === 'string' ? axisTitle : axisTitle[0].name,
-      }
-    }],
+        text: axisTitle,
+      },
+    },
     xAxis: {
       categories: xAxisCategories,
     },
@@ -131,20 +124,6 @@ const BarGraph = ({
     credits: false,
   };
 
-if (Array.isArray(axisTitle) && axisTitle.length > 1 && axisTitle[1].name) {
-  staticOptions.yAxis.push({
-    labels: {
-      format: typeof axisFormat === 'string' ? axisFormat : axisFormat[1].format,
-    },
-    min: yAxisMin,
-    max: yAxisMax,
-    opposite: true,
-    title: {
-      text: axisTitle[1].name,
-    }
-  });
-}
-
   if (!toggleLegendClick) {
     staticOptions.plotOptions.series.events = { legendItemClick: () => false };
   }

data/app/pb_kits/playbook/pb_bar_graph/bar_graph.rb

@@ -7,7 +7,6 @@ module Playbook
                    values: %w[left right center],
                    default: "center"
       prop :axis_title
-      prop :axis_format
       prop :chart_data, type: Playbook::Props::Array,
                         default: []
       prop :custom_options, default: {}
@@ -52,7 +51,6 @@ module Playbook
           title: title,
           subTitle: subtitle,
           axisTitle: axis_title,
-          axisFormat: axis_format,
           pointStart: point_start,
           xAxisCategories: x_axis_categories,
           yAxisMin: y_axis_min,

data/app/pb_kits/playbook/pb_bar_graph/docs/example.yml

@@ -9,7 +9,6 @@ examples:
   - bar_graph_spline: Spline
   - bar_graph_colors: Color Overrides
   - bar_graph_custom: Custom Overrides
-  - bar_graph_secondary_y_axis: Secondary Y-Axis
 
 
   react:
@@ -21,4 +20,3 @@ examples:
   - bar_graph_spline: Spline
   - bar_graph_colors: Color Overrides
   - bar_graph_custom: Custom Overrides
-  - bar_graph_secondary_y_axis: Secondary Y-Axis

data/app/pb_kits/playbook/pb_bar_graph/docs/index.js

@@ -6,4 +6,3 @@ export { default as BarGraphHeight } from './_bar_graph_height.jsx'
 export { default as BarGraphSpline } from './_bar_graph_spline.jsx'
 export { default as BarGraphColors } from './_bar_graph_colors.jsx'
 export { default as BarGraphCustom } from './_bar_graph_custom.jsx'
-export { default as BarGraphSecondaryYAxis } from './_bar_graph_secondary_y_axis.jsx'

data/app/pb_kits/playbook/pb_body/_body.scss

@@ -19,7 +19,7 @@
     }
   }
   b, strong {
-    font-weight: $bold;
+    @include pb_title_4
   }
 
   a {
@@ -29,8 +29,8 @@
     }
   }
 
-  em, i {
-    font-style: italic;
+  em {
+    font-weight: $bold;
   }
 
   small {

data/app/pb_kits/playbook/pb_typeahead/_typeahead.tsx

@@ -7,21 +7,17 @@ import { get, isString, uniqueId } from 'lodash'
 import { globalProps } from '../utilities/globalProps'
 import classnames from 'classnames'
 
-import {
-  Control,
-  ClearIndicator,
-  IndicatorsContainer,
-  MenuList,
-  MultiValue,
-  Option,
-  Placeholder,
-  ValueContainer,
-} from "./components"
-
-import * as kitComponents from "./components"
+import Control from './components/Control'
+import ClearIndicator from './components/ClearIndicator'
+import IndicatorsContainer from './components/IndicatorsContainer'
+import MenuList from './components/MenuList'
+import MultiValue from './components/MultiValue'
+import Option from './components/Option'
+import Placeholder from './components/Placeholder'
+import ValueContainer from './components/ValueContainer'
 
 import { noop, buildDataProps, buildHtmlProps } from '../utilities/props'
-import { GenericObject, Noop } from '../types'
+import { Noop } from '../types'
 
 /**
  * @typedef {object} Props
@@ -33,7 +29,7 @@ import { GenericObject, Noop } from '../types'
 type TypeaheadProps = {
   async?: boolean,
   className?: string,
-  components?: GenericObject,
+  components?: object,
   createable?: boolean,
   dark?: boolean,
   data?: { [key: string]: string },
@@ -104,7 +100,7 @@ const Typeahead = ({
     multiKit: '',
     onCreateOption: null as null,
     plusIcon: false,
-    onMultiValueClick: (_option: SelectValueType): any => undefined,
+    onMultiValueClick: (_option: SelectValueType) => { },
     ...props,
   }
 
@@ -141,23 +137,19 @@ const Typeahead = ({
   const inlineClass = selectProps.inline ? 'inline' : null
 
   return (
-    <div
-        {...dataProps}
-        {...htmlProps}
-        className={classnames(classes, inlineClass)}
+    <div 
+      {...dataProps}
+      {...htmlProps}
+      className={classnames(classes, inlineClass)}
     >
       <Tag
-          classNamePrefix="typeahead-kit-select"
-          error={error}
-          onChange={handleOnChange}
-          {...selectProps}
+        classNamePrefix="typeahead-kit-select"
+        error={error}
+        onChange={handleOnChange}
+        {...selectProps}
       />
     </div>
   )
 }
 
-Object.keys(kitComponents).forEach((k) => {
-  (Typeahead as GenericObject)[k] = (kitComponents as {[key: string]: unknown})[k]
-})
-
 export default Typeahead

data/app/pb_kits/playbook/pb_typeahead/components/MenuList.tsx

@@ -1,12 +1,10 @@
 import React from 'react'
 import { components } from 'react-select'
 
-const MenuList = (props: any) => {
-  return (
+const MenuList = (props: any) => (
   <components.MenuList {...props}>
     {props.children}
-    {props.footer}
   </components.MenuList>
-)}
+)
 
 export default MenuList

data/app/pb_kits/playbook/pb_typeahead/docs/_typeahead_with_highlight.jsx

@@ -46,7 +46,7 @@ const TypeaheadWithHighlight = (props) => {
       if (!inputValue.length) return text
       return text.replace(
         new RegExp(inputValue, 'gi'),
-        (highlighted) => `<mark>${highlighted}</mark>`
+        highlighted => `<mark>${highlighted}</mark>`
       )
     }
     return (

data/app/pb_kits/playbook/pb_typeahead/docs/example.yml

@@ -22,4 +22,3 @@ examples:
     - typeahead_createable: Createable
     - typeahead_async_createable: Createable (+ Async Data)
     - typeahead_error_state: Error State
-    - typeahead_custom_menu_list: Custom MenuList

data/app/pb_kits/playbook/pb_typeahead/docs/index.js

@@ -9,4 +9,3 @@ export { default as TypeaheadMultiKit } from './_typeahead_multi_kit.jsx'
 export { default as TypeaheadCreateable } from './_typeahead_createable.jsx'
 export { default as TypeaheadAsyncCreateable } from './_typeahead_async_createable.jsx'
 export { default as TypeaheadErrorState } from './_typeahead_error_state.jsx'
-export { default as TypeaheadCustomMenuList } from './_typeahead_custom_menu_list.jsx'