playbook_ui 13.21.0.pre.alpha.pbntr220improveexpansionspeed2451 → 13.21.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 53ec5eba2bcbca69770aff3a4995d6acebd6837d3e47ca43f6e65a075945114f
-  data.tar.gz: 6834eef7adb98d03a39e1b9fc62eb0cf6c3d419d884a8aa55047898169b49bfe
+  metadata.gz: e6c19fad05505af542ad2b4998d9d9d6f225ad3b46568420e87f7a3d72847cf2
+  data.tar.gz: '05208a0115fc90b97569c6c96c3847211b2136550f95817eb2dd8eb3eac2c90a'
 SHA512:
-  metadata.gz: 8192c971c521ec1a33906219fc0cab51b8c325b722a9c1339743d2f0702f9584a7edd3a27e850fedd45f6262b197a41f5a4ad3c0a132e790870eb62c430560f5
-  data.tar.gz: 89019b191251d20c60eb613df60e14ac50dee6567b552b274d0bb03979817a4a4026538229b7e41be05d50000373f2fbb430bc30035a231279f5d676f975fac3
+  metadata.gz: adad3d8a3607b475d9f16c1cc34ee1937fb52b4d2e3af4c7dd481a5a258ba972aa6df89bcbc1c59bb833300b3b9ff9d5988741321bfb5908d6e3706449f7b397
+  data.tar.gz: 1636c11fdc69b49524df0d8c0d17e91dc732f356fe279b78fc90287053bec7c7529377376acd1cb22d2b6903552d1ea448e91e3730c2738b47f62fdc4a15452e

data/app/pb_kits/playbook/pb_advanced_table/Utilities/ExpansionControlHelpers.tsx

@@ -15,27 +15,42 @@ export const updateExpandAndCollapseState = (
   expanded: Record<string, boolean>,
   targetParent: string
 ) => {
-  const updateExpandedRows: Record<string, boolean> = {};
-  const rows = tableRows.rows;
-
-  let isExpansionConsistent = true;
-  const areRowsExpanded = new Set<boolean>();
+  const updateExpandedRows: Record<string, boolean> = {}
+  const rows = tableRows.flatRows
+  // Variable checks if all rows in a section have same expansion state or not
+  let isExpansionConsistent = true
+  const areRowsExpanded = new Set<boolean>()
 
+  // Update isExpansionConsistent variable
   for (const row of rows) {
-    const shouldBeUpdated = targetParent === undefined ? row.depth === 0 : targetParent === row.parentId;
-    
-    if (shouldBeUpdated) {
-      const isExpanded = row.getIsExpanded();
-      areRowsExpanded.add(isExpanded);
-
-      updateExpandedRows[row.id] = !isExpansionConsistent ? true : !isExpanded;
-
+    if (
+      targetParent === undefined
+        ? row.depth === 0
+        : targetParent === row.parentId
+    ) {
+      areRowsExpanded.add(row.getIsExpanded())
       if (areRowsExpanded.size > 1) {
-        isExpansionConsistent = false;
-        // If expansion inconsistent, ensure all target rows are set to expand
-        for (const key in updateExpandedRows) {
-          updateExpandedRows[key] = true;
-        }
+        isExpansionConsistent = false
+        break
+      }
+    }
+  }
+
+  // The if statement runs only for row depth 0, the else statement for the rest
+  if (targetParent === undefined) {
+    rows.forEach(row => {
+      if (row.depth === 0) {
+        updateExpandedRows[row.id] = !isExpansionConsistent
+          ? true
+          : !row.getIsExpanded()
+      }
+    })
+  } else {
+    for (const row of rows) {
+      if (targetParent === row.parentId) {
+        updateExpandedRows[row.id] = !isExpansionConsistent
+          ? true
+          : !row.getIsExpanded()
       }
     }
   }
@@ -43,5 +58,5 @@ export const updateExpandAndCollapseState = (
   return filterExpandableRows({
     ...(expanded as ExpandedStateObject),
     ...updateExpandedRows,
-  });
-};
+  })
+}

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.tsx

@@ -191,13 +191,14 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     }
   }, [loading, updateLoadingStateRowCount]);
 
-  const handleExpandOrCollapse = async (row: Row<DataType>) => {
+  const handleExpandOrCollapse = (row: Row<DataType>) => {
     onToggleExpansionClick && onToggleExpansionClick(row);
-  
+
     const expandedState = expanded;
     const targetParent = row?.parentId;
-    const updatedRows = await updateExpandAndCollapseState(tableRows, expandedState, targetParent);
-    setExpanded(updatedRows);
+    return setExpanded(
+      updateExpandAndCollapseState(tableRows, expandedState, targetParent)
+    );
   };
 
   const ariaProps = buildAriaProps(aria);

data/app/pb_kits/playbook/pb_advanced_table/advanced_table.test.jsx

@@ -1,5 +1,5 @@
 import React, {useState} from "react";
-import { render, screen, waitFor } from "../utilities/test-utils";
+import { render, screen } from "../utilities/test-utils";
 
 import { AdvancedTable } from "../";
 
@@ -198,7 +198,7 @@ test("Row toggle button exists and toggles subrows open and closed", () => {
   expect(subRow).toBeInTheDocument()
 });
 
-test("toggleExpansionAll button exists and toggles subrows open and closed", async () => {
+test("toggleExpansionAll button exists and toggles subrows open and closed", () => {
   render(
     <AdvancedTable
         columnDefinitions={columnDefinitions}
@@ -208,21 +208,15 @@ test("toggleExpansionAll button exists and toggles subrows open and closed", asy
   );
 
   const kit = screen.getByTestId(testId);
-  const toggleButton = kit.querySelector(".gray-icon.toggle-all-icon");
-  expect(toggleButton).toBeInTheDocument();
-
-  const subRow1 = kit.querySelector(".bg-white.depth-sub-row-1");
-  expect(subRow1).not.toBeInTheDocument();
-
-  toggleButton.click();
-
-  await waitFor(() => {
-    const subRow = kit.querySelector(".bg-white.depth-sub-row-1");
-    expect(subRow).toBeInTheDocument();
-  });
+  const toggleButton = kit.querySelector(".gray-icon.toggle-all-icon")
+  expect(toggleButton).toBeInTheDocument()
+  const subRow1 = kit.querySelector(".bg-white.depth-sub-row-1")
+  expect(subRow1).not.toBeInTheDocument()
+  toggleButton.click()
+  const subRow = kit.querySelector(".bg-white.depth-sub-row-1")
+  expect(subRow).toBeInTheDocument()
 });
 
-
 test("loading state + initialLoadingRowCount prop", () => {
   render(
     <AdvancedTable

data/lib/playbook/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module Playbook
-  PREVIOUS_VERSION = "13.21.0"
-  VERSION = "13.21.0.pre.alpha.pbntr220improveexpansionspeed2451"
+  PREVIOUS_VERSION = "13.20.0"
+  VERSION = "13.21.0"
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: playbook_ui
 version: !ruby/object:Gem::Version
-  version: 13.21.0.pre.alpha.pbntr220improveexpansionspeed2451
+  version: 13.21.0
 platform: ruby
 authors:
 - Power UX
 - Power Devs
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-22 00:00:00.000000000 Z
+date: 2024-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack
@@ -2874,7 +2874,7 @@ homepage: https://playbook.powerapp.cloud/
 licenses:
 - ISC
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -2885,12 +2885,12 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubygems_version: 3.3.7
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Playbook Design System
 test_files: []