playbook_ui 13.19.0 → 13.20.0.pre.alpha.PBNTR225advancedtablefeedback2375

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5e7f392fc3d4bc8c6c896b4b54fd0cf5fcb4953fc1de2ee8bd59f14e223462a5
-  data.tar.gz: 71904fc8f23cb411b2022643cb08167a3c8a882a9f1bd135dbbeb980674c0bf4
+  metadata.gz: e15b75aa8e734fcf7c1d4a4d6125f4bdb85d88513c1f0f8815c35220855b044e
+  data.tar.gz: 9e7cee23ebd94a5a90bd9d35902b7bc671d9f284311048197e6e15c76ae65630
 SHA512:
-  metadata.gz: 85f2629ac4ad220d2c39ca406eb422a9ae0d04052f6bb893b3feceb1b909b281d19faa7a47e2f09a2003fb5ac2f2aa42bddabcf337b54ee345841d96be308ec3
-  data.tar.gz: cb38c42e015efbec6d56ed5d6cb4bdfe8c0cdeb91f4c8baeb02679348380c4dbca08f1a6d977bc3c23f0e761b43f1e9578ee1d4c1600cd94048fbe2970d6a27d
+  metadata.gz: c16e3c834fd8dc73924855756f1b4baaa88c96904968fbe1233f673621018aa3bbb5812ec1b03c6e903c5f99d01e3e41442e07ecfda409a4f95724e37279b053
+  data.tar.gz: 2bd9cfe1dc2a14974eb3f3c7cbffa5ff5493c26770ad8aaaa9fe5cb2bb5d0476b6e62abaa7e642967a45774b7af6fbd69fce21b3b32dfddafae68a1218beb8e9

data/app/pb_kits/playbook/pb_advanced_table/Components/CustomCell.tsx

@@ -1,19 +1,21 @@
-import React, { useContext } from "react";
+import React, { useContext } from "react"
+import { Getter, Row } from "@tanstack/react-table"
 
-import Flex from "../../pb_flex/_flex";
-import FlexItem from "../../pb_flex/_flex_item";
-import Icon from "../../pb_icon/_icon";
-import { GlobalProps } from "../../utilities/globalProps";
+import { GenericObject } from "../../types"
 
-import { Getter, Row } from "@tanstack/react-table";
-import { DataType } from "../Utilities/types";
-import AdvancedTableContext from "../Context/AdvancedTableContext";
+import { GlobalProps } from "../../utilities/globalProps"
+
+import Flex from "../../pb_flex/_flex"
+import FlexItem from "../../pb_flex/_flex_item"
+import Icon from "../../pb_icon/_icon"
+
+import AdvancedTableContext from "../Context/AdvancedTableContext"
 
 interface CustomCellProps {
-  getValue?: Getter<string>;
-  onRowToggleClick?: (arg: Row<DataType>) => void;
-  row: Row<DataType>;
-  value?: string;
+  getValue?: Getter<string>
+  onRowToggleClick?: (arg: Row<GenericObject>) => void
+  row: Row<GenericObject>
+  value?: string
 } 
 
 export const CustomCell = ({
@@ -22,12 +24,12 @@ export const CustomCell = ({
   row,
   value,
 }: CustomCellProps & GlobalProps) => {
-  const { setExpanded, expanded, inlineRowLoading } = useContext(AdvancedTableContext);
+  const { setExpanded, expanded, inlineRowLoading } = useContext(AdvancedTableContext)
 
-  const handleOnExpand = (row: Row<DataType>) => {
-    onRowToggleClick && onRowToggleClick(row);
-    setExpanded({ ...expanded, [row.id]: !row.getIsExpanded() });
-  };
+  const handleOnExpand = (row: Row<GenericObject>) => {
+    onRowToggleClick && onRowToggleClick(row)
+    setExpanded({ ...expanded, [row.id]: !row.getIsExpanded() })
+  }
   const RowHasChildren = row.original.children ? true : false
   const renderButton = inlineRowLoading ? RowHasChildren : row.getCanExpand()
 
@@ -59,5 +61,5 @@ export const CustomCell = ({
         </FlexItem>
       </Flex>
     </div>
-  );
-};
+  )
+}

data/app/pb_kits/playbook/pb_advanced_table/Components/SortIconButton.tsx

@@ -1,11 +1,14 @@
 import React from "react"
-import Icon from "../../pb_icon/_icon"
 import { Header } from "@tanstack/react-table"
-import { DataType } from "../Utilities/types"
+
+import { GenericObject } from "../../types"
+
+import Icon from "../../pb_icon/_icon"
+
 import { displayIcon } from "../Utilities/IconHelpers"
 
 type SortIconButtonProps = {
-  header: Header<DataType, unknown>
+  header: Header<GenericObject, unknown>
   sortIcon?: string | string[]
 }
 export const SortIconButton = ({ header, sortIcon }: SortIconButtonProps) => {

data/app/pb_kits/playbook/pb_advanced_table/Components/SubRowHeaderRow.tsx

@@ -1,23 +1,27 @@
 import React, { useContext } from "react"
+import { Row, Table } from "@tanstack/react-table"
+
+import { GenericObject } from "../../types"
+
+import { GlobalProps } from "../../utilities/globalProps"
+
 import Flex from "../../pb_flex/_flex"
 import Caption from "../../pb_caption/_caption"
-import { Row, Table } from "@tanstack/react-table"
 
-import AdvancedTableContext from "../Context/AdvancedTableContext";
 import { ToggleIconButton } from "./ToggleIconButton"
 import { renderCollapsibleTrail } from "./CollapsibleTrail"
 
 import { isChrome } from "../Utilities/BrowserCheck"
-import { DataType } from "../Utilities/types"
-import { GlobalProps } from "../../utilities/globalProps"
+
+import AdvancedTableContext from "../Context/AdvancedTableContext"
 
 interface SubRowHeaderRowProps {
   collapsibleTrail?: boolean
   enableToggleExpansion?: "all" | "header" | "none"
-  onClick: (row: Row<DataType>) => void
-  row: Row<DataType>
+  onClick: (row: Row<GenericObject>) => void
+  row: Row<GenericObject>
   subRowHeaders?: string[]
-  table: Table<DataType>
+  table: Table<GenericObject>
 }
 
 export const SubRowHeaderRow = ({
@@ -28,7 +32,7 @@ export const SubRowHeaderRow = ({
   subRowHeaders,
   table,
 }: SubRowHeaderRowProps & GlobalProps) => {
-  const { inlineRowLoading } = useContext(AdvancedTableContext);
+  const { inlineRowLoading } = useContext(AdvancedTableContext)
 
   const numberOfColumns = table.getAllFlatColumns().length
   const rowHasChildren = row.original.children ? true : false

data/app/pb_kits/playbook/pb_advanced_table/Components/TableHeaderCell.tsx

@@ -1,20 +1,25 @@
 import React, { useContext } from "react"
-import classnames from "classnames";
-import Flex from "../../pb_flex/_flex"
+import classnames from "classnames"
 import { flexRender, Header } from "@tanstack/react-table"
 
+import { GenericObject } from "../../types"
+
+import { GlobalProps } from "../../utilities/globalProps"
+
+import Flex from "../../pb_flex/_flex"
+
 import { SortIconButton } from "./SortIconButton"
 import { ToggleIconButton } from "./ToggleIconButton"
+
 import { isChrome } from "../Utilities/BrowserCheck"
-import { DataType } from "../Utilities/types"
+
 import AdvancedTableContext from "../Context/AdvancedTableContext"
-import { GlobalProps } from "../../utilities/globalProps"
 
 type TableHeaderCellProps = {
   enableSorting?: boolean
   enableToggleExpansion?: "all" | "header" | "none"
   handleExpandOrCollapse?: () => void
-  header?: Header<DataType, unknown>
+  header?: Header<GenericObject, unknown>
   headerChildren?: React.ReactNode | React.ReactNode[]
   loading?: boolean
   sortIcon?: string | string[]
@@ -45,24 +50,24 @@ export const TableHeaderCell = ({
 const cellClassName = classnames("table-header-cells", 
   `${isChrome() ? "chrome-styles" : ""}`, 
   `${enableSorting ? "table-header-cells-active" : ""}`
-);
+)
 
 const cellId = `${loading ? 
     `loading-${header.id}`
     : `${header.id}`
-}`;
+}`
 
 const isToggleExpansionEnabledLoading =
   header.index === 0 &&
   loading &&
   (enableToggleExpansion === "all" || "header") &&
-  enableToggleExpansion !== "none";
+  enableToggleExpansion !== "none"
   
 const isToggleExpansionEnabled =
   header.index === 0 &&
   !loading &&
   (enableToggleExpansion === "all" || "header") &&
-  enableToggleExpansion !== "none";
+  enableToggleExpansion !== "none"
 
   return (
     <th

data/app/pb_kits/playbook/pb_advanced_table/Components/ToggleIconButton.tsx

@@ -1,13 +1,17 @@
 import React, { useContext } from "react"
-import Icon from "../../pb_icon/_icon"
 import { Row } from "@tanstack/react-table"
-import AdvancedTableContext from "../Context/AdvancedTableContext"
-import { DataType } from "../Utilities/types"
+
+import { GenericObject } from "../../types"
+
+import Icon from "../../pb_icon/_icon"
+
 import { displayIcon } from "../Utilities/IconHelpers"
 
+import AdvancedTableContext from "../Context/AdvancedTableContext"
+
 interface ToggleIconButtonProps {
-  onClick: (row: Row<DataType>) => void
-  row?: Row<DataType>
+  onClick: (row: Row<GenericObject>) => void
+  row?: Row<GenericObject>
 }
 
 export const ToggleIconButton = ({ row, onClick }: ToggleIconButtonProps) => {

data/app/pb_kits/playbook/pb_advanced_table/SubKits/TableBody.tsx

@@ -1,21 +1,25 @@
 import React, { useContext } from "react"
-import classnames from "classnames";
-import { buildCss } from "../../utilities/props";
-import { globalProps } from "../../utilities/globalProps";
-import LoadingInline from "../../pb_loading_inline/_loading_inline"
+import classnames from "classnames"
 import { flexRender, Row } from "@tanstack/react-table"
 
+import { GenericObject } from "../../types"
+
+import { buildCss } from "../../utilities/props"
+import { globalProps } from "../../utilities/globalProps"
+import { isChrome } from "../Utilities/BrowserCheck"
+
+import LoadingInline from "../../pb_loading_inline/_loading_inline"
+
 import { SubRowHeaderRow } from "../Components/SubRowHeaderRow"
 import { LoadingCell } from "../Components/LoadingCell"
 import { renderCollapsibleTrail } from "../Components/CollapsibleTrail"
+
 import AdvancedTableContext from "../Context/AdvancedTableContext"
-import { isChrome } from "../Utilities/BrowserCheck"
-import { DataType } from "../Utilities/types"
 
 type TableBodyProps = {
-  className?: string;
+  className?: string
   collapsibleTrail?: boolean
-  id?: string;
+  id?: string
   subRowHeaders?: string[]
 }
 
@@ -40,14 +44,14 @@ export const TableBody = ({
     buildCss("pb_advanced_table_body"),
     globalProps(props),
     className
-  );
+  )
 
   return (
     <>
       <tbody className={classes} 
           id={id}
       >
-        {table.getRowModel().rows.map((row: Row<DataType>) => {
+        {table.getRowModel().rows.map((row: Row<GenericObject>) => {
           const isExpandable = row.getIsExpanded()
           const isFirstChildofSubrow = row.depth > 0 && row.index === 0
           const rowHasNoChildren = row.original.children && !row.original.children.length ? true : false

data/app/pb_kits/playbook/pb_advanced_table/SubKits/TableHeader.tsx

@@ -1,17 +1,21 @@
 import React, { useContext } from "react"
-import classnames from "classnames";
-import { buildCss } from "../../utilities/props";
-import { globalProps } from "../../utilities/globalProps";
+import classnames from "classnames"
 import { HeaderGroup } from "@tanstack/react-table"
-import AdvancedTableContext from "../Context/AdvancedTableContext"
+
+import { GenericObject } from "../../types"
+
+import { buildCss } from "../../utilities/props"
+import { globalProps } from "../../utilities/globalProps"
+
 import { TableHeaderCell } from "../Components/TableHeaderCell"
-import { DataType } from "../Utilities/types"
+
+import AdvancedTableContext from "../Context/AdvancedTableContext"
 
 type TableHeaderProps = {
   children?: React.ReactNode | React.ReactNode[]
   className?: string
   enableSorting?: boolean
-  id?: string;
+  id?: string
   sortIcon?: string | string[]
 }
 
@@ -34,7 +38,7 @@ export const TableHeader = ({
     buildCss("pb_advanced_table_header"),
     globalProps(props),
     className
-  );
+  )
 
 
   return (
@@ -43,7 +47,7 @@ export const TableHeader = ({
           id={id}
       >
         {/* Get the header groups (only one in this example) */}
-        {table.getHeaderGroups().map((headerGroup: HeaderGroup<DataType>) => (
+        {table.getHeaderGroups().map((headerGroup: HeaderGroup<GenericObject>) => (
           <tr key={`${headerGroup.id}-headerGroup`}>
             {headerGroup.headers.map(header => (
               <TableHeaderCell

data/app/pb_kits/playbook/pb_advanced_table/Utilities/ExpansionControlHelpers.tsx

@@ -1,5 +1,6 @@
 import { RowModel } from "@tanstack/react-table"
-import { DataType, ExpandedStateObject } from "./types"
+import { ExpandedStateObject } from "./types"
+import { GenericObject } from "../../types"
 
 const filterExpandableRows = (expandedState: Record<string, boolean>) => {
   for (const expandedRow in expandedState) {
@@ -11,7 +12,7 @@ const filterExpandableRows = (expandedState: Record<string, boolean>) => {
 }
 
 export const updateExpandAndCollapseState = (
-  tableRows: RowModel<DataType>,
+  tableRows: RowModel<GenericObject>,
   expanded: Record<string, boolean>,
   targetParent: string
 ) => {

data/app/pb_kits/playbook/pb_advanced_table/Utilities/types.ts

@@ -4,5 +4,3 @@ export type ExpandedStateObject = Extract<
   ExpandedState,
   Record<string, boolean>
 >
-
-export type DataType = { [key: string]: any }

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.scss

@@ -4,6 +4,7 @@
 @import "../tokens/spacing";
 @import "./scss_partials/loading";
 @import "./scss_partials/pseudo_states";
+@import "./scss_partials/chrome_styles";
 
 .pb_advanced_table {
   $border-color: 1px solid $border_light !important;
@@ -86,13 +87,5 @@
     box-shadow: 1px 0px 0px 0px #e4e8f0 !important;
   }
 
-  .chrome-styles:first-child {
-    border-right: $border-color;
-  }
-
-  .table-card {
-    .chrome-styles:first-child {
-      border-right: $transparent !important;
-    }
-  }
+  @include chrome_styles($border-color);
 }

data/app/pb_kits/playbook/pb_advanced_table/_advanced_table.tsx

@@ -1,8 +1,8 @@
-import React, { useState, useEffect, useCallback } from "react";
-import classnames from "classnames";
-import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from "../utilities/props";
-import { globalProps, GlobalProps } from "../utilities/globalProps";
-import Table from "../pb_table/_table";
+import React, { useState, useEffect, useCallback } from "react"
+import classnames from "classnames"
+
+import { GenericObject } from "../types"
+
 import {
   createColumnHelper,
   getCoreRowModel,
@@ -11,38 +11,42 @@ import {
   Row,
   useReactTable,
   Getter,
-} from "@tanstack/react-table";
+} from "@tanstack/react-table"
+
+import { buildAriaProps, buildCss, buildDataProps, buildHtmlProps } from "../utilities/props"
+import { globalProps, GlobalProps } from "../utilities/globalProps"
 
-import { updateExpandAndCollapseState } from "./Utilities/ExpansionControlHelpers";
+import Table from "../pb_table/_table"
 
-import { CustomCell } from "./Components/CustomCell";
-import AdvancedTableContext from "./Context/AdvancedTableContext";
-import { TableHeader } from "./SubKits/TableHeader";
-import { TableBody } from "./SubKits/TableBody";
+import AdvancedTableContext from "./Context/AdvancedTableContext"
 
-import { DataType, ExpandedStateObject } from "./Utilities/types";
+import { updateExpandAndCollapseState } from "./Utilities/ExpansionControlHelpers"
+
+import { CustomCell } from "./Components/CustomCell"
+import { TableHeader } from "./SubKits/TableHeader"
+import { TableBody } from "./SubKits/TableBody"
 
 type AdvancedTableProps = {
-  aria?: { [key: string]: string };
-  children?: React.ReactNode | React.ReactNode[];
-  className?: string;
-  columnDefinitions: DataType[];
-  data?: { [key: string]: string };
-  enableToggleExpansion?: "all" | "header" | "none";
-  expandedControl?: DataType;
+  aria?: { [key: string]: string }
+  children?: React.ReactNode | React.ReactNode[]
+  className?: string
+  columnDefinitions: GenericObject[]
+  data?: { [key: string]: string }
+  enableToggleExpansion?: "all" | "header" | "none"
+  expandedControl?: GenericObject
   htmlOptions?: {[key: string]: string | number | boolean | (() => void)},
-  id?: string;
-  initialLoadingRowsCount?: number;
-  inlineRowLoading?: boolean;
-  loading?: boolean | string;
-  onRowToggleClick?: (arg: Row<DataType>) => void;
-  onToggleExpansionClick?: (arg: Row<DataType>) => void;
-  sortControl?: DataType;
-  tableData: DataType[];
-  tableOptions?: DataType;
-  tableProps?: DataType;
-  toggleExpansionIcon?: string | string[];
-} & GlobalProps;
+  id?: string
+  initialLoadingRowsCount?: number
+  inlineRowLoading?: boolean
+  loading?: boolean | string
+  onRowToggleClick?: (arg: Row<GenericObject>) => void
+  onToggleExpansionClick?: (arg: Row<GenericObject>) => void
+  sortControl?: GenericObject
+  tableData: GenericObject[]
+  tableOptions?: GenericObject
+  tableProps?: GenericObject
+  toggleExpansionIcon?: string | string[]
+} & GlobalProps
 
 const AdvancedTable = (props: AdvancedTableProps) => {
   const {
@@ -65,22 +69,22 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     tableOptions,
     tableProps,
     toggleExpansionIcon = "arrows-from-line",
-  } = props;
+  } = props
 
   const [loadingStateRowCount, setLoadingStateRowCount] = useState(
     initialLoadingRowsCount
-  );
+  )
 
   // Create a local state for expanded and setExpanded if expandedControl not used
-  const [localExpanded, setLocalExpanded] = useState({});
+  const [localExpanded, setLocalExpanded] = useState({})
 
   // Determine whether to use the prop or the local state
-  const expanded = expandedControl ? expandedControl.value : localExpanded;
+  const expanded = expandedControl ? expandedControl.value : localExpanded
   const setExpanded = expandedControl
     ? expandedControl.onChange
-    : setLocalExpanded;
+    : setLocalExpanded
 
-  const columnHelper = createColumnHelper<DataType>();
+  const columnHelper = createColumnHelper()
 
   //Create cells for first columns
   const createCellFunction = (cellAccessors: string[]) => {
@@ -88,10 +92,10 @@ const AdvancedTable = (props: AdvancedTableProps) => {
       row,
       getValue,
     }: {
-      row: Row<DataType>;
-      getValue: Getter<string>;
+      row: Row<GenericObject>
+      getValue: Getter<string>
     }) => {
-      const rowData = row.original;
+      const rowData = row.original
 
       switch (row.depth) {
         case 0: {
@@ -101,12 +105,12 @@ const AdvancedTable = (props: AdvancedTableProps) => {
                 onRowToggleClick={onRowToggleClick}
                 row={row}
             />
-          );
+          )
         }
         default: {
           // Handle other depths based on cellAccessors
-          const depthAccessor = cellAccessors[row.depth - 1]; // Adjust index for depth
-          const accessorValue = rowData[depthAccessor];
+          const depthAccessor = cellAccessors[row.depth - 1] // Adjust index for depth
+          const accessorValue = rowData[depthAccessor]
           return accessorValue ? (
             <CustomCell
                 onRowToggleClick={onRowToggleClick}
@@ -115,13 +119,13 @@ const AdvancedTable = (props: AdvancedTableProps) => {
             />
           ) : (
             "N/A"
-          );
+          )
         }
       }
-    };
+    }
 
-    return columnCells;
-  };
+    return columnCells
+  }
 
   //Create column array in format needed by Tanstack
   const columns =
@@ -132,12 +136,12 @@ const AdvancedTable = (props: AdvancedTableProps) => {
         ...columnHelper.accessor(column.accessor, {
           header: column.label,
         }),
-      };
+      }
       if (column.cellAccessors) {
-        columnStructure.cell = createCellFunction(column.cellAccessors);
+        columnStructure.cell = createCellFunction(column.cellAccessors)
       }
-      return columnStructure;
-    });
+      return columnStructure
+    })
 
   //Syntax for sorting Array if we want to manage state ourselves
   const sorting = [
@@ -148,22 +152,22 @@ const AdvancedTable = (props: AdvancedTableProps) => {
           ? !sortControl.value.desc
           : false,
     },
-  ];
+  ]
 
   const expandAndSortState = () => {
     if (sortControl) {
-      return { state: { expanded, sorting } };
+      return { state: { expanded, sorting } }
     } else {
-      return { state: { expanded } };
+      return { state: { expanded } }
     }
-  };
+  }
 
 //initialize table
   const table = useReactTable({
     data: loading ? Array(loadingStateRowCount).fill({}) : tableData,
     columns,
     onExpandedChange: setExpanded,
-    getSubRows: (row) => row.children,
+    getSubRows: (row: GenericObject) => row.children,
     getCoreRowModel: getCoreRowModel(),
     getExpandedRowModel: getExpandedRowModel(),
     getSortedRowModel: getSortedRowModel(),
@@ -171,42 +175,42 @@ const AdvancedTable = (props: AdvancedTableProps) => {
     sortDescFirst: true,
     ...expandAndSortState(),
     ...tableOptions,
-  });
+  })
 
-  const tableRows = table.getRowModel();
+  const tableRows = table.getRowModel()
 
   // Set table row count for loading state
   const updateLoadingStateRowCount = useCallback(() => {
-    const rowsCount = table.getRowModel().rows.length;
+    const rowsCount = table.getRowModel().rows.length
     if (rowsCount !== loadingStateRowCount && rowsCount !== 0) {
-      setLoadingStateRowCount(rowsCount);
+      setLoadingStateRowCount(rowsCount)
     }
-  }, [tableData, loadingStateRowCount]);
+  }, [tableData, loadingStateRowCount])
 
   useEffect(() => {
     if (!loading) {
-      updateLoadingStateRowCount();
+      updateLoadingStateRowCount()
     }
-  }, [loading, updateLoadingStateRowCount]);
+  }, [loading, updateLoadingStateRowCount])
 
-  const handleExpandOrCollapse = (row: Row<DataType>) => {
-    onToggleExpansionClick && onToggleExpansionClick(row);
+  const handleExpandOrCollapse = (row: Row<GenericObject>) => {
+    onToggleExpansionClick && onToggleExpansionClick(row)
 
-    const expandedState = expanded as ExpandedStateObject;
-    const targetParent = row?.parentId;
+    const expandedState = expanded
+    const targetParent = row?.parentId
     return setExpanded(
       updateExpandAndCollapseState(tableRows, expandedState, targetParent)
-    );
-  };
+    )
+  }
 
-  const ariaProps = buildAriaProps(aria);
-  const dataProps = buildDataProps(data);
-  const htmlProps = buildHtmlProps(htmlOptions);
+  const ariaProps = buildAriaProps(aria)
+  const dataProps = buildDataProps(data)
+  const htmlProps = buildHtmlProps(htmlOptions)
   const classes = classnames(
     buildCss("pb_advanced_table"),
     globalProps(props),
     className
-  );
+  )
 
   return (
     <div {...ariaProps} 
@@ -247,10 +251,10 @@ const AdvancedTable = (props: AdvancedTableProps) => {
         </Table>
       </AdvancedTableContext.Provider>
     </div>
-  );
-};
+  )
+}
 
-AdvancedTable.Header = TableHeader;
-AdvancedTable.Body = TableBody;
+AdvancedTable.Header = TableHeader
+AdvancedTable.Body = TableBody
 
-export default AdvancedTable;
+export default AdvancedTable